nodebb/test
Julian Lam a716a5529c
feat: more discrete commit-on-save instead of commit-on-change w/ confirm modals ()
* feat: privileges save button, , WIP

* fix: disable firefox autocomplete on privilege form fields

* feat: closes  privilege changes commit on save

- new language strings for confirmation and success modals/toasts
- indeterminate privilege handling (/cc @psychobunny)
- added new discard button
- both discard and save buttons now have confirmation dialogs

* fix(tests): remove duplicate template helper test

* fix(tests): broken template helper test

* feat: confirm dialogs for all privilege copy actions

Also, ability to add user to a privilege table without needing
to refresh the privilege table.

* feat: group row addition w/o table refresh

breaking: helpers.getUserPrivileges and helpers.getGroupPrivileges
no longer make socket calls to the following hooks:

- filter:privileges.list, filter:privileges.admin.list,
  filter:privileges.global.list, filter:privileges.groups.list,
  filter:privileges.admin.groups.list,
  filter:privileges.gloval.groups.list

The filters are still called, but done before the helper method
is called, and the results are passed in instead. This change
should only affect you if you directly call the helper methods,
otherwise the change is transparent.

* fix: stale ajaxify data on privilege category switch

* fix: implicit privileges not showing for user privs

* fix: groups, not group, also fix tests

* fix(tests): again

* fix: wrong tpl rendered when adding group to global priv table
..
database Zscan ()
files fix: , remove webfonts ()
helpers fix: vulnerability in cover and admin uploads ()
mocks fix: try again
.eslintrc ESlint no-unused-vars
api.js feat: increase wait
authentication.js feat: add privilege give/rescind hooks ()
batch.js Async refactor in place ()
blacklist.js fix(deps): update to eslint@6
build.js fix: , upgrade mkdirp to 1.0.x
categories.js fix: missing await
controllers-admin.js feat: consolidation of flags to reduce flagspam,
controllers.js fix: remove old test
coverPhoto.js fix:
database.js fix: db info page
defer-logger.js upgrade to winston 3.1, closes ()
emailer.js fixed tests, closes
feeds.js feat: add privilege give/rescind hooks ()
file.js fix: vulnerability in cover and admin uploads ()
flags.js feat: consolidation of flags to reduce flagspam,
groups.js fix: groups.updateCover
image.js up deps
locale-detect.js fix: , autoLocale logic not playing nicely with no-refresh auths ()
messaging.js fix: , update deleted/restored messages
meta.js fix: return null if field does not exist
notifications.js fix: tests
pagination.js ESlint object-curly-spacing
plugins-installed.js feat: move plugin tests to separate file
plugins.js feat: move plugin tests to separate file
posts.js feat: , allow editing category of queued topic
pubsub.js fix:
rewards.js fix: change params
search-admin.js style(eslint): match operator-linebreak preferences
search.js feat: add privilege give/rescind hooks ()
settings.js more settings tests
socket.io.js fix: event tests
template-helpers.js feat: more discrete commit-on-save instead of commit-on-change w/ confirm modals ()
topics.js feat: , min/max tags per category
translator.js fix: ()
uploads.js feat: remove file.isFileTypeAllowed
user.js fix: edge case in test
utils.js feat: remove deprecated utils.walk