577 Commits (e09f00ba0a0327d8df46fc371b24637ce7b574cf)

Author SHA1 Message Date
Barış Soner Uşaklı f6cfbbb520 fix: don't crash if body doesn't have `skin-` 6 years ago
Julian Lam 63061ffd37 feat: new hook filter:user.logout
- used for setting "next" for post logout redirection
6 years ago
Julian Lam 5ee173c2f6 fix: #7276 improper request for client-noskin.css 6 years ago
Julian Lam 3859d417ce fix: #7236, header search stops working after header update 6 years ago
Julian Lam 954af0f0d2 fix: #7176, FUOC on app.reskin() 6 years ago
Julian Lam 8e9de540b4 fix: #7136 socket.disconnect() now called on invalid session 6 years ago
Julian Lam d81e0a5f5b fix: #7146 Better RTL handling on (de-)authentication
- RTL is applied (or unapplied) on login and logout depending on
  user language/guest-detected language.
- config is automatically saved into res.locals.config whenever
  loadConfig is called
- On login/logout, buildHeader is called instead of getting config
- On logout, req.uid is deleted instead of set to 0
6 years ago
Julian Lam 900f0a0b78 fix: #7118, invoking autoLocale middleware on logout
Also:
- firing client-side hook on header update
- updating bootbox locale on header update
6 years ago
Andrew Rodrigues 7fb29f4272 fix: closes #6784 (#7137)
* fix: closes #6784

* #6784 also fix homepage + subfolder installs

* #6784 fixes suburls as well (ex. /tags/x and /groups/y)

* #6784 more elegant solution @pitaj

and the last time I touch this function, lol

* #6784 regis, final answer

I lied in that last commit
6 years ago
Barış Soner Uşaklı f103390aa5 fix: #7103
update counter when user navigates to /unread
fix new topic alert on /unread
moved unread code from footer to unread
6 years ago
Barış Soner Uşaklı 74d0e88df3 fix: don't explode if there is no css el 6 years ago
Julian Lam 5f3d1c76c8
fix: #7038, autoLocale logic not playing nicely with no-refresh auths (#7059)
* fix: #7038, autoLocale logic not playing nicely with no-refresh auths

- on login, req.query.lang is deleted (since it seems to be left over)
- on logout, the middleware.autoLocale is executed, which resets
  req.query.lang
- middleware.autoLocale is new, just refactored existing logic in
  webserver.js into new middleware method.

* style: tests, use lodash

* fix: timeago strings not switching languages on login or out
6 years ago
Julian Lam 6df5668e64 fix: #7063, logout code should do hard page nav to / or data.next 6 years ago
Julian Lam 28a1fa780a fix: skin not changing after login or logout, #7038 6 years ago
Julian Lam f6b92c1d3e fix: #7013, add cache buster to js-enabled.css 6 years ago
Barış Soner Uşaklı c0a75d735b fix requires 6 years ago
Baris Usakli c343b93a37 optimize ajaxify
- do not call $.timeago twice on topic load and for widgets
- do not use toLocaleString for each timeago string, use a single
Intl.DateTimeFormat instance instead
- do not call format for empty timeago strings, ie a post that isnt
edited doesnt have a timeago string
- do not call isTouchDevice for every element
- remove app.replaceSelfLinks, this is superceded with /me route
- store references to jquery objects in navigator instead of creating
them on every scroll
6 years ago
Julian Lam f7bd398eb1 style(eslint): newlines in public/src as well 6 years ago
Julian Lam 84433f29ab
Do not require a full refresh on login/logout (#6841)
* no-refresh login as well, plus lots of fixes for missing config on login

* replace config with new set on logout as well

* passing new payload data into new action:app.loggedIn hook, and old action:app.loggedOut hook

* fixed issues with socket.io not properly representing uid on server

* some light refactoring and cleanup

* minor cleanup, fixed spa logout not working after login

* have reconnection handler for socket.io wait 2s to confirm disconnection before reporting -- stops flicker if reconnecting immediately

* Dynamically replace chat and slideout menu on updateHeader()

... instead of just the menu items.

* more efficient calls to Benchpress and translator /cc @pitaj

* fix: chats and notification handlers not working after login

* fix: accidentally calling cb multiple times
6 years ago
Andrew Rodrigues e2ecbae06c add body class when cookie consent warning is open 6 years ago
Barış Soner Uşaklı 702be3f6de https://github.com/NodeBB/nodebb-theme-persona/issues/363 6 years ago
Barış Soner Uşaklı df4f5f6f27
closes #6784 6 years ago
Julian Lam 32edfb6c5a updating chat logic to save uuid in data-uuid attr instead of uuid attr 7 years ago
Barış Soner Uşaklı a7267df404 closes #6464 7 years ago
Julian Lam a4a961639d only triggering forum updated messaging if hostname matches, fixes #6333 7 years ago
Barış Soner Uşaklı c70cb0d7ad please eslint 7 years ago
Barış Soner Uşaklı bac2da0ace dont crash if app.logout is called from code 7 years ago
Julian Lam 94e8b2b38d Added ajaxify.isCold()
And used it in app.js, so window.scrollTo(0, 0); is not called
on cold load (since you're already at the top). Useful in low-
bandwidth modes since you might accidentally get kicked to the
top of the page due to a slow connection and delayed .init().

Slightly related to testing in #6150
7 years ago
Barış Soner Uşaklı fd78eb6d57 closes #5533 7 years ago
Julian Lam 514317ab20 using translator.unescape instead of replaces 8 years ago
Julian Lam 211482bbc0 fixes #5927 8 years ago
Peter Jaszkowiak dc3f89a505 ajaxify t.js usage to Benchpress 8 years ago
Andrew Rodrigues 60e0f4ced9 minor typo 8 years ago
Peter Jaszkowiak abffc29128 Use Benchpress (#5901)
* Use Benchpress

* Use Benchpress.compileParse

* Error for template load failure

* Use benchpressjs package

* Compile templates on demand

* Fix user settings page

* Fix admin search to exclude `.jst` files

* Fix 500-embed

So ajaxify can still show an error if the server goes down
8 years ago
Julian Lam c4fbed24f8 Squashed commit of the following:
commit 9c86d9b2904e14927cd7e9679b92aec0951d1063
Merge: ebfa63a 5a7f811
Author: Julian Lam <[email protected]>
Date:   Thu Jul 20 08:41:39 2017 -0400

    Merge branch 'noscript-login' of https://github.com/An-dz/NodeBB into noscript

commit 5a7f81185e8f9bd7d2d011c3d495988be7e437a3
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Mon Jul 17 23:07:14 2017 -0300

    Rename clashing variable 'next'

commit ebfa63a984073a58c17aa408c363cdb03ef89985
Merge: c1801cd f159d0d
Author: Julian Lam <[email protected]>
Date:   Mon Jul 17 16:30:40 2017 -0400

    Merge branch 'noscript-logout' of https://github.com/An-dz/NodeBB into noscript

commit c1801cda14e6363491e30b659902e2ae71f7e1f7
Merge: 7a5f9f3 9fd542d
Author: Julian Lam <[email protected]>
Date:   Mon Jul 17 16:30:31 2017 -0400

    Merge branch 'noscript-register' of https://github.com/An-dz/NodeBB into noscript

commit 7a5f9f35abc834bb72ddddc9ca07d34f2fde8353
Merge: 44851f9 d37b95c
Author: Julian Lam <[email protected]>
Date:   Mon Jul 17 16:30:10 2017 -0400

    Merge branch 'noscript-compose' of https://github.com/An-dz/NodeBB into noscript

commit f159d0d9ef1b7f600e830a96fdb4b9c87c79bb4a
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Thu Jul 6 12:16:38 2017 -0300

    Prevent form submit

    Required for theme change

commit d37b95cb71d32d4483190609798e244c331db165
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Thu Jul 6 01:49:52 2017 -0300

    Prevent link action with scripts

    Required for the theme change that changes the buttons to `a` tags.

commit 9fd542d8970b7d1a4126f4edc4b44eab7d708fb0
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Wed Jul 5 19:57:56 2017 -0300

    Fix tests

commit cdad5bf8c2891ad76f7441fd4d8a74b058a14e6d
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Wed Jul 5 19:09:17 2017 -0300

    Update error handling

commit 4ff11cd136a4fb98483f837e2cebc741380dfe76
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Wed Jul 5 17:29:08 2017 -0300

    Remove async waterfall

commit df01d44e821a70c984b89e9585a325c3e02c6e37
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Wed Jul 5 16:59:43 2017 -0300

    Set noscript compose as noscript at start

commit 4bcc380da72239b8315cc849a77a3036e06e4a12
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Wed Jul 5 16:59:12 2017 -0300

    Remove last useless next

commit b5eac6fea11e209934c0648a7e75ad07a2167123
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Sun Jul 2 18:35:08 2017 -0300

    Last function requires no next

commit 20a5cce6e6e32a454c304c448383707ec44c75a8
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Sun Jul 2 18:06:58 2017 -0300

    Remove more useless next calls

commit 85ee22a79bcbbb1995106f43d4c74d6ba9206cab
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Sun Jul 2 17:46:07 2017 -0300

    Remove useless next calls

commit 7d984c47ad24faac1fe537dee4a5a7d697e8634c
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Sun Jul 2 15:45:31 2017 -0300

    Support old themes

commit 4a09dfbd08253115c342a9e829c4e6940cecb8cc
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Sun Jul 2 15:37:23 2017 -0300

    Moved all error handling into helpers function

commit 391aa6e67ef9ab67304005e14ac0633cdb630713
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Thu Jun 8 15:37:37 2017 -0300

    ESLint - Fix mixed conditionals

commit 80ccc6fd581d791f31e7ab62de8de611837bfc3c
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Sat Jun 3 18:08:15 2017 -0300

    Compose without scripts

commit 2aca811256721238ca0cede4954213d369009885
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Sat Jun 3 18:00:44 2017 -0300

    Register without scripts

commit 097bb51577fb26f8e22f86dc274cb670ab606a8a
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Sat Jun 3 16:42:15 2017 -0300

    Logout without scripts

commit d497e08109891079656fee1c145043a9c0e55f2e
Author: André Zanghelini <an_dz@simutrans-forum>
Date:   Sat Jun 3 16:27:10 2017 -0300

    Login without script
8 years ago
Baris Usakli 5af1161e09 fix eslint 8 years ago
psychobunny 1b98449686 closes #5704 8 years ago
Barış Soner Uşaklı 3a1eba2537 merge 8 years ago
psychobunny b3bd70235a refactor ban messaging; add ban duration to message; use bootbox instead of alert 8 years ago
Barış Soner Uşaklı 6fb90a17e0 closes #5613 8 years ago
Peter Jaszkowiak 30b47d39f3 Fix #5536 8 years ago
barisusakli b8c606cbbd closes #5519 8 years ago
Julian Lam 1594a84e1c fixes #5536 8 years ago
Julian Lam e71bd7a27f Merge branch 'master' into styleguide 8 years ago
barisusakli 048eb8a320 some helper tests 8 years ago
Peter Jaszkowiak b227297ef3 ESlint no-use-before-define 8 years ago
Peter Jaszkowiak c18808fdeb ESlint no-useless-concat, no-mixed-spaces-and-tabs 8 years ago
Peter Jaszkowiak c4bdb72941 ESlint no-unneeded-ternary
and no-extend-native, no-sequences
8 years ago
Peter Jaszkowiak 64a6322002 ESlint no-extra-boolean-cast
and no-shadow-restricted-names
8 years ago
Peter Jaszkowiak 896c8c7343 ESlint object-curly-spacing 8 years ago
Peter Jaszkowiak 1493afee2a ESlint indent 8 years ago
Peter Jaszkowiak 3b0dd2d1ef ESlint padded-blocks 8 years ago
Peter Jaszkowiak a038c66549 ESlint quotes 8 years ago
Peter Jaszkowiak 604358ecc4 ESlint keyword-spacing, no-multi-spaces 8 years ago
Peter Jaszkowiak 277a7fb8b4 ESlint key-spacing, no-trailing-spaces 8 years ago
Peter Jaszkowiak b09b3aef7f ESlint no-undef, remove global comments 8 years ago
Peter Jaszkowiak 2ba46808a1 ESlint one-var, fix comma-dangle 8 years ago
Peter Jaszkowiak bc1d70c126 ESlint comma-dangle 8 years ago
Peter Jaszkowiak aaacdb8413 Fix #5416, uploads path config setting
- Finish moving uploads route to `/assets/uploads`
- Remove `upload_url` config setting, it was broken
8 years ago
Peter Jaszkowiak 05b68391dd Use `/assets` for client assets
- Route `/assets` -> `build/public`, falling back on `public`
- Moved destinations for `nodebb.min.js`, `acp.min.js`, `admin.css`, `stylesheet.css`, `templates`, and `sounds` to `build/public`
- r.js modules previously routed through express are now symlinked into `public/build/src/modules`
- minfiles no longer served from a memory cache
- use config `views_dir` setting everywhere template directory is used
- fix cache buster `v=v=`
8 years ago
Peter Jaszkowiak 0b4c39338e Translation bootbox wrapper
- Replaced minfied bootbox file with unminified one since it's minified at build anyways
- Removed existing override
- Made translator more verbose in dev mode; it now warns about missing translations
8 years ago
barisusakli a4b46fd5ce closes #5236 8 years ago
Julian Lam 6f1e5a83ab resolve regression caused by part of d28f7de 8 years ago
Julian Lam d28f7de19e fixes #5228 8 years ago
barisusakli 0756fcce7e eslint 8 years ago
barisusakli 2c77a88ba4 closes #5220 8 years ago
Timothy Fike f1e3e155c4 Update app.js 8 years ago
Timothy Fike 2d84c98565 Allow sending Error objects to alertError instead of just plain strings. 8 years ago
Julian Lam ede7a71db7 Fixes #5186
On socket.io connection, all clients join a room pertaining to
their express session id. We use this room to keep track of any
sessions in different browser windows (but the same cookie jar),
so if a login/logout occurs, we can throw a session mismatch
modal.

This room can also be used to emit messages across windows/tabs...
8 years ago
Ben Lubar e151916f1a
Fix followed topic notifications going to the last unread post
Regression introduced in 1b34ebe230.

Bug originally reported in #4469.
8 years ago
Julian Lam e6c9c89342 closes #5197 8 years ago
barisusakli 5703bf6eac fix test 8 years ago
barisusakli ce9be7e694 closes #5132 8 years ago
Julian Lam 66aea0eed1 closes #5167 8 years ago
Julian Lam 2da32512af not displaying banned modal if you're not actually banned, heh 8 years ago
Julian Lam f97f45a138 logic to show a modal to banned users when they try to log in via SSO 8 years ago
Sergii Paryzhskyi e515b791da Fix eslint rules (#5117)
* Fix semi linter rule

* Fix semi-spacing linter rule

* Fix no-undef-init linter rule

* Fix space-before-blocks linter rule
8 years ago
psychobunny ee4943c485 fix regression: open chat page when in chats route instead of in modal 8 years ago
Barış Soner Uşaklı cbd936c547 closes #5140 8 years ago
HeeL 4a3c31b2dc Fix space-before-function-paren linter rule 8 years ago
barisusakli aca0a893e7 remove since properly 8 years ago
barisusakli a93ee97926 closes #5073 8 years ago
Julian Lam 2931af18d4 define two client-side hooks for logout 8 years ago
barisusakli 8273dab368 ability to pass tags to new topics 9 years ago
Timothy Fike fc68b64fe0 New topic from anywhere.
Like on the navbar.
9 years ago
psychobunny 0afa55517f fixed app.loadJQueryUI; minified jquery-ui.js; removed jqueryui from cold load payload; fixed broken image paths 9 years ago
psychobunny 8b9f004b7b Revert "fixed app.loadJQueryUI and minified jquery-ui.js"
This reverts commit 2c9c14ff7d.
9 years ago
psychobunny 2c9c14ff7d fixed app.loadJQueryUI and minified jquery-ui.js 9 years ago
barisusakli 5c83075806 moved variables parse to ajaxify.js 9 years ago
barisusakli 276031cd6f closes #4585, closes https://github.com/NodeBB/nodebb-theme-persona/issues/299 9 years ago
psychobunny 59bd1d71f4 return roomId in optional callback when opening new chat 9 years ago
Mathias Schreck ce9ee62fa0 Handle callback errors 9 years ago
barisusakli d43c19c173 closes #4952 9 years ago
Julian Lam e26166a45b closes #4950 9 years ago
barisusakli 32320018ab closes #4911 9 years ago
Julian Lam 7902987900 added jqueryUI to list of prefetched resources, and updated its loader to not use $.getScript(). Updated require.js files to use ?v= in the url argument for cache buster 9 years ago
barisusakli 514c12aa68 closes #4885 9 years ago
Ben Lubar b08696515f Fix restarted secondary instances waiting forever for the templates:compiled message. Fix update notification always appearing when an instance restarts even if there was no update. Closes #4870 (#4871) 9 years ago
pichalite 11ba5e2bcc fix header tooltips 9 years ago
barisusakli bb7303834f remove csrf r.js module 9 years ago