968be7d8de
make lint happy
6 years ago
3c611d85ed
closes #6912
...
- on category setParent dialog do not show children of current category
- break recursion if category parentCid is equal to child cid to prevent
infinite loop
- dont allow setting the parentCid of a category to one of it's children
6 years ago
6f47446171
closes #6910
6 years ago
3c8939a80d
fix: interstitial redirects failing if done via ajaxify
6 years ago
2df19c0ae4
fix typo
6 years ago
ed7399f9ed
shorter code
6 years ago
412358b070
#6903
6 years ago
67d3b29204
#6903
6 years ago
ff38abc225
move bcrypt into password
6 years ago
4e297921c4
dont show object cache if it doesnt exist
6 years ago
4caaa046d7
dont load post data again
...
shorter async.parallel
6 years ago
d3e4daebec
posts/delete cleanup
6 years ago
0de60cfdca
fix mongodb tests
6 years ago
8ca36ad122
closes #6890
6 years ago
157bea6966
fix: username trim on login, closes #6894
6 years ago
5ccdc1c017
internationalising english labels in session time ACP block, #6883
6 years ago
58b088c054
update html on session time ACP block, #6883
6 years ago
2e579ee0f9
closes #6883
6 years ago
5ee4529a8e
if source has no parentCid assume 0
6 years ago
9918389a43
closes #6884
6 years ago
7aa937a657
remove dupe code in mongodb sorted
6 years ago
ea1e8fb8fe
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
c27be9db5a
Recent refactor ( #6879 )
...
* wip
* fix inf scroll
* remove duplicated code
* remove dupe code in /unread
* use topicList
* update tag page to use topicList
* fix tests
* combine ifs
* remove more dupe code
* disable timeout
6 years ago
66ed48e088
closes #6875
6 years ago
4919e9efa3
feat: allow disabling of GDPR features via ACP toggle, closes #6847
6 years ago
51792da430
dont crash if there is nothing to write
6 years ago
12f3f56b01
change to .exists
6 years ago
566564ed74
fix redis tests
...
fixed typo in groups/data.js
added postcount,viewcount to int fields
6 years ago
fb6067a7ca
only parse if field is requested
6 years ago
f3a679e268
remove parseInts
6 years ago
aca50f1fe1
dont crash if topic is moved to pinned topic
6 years ago
da22940b80
dont retry absolute paths
6 years ago
ebd4b19a65
moved req.user up
6 years ago
9c03881d5a
add threshold for image resizing
6 years ago
369e4854d2
remove parseInts
6 years ago
541997a755
fix lint
6 years ago
40f9ee3003
dont crash if topic does not exist
6 years ago
2f198583c4
change to this
6 years ago
a2aae7f805
shorter error message
6 years ago
69253d9a7f
use chart.js legend
6 years ago
1d15449076
write analytics before exiting
6 years ago
5b842c98ac
fix typo
6 years ago
9f36ce3997
#6862
6 years ago
a73bcabad8
don't call .jpeg quality on pngs
6 years ago
44a957faca
remove more parseints
6 years ago
728e7bdae9
remove more parseInts
6 years ago
537b7ff7e8
remove more parseInts
6 years ago
a228dc2de9
closes #6797
6 years ago
82cda248f3
fix plugin requires
6 years ago
138154a71c
move modules
6 years ago
5293a6515c
fix lint
6 years ago
fdbefa3d1f
remove more parseInts
6 years ago
175e13edf6
group data
6 years ago
c738dc7d3e
remove some more parseInts
6 years ago
7a44424214
parse '123' to 123 if it has no default
6 years ago
d07e3e6d97
if not in defaults use string
6 years ago
4fff5e9baf
closes #6855
6 years ago
881185ae59
closes #6857
6 years ago
ab7657d445
closes #6854
6 years ago
ac39112271
remove more parseInts
6 years ago
9c022afae1
Parse int ( #6853 )
...
* Store config fields as JSON in the db
Fewer parseInts
* Remove unnecessary parseInts
* remove some dupe code add tests
* remove console.log
* remove more parseInts
* WIP: read meta.configs defaults from defaults.json
remove more parseInts
* more work
* add log for failing test
* update admin pwd
* fix tests, dont require posts/cache before configs are initialized
* handle saves
* Test boolean conditions
* remove more parseInts
* Fix boolean values
* remove lots more parseInts
* removed json parsing
* renamed var to number
* categories dont have timestamp
6 years ago
60c58870af
remove hotswap ( #6835 )
6 years ago
92744a7200
closes #6852
6 years ago
ee2f9e9434
remove some parseInts
6 years ago
f5fe91286e
closes #6851
6 years ago
f53984aeae
refactor user/category data
6 years ago
c3a903142a
closes #6850
6 years ago
b2b33ffa57
topics data refactor
6 years ago
26d4e0852f
use includes instead of indexOf
...
use _.uniq instead of filter&indexOf
6 years ago
a6c70412db
temp fix for #6848
6 years ago
54c638c3c8
fix upgrade script for notification types
6 years ago
5ef708d765
fix navigation
6 years ago
250e8c01ff
closes #5008
6 years ago
da1a90a470
add search test
6 years ago
e6546e6263
#6848
...
this handles winston.error(err);
6 years ago
9dd65cf772
closes #6822
6 years ago
8b8feb5b88
remove emitter
6 years ago
9251912282
move methods from posts to posts/data
6 years ago
baf91089a6
remove unused methods
6 years ago
444fd70ba3
test pubsub
6 years ago
b4d8b7cf38
move sorted topics code out of recent
6 years ago
837f411783
closes #6843
6 years ago
986511e718
try with higher timeout
6 years ago
1d15dc089b
revert isCluster
6 years ago
0aebb9caf8
closes #6844
6 years ago
154d7076d9
dont pass options
6 years ago
9dbe68a9cb
testing again
6 years ago
aa567a5f2d
print out connString and opts
6 years ago
2d8d234c57
test mongodb again
6 years ago
f4df89fe90
closes #6840
6 years ago
8079d3d3b7
add tids used to returned data
6 years ago
85c60316ed
upgrade to winston 3.1, closes #6590 ( #6838 )
...
* upgrade to winston 3.1
* fix winston in web/install and tests
6 years ago
6c15aee888
add cache hits/misses to posts cache
6 years ago
b57db7fd8e
update groups join to take array of group names ( #6834 )
...
* allow groups.join to take an array of group names
* pass an array to groups.join/leave in privileges
* split up groups/membership
* add hits/miss to group cache
* fix typo
6 years ago
c06480b82e
add tests for blocked users teaser/unread
6 years ago
687adea5dd
closes #6836
6 years ago
d4db8c2d42
removed reset
6 years ago
c9a415c469
check if process.send exists
6 years ago
1024a0efa1
add reset to pubsub for tests
6 years ago
a0f5461860
don't set and read from topic hash in parallel ( #6831 )
...
this was causing a test to fail, although very rarely
6 years ago
1ec2d511b2
remove unnecessary code
6 years ago
ba21c5170a
moved increase/decrease
...
moved these two methods into addPostToTopic&removePostFromTopic
6 years ago
e615391b22
convert values to string before removing
6 years ago
5c7dd54815
fix zsets and update them on post move, closes #6823 ( #6827 )
6 years ago
702be3f6de
https://github.com/NodeBB/nodebb-theme-persona/issues/363
6 years ago
ed9b3a31df
fix navigation items not getting saved if they are not modified at all
...
if you add 2 nav items and dont make any changes they weren't being saved, adding order fixes this issue
6 years ago
cf1173b0c4
closes https://github.com/NodeBB/nodebb-theme-persona/issues/408
6 years ago
a3d463916c
closes #6822
6 years ago
5e1c33bb3b
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
a4d5c81de5
closes #6819
6 years ago
3886a704e0
fix lint
6 years ago
84737b5a49
use buildForSelect
6 years ago
6dc84deca9
allow admins mods to watch/ignore categories for other users
6 years ago
71905bb2c6
fix watched categories
6 years ago
9ed4239d8e
small changes and test for user/:slug/categories
6 years ago
523a2dc54c
Add settings page to control watched categories ( #6648 )
...
* Add settings page to control watched categories
* Fix passing undefined to pushUnreadCount
6 years ago
1df9961eb4
make lint happy
6 years ago
8df6838561
closes #6816
6 years ago
b58ab48485
add test for /sessions controller
6 years ago
002522834c
closes #6815
6 years ago
b033d6f115
add tid to post-purge event
6 years ago
13a1497617
closes #6801
6 years ago
7bc69e9182
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
1bea247748
add username/email to user-delete event
6 years ago
49ba5af5fa
closes #6810 ( #6813 )
6 years ago
48d49cfcad
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
d1491feed9
add tid to topic rename and post delete restore events
6 years ago
f77091d1ed
change user delete so it returns quickly
6 years ago
f45d24d351
change if to !== 0
6 years ago
b7eaf4191e
return correct post count if its out of sync
6 years ago
77beaf2e15
Allow local login,closes #6800 ( #6803 )
...
* WIP
* reset groups cache after every suite
6 years ago
d92ef9ca11
remove id
6 years ago
cf4ea94e6d
Fix single-host-cluster socket.io ( #6802 )
...
It was silently dropping every message because every node thought it was the master node.
6 years ago
f95308bf33
move sharp require into the method it is used in src/file.js
6 years ago
ebabcc5e3c
if authenticate middleware is overridden by plugin, check for req.user and return notAllowed helper otherwise
...
/cc @LudwikJaniuk
6 years ago
4b970a1072
use lodash, load 3 posts per iteration
6 years ago
18d0deeccb
update deprecated methods ( #6794 )
6 years ago
1cb2e1e368
remove console.log switch to series
6 years ago
c9dfb4e109
closes #6790
6 years ago
02046889ec
closes #6691
6 years ago
11b655163e
Only run the DDL for session storage on the primary instance. ( #6788 )
...
This fixes a restart loop caused by deadlocks in large clusters.
6 years ago
1590452697
filter topics you cant read @benlubar
6 years ago
95501e8fee
closes #6738 closes #6290 ( #6785 )
...
* closes #6738 closes #6290
* fix test, delete keys
* delete all bans on user delete
* fix upgrade script to actually read reason
6 years ago
4570daa033
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
3ed856f587
change if
6 years ago
9724ef083e
remove v from query
6 years ago
786311fa64
use value
6 years ago
5a69f979a8
update processSortedSet to use withScores
6 years ago
cf75c79611
Unread changes closes #6781 ( #6783 )
...
* WIP
* more unread work
* faster teaser block handling
if user doesn't have anyone blocked don't check
* much faster filtering of blocked posts
* add missing uid
* add tidsByFilter to return
* dont load all pids to find previous non-blocked teaser
* fix unread filters
they no longer use unread/new unread/watched etc they are query strings now
* shorter nav item code
* add unreplied to filters
fix icons not clearing to 0
dont increment unread counters if there is a reply in a topic where you ignored the topic creator
6 years ago
7f863b8af0
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
17ce482c9f
closes #6780
6 years ago
7787c9b4bb
fix wrong year on upgrade script
6 years ago
24601694db
fix wrong year on upgrade script
6 years ago
edefab1d69
closes #6728
...
add option to disable a category on creation
show disabled categories on manage privileges
6 years ago
4d5e164fd2
closes #6778
6 years ago
59b988a205
change test so it checks url
6 years ago
71ccd67665
closes #6722
...
calculate size of base64 image from buffer, still not perfect but better than string.length
6 years ago
b7ead6dc9c
Replace jimp with sharp ( #6774 )
...
* add probe image size and max image size
* replace jimp and image-probe with sharp
* better name for test
* resize with just path
* resize thumb inplace
* use filename
6 years ago
69c7260fe9
dont let sending more than max invites via bulk invite
6 years ago
669a5135e1
closes #6768
6 years ago
dff86b1ac9
closes #6740
...
* flag notifications will go to the flag details page instead of the post or user that was flag
* if you assign a flag to yourself you won't get a notification about it
@benlubar
6 years ago
089bf5d8bb
closes #6773
6 years ago
382d06bbb0
fixes #6765 -- no need to have gmods and admins access login sessions page
6 years ago
d996ea27be
closes #6763
6 years ago
6a377568d2
closes #6764 fix typo in notif rescind
6 years ago
08dfb3470c
fix tests
6 years ago
b43bfa3d5b
closes #6759
...
-moved user.blocks.filter from unread controller to getUnreadTopics so
topics are filtered at other places this function is called
- when a new post is made do not send it to uids that have blocked the
poster
- update getUnreadTids so it does not return topics that have new posts
from blocked users
- update hasReadTopics so it does not return false data if topic has new
posts from blocked users
6 years ago
41aae6f418
closes #6749
7 years ago
37ca5a1c63
filter falsy teasers
7 years ago
93d52ef338
default to 'recent' sort
7 years ago
25fed0aa8d
change isPasswordCorrect to return false if user does not have password
7 years ago
6f18cf368b
closes #6741
7 years ago
446b125c83
escape post content
7 years ago
c7f3b76b4e
DRY req props that depend on auth ( fix #6727 ) ( #6731 )
...
* DRY req props that depend on auth (fix #6727 )
authentication leads to req.loggedIn and req.uid being set. However, a
later authentication event might outdate them. Here, I create one
function for setting those properties, and make sure it also is called
on the `action:middleware.authenticate` hook, which would be such an
authentication event. If there are other places, those should be added
as well.
* fix lint errors
* fix lint error
* change exports
7 years ago
3e1b007f9f
escape title in post queue
7 years ago
97a3079bc0
Optimize PostgreSQL session store.
...
- Sets session ID to be a constant-sized character field inline in the
table instead of a variable-length character field compressed outside
of the row.
- Changes the session data from "json" to "jsonb" which is faster and
smaller on disk with the drawback of not maintaining key order and
whitespace (which we don't care about at all)
- Adds a clustered index on the session expiration timestamp, which will
make periodic session purging much faster.
(For an example, WTDWTF currently has 482355 sessions in the table, and
because there is no index on the expiration timestamp, PostgreSQL must
check all the rows in the table every time.)
This upgrade script can run concurrently with a live NodeBB instance,
but any action that touches sessions will wait until the upgrade script
is done.
Does not touch the database if the database driver is not set to
PostgreSQL or if there is a Redis database configured.
7 years ago
c2c925cacd
closes #6678
7 years ago
29836aaad9
rename session account middleware to sessions, plural, prep for fixing #6678
7 years ago
5b45b2f72c
closes #6729
7 years ago
0519f84734
Promisify modules ( #6723 )
...
* WIP promisify
* promisify psql
* ability to skip some keys
* dont promisify client object
* remove async
* clone entire module so it has all properties
* add shim for node 6
* ignore sessionStore as well
* ignore pool on psql
7 years ago
c1725442ea
added progress bar to username_email_history upgrade script
7 years ago
545e678e8a
fixes #6726
7 years ago
5c04ec2d63
removed client-side chat message length check in favour of server-side check, firing new hook on messaging.checkContent for hooks to intercept
7 years ago
1e3cdc99ac
fixes #6702
7 years ago
a06b33a713
fix html characters when cloning children categories
7 years ago
aaa9561b7f
Revert "moved filter:post.getPostSummaryByPids to before parsePosts call"
...
This reverts commit cf82407a8f
7 years ago
cf82407a8f
moved filter:post.getPostSummaryByPids to before parsePosts call
...
/@pitaj
7 years ago
ae4016d9e0
add getCateries to helpers
7 years ago
12940b577b
closes #6703
7 years ago
2ce6a85756
properly closes #6698
7 years ago
f751d21d1e
removed debug line
7 years ago
f9d3484ec6
fixes #6543
7 years ago
ed9dc113b0
sanitizing notes in flags details page, fixes #6698
7 years ago
a77630c6be
closes #6697
7 years ago
33228bb7fe
PostgreSQL database driver ( #5861 )
...
* [test/database/list] Fix test list 4 being used in two different tests
* [database/postgres] PostgreSQL database driver
* [database/postgres] Make transactions work based on continuation scope.
* [database/postgres] Implement nested transactions
* eslint --fix
* Add database changes from earlier this week to the PostgreSQL driver.
* Fix typo
* Fix postgres.incrObjectFieldBy returning undefined instead of null when given NaN
* [database/postgres] Fix sortedSetsCard returning an array of strings.
* Update socket.io postgres adapter
* Fix PostgreSQL erroring when multiple updates are made to the same sorted set entry in a single operation.
Add a test case to catch this error.
* Fix lint errors.
* Only prune sessions on one instance in a cluster to avoid deadlocks.
They're caught and handled by the database server, but they spam the logs.
* Fix arguments.slice.
7 years ago
3cccbbc1f2
Add option to enable/disable HSTS
...
Also fix HSTS middleware being added twice.
7 years ago
1c286e4536
not even used
7 years ago
fa499aef18
closes #6680
7 years ago
e7bd0cea74
fix lint
7 years ago
bcef32c5af
closes #6645
7 years ago
Baris Usakli
Barış Soner Uşaklı
Julian Lam
André Zanghelini
Ben Lubar
LudwikJaniuk
Ben Lubar
Andrew Rodrigues
Jimb Esser