Julian Lam
7419922040
fix: improper override of req.body.username in login logic
5 years ago
Julian Lam
b820d23401
feat: new hook `filter:login.override`, deprecate `action:auth.overrideLogin`
5 years ago
Julian Lam
473d5f4aba
fix: full settings hash not passed through to action:settings.set
...
The sorted lists were being filtered out
5 years ago
Julian Lam
eb96046e97
Revert "refactor: use Map to track sorted lists in Settings.set()"
...
This reverts commit 65de2e76b4 .
5 years ago
Julian Lam
65de2e76b4
refactor: use Map to track sorted lists in Settings.set()
5 years ago
Baris Usakli
a5bf9779fd
fix : #9223 , don't overwrite stmp settings
5 years ago
Julian Lam
3052256db3
chore: deprecation notices for plugins using plugin old hook methods
5 years ago
Julian Lam
15ba0abb34
docs: update deprecation-removal version for plugin hook helper methods in 1.18.0
5 years ago
Barış Soner Uşaklı
e8429f509b
fix: handle delete and update for categories:name zset
5 years ago
Barış Soner Uşaklı
34c42c6fa3
feat: ability to search categories, #8813
5 years ago
Barış Soner Uşaklı
a1c014462c
revert: bring back backwards compat
5 years ago
Barış Soner Uşaklı
647d3ba810
fix: removed methods
5 years ago
Julian Lam
fb84c78544
chore: remove deprecated `User.emailConfirm` [breaking]
...
Use `User.email.confirmByCode` instead.
5 years ago
Julian Lam
5a775e09dc
chore: remove deprecated plugin hook `filter:privileges:isUserAllowedTo` [breaking]
...
Use `filter:privileges:isAllowedTo` instead.
5 years ago
Julian Lam
d41de481a4
chore: remove deprecated plugin hook methods [breaking]
...
Call plugins.hooks.fire() instead.
5 years ago
Julian Lam
cc0d562e9a
chore: more removals of thumb specific backwards-compatibility [breaking]
5 years ago
Julian Lam
5f9f241e37
chore: remove deprecated `filter:admin/header.build` hook [breaking]
...
Use `filter:middleware.renderAdminHeader` instead.
5 years ago
Julian Lam
84dfdfe659
chore: remove deprecated v2 style responses for thumbs upload route [breaking]
5 years ago
Julian Lam
2ad0d0d0d8
chore: remove deprecated getObject routes [breaking]
...
`/api/post/pid/:pid`, `/api/topic/tid/:tid`, `/api/category/cid/:cid` have now been removed in favour of routes in the Write API (`/api/v3/(posts|topics|categories)/:id`)
5 years ago
Julian Lam
7b090c588b
fix: incorrect return for Thumbs.get() if thumbs were disabled
5 years ago
Julian Lam
dc84559d0b
feat(topic-events): topic events GET route in write API
5 years ago
Julian Lam
449c379d22
feat(topic-events): server-side tests for topic events
5 years ago
Julian Lam
0d4a377558
feat(topic-events): clear out topic events when a topic is purged
5 years ago
Julian Lam
8e93bf7362
feat(topic-events): client-side handling on topic event log
5 years ago
Julian Lam
df2fdd56ba
fix(topic-events): repeated invocations of Posts.addTopicEvents caused dupes to be added to DOM
5 years ago
Julian Lam
cec3fc934d
refactor(topic-events): break out some logic in events.get into local modifyEvent method
...
+ events.log now returns a complete event object
5 years ago
Julian Lam
611d1f872d
feat(topic-events): support for uids in topic event payloads
5 years ago
Julian Lam
425eca145b
refactor(topic-events): fire topic event logging in topics/tools instead, pass uid into payload
5 years ago
Julian Lam
ab2e1ecb40
feat(topic-events): work in progress topic events logic and client-side implementation
5 years ago
Julian Lam
8ff07bc196
fix: update js concatenation logic to bundle scripts.rjs into minfile regardless of build environment
...
The slowdown is fairly insignificant (< .1s), and the only change is the minified file is identical across environments, which is better from a debugging standpoint
5 years ago
Julian Lam
412d285850
fix(hooks): fallback handling for core invocations of hooks.fire
...
+ .on() which is the same as .register()
5 years ago
Julian Lam
f975063b7d
fix : #7125 , allow list for page route, configurable via plugin hook
5 years ago
Julian Lam
8b72479f62
fix: remove 'filters' and 'categories' from flag details API return [breaking]
...
These options were originally used when the flag filters were shown in the sidebar. This has seen been removed, and so the information is now superfluous
5 years ago
Julian Lam
1603566bcc
fix: filtering logic of flags [breaking]
...
When combining filters, the old logic assumed that every filter was
exclusive, unless that filter contained multiple items, in which
case it was added to a list of "or" filters that returned all
matching flags.
A fault was discovered in that if you passed in multiple "or"
states, it did not return flags with the expected filtering.
e.g. open flags, closed flags, flags of cid 1, flags of cid 2
This could return open flags of cid 3, since all of the filters
were "OR"'d.
This logic change updates the behaviour so disparate OR sets are
intersected (ANDed).
5 years ago
Julian Lam
942d924779
fix: error on flag list if no flag filters were saved in session
5 years ago
Julian Lam
6b1c97db79
feat: feature flag for auto-resolving a user's flags on ban [breaking]
...
The default behaviour has now been changed to 'off'. Going forward, a user's flags will no longer automatically resolve on ban.
5 years ago
Julian Lam
35c92d0cff
fix: mod cid filter accidentally saved in session
5 years ago
Julian Lam
27cae0d5d8
fix: missing return for #9217
5 years ago
Julian Lam
b2b1450e5d
fix : #9217 , render 400 error page on bad access to /register
5 years ago
Barış Soner Uşaklı
78896fc623
fix: redis check compat tests
5 years ago
Barış Soner Uşaklı
fdfbc90255
feat: async/await redis connection
5 years ago
Barış Soner Uşaklı
33bf1b0e2c
feat: async/await psql connection
5 years ago
Barış Soner Uşaklı
672959c13f
feat: add group name to csv event
5 years ago
Julian Lam
a186ea0fe3
fix: registration completion overriding returnTo if it was already set
5 years ago
Julian Lam
280285cda9
feat: allow interstitial callbacks to be async functions [breaking]
...
This change is breaking in the sense that if you have written
interstitial callbacks before that are async functions _with_ a
callback, those are no longer allowed. You will not need to call
next() as that argument will no longer be passed in to async
functions.
5 years ago
Barış Soner Uşaklı
5c1b742979
fix: add missing user delete event types
5 years ago
Barış Soner Uşaklı
7fb583dcfd
Merge branch 'master' of https://github.com/NodeBB/NodeBB
5 years ago
Barış Soner Uşaklı
c608b0e8a3
fix: https://github.com/NodeBB/nodebb-plugin-webhooks/issues/3
5 years ago
Julian Lam
d85ad10d34
fix: restored sanity checks for post move socket calls
5 years ago
Julian Lam
966c4117ec
refactor(api): post move to write API
5 years ago
Julian Lam
e118e59ce0
refactor(api): post diffs to use write API
5 years ago
Barış Soner Uşaklı
c2e2370655
feat: add filter:email.cancel to allow plugins to cancel sending emails
5 years ago
Julian Lam
f5fcd232f6
fix: regression caused by 77ab46686d
...
Access checks were added for topic GET route, but occasionally a post_uuid is passed in, which is available to everyone, and so checks should be skipped
5 years ago
Barış Soner Uşaklı
4fb907875e
fix: don't crash if fullname is not a string
...
https://community.nodebb.org/topic/15291/upgrade-error-fullname-substr-is-not-a-function
5 years ago
Barış Soner Uşaklı
1374e0eeba
refactor: change var to const
5 years ago
Barış Soner Uşaklı
00ba89b6d6
fix : #9204 , bypass groupname length check for system group in upgrade script
5 years ago
Barış Soner Uşaklı
9938a139fe
fix: add missing await
5 years ago
Barış Soner Uşaklı
25ab99b91d
refactor: single remove call
5 years ago
Julian Lam
ab11435ed5
feat: grant plugins the ability to specify options to the SSO handler
...
... to be handled in the plugin itself (overriding the passport prototype's authorizationParams method)
+ new hook filter:auth.options
5 years ago
Julian Lam
9b289eca9d
fix: ssoState passed to strategies even if not called for
5 years ago
Julian Lam
77ab46686d
fix: access checks for tags and thumbs get route
5 years ago
Julian Lam
c0fb1cb59c
fix : #9194 global mods unable to pin or unpin topics
5 years ago
Barış Soner Uşaklı
ef16cd2e6f
fix : #9192 , exit after logging error
5 years ago
gasoved
69419571a9
fix: make sure inviter user exists
5 years ago
Barış Soner Uşaklı
89e6c75d58
fix : #9185 , fix string boolean values
5 years ago
Julian Lam
66da6bcd1c
fix : #9184 proper relative_path usage in topic thumbs.get
5 years ago
Julian Lam
b742229e59
fix : #9169 , re-adding v2-style behaviour so as to not break the API... yet
5 years ago
Barış Soner Uşaklı
aa95cc7d60
Merge branch 'master' of https://github.com/NodeBB/NodeBB
5 years ago
Barış Soner Uşaklı
eaf62d39fd
fix : #9177 , handled multiple deleted users properly
5 years ago
Julian Lam
4ede18ce5f
fix: broken test caused by errant .pop(), missing await
5 years ago
Julian Lam
c07e1e16af
feat: add unread-count badge if navigator contains /flags route
5 years ago
Julian Lam
6a1311b4bc
refactor: flags lib to have a separate getFlagIdsWithFilters method
...
added quick filter for unresolved flags
5 years ago
Julian Lam
6cb5888c13
fix: unescape header navigation originalRoute [breaking]
5 years ago
Julian Lam
03a0e72fae
refactor: split out logic dedicated to calculating unread counts, to a separate local method
5 years ago
Manuel Valle
e14b67786c
Solve Custom home page route error bug ( #9180 )
...
When you select Custom Route as home you get a 404 error "/custom not found" error.
This because 'homePageRoute' property was used instead of 'homePageCustom'
5 years ago
Barış Soner Uşaklı
7069735aa2
Merge branch 'master' of https://github.com/NodeBB/NodeBB
5 years ago
Barış Soner Uşaklı
da54697075
fix : #9176 , limit description size
5 years ago
Julian Lam
97d678fd2a
fix: return a user object, not an array of user objects (in v3 login check route)
5 years ago
Julian Lam
8c86f5bcec
fix: bad execution flow in utilities.login
5 years ago
Julian Lam
534224133b
fix: random loadFiles added by errant vscode autocompletion
5 years ago
Julian Lam
8bbb320867
feat: handle HTTP 429 as a response code
5 years ago
Julian Lam
56f929ed4f
feat: add write API route for checking login credentials
5 years ago
Julian Lam
1cf0032d9f
feat: allow override of local fns in login controller, 400 instead of 500 for wrong login type [breaking]
5 years ago
Barış Soner Uşaklı
6cbb77afda
fix: add missing breadcrumb on /user/<slug>/categories
5 years ago
Barış Soner Uşaklı
f0dd302c77
perf: use only required calls
5 years ago
Peter Jaszkowiak
a51c5698c7
fix: `--help` usage info
...
yargs (via nconf) would exit when detecting a help flag
also improves the speed of `./nodebb help build`
5 years ago
Julian Lam
171017c38c
fix : #9130 , remove timestamp prefix from thumbnail names in API response
5 years ago
Barış Soner Uşaklı
8c31afae7d
feat: #9173 , show installed plugin versions in ./nodebb plugins
5 years ago
Julian Lam
b9ba44edd7
fix : #9166 missing relative path in topic thumbs modal and topic list
5 years ago
Barış Soner Uşaklı
1968bf50f1
fix : #9163 , fix total connection count on ACP
...
sockets.sockets is a JS map in 3.x
5 years ago
Julian Lam
edb8da1ef9
feat(api): closes #9123 category and topic routes migrated to Write API
5 years ago
Julian Lam
9ecfac9b68
feat(api): #9123 , migrate rest of the getObject controllers to Write API
5 years ago
Julian Lam
cdff8d286a
chore(api): add deprecation notices re: #9123
5 years ago
Julian Lam
e267f29584
feat(api): #9123 , migrate /api/post/pid/:pid to Write API
5 years ago
Barış Soner Uşaklı
33290850ee
fix : #9126 , skip base64 and long values
5 years ago
Barış Soner Uşaklı
c1ecfd1ebf
feat: #9135 , don't try to reconnect forever
5 years ago
Julian Lam
a555f02415
fix: inability for admins with setting privilege to save plugin settings
5 years ago
Julian Lam
895e3d939e
fix : #9149 , server-side handling of disableChatMessageEditing
5 years ago
Julian Lam
d27815a8c0
fix : #9149 , incorrect client-side `disableChatMessageEditing` value for admins/gmods
5 years ago
Julian Lam
2874036024
fix: tests
5 years ago