1391 Commits (c27567289f9937abd4abe6960a9b6e387cf68331)

Author SHA1 Message Date
Barış Soner Uşaklı e0b2065802 test: update socket.io test 2 years ago
Barış Soner Uşaklı 1aff9cad91 lint: fix arrow 2 years ago
Barış Soner Uşaklı 37b48b82a4 fix: don't crash if event name is not a string 2 years ago
Barış Soner Uşaklı 767c1d1faf fix: thumb remove on windows, closes #11357 2 years ago
Barış Soner Uşaklı 56427e4f9d fix: closes #11343, don't crash if tags array is empty 2 years ago
Julian Lam 1b29dbb69d test: add dummy emailer hook in authentication test 2 years ago
Barış Soner Uşaklı 845c8013b6
fix: #11259, clean old emails when updating via admin (#11260)
when admin is changing users emails check if its avaiable and remove old email of user first
upgrade script to cleanup email:uid, email:sorted, will remove entries if user doesn't exist or doesn't have email or if entry in user hash doesn't match entry in email:uid
fix missing ! in email interstitial
fix missing await in canSendValidation,
fix broken tests
dont pass sessionId to email.remove if admin is changing/removing email
2 years ago
Julian Lam fecd84d1a0 revert: a788bd1344 2 years ago
Julian Lam a788bd1344 revert: 9c250b78b0, fix: comment out broken test for now 2 years ago
Julian Lam f295174e07 test: fix broken test 2 years ago
Julian Lam 459bc52338 fix: #11136, tests, and returning the proper number of arrays 2 years ago
Barış Soner Uşaklı 586eed1407
fix: vulnerability in socket.io nested namespaces (#11117) 2 years ago
Barış Soner Uşaklı 1ea9481af6 fix: lock post/reply similar to user.create 2 years ago
Barış Soner Uşaklı c2bb2b30be test: dont try to load admin upload routes 2 years ago
Julian Lam 10ba7b9ced Merge branch 'master' into develop 2 years ago
Barış Soner Uşaklı abcfb63126 fix: #11044, allow banned users to post
if given privileges
2 years ago
Barış Soner Uşaklı 3c85b944e3 feat: allow groups to be exempt from maintenance mode
closes #11030
2 years ago
Julian Lam 892ac2eb20 Merge branch 'master' into develop 2 years ago
Julian Lam 2f9d8c350e fix: pass csrf_token into calls to /register/abort, #11017 2 years ago
Julian Lam 97d8b53fd3 Merge branch 'master' into develop 2 years ago
Barış Soner Uşaklı 06d1539137 test: fix tests again 2 years ago
Barış Soner Uşaklı c833d3cdc4 test: fix test 2 years ago
Julian Lam 96b46411b1 Merge branch 'master' into develop 2 years ago
Julian Lam 9c576a0758
Email confirmation QOL updates (#10987)
* breaking: remove `SocketUser.emailConfirm`, re: #10954

* chore: move email confirmation related configs to own section in Settings > Email

* feat: new user email method `getValidationExpiry`, returns expiration in ms.. probably.

* fix: bug where `user.email.isValidationPending` returned an u nexpected non-boolean value if there was no confirmation pending (only when checking email as well)

* fix: update getValidationExpiry to return ms

* test: use emailConfirmInterval for tests, for now

* fix: throw friendly error when attempting an email change within email confirmation window

* feat: new config option `emailConfirmExpiry` in days, governs how long the confirm link is good for

* test: additional tests for user email methods

* fix: add back missing handling of  option

* test: fix tests
2 years ago
Barış Soner Uşaklı 61d32bdebb fix: category ordering add test 2 years ago
Barış Soner Uşaklı 177d904812 fix: category ordering add test 2 years ago
Julian Lam 6391f77b01 Merge remote-tracking branch 'origin/master' into develop 2 years ago
Barış Soner Uşaklı b5dd89e1c0
feat: store topic title and tags in diffs (#10900)
* feat: store topic title and tags in diffs

allow restoring post diff if tags didn't change

* test: fix tests, fast computer problems
2 years ago
Barış Soner Uşaklı c039a699bd sharp test fix 2 years ago
Barış Soner Uşaklı 1c9c39a8c8 test: add back /admin/extend/plugins test 2 years ago
Barış Soner Uşaklı b45e241390 lint: fix lint error 2 years ago
Barış Soner Uşaklı 1dc79d76a0 test: disable nbbpm test temporarily 2 years ago
Julian Lam 15b1561fd3 feat: introduce ACP defined option to rescind notif or do nothing on flag resolve/reject
/cc #10867
2 years ago
Julian Lam b3b48fa62f Merge remote-tracking branch 'origin/master' into develop 2 years ago
Julian Lam 7c5a915dc9 test: have some build tests not pollute build folder 2 years ago
gasoved b424ba4637 test: User.hidePrivateData 2 years ago
Julian Lam c07d595662
Update to lru-cache@^7 (#10815)
* chore(deps): bump lru-cache from 6.0.0 to 7.13.1 in /install

Bumps [lru-cache](https://github.com/isaacs/node-lru-cache) from 6.0.0 to 7.13.1.
- [Release notes](https://github.com/isaacs/node-lru-cache/releases)
- [Changelog](https://github.com/isaacs/node-lru-cache/blob/main/CHANGELOG.md)
- [Commits](https://github.com/isaacs/node-lru-cache/compare/v6.0.0...v7.13.1)

---
updated-dependencies:
- dependency-name: lru-cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix(lru-cache): remove unneeded `length` params for cache creation, as `maxSize` was not used in those init calls, also renamed some methods to match new method names in lru-cache [breaking]

Added deprecation notices for old params

* fix: replace three direct calls to lru-cache with call to cacheCreate, moved cache creation call in uploads to run on first init as config is not populated at lib init

* test: move configs init above cache reset calls in databasemock

* move some more code above cache clear

* refactor: remove unused

* test: lru

* test: more debug

* test: on more test

* use await helpers.uploadFile

* fix: tests remove logs

* fix: acp cache page

* fix: add in one more guard again cache instantiation with `length` prop but no `maxSize` prop

* fix(deps): bump markdown

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
2 years ago
Julian Lam 59f3ae201a Merge remote-tracking branch 'origin/master' into develop 2 years ago
Barış Soner Uşaklı 961be70725 fix test on redis 2 years ago
Julian Lam 65c59cc16a test: additional tests for password challenge on email update 2 years ago
Julian Lam 8e1a4bb5df test: add dummy emailer hook to suppress sendmail error logging 2 years ago
Julian Lam 68bcd7f48e test: fix one last failing test 2 years ago
Julian Lam 342cca35c1 chore: re-order interstitial tests so email and gdpr tests are in sub-blocks 2 years ago
Julian Lam 9ee1afbb0f Merge branch 'master' into develop 2 years ago
Julian Lam 06f089afda test: fix user email tests 2 years ago
Julian Lam 3b296c3aa4 Merge remote-tracking branch 'origin/master' into develop 2 years ago
Julian Lam f93a0b83bb test: fix tests so that when user.create is called, email is set prior to confirmation 2 years ago
Julian Lam 1ca09b63ed fix: #10809, test runner to only run tests for plugins included in `test_plugins` 2 years ago
Opliko 23cb67a112 feat: Allow defining active plugins in config (#10767)
* Revert "Revert "feat: cross origin opener policy options (#10710)""

This reverts commit 46050ace1a.

* Revert "Revert "chore(i18n): fallback strings for new resources: nodebb.admin-settings-advanced""

This reverts commit 9f291c07d3.

* feat: closes #10719, don't trim children if category is marked section

* feat: fire hook to allow plugins to filter the pids returned in a user profile

/cc julianlam/nodebb-plugin-support-forum#14

* fix: use `user.hidePrivateData();` more consistently across user retrieval endpoints

* feat: Allow defining active plugins in config

resolves #10766

* fix: assign the db result to files properly

* test: add tests with plugins in config

* feat: better theme change handling

* feat: add visual indication that plugins can't be activated

* test: correct hooks

* test: fix test definitions

* test: remove instead of resetting nconf to avoid affecting other tests

* test: ... I forgot how nconf worked

* fix: remove negation

* docs: improve wording of error message

* feat: reduce code duplication

* style: remove a redundant space

* fix: remove unused imports

* fix: use nconf instead of requiring config.json

* fix: await...

* fix: second missed await

* fix: move back from getActiveIds to getActive

* fix: use paths again?

* fix: typo

* fix: move require into the function

* fix: forgot to change back to getActive

* test: getActive returns only id

* test: accedently commented out some stuff

* feat: added note to top of plugins page if \!canChangeState

Co-authored-by: Julian Lam <julian@nodebb.org>
Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
3 years ago
Julian Lam 05c30677f5 test: fix i18n tests 3 years ago