609e37a67b
feat: remove deprecated utils.walk
5 years ago
55b0e902fb
feat: consolidation of flags to reduce flagspam, #8510
...
Squashed commit of the following:
commit c6d09396208a10c244d7b3d22ffd2d7dd1274d3a
Author: Julian Lam <julian@nodebb.org>
Date: Fri Jul 24 13:41:32 2020 -0400
fix: more tests
commit 32f9af2a87a81fa62ecca01e71d6f0d5b9d37ba1
Merge: e50907535 4eae927d1#8510
commit 08c75c020021ada754bf0e39eae77d631b01dee5
Author: Julian Lam <julian@nodebb.org>
Date: Thu Jul 16 20:53:18 2020 -0400
feat: upgrade script for #8510
5 years ago
2cdb935f1d
feat: remove file.isFileTypeAllowed
5 years ago
b9cff5775c
fix: edge case in test
...
if user is created the other one will be renamed
5 years ago
844f2b4ed0
feat: #8524 , allow editing category of queued topic
5 years ago
6f889c9c83
fix: try again
5 years ago
a46adb3fd5
fix: more tests
5 years ago
65395ae59d
fix: tests
5 years ago
2485a55092
feat: #8521 , allow editing title before posting from queue
5 years ago
00d39fb32c
feat: #8460 , export groups members as csv
5 years ago
73ddf1cb98
fix: groups.updateCover
5 years ago
c513b88dff
feat: #8427 , daily downvote limits
5 years ago
c2ca02dfc7
fix : #8474
...
make isPrimary and isCluster always booleans
they were strings when using ./nodebb start and boolean if they were in config.json and started with node app.js
5 years ago
02ac44cc5a
fix: dont allow searching by ip/banned/flagged for regular users
5 years ago
e95cd28f6f
Zscan ( #8458 )
...
* feat: zscan
* fix: mongodb tests
* feat: scan, ip search starts with
5 years ago
723fe8e8e0
feat: zscan ( #8457 )
...
* feat: zscan
* fix: mongodb tests
5 years ago
f0ce309d03
fix: test
5 years ago
c718b7293e
feat: #3783 , min/max tags per category
5 years ago
6aecc1770c
feat: increase wait
5 years ago
f03ca0867b
fix: tests
5 years ago
48b41debe6
fix: vulnerability in cover and admin uploads ( #8419 )
...
* fix: vulnerability in cover and admin uploads
* fix: remove old test
* fix: update tests
5 years ago
bef37e27cb
fix: test lock for user create ( #8415 )
...
* fix: test lock for user create
* fix: redis hdel with undefined
* feat: add test for undefined key in deleteObjectFields
5 years ago
f909ed2541
feat: show editor in post diffs if available
5 years ago
d5578c9906
fix: tests breaking due to #8406
5 years ago
18d892398f
fix: add timestamp to initial username history
5 years ago
bb3aa54006
feat: merge changes
...
allow selecting main topic to merge into
allow specifying a new title for merge topic
upon merge go to correct topic
new tests for merging with options
5 years ago
3be4d5f7d5
feat: redirect /me to user profile
5 years ago
6b1d1acb48
fix(style): more switch..case
5 years ago
75b3a81dad
fix: clear error log before checking
...
fix intermittent test failure due to analytics being written every 10 seconds
5 years ago
de7ec47f13
fix : #8352 , remove webfonts ( #8354 )
5 years ago
da90fd562e
fix: more tests
5 years ago
a51fff8bd1
refactor: remove general menu from ACP ( #8347 )
...
* refactor: remove general menu from ACP
* fix: incorrect translation keys, fixed tests
5 years ago
a66fe01377
fix: test breakages from 8d995d1eb6
5 years ago
0009f54e6e
feat: add getSortedSetMembers
5 years ago
ec5582b53c
feat: add privilege give/rescind hooks ( #8336 )
...
* feat: add privilege give/rescind hooks
action:privileges.categories.give/rescind
action:privileges.global.give/rescind
breaking change, privileges.categories.give/rescind and privileges.global.give/rescind use full privilege name for groups ie `groups:find` instead of `find`
* fix: tests, privileges renamed
5 years ago
3b6d57e497
refactor: move code
5 years ago
4ee3543ea4
feat: tweak intersection code, add tests
5 years ago
6f504c4142
Remove allowFileUploads ACP option ( #8324 )
...
* feat: allow awaitable upgrade scripts
* feat: allowFileUploads removal upgrade script
* refactor: remove unnecessary ACP option `allowFileUploads`
* fix: updated upgrade script template to not use callback arg
* fix: upgrade script as per @baris
* fix: add missing await
* fix: add missing await
5 years ago
f2907908c9
fix: another test fix
5 years ago
feb748a44d
fix: tests
5 years ago
12c6bc2e07
feat: convert queries so they used indices directly
5 years ago
7a801abade
fix: tests on redis
5 years ago
a032e12b7e
fix: tests
5 years ago
81e33b9391
fix : #8317
5 years ago
bfad457275
feat: add methods for adding/removing tags from topics
5 years ago
97c086aba9
fix: missing await
5 years ago
edf9fe3b7f
feat: add null tests for sorted sets
5 years ago
aad0880f7c
feat: add filter:categories.getRecentTopicReplies
...
pass req.query to getRecentTopicReplies
5 years ago
a969c5cec9
feat: allow activating additional plugins for testing via config.json
5 years ago
3a23ddaba5
feat: move plugin tests to separate file
5 years ago
a6bb9f4364
fix : #3321 , run plugin tests for installed plugins
5 years ago
3d0db9630f
fix: remove deprecated mocha.opts
5 years ago
9d153fd388
fix : #8287 , dont readd user after deletion
...
don't add user uid back to users:* sorted sets if they are deleted
upgrade script to fix users:* sorted sets
5 years ago
0391856d7d
fix : #8286 , rescind notif when its resolved/rejected
5 years ago
ccc6118d30
Testing suite integration for openapi spec ( #8263 )
...
* feat: testing suite integration for openapi spec
The testing suite now takes the openapi spec into account. It will
check each route defined, make a call to it, and compare the
response with the defined schema. Any mismatches will cause the
test to fail.
* fix(openapi): removed debug stuff from tests
* fix(openapi): fixed some tests
* fix(openapi): added additional check to tests, test fixes
* fix(openapi): better tests, fixed spec errors
* fix(openapi): bad conditional in test
* fix: oops
* fix(openapi): more tests fixing
* fix(openapi): more tests
* fix(openapi): fix some more tests
* fix: verbose'd an info log
* fix: topic pagination route returns schema-optimized pagination block
* fix(openapi): more test/spec fixes
* fix(openapi): accidentally sending in authenticated jar for anon routes
* fix(openapi): more test/spec fixes
* fix(openapi): more spec fixes
* fix: timestampReadable Invalid Date
* fix(openapi): more tests... almost there
* fix(openapi): more tests fixing
* fix(openapi): finally all tests passing
* fix(openapi): added reverse test to compare response to spec
... and fixed all the tests that broke
* fix: remove tests related to group covers, as route is gone
* fix(openapi): broken test on travis
* fix(openapi): broken test on travis
* fix(openapi): broken test on travis
* fix(openapi): object cache is not present for psql
* fix: tests
Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
5 years ago
6edf02d4a5
fix: remove upload picture test (avatars)
5 years ago
442fe65f5a
fix: remove tests related to group covers, as route is gone
5 years ago
8387178b25
feat(openapi): merging openapi-test branch into master
5 years ago
8e23dec84b
fix: lint
5 years ago
e72a29b3fd
fix: return null if field does not exist
5 years ago
3c9689a5ac
feat: settings sorted list ( #8170 )
...
* feat: settings sorted list
see https://github.com/NodeBB/nodebb-plugin-quickstart/pull/9/files for sample
5 years ago
067034082f
fix : #6422 , update deleted/restored messages
5 years ago
4d0636f847
fix : #8163 , prevent account deletion
5 years ago
d6e3f3f058
fix : #8142 , broken site if no server-side session ( #8148 )
...
* fix : #8142 , broken site if no server-side session
During the `addHeader` middleware, a check is now done to see if
`req.session.meta` is present. This value is only present if the user
has a valid server-side session. If it is missing, then it is probably
safe to assume that the server-side session was deleted (either
intentionally or accidentally). In that scenario, the client-side cookie
should be cleared.
Also, there was an issue where the sessionRefresh flag was never cleared
after a successful login, so that was fixed too.
* feat: exported method to get cookie config
* fix: don't clear cookie if cookie is being set
* fix: socket.io tests
Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
5 years ago
87225a90c3
fix : #8134 , upgrade mkdirp to 1.0.x
5 years ago
8c48f94b96
fix : #8139 , dont allow restore if not deleted by self
5 years ago
66febb8071
feat: add test for isOnline
5 years ago
df2c785127
feat: add test for change post owner
5 years ago
23810cc64b
fix : #8133 , check if user is in room before removing
5 years ago
418c174d56
fix: dont return flag data to client
5 years ago
51236df4ed
fix: check if user has read priv before flagging
5 years ago
1f13ab8a19
fix: restrict getUsersInRoom to members
5 years ago
ecc579a29c
fix: tests for messaging
5 years ago
1b08f37612
fix: tests, was using hardcoded message id
5 years ago
bfaba89557
Merge branch 'master' of https://github.com/NodeBB/NodeBB
5 years ago
8e5a2276af
feat: check flag values on save (assignee and state) ( #8122 )
...
* feat: add assignee checking when updating flag
Prior to this, it was possible to update the assignee to any value (or
any user. This commit adds checking to allow only admins, global
moderators, or in the case of flagged posts, moderators.
Also some prep work was added for value checking `state`.
* feat: value checking `state` on flag update
The state should be one of the constants defined earlier in the file.
5 years ago
6a63c1a100
fix: escape system message, don't allow editing system messages
5 years ago
8c6a7954cf
fix: delete upload
5 years ago
01d1ae78c8
fix : #8120 , bubble errors from static hooks
5 years ago
3e52557689
fix: change owner missing await
5 years ago
e06c1bfcd2
fix: escape config.userLang/acpLang, don't allow invalid language codes
5 years ago
61da8c29ac
fix: group create/join/update name validation
5 years ago
10989cccaa
fix: meta description missing if url doesn't have post index
5 years ago
9d074731f4
fix: login with weak password
5 years ago
c2cd7de891
fix : #8069 , dont show hidden groups in search
5 years ago
0efe27b1f2
fix: make _csrf a secure cookie if the website is using https ( #8045 )
...
* Make _csrf a secure cookie if the website is using https
* fix style for TravsCI
* Add `url_parsed` to databasemock
5 years ago
480a64aaa7
feat: #7467 , pass query params when redirecting to posts
5 years ago
e3c9dafa08
fix: tests
5 years ago
1cedc4a0d6
feat: #7957 , allow post queue based on group
...
allow multiple select in ACP pages
5 years ago
cf7e0cfd2d
feat: no more session cookie for guests ( #7982 )
...
* feat: no more session cookie for guests
* fix(tests): added additional tests and fixed the broken test
5 years ago
441dd86d29
fix: convert param to string in slugify
...
fixes adding users to privilege table
5 years ago
ca3be1f336
fix : #7974 ( #7976 )
5 years ago
0da4f7ee8d
fix: event tests
5 years ago
661a0f5068
fix: don't show deleted topics on unread
5 years ago
75bcb0f484
fix: remove unused data from post/topic/user hashes
5 years ago
6fb29e8408
fix: tests
5 years ago
02d38caf47
refactor: async/await
5 years ago
3caa387ac6
fix: tests
5 years ago
9c051386d5
fix: tests
5 years ago
ffe3670ff5
feat: deprecate file.isFileTypeAllowed
...
use image.isFileTypeAllowed, this function was always meant for images
5 years ago
310c6fd33f
properly filter /unread /recent /popular /top ( #7927 )
...
* feat: add failing test for pagination
* feat: test
* fix: redis tests
* refactor: remove logs
* fix: add new test
* feat: make sortedSetRangeByScore work with keys on redis
* fix: hardcoded set name
* feat: show topics from readable categories on recent/popular/top
* feat: rewrite unread topics
respect watched categories and followed topics
* fix: term + watched
5 years ago
22b02f1407
feat: add failing test for pagination ( #7924 )
...
* feat: add failing test for pagination
* feat: test
* fix: redis tests
* refactor: remove logs
5 years ago
b602c04463
feat: refactor getSortedSetRange to allow big arrays
5 years ago
1e5246f9ad
feat: add new test
5 years ago
f9d6912b4a
refactor: async/await file
5 years ago
96ab8d05aa
fix: only allow png/jpg/bmp in cover/profile images
5 years ago
ecf39727cc
fix : #7912
5 years ago
b9583ed838
Add privilege for accessing user information ( #7859 )
...
* Add view users info global privilege
* Show user ip only to global mods and admins
* fix missing comma
* Hide link for users without correct privilege
* move getting privilege information to getAllData
* Hide the link from Global Moderators as well
* Give Global Moderator view:users:info privilege
* Restrict ip in post menu to view:users:info
* add some trailing commas....
* Add privilege to categories test
* Add group privilege to categories test
* add upgrade script
* fix style for TravisCI
* more styling - change spaces to tabs
* some more styling fixes (hopefully final one)
* fix style for Travis CI
* hide ip in chat messages
* Don't show even hidden ips on user profile page
5 years ago
de4619689b
fix: change params
5 years ago
1796b65d34
feat: option to restrict group leaving, closes #7770
5 years ago
30a86ed553
fix : #7853 , dissociation on post purge
5 years ago
aea04de094
feat: update LESS to v3.x, #7855 ( #7867 )
...
* feat: #7855
* fix: tests
6 years ago
f15c7f12b3
refactor: async/await
6 years ago
1e0190abef
fix : #7842 , groups.invite works with an array of uids
6 years ago
fa26855671
feat: #7842 , make isInvited, isPending work with uids
6 years ago
c44bf48c01
fix: removed console.logs
6 years ago
f736f0b382
fix: broken tests from 71b205a889
6 years ago
23046bab9a
Merge branch 'master' of https://github.com/NodeBB/NodeBB
6 years ago
2abe244b6e
fix: newPostEditDuration
6 years ago
dec8040c09
feat: widgets/index.js
...
enable widget-essentials in tests
fix widget test
6 years ago
3c32d8600f
fix : #7788 No new posts ( #7793 )
...
* feat: debug no-new-posts
* feat: add test for user delete
* fix: timeout for flag test
* feat: shorter
6 years ago
79eed9ae60
feat: #7743 meta/templates.js
6 years ago
0b498acdcf
fix : #7765
6 years ago
2f0a331f02
fix: don't return promise
6 years ago
44a3352003
fix: socket.io methods calling callbacks twice if method returns promise
6 years ago
4fb271c684
System chat messages ( #7771 )
...
* fix: removed duplicate checkContent call in addMessage
addMessage is called in one place (sendMessage), and the checks
are already contained there. addMessage is the lower level call
and so should be called only from within core itself.
* feat: #7330 chat system messages for join, leave, rename
* fix: add back content checking in .addMessage();
* fix: tests, and added .addSystemMessage() method
Tests were relying on message indices that changed due to the
new system messages.
* feat: add tests for system chat messages
* refactor: rewrite half of src/messaging/rooms.js, fix tests
* feat: #7743 messaging/room.js
* fix: tests for messaging/room.js, #7743
* fix: trying to fix tests
* fix: omg :rage2:
6 years ago
c0c6c652be
feat: #7743 , finish post module
6 years ago
1b2b308a7e
feat: #7743 , posts module
6 years ago
cd80c2638c
feat: #7743
...
user/password
user/picture
6 years ago
0a690c5710
feat: #7743
...
user/online.js
6 years ago
fe4c048198
feat: #7743
...
user/index.js
user/info.js
user/invite.js
user/jobs.js
6 years ago
cd2e68cb2d
feat: remove unused code, add 2 tests
6 years ago
53e1b349ae
Change post owner ( #7752 )
...
* feat: #7749 , allow array of keys for setObject
* feat: sortedSetRemoveBulk
* feat: test for bulk remove
* feat: #7083 , ability to change post ownership
* feat: #7083 , fix tid:<tid>:posters
* feat: #7083 , front end
* fix : #7752 , psql methods
* fix: add missing await
* fix: maybe psql
6 years ago
4170abfd6b
feat: add utils.promiseParallel
6 years ago
805dcd7ca2
Async refactor in place ( #7736 )
...
* feat: allow both callback&and await
* feat: ignore async key
* feat: callbackify and promisify in same file
* Revert "feat: callbackify and promisify in same file"
This reverts commit cea206a9b8e6d8295310074b18cc82a504487862.
* feat: no need to store .callbackify
* feat: change getTopics to async
* feat: remove .async
* fix: byScore
* feat: rewrite topics/index and social with async/await
* fix: rewrite topics/data.js
fix issue with async.waterfall, only pass result if its not undefined
* feat: add callbackify to redis/psql
* feat: psql use await
* fix: redis 🌋
* feat: less returns
* feat: more await rewrite
* fix: redis tests
* feat: convert sortedSetAdd
rewrite psql transaction to async/await
* feat: 🐶
* feat: test
* feat: log client and query
* feat: log bind
* feat: more logs
* feat: more logs
* feat: check perform
* feat: dont callbackify transaction
* feat: remove logs
* fix: main functions
* feat: more logs
* fix: increment
* fix: rename
* feat: remove cls
* fix: remove console.log
* feat: add deprecation message to .async usage
* feat: update more dbal methods
* fix: redis :voodoo:
* feat: fix redis zrem, convert setObject
* feat: upgrade getObject methods
* fix: psql getObjectField
* fix: redis tests
* feat: getObjectKeys
* feat: getObjectValues
* feat: isObjectField
* fix: add missing return
* feat: delObjectField
* feat: incrObjectField
* fix: add missing await
* feat: remove exposed helpers
* feat: list methods
* feat: flush/empty
* feat: delete
* fix: redis delete all
* feat: get/set
* feat: incr/rename
* feat: type
* feat: expire
* feat: setAdd
* feat: setRemove
* feat: isSetMember
* feat: getSetMembers
* feat: setCount, setRemoveRandom
* feat: zcard,zcount
* feat: sortedSetRank
* feat: isSortedSetMember
* feat: zincrby
* feat: sortedSetLex
* feat: processSortedSet
* fix: add mising await
* feat: debug psql
* fix: psql test
* fix: test
* fix: another test
* fix: test fix
* fix: psql tests
* feat: remove logs
* feat: user arrow func
use builtin async promises
* feat: topic bookmarks
* feat: topic.delete
* feat: topic.restore
* feat: topics.purge
* feat: merge
* feat: suggested
* feat: topics/user.js
* feat: topics modules
* feat: topics/follow
* fix: deprecation msg
* feat: fork
* feat: topics/posts
* feat: sorted/recent
* feat: topic/teaser
* feat: topics/tools
* feat: topics/unread
* feat: add back node versions
disable deprecation notice
wrap async controllers in try/catch
* feat: use db directly
* feat: promisify in place
* fix: redis/psql
* feat: deprecation message
logs for psql
* feat: more logs
* feat: more logs
* feat: logs again
* feat: more logs
* fix: call release
* feat: restore travis, remove logs
* fix: loops
* feat: remove .async. usage
6 years ago
8a6a58ee43
feat: added new admin option newbiePostEditDuration ( #7737 )
...
* feat: added new admin option newbiePostEditDuration
Also:
- Grammar-checked a couple language strings
- Moved a couple form inputs around in new user restrictions
- Added a test for the new option
- fix: 'defore' typo
6 years ago
bd640a1107
Topic await errors ( #7727 )
...
* feat: derp await
* feat: restore user.getSettings
* feat: cleanup
* feat: make tid const
* feat: cleanup
* fix: tests
* feat: deprecate filter:controllers.topic.get
* feat: rewrite post-index logic
* feat: change calculation to match others
* fix: use .async
* feat: remove try/catch wrapper
6 years ago
3ecd703ea3
feat: #7707 , added sortedSetAddBulk
6 years ago
a39f0ef592
fix : #5570 , create per category user post zsets
6 years ago
289dada5f7
fix(deps): update to eslint@6
6 years ago
a6436716ea
feat: hooks can now return promise or call callbacks
...
* hooks can now return promise or call callbacks, either way works
* cleanups
* moar cleanups and fix callback 1st null arg
* rm unnessesary spread
6 years ago
4b843ba16f
fix : #7567 , allow invite and approval at the same time
6 years ago
31ccc860d3
feat: allow multiple scores in sortedSetsAdd
6 years ago
8aef689f05
fix: no need for moderate bit for global mods and admins
6 years ago
035f624758
Remove implicit mod privs. closes #6345 ( #7648 )
...
* feat: add upgrade script to give mods privs
* feat: give all privileges when making a moderator
* feat: remove implicit privs
* feat: give global mods default privs
* feat: more priv fixes
* feat: use lodash
* fix: remove implicit mod priv from topic delete
* fix: more privs
* fix: posts.canEdit
* fix: canDelete and canEdit
* fix: tests, remove console.log
* feat: shorter functions
* feat: add tests
* fix: uids
* fix: redis random test fail
6 years ago
64679b37cc
fix : #7647 , fix getModeratorUids
...
sets.groupNames is an array that contains other arrays of groupnames so passing it to getMembersOfGroups returned wrong results when there were more than 1 element in it.
6 years ago
dfab231afd
Copy group privs ( #7610 )
...
* feat: ability to copy a groups privileges
ability to copy a group's privileges to all categories, or children of current category
* feat: switch to dropdown
added copy from category to groups
* fix: indents
6 years ago
b990312088
fix: test
6 years ago
2c98dd5f9d
Object cache refactor ( #7558 )
...
* fix: cache refactor
db.getObjectField no longer loads entire object
db.getObjectsFields only clones data once
more tests
* feat: add back cache to redis
db.getObjectField no longer loads entire object
6 years ago
808c4909a4
fix : #6438 only apply whitelist when fields request empty ( #7528 )
...
* fix : #6438 only apply whitelist when fields request empty
* feat: explicit password retrieval denied via getUsersFields
6 years ago
Barış Soner Uşaklı
Julian Lam
Peter Jaszkowiak
Andrew Rodrigues
Opliko
Aziz Khoury