fe072d6091
Allows socket authentication to be handled within plugins ( #10428 )
3 years ago
fa01801f64
fix: don't throw on invalid session, just return early so socket is not opened.
...
Also updated the plugin hook call to `static:sockets.validateSession` to not return a result, because in static calls that result is always null anyway
3 years ago
c5f08fdc81
breaking: remove socket.io/flags.js
...
refactor: helpers.loginUser returns a single object {jar, csrf_token}
3 years ago
61d1f56500
test: socket.emit doesnt exist in tests
4 years ago
997fb2b348
refactor: remove unused code
4 years ago
e59d357533
feat: als ( #9749 )
...
* feat: als
* fix: up test timeout
* fix: don't overwrite caller if it already exists
* fix: up test timeout for psql
4 years ago
0096cf178a
refactor: bubble other errors
4 years ago
a9bb108802
fix: wrong error message checked
4 years ago
ec6d1e2321
fix : #9507 session reroll causes socket.io to become confused ( #9534 )
...
* fix : #9507 session reroll causes socket.io to become confused
* fix: added return
* fix: simpler logic for error handling
* fix: overly sensitive catch
4 years ago
670cde78da
feat: add invalid event name to error message
4 years ago
cc9d6fd08b
chore: eslint max-len
4 years ago
23f212a4c0
chore: eslint prefer-destructuring
4 years ago
dab3b23575
chore: eslint no-var, vars-on-top
4 years ago
b56d9e12b5
chore: eslint prefer-arrow-callback
4 years ago
707b55b6a5
chore: eslint prefer-template
4 years ago
5bc1f5b4e8
fix : #9231 , fix redis pubsub connection
...
regression from fdfbc90255
4 years ago
1c45fa1ba5
feat: socket.io 3 changes ( #8845 )
...
* feat: socket.io 3 changes
* feat: replace socketio-wildcard with socket.onAny
up socket.io-redis to 6.x
* feat: remove mongodb/psql socket.io adapters
* feat: show data on fail
* fix: tests
* fix: typo
* fix: logger test fix
* fix: logger.io_close
* chore: up deps
* chore: update readme to reflect redis requirement
* fix: increase timeout show data if test fails
4 years ago
fcb10ebdbb
feat: add socket connect/disconnect action hooks
4 years ago
7e867cf95e
fix : #7597 , fix progress bar of cover/profile uploads
...
send big cover images in chunks
4 years ago
700736535c
fix: guests dont always have sid
4 years ago
a4fe4d3cf5
fix: allow guests to see their replies immediately
4 years ago
f4d217d829
fix : #8980 , fix lang string
4 years ago
6e2da9966e
refactor: move plugin hook methods to plugin.hooks.*
4 years ago
965671a97b
fix: remove params from error log
4 years ago
a05905f196
performance improvements ( #8795 )
...
* perf: nconf/winston/render
cache nconf.get calls
modify middleware.pageView to call next earlier
don't call winston.verbose on every hook see https://github.com/winstonjs/winston/issues/1669
translate header/footer separately and cache results for guests
* fix: copy paste fail
* refactor: style and fire hook only log in dev mode
* fix: cache key, header changes based on template
* perf: change replace
* fix: add missing await
* perf: category
* perf: lodash clone
* perf: remove escapeRegexChars
5 years ago
ea31f50554
refactor: show more lines of stack trace
5 years ago
bc880ee0ca
refactor: remove sockets.reqFromSocket
5 years ago
40598b368e
refactor: topic creation to use api lib
5 years ago
5e2caf19f5
refactor: use single function for api code
5 years ago
b8703ba9f6
fix(writeapi): tests
5 years ago
58043e07ba
fix: use POST call for user creation in ACP
...
- Not entirely sure about error handling yet, more research needed
- Also added socket method deprecation utility method
5 years ago
d6baf5c278
feat: show event/params on error
5 years ago
4658121a7d
fix: don't crash if content is undefined
5 years ago
c2ca02dfc7
fix : #8474
...
make isPrimary and isCluster always booleans
they were strings when using ./nodebb start and boolean if they were in config.json and started with node app.js
5 years ago
91e8e3905c
fix : #7947 , disable unused cookie
6 years ago
603908c10a
refactor: async/await socket.io/index
6 years ago
88dfbf213f
refactor: async/await socket.io/admin
6 years ago
b734defbfa
feat: rewrite getRawPost to async/await
...
promisify SocketPosts
6 years ago
44a3352003
fix: socket.io methods calling callbacks twice if method returns promise
6 years ago
aee47b299a
feat: awaitable websockets ( #7645 )
...
* feat: awaitable websockets
Adding in conditionals to check the method to call, and handling
it as a promise vs. a regular function depending on whether the
method itself is an asynchronous function.
* fix: switch to .then-checking for awaitable check
* fix: proper use of .then check
6 years ago
0263b4daec
feat: added new hook `static:sockets.validateSession` ( #7189 )
...
* feat: added new hook
* fix: improper .bind() call, +req in static:sockets.validateSession
* fix: restored original sessionStore logic, +hook
original logic to retrieve the sessionStore was not faulty, but
was changed for the sake of changing things, which ultimately
led to issues with tests, etc.
6 years ago
89c025d102
feat: close #7002 , console message if mismatched origins
6 years ago
64b9dabff8
chore(deps): update dependency eslint-config-airbnb-base to v13 ( #6599 )
...
* chore(deps): update dependency eslint-config-airbnb-base to v13
* chore: #6599 , linting 😬
7 years ago
9c022afae1
Parse int ( #6853 )
...
* Store config fields as JSON in the db
Fewer parseInts
* Remove unnecessary parseInts
* remove some dupe code add tests
* remove console.log
* remove more parseInts
* WIP: read meta.configs defaults from defaults.json
remove more parseInts
* more work
* add log for failing test
* update admin pwd
* fix tests, dont require posts/cache before configs are initialized
* handle saves
* Test boolean conditions
* remove more parseInts
* Fix boolean values
* remove lots more parseInts
* removed json parsing
* renamed var to number
* categories dont have timestamp
7 years ago
cf4ea94e6d
Fix single-host-cluster socket.io ( #6802 )
...
It was silently dropping every message because every node thought it was the master node.
7 years ago
44373afc52
Fix socket.io not working properly in single-host clusters. ( #6669 )
...
This is because we don't use the cluster module, so the master nodejs process doesn't know about any of the clients through the socket API.
7 years ago
c1e98eefa7
Allow single-host clusters to not send pubsub and socket.io messages through the database. ( #6659 )
...
* Allow single-host clusters to not send pubsub and socket.io messages through the database.
* Fix lint errors.
7 years ago
a37dc1856f
#6561
7 years ago
c25d752573
Merge remote-tracking branch 'origin/master' into develop
7 years ago
a4a961639d
only triggering forum updated messaging if hostname matches, fixes #6333
7 years ago
chadjw
Julian Lam
Barış Soner Uşaklı
Barış Soner Uşaklı
Peter Jaszkowiak
renovate[bot]
Ben Lubar