19 Commits (707b55b6a5a08b5c94e769356b0b89a787788cb7)

Author SHA1 Message Date
Julian Lam 512f6de6de
feat: allow passwords with length > 73 characters (#8818)
* feat: allow passwords longer than 73 characters

Context: A bcrypt/blowfish limitation means that password length is capped at 72 characters. We can get around this without compromising on security
by hashing all incoming passwords with SHA512, and then sending that to bcrypt.

https://dropbox.tech/security/how-dropbox-securely-stores-your-passwords

* feat: add additional test for passwords > 73 chars

* fix: remove 'password-too-long' error message and all invocations

* test: added test to show that a super long password won't bring down NodeBB

* fix: remove debug log

* Revert "fix: remove 'password-too-long' error message and all invocations"

This reverts commit 1e312bf7ef7e119fa0f1bd3517d756ca013d5e79.

* fix: added back password length checks, but at 512 chars

As processing a large string still uses a lot of memory
4 years ago
Baris Usakli dd8386d93d refactor: password async/await 5 years ago
Barış Soner Uşaklı cd80c2638c feat: #7743
user/password
user/picture
6 years ago
Barış Soner Uşaklı ff38abc225 move bcrypt into password 6 years ago
Peter Jaszkowiak ec38b18e34 Always compare password with a hash
Prevents quick response when user / email doesn't exist
7 years ago
Peter Jaszkowiak 1c35213934 Fix #5970 and forking while debugging (#5965)
* Fix forking while debugging

Debugger address in use no longer happens

* Fix cropper error
7 years ago
Peter Jaszkowiak e71fb9ab24 Fix `node --inspect` 8 years ago
Barış Soner Uşaklı 890c2eff70 style changes 8 years ago
Barış Soner Uşaklı 870bb87b08 always pass strings to bcrypt compare 8 years ago
Peter Jaszkowiak 75d291183d Fix using nodebb in other CWDs 8 years ago
Peter Jaszkowiak 896c8c7343 ESlint object-curly-spacing 8 years ago
Peter Jaszkowiak feb8405f95 ESlint eol-last 8 years ago
Peter Jaszkowiak 604358ecc4 ESlint keyword-spacing, no-multi-spaces 8 years ago
HeeL 4a3c31b2dc Fix space-before-function-paren linter rule 8 years ago
HeeL 9a0d764bbd Fix wrap-iife linter rule 8 years ago
barisusakli c8ba61ac7b closes #4791 9 years ago
barisusakli a445e3f7b1 use send for child process 10 years ago
Julian Lam ea2fbcfcfc closed #2242 10 years ago
barisusakli 005405b16c closes #1976 11 years ago