688 Commits (6b054d7a23208ab0230b5adb68066ee4698f5a16)

Author SHA1 Message Date
Barış Soner Uşaklı fb363957d1 refactor: tab rules 4 years ago
Barış Soner Uşaklı 190532b3b4 refactor: shorter meta.settings.get 4 years ago
Barış Soner Uşaklı 51cbeccb08 refactor: clone settings before returning
prevents plugins from mistakenly modifying saved settings in cache
4 years ago
Barış Soner Uşaklı 8379c11b22 refactor: setObjectBulk to match sortedSetAddBulk 4 years ago
Baris Usakli d412ba4411 perf: closes #9994, bulk methods for settings 4 years ago
Barış Soner Uşaklı 8b4510cc70 refactor: deprecate app.logout
use logout module instead
move header related code out of app.js
4 years ago
Barış Soner Uşaklı 1a9b15989b refactor: move search functions from app.js to search module
deprecate:
app.handleSearch, use search.init(options) instead
app.enableTopicSearch, use search.enableQuickSearch(options) instead
app.prepareSearch, use search.showAndFocusInput() instead
4 years ago
Barış Soner Uşaklı 518552543d refactor: move warnings/messages out of app.js 4 years ago
Barış Soner Uşaklı 890bf03fcc refactor: acp only uses 3 modes and a single theme
so only copy 7 files to build folder instead of 400+
4 years ago
Julian Lam 28efcb59cb chore: remove .opacity() mixin as it is supported cross-browser 4 years ago
Barış Soner Uşaklı 719cfc0d57 breaking: disable javascript in custom less tab 4 years ago
Barış Soner Uşaklı 998b9e7918 fix: minification regression 4 years ago
Barış Soner Uşaklı b2429ef00e refactor: meta/minifier use async/await 4 years ago
Barış Soner Uşaklı 6da3239230 refactor: less.render already returns promise
rename callback to next to match other controllers
4 years ago
Barış Soner Uşaklı 38756a0c34 refactor: no more 🐮 4 years ago
Barış Soner Uşaklı 9e0ce0272c fix: don't overwrite reloadRequired with false
1. meta.settings.set('name', values); // reloadRequired is set to true
2. meta.settings.set('otherName', values, false); // reloadRequired was set to false, even though it should stay true until restart due to step 1
4 years ago
Barış Soner Uşaklı 1feb111ade
perf: dont fs.open if plugin doesnt have language namespace (#9893)
closes #9892
4 years ago
Julian Lam 819917daf2 refactor: allow plugins to replace og:image, or specify additional og:image
/cc @antosik
4 years ago
Barış Soner Uşaklı 488f0978a4 fix: manifest error 4 years ago
opliko a370c26f73 feat: re-add FontAwesome font for compatibility 4 years ago
opliko 41762e6603 feat: update to FontAwesome 5.15, resolve #6976 4 years ago
Opliko d509a307f0
Remove some deprecated/unnecessary code (#9688)
* refactor: remove mkdirp promisify

* refactor: remove old session deletion API route

* refactor: remove middleware.isAdmin

* refactor: remove templateValues.config.bootswatchSkin

* fix: unused dependencies
4 years ago
Julian Lam 849049765b fix: #9636, sanitize all attributes in meta and link tags 4 years ago
Julian Lam 16e0bca570 fix: improper use of filename extensions 4 years ago
psychobunny 771a8955a4 fix: #9362 best not to check file exists on every page load; copying favicon to uploads/system folder instead 4 years ago
psychobunny ad5654952a fix: #9362 4 years ago
psychobunny e5133a78f8 feat: add $.deserialize to client side 4 years ago
Barış Soner Uşaklı 902a88c25e feat: remove promise-pollyfil 4 years ago
Peter Jaszkowiak 5c2f0f0557 chore: eslint no-restricted-syntax 4 years ago
Peter Jaszkowiak 115d19e289 chore: eslint prefer-rest-params, prefer-spread 4 years ago
Peter Jaszkowiak 23f212a4c0 chore: eslint prefer-destructuring 4 years ago
Peter Jaszkowiak dab3b23575 chore: eslint no-var, vars-on-top 4 years ago
Peter Jaszkowiak b56d9e12b5 chore: eslint prefer-arrow-callback 4 years ago
Peter Jaszkowiak 707b55b6a5 chore: eslint prefer-template 4 years ago
Peter Jaszkowiak 4ee0f1459d chore: eslint import/newline-after-import 4 years ago
Julian Lam d6f60f4502 fix: broken test after sorted-lists logic change 4 years ago
Julian Lam d5d24594e8 feat: allow sorted-lists on multiple pages
If multiple sorted-lists were on separate pages, saving one page would erase the sorted-lists saved on the other page. This was caused by naive deletion of the sorted-lists index on settings save.

At the same time, a bug was found where if fewer items were passed in, only that many items were removed from the database, leaving leftover orphan data in the database.

The logic now:

- Only removes sorted-lists if they are passed in (and empty)
- Deletes all sorted list items, not just the items passed in.
4 years ago
Julian Lam a8be6fb8fb fix: regression where `filter:settings.set` no longer received sorted-lists 4 years ago
Julian Lam 473d5f4aba fix: full settings hash not passed through to action:settings.set
The sorted lists were being filtered out
4 years ago
Julian Lam eb96046e97 Revert "refactor: use Map to track sorted lists in Settings.set()"
This reverts commit 65de2e76b4.
4 years ago
Julian Lam 65de2e76b4 refactor: use Map to track sorted lists in Settings.set() 4 years ago
Julian Lam 8ff07bc196 fix: update js concatenation logic to bundle scripts.rjs into minfile regardless of build environment
The slowdown is fairly insignificant (< .1s), and the only change is the minified file is identical across environments, which is better from a debugging standpoint
4 years ago
Julian Lam 412d285850 fix(hooks): fallback handling for core invocations of hooks.fire
+ .on() which is the same as .register()
4 years ago
Peter Jaszkowiak a51c5698c7 fix: `--help` usage info
yargs (via nconf) would exit when detecting a help flag

also improves the speed of `./nodebb help build`
4 years ago
Barış Soner Uşaklı bb6cc49c16 perf: dont build identical langs 5 years ago
Barış Soner Uşaklı 4a0d883359 breaking: #8808, remove utils.slugify 5 years ago
Peter Jaszkowiak ba3981e270
fix: use package.name for theme.id (#8965)
Prevents cases like #8953
5 years ago
Barış Soner Uşaklı 3af4d13fa5 fix: basepath for r.js modules 5 years ago
Julian Lam 6e2da9966e refactor: move plugin hook methods to plugin.hooks.* 5 years ago
Peter Jaszkowiak d30ea25629
feat(deps): benchpressjs@2.2.1 (#8887)
Better warnings, faster template compiles
5 years ago