11344 Commits (60e7de0d1351ecdd51c925bce83671a80b28f8bc)

Author SHA1 Message Date
Barış Soner Uşaklı ae5d4405c0 fix: setting 4 years ago
Barış Soner Uşaklı 9ca44e6f54
feat: add displayname into user obj #8637 (#8909)
* feat: add displayname into user obj #8637

* fix: spec

* perf: dont load settings if acp setting is turned off
4 years ago
Barış Soner Uşaklı 8d060065a0 fix: spec 4 years ago
Barış Soner Uşaklı e9585b9be2 fix: group userTitles translation escapes 4 years ago
Barış Soner Uşaklı 965671a97b fix: remove params from error log 4 years ago
Barış Soner Uşaklı fa4177c3bc fix: #6407, fix feeds
display latest posts instead of oldest in topic rss feed
fix missing await that was causing rss_tokens to not function
fix feed test
more tests for getTopicWithPosts
4 years ago
Barış Soner Uşaklı 4e9b10ab76 feat: #5274 4 years ago
Barış Soner Uşaklı fb567a7a33 feat: #4456 4 years ago
Barış Soner Uşaklı a6afcfd531 feat: #8475, allow flagging self posts
dont count flags towards self posts
dont allow flagging your own account
4 years ago
Barış Soner Uşaklı a87ccccc9c fix: benchpress warnings 4 years ago
Barış Soner Uşaklı dfdc0c420c fix: benchpress warnings 4 years ago
Julian Lam a0b7a82350
feat(api): account deletion routes for the Write API (#8881)
* feat(api): account deletion routes for the Write API

* refactor: rewrite client-side calls to account deletion to use api

* style: apply DRY
4 years ago
Barış Soner Uşaklı 120999bf63 feat: #7550, show message if post is queued when js is disabled 4 years ago
Barış Soner Uşaklı 35f932cd64 feat: #8171, add oldCategory if topic is moved 4 years ago
Barış Soner Uşaklı b44ddecdf8 feat: #8204, separate notification type for group chats 4 years ago
Barış Soner Uşaklı 1d6bcbebde feat: https://github.com/NodeBB/NodeBB/issues/8147 4 years ago
Julian Lam e1d7c4d8aa fix: internal helper method hasGlobalPrivilege, DRY 4 years ago
gasoved 3ccebf112e
feat: invites regardless of registration type, invite privilege, groups to join on acceptance (#8786)
* feat: allow invites in normal registration mode + invite privilege

* feat: select groups to join from an invite

* test: check if groups from invitations have been joined

* fix: remove unused variable

* feat: write API versions of socket calls

* docs: openapi specs for the new routes

* test: iron out mongo redis difference

* refactor: move inviteGroups endpoint into write API

* refactor: use GET /api/v3/users/:uid/invites/groups

Instead of GET /api/v3/users/:uid/inviteGroups

* fix: no need for /api/v3 prefix when using api module

* fix: tests

* refactor: change POST /api/v3/users/invite

To POST /api/v3/users/:uid/invites

* refactor: make helpers.invite awaitable

* fix: restrict invite API to self-use only

* fix: move invite groups controller to write api, +tests

* fix: tests

Co-authored-by: Julian Lam <julian@nodebb.org>
4 years ago
Peter Jaszkowiak d30ea25629
feat(deps): benchpressjs@2.2.1 (#8887)
Better warnings, faster template compiles
4 years ago
Tudor-Dan Ravoiu 452d7f2b17
Create verified/unverified user groups (#8889)
Co-authored-by: Tudor-Dan Ravoiu <tudor-dan.ravoiu@ubisoft.com>
4 years ago
Barış Soner Uşaklı e4d2764d4c fix: #8884, remove header/footer cache 4 years ago
Barış Soner Uşaklı 5598130a92 refactor: async/await controllers/index.js 4 years ago
Barış Soner Uşaklı f14e42d8bc fix: #8883 4 years ago
Barış Soner Uşaklı 8fbe832460 refactor: less dupe code 4 years ago
Julian Lam 8518404e22
feat: allow groups to specify which cids to show member posts from (#8875)
* feat: allow groups to specify which cids to show member posts from

* docs: fix tests for openapi

* fix: test breakage caused by improper conditional

* feat: server-side checking of memberPostCids for validity

* feat: admin panel template update to select categories to include

* refactor: privilege helpers.isUserAllowedTo

... to helpers.isAllowedTo, allowing group names to be passed in
4 years ago
Barış Soner Uşaklı 51b7eca119 fix: run every hour, dont show message if average_time is 0 4 years ago
Opliko 04f4429f72
Resolve #7514 - optional timer for registration queue (#8796)
* feat: #7514 Optional timer for registration queue

* feat: show minutes in average time

* fix: don't show total number of minutes

* feat: implement requested changes

* fix: just store minutes instead of milliseconds

* feat: set default values
4 years ago
Julian Lam bcccb331db docs: openapi schema for user/group exist check, session deletion 4 years ago
Julian Lam dc9668e417 fix: pass length to messaging checkContent hook 4 years ago
Barış Soner Uşaklı 567c5f2056 fix: #8869, dont escape category title,description twice 4 years ago
Julian Lam f300c933a5 refactor: move session revocation route to write api 4 years ago
Barış Soner Uşaklı 9c5c32d4a5 feat: #8864, add action:events.log 4 years ago
Barış Soner Uşaklı 62c0454cfe feat: show db info side by side 4 years ago
Barış Soner Uşaklı a0164b1c38 fix: use header/footer cache in prod 4 years ago
Barış Soner Uşaklı 05a92885f2 fix: add missing maxAge to cache 4 years ago
Barış Soner Uşaklı 2e44639210 fix: guest header/footer cache
allow clearing individual caches
4 years ago
Barış Soner Uşaklı f1f9b225b0
feat: #8824, cache refactor (#8851)
* feat: #8824, cache refactor

ability to disable caches
ability to download contents of cache
refactor cache modules to remove duplicated code

* fix: remove duplicate hit/miss tracking

check cacheEnabled in getUncachedKeys
4 years ago
Barış Soner Uşaklı 6255874e32 feat: move mkdirp to beforeBuild so it doesnt get called twice 4 years ago
Barış Soner Uşaklı 74951f5967 fix: #8846, possible fix 4 years ago
Barış Soner Uşaklı 0b30efba31 Merge branch 'master' of https://github.com/NodeBB/NodeBB 4 years ago
Barış Soner Uşaklı 16d03975a0 fix: winston error message 4 years ago
Julian Lam d263192271 feat: group exists API call in write api 4 years ago
Julian Lam 1446cec77f feat: user exist route in write api 4 years ago
Julian Lam 6b196a207f fix: permanent redirect on user api redirect shorthand 4 years ago
Julian Lam f2bb42c076 fix: user exist route needs no authentication 4 years ago
Julian Lam 60e1e99b4f feat: new shorthand route /api/v3/users/bySlug/:userslug
closes #8844
4 years ago
Julian Lam 512f6de6de
feat: allow passwords with length > 73 characters (#8818)
* feat: allow passwords longer than 73 characters

Context: A bcrypt/blowfish limitation means that password length is capped at 72 characters. We can get around this without compromising on security
by hashing all incoming passwords with SHA512, and then sending that to bcrypt.

https://dropbox.tech/security/how-dropbox-securely-stores-your-passwords

* feat: add additional test for passwords > 73 chars

* fix: remove 'password-too-long' error message and all invocations

* test: added test to show that a super long password won't bring down NodeBB

* fix: remove debug log

* Revert "fix: remove 'password-too-long' error message and all invocations"

This reverts commit 1e312bf7ef7e119fa0f1bd3517d756ca013d5e79.

* fix: added back password length checks, but at 512 chars

As processing a large string still uses a lot of memory
4 years ago
Barış Soner Uşaklı c61dee4b62 fix: #8840, don't crash if /compose route is called with no query params 4 years ago
Barış Soner Uşaklı 9e3eb5d41a feat: #8821, allow guest topic views 4 years ago
Julian Lam f68bce86a9 fix: XSS in event:banned messaging modal 4 years ago
Barış Soner Uşaklı 76cd5b0fc1 fix: #8836, truncate fullname 4 years ago
psychobunny eec630f1ef fix(acp): max-height for plugin menu list 4 years ago
Julian Lam 891a1ea2af fix: #8827, do not require admin:users privilege to ban users 4 years ago
Barış Soner Uşaklı 4b63f9937c fix: check is banned in buildHeader
remove unused banReason
remove generateHeader function
4 years ago
Barış Soner Uşaklı a338f52780 feat: #8823, remove hardcoded write concern 4 years ago
Barış Soner Uşaklı 08ff4041aa fix: missing await 4 years ago
Julian Lam c0f699e655 fix: disallow registration attempts with password length > 4096
This is a stopgap measure for v1.15.0
4 years ago
Barış Soner Uşaklı 4818ec377e fix: missing await 4 years ago
Barış Soner Uşaklı 6e85920cb6 feat: allow mods/admins to see deleted posts on user profile 4 years ago
Julian Lam 87bff6cd65 fix: broken test 4 years ago
Julian Lam dda5d42610 fix: restore old behaviour of empty json w/ 401 code in admin middleware 4 years ago
Julian Lam 15e0731dd9 fix: deprecate middleware.isAdmin
Also, handle admin logout timer in middleware.admin.checkPrivileges
4 years ago
Julian Lam 4439864ce0 fix: post editing not taking plugin hook results into account 4 years ago
Barış Soner Uşaklı a02ae6f5df refactor: simpler check in user.blocks.filter 4 years ago
Barış Soner Uşaklı 27016d221c feat: rearrange buttons on manage/users 4 years ago
Julian Lam 57ed6be78b fix: #8805 define our own name for write API v3 4 years ago
Julian Lam 266d7587b2 refactor: remove usage of middlewares
Specifically, middleware.isAdmin|exposePrivilegeSet|exposePrivileges
4 years ago
Julian Lam a6a52430ce fix: remove setCategorySort and setTopicSort 4 years ago
Julian Lam aa8faf58a0 refactor: remove /users/{uid}/settings/{setting} route
@baris Also, I am now allowing the following properties to be saved in User.saveSettings:
- categoryTopicSort
- topicPostSort
- setCategorySort
- setTopicSort
4 years ago
Barış Soner Uşaklı 6ac73ccb7e feat: #8801, disable express compression by default 4 years ago
Julian Lam 3c98cd3d95 fix: topic object in post editing data return 4 years ago
Julian Lam 1392d064a1 fix(writeapi): normalizing data 4 years ago
Julian Lam ec03af7a38 feat: allow passing subset of user settings on update route 4 years ago
Julian Lam 618e098305 fix: bug where token generation route would fail on null case 4 years ago
Julian Lam b156b8b573 feat: wip, write api tests framework
re-using read api tests if possible
4 years ago
Barış Soner Uşaklı 2e9f27d8ff fix: typo 4 years ago
Barış Soner Uşaklı 93bdfe2f10 perf: reorder async calls 4 years ago
Barış Soner Uşaklı 88a07e69b5 feat: add filter:category.getFields 4 years ago
Barış Soner Uşaklı a05905f196
performance improvements (#8795)
* perf: nconf/winston/render

cache nconf.get calls
modify middleware.pageView to call next earlier
don't call winston.verbose on every hook see https://github.com/winstonjs/winston/issues/1669
translate header/footer separately and cache results for guests

* fix: copy paste fail

* refactor: style and fire hook only log in dev mode

* fix: cache key, header changes based on template

* perf: change replace

* fix: add missing await

* perf: category

* perf: lodash clone

* perf: remove escapeRegexChars
4 years ago
Barış Soner Uşaklı 0db0231cff feat: move postercount to topic hash 4 years ago
Barış Soner Uşaklı 203db47b30 fix: return early for guests/spiders 4 years ago
Barış Soner Uşaklı 156e1396f2 fix: #8789,cache meta.settings 4 years ago
Barış Soner Uşaklı a7b6d0dfe5 feat: add free and total mem usage to info 4 years ago
Julian Lam c26f2b6599 feat(writeapi): user settings API 4 years ago
Barış Soner Uşaklı db63f5e3f0 fix: #8781 4 years ago
Julian Lam 177a961000 feat: new filter filter:teasers.configureStripTags 4 years ago
Julian Lam d68ffea80d feat: send 'Vary' header when ACAO header set 4 years ago
Barış Soner Uşaklı 1f43e98f8b fix: allow admins adding users to global moderators
add new test
4 years ago
Barış Soner Uşaklı bbafa1b82a Revert "fix: [breaking] send configured config URL as origin if not custom"
This reverts commit 205a10308e.
4 years ago
Julian Lam a691be5952 fix: incorrect logic for post history editable bool 4 years ago
Julian Lam 205a10308e fix: [breaking] send configured config URL as origin if not custom
This is a breaking change if your install uses multiple URLs to access. You will need to update the Access-Control-Allow-Origin header in ACP > Advanced > Headers to supply all URLs you use to access your site
4 years ago
Barış Soner Uşaklı 7a019494e8 feat: add filter.topics.getPostReplies 4 years ago
Julian Lam 7a8f704900 fix: #8776 some users unable to restore old versions via history 4 years ago
Barış Soner Uşaklı b26e9b5993 fix: #8595, dont save escaped data when renaming groups 4 years ago
Barış Soner Uşaklı ea31f50554 refactor: show more lines of stack trace 4 years ago
Barış Soner Uşaklı 7bddec93ec fix: sortby 4 years ago
Barış Soner Uşaklı b3619d3d47
fix: #8774 4 years ago
Julian Lam ff4fcc23b6
Update bundled logos with new branding (#8702)
* feat: updating logo assets, square logos missing still

* fix: squared logo for touch icon and notification fallback

* fix: update link to favicon

* feat: add default touch icon sizes, if one isn't uploaded

Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
4 years ago
Barış Soner Uşaklı e362c342a3 fix: #8630, sort extra deps 4 years ago
Barış Soner Uşaklı d9a16855d0 refactor: posts api 4 years ago
Barış Soner Uşaklı 272e73da53 refactor: post restore/delete/purge 4 years ago
Barış Soner Uşaklı 9738e20207 refactor: merge post.edit
fix: dont fadeout/fadeint if title/post didnt change
4 years ago
Barış Soner Uşaklı 2279e37261 refactor: deprecate socket.emit('users.search') use api route 4 years ago
Barış Soner Uşaklı 083c74e059 refactor: api categories 4 years ago
Barış Soner Uşaklı e78c498e84 fix: missing doTopicAction, fix wrong api params 4 years ago
Barış Soner Uşaklı bc880ee0ca refactor: remove sockets.reqFromSocket 4 years ago
Barış Soner Uşaklı 9d81660e24 Revert "Revert "fix: appropriate 404 handling for write API calls""
This reverts commit 135c2d6c7d.
4 years ago
Barış Soner Uşaklı 135c2d6c7d Revert "fix: appropriate 404 handling for write API calls"
This reverts commit b6cce75d97.
4 years ago
Julian Lam 9ee3cb9b62 refactor: topic follow/ignore to use api lib 4 years ago
Julian Lam 68d6818bca refactor: topic tools' actions to use api lib 4 years ago
Julian Lam 21974a77f8 feat: topic reply to use api lib (also + missing file) 4 years ago
Julian Lam 40598b368e refactor: topic creation to use api lib 4 years ago
Julian Lam b6cce75d97 fix: appropriate 404 handling for write API calls 4 years ago
Julian Lam ede9435f0e feat: send 401 for invalid-uid 4 years ago
Barış Soner Uşaklı c913900ed6 feat: async/await admin/search 4 years ago
Barış Soner Uşaklı bf480ee58b refactor: setupApiRoute signature 4 years ago
Barış Soner Uşaklı 688d7a2cc2 refactor: remove unused middleware 4 years ago
Barış Soner Uşaklı b2ff1594b8 fix: redis hget
'node_redis: The HGET command contains a invalid argument type.\n' +
'Only strings, dates and buffers are accepted. Please update your code to use valid argument types.'
4 years ago
Julian Lam e98285dbbb fix: reimplementing isPrivilegedOrSelfAndPasswordMatch 4 years ago
Barış Soner Uşaklı 84a179f48c Merge branch 'master' of https://github.com/NodeBB/NodeBB 4 years ago
Julian Lam 3f347baadb fix: socket user bans 4 years ago
Julian Lam 14f9d8b0e5 feat: send back 403 on no-privileges error 4 years ago
Julian Lam 222b4c9533 fix: broken tests from api change 4 years ago
Julian Lam 2d252f2fa4 refactor: user bans to use api lib 4 years ago
Barış Soner Uşaklı 7d86be2bc2 fix: tests 4 years ago
Barış Soner Uşaklı e367c5403e refactor: move groups.leave, fix some tests 4 years ago
Barış Soner Uşaklı bbbd9fee85 Merge branch 'master' of https://github.com/NodeBB/NodeBB 4 years ago
Julian Lam 960e925e40 refactor: change password/user follow to use api lib 4 years ago
Barış Soner Uşaklı 081c4fa6d4 Merge branch 'master' of https://github.com/NodeBB/NodeBB 4 years ago
Julian Lam 430e7f5834 refactor: user deletion to use api lib 4 years ago
Barış Soner Uşaklı 8ae1f81cf4 feat: refactor groups.delete 4 years ago
Julian Lam 77481947f0 refactor: socket profile update to use api lib 4 years ago
Julian Lam 31ae8a8323 refactor: socket profile update to use api lib 4 years ago
Barış Soner Uşaklı d69e503d21 feat: move groups.join to api 4 years ago
Julian Lam d07f0081b7 fix: add missing file 4 years ago
Julian Lam 23086daead refactor: user create and profile update to use api lib 4 years ago
Barış Soner Uşaklı 5e2caf19f5 refactor: use single function for api code 4 years ago
Barış Soner Uşaklı 25e4a09816 Merge branch 'master' of https://github.com/NodeBB/NodeBB 4 years ago
Barış Soner Uşaklı 4418ff0716 fix: #8768 4 years ago
Julian Lam cc6e995ee2 fix: api bug where user profile editing continued even if not allowed 4 years ago
Barış Soner Uşaklı 43afe7ffab refactor: async/await src/user/approval 4 years ago
Barış Soner Uşaklı bae0f343e1 fix: module build 4 years ago
Barış Soner Uşaklı 1fd2eba6f2 refactor: async/await
src/cli/manage.js
src/meta/build.js
src/meta/css.js
src/meta/js.js
4 years ago
Barış Soner Uşaklı b295d15eae fix: tests 4 years ago
Barış Soner Uşaklı d89477cad0 refactor: use app.render 4 years ago
Julian Lam 9dd3cc0483 feat: allow plugins to define api routes
via new plugin hook static:api.routes
4 years ago
Julian Lam a4ba23899e feat: require https if nodebb is configured with https url 4 years ago
Barış Soner Uşaklı e6ea71c95a fix: test 4 years ago
Barış Soner Uşaklı 8c6a559188 fix: timestamp 4 years ago
Barış Soner Uşaklı 331d236f6e fix: #8763 4 years ago