921 Commits (3b1c03ed5098f5828d524eb0381e12717aa790f3)

Author SHA1 Message Date
Barış Soner Uşaklı 48b41debe6
fix: vulnerability in cover and admin uploads (#8419)
* fix: vulnerability in cover and admin uploads

* fix: remove old test

* fix: update tests
5 years ago
Barış Soner Uşaklı e80379dc0e feat: display stack trace on winston.error 5 years ago
Barış Soner Uşaklı 79a7f89235 Merge branch 'master' of https://github.com/NodeBB/NodeBB 5 years ago
Barış Soner Uşaklı 2bcf7f72d2 fix: follower count going out of sync with real follower count 5 years ago
Barış Soner Uşaklı bef37e27cb
fix: test lock for user create (#8415)
* fix: test lock for user create

* fix: redis hdel with undefined

* feat: add test for undefined key in deleteObjectFields
5 years ago
Barış Soner Uşaklı f0526bff9f fix: add mising timestamp 5 years ago
Barış Soner Uşaklı a680a95e73 feat: add filter:user.getFields to match topic/posts 5 years ago
Barış Soner Uşaklı 18d892398f fix: add timestamp to initial username history 5 years ago
Julian Lam 67aca822e6 feat: account content deletion, closes #8381 5 years ago
Barış Soner Uşaklı 5a2b515431 feat: #8349, remove user posts from queue if user is deleted 5 years ago
Barış Soner Uşaklı 8bf980cb63 fix: tests, handle no sessions 5 years ago
Barış Soner Uşaklı a0d76ff0a6 fix: #8318, clean expired sessions on login and get 5 years ago
Barış Soner Uşaklı 1d3fa3bc4e feat: throw error if uid is missing for update 5 years ago
Opliko c4545381d7
feat: Add hooks for user blocks (#8296)
* Add hooks for user blocks

* change naming

* Fix the filter...

fixes #8109
5 years ago
Barış Soner Uşaklı 5ebcdb1806 fix: #8287, fix users:flags as well 5 years ago
Barış Soner Uşaklı 9d153fd388 fix: #8287, dont readd user after deletion
don't add user uid back to users:* sorted sets if they are deleted
upgrade script to fix users:* sorted sets
5 years ago
Barış Soner Uşaklı 0ca84bd9f4 fix: #8284, parse ToS on register
rewrite intersitials to async/await
5 years ago
Julian Lam ccc6118d30
Testing suite integration for openapi spec (#8263)
* feat: testing suite integration for openapi spec

The testing suite now takes the openapi spec into account. It will
check each route defined, make a call to it, and compare the
response with the defined schema. Any mismatches will cause the
test to fail.

* fix(openapi): removed debug stuff from tests

* fix(openapi): fixed some tests

* fix(openapi): added additional check to tests, test fixes

* fix(openapi): better tests, fixed spec errors

* fix(openapi): bad conditional in test

* fix: oops

* fix(openapi): more tests fixing

* fix(openapi): more tests

* fix(openapi): fix some more tests

* fix: verbose'd an info log

* fix: topic pagination route returns schema-optimized pagination block

* fix(openapi): more test/spec fixes

* fix(openapi): accidentally sending in authenticated jar for anon routes

* fix(openapi): more test/spec fixes

* fix(openapi): more spec fixes

* fix: timestampReadable Invalid Date

* fix(openapi): more tests... almost there

* fix(openapi): more tests fixing

* fix(openapi): finally all tests passing

* fix(openapi): added reverse test to compare response to spec

... and fixed all the tests that broke

* fix: remove tests related to group covers, as route is gone

* fix(openapi): broken test on travis

* fix(openapi): broken test on travis

* fix(openapi): broken test on travis

* fix(openapi): object cache is not present for psql

* fix: tests

Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
5 years ago
Barış Soner Uşaklı 8e23dec84b fix: lint 5 years ago
Barış Soner Uşaklı 00e299e93e feat: closes #8229, add targetUid to action:password.change 5 years ago
Barış Soner Uşaklı f07f4f8e1a fix: #8202, filter non-existing users in search by uid 5 years ago
psychobunny 266061c31a fix: notification bodyShort truncated if there is a comma in topic title 5 years ago
Julian Lam 1efb238a9a refactor: getUsersCSV to use batch lib 5 years ago
Barış Soner Uşaklı 14e7866745 fix: #8179, limit length of location/website/fullname, check grouptitle 5 years ago
Julian Lam 667608a02c fix: #8168 re-allowing slashes in homePageRoute
Resolves regression introduced by b0f3e48ac2
5 years ago
Barış Soner Uşaklı 3cca929a88 fix: add missing await 5 years ago
Barış Soner Uşaklı 8c6a7954cf fix: delete upload 5 years ago
Barış Soner Uşaklı 153b1a0eaa fix: check uploadName 5 years ago
Barış Soner Uşaklı b0f3e48ac2 fix: escape bootswatchSkin and homepageRoute 5 years ago
Barış Soner Uşaklı e06c1bfcd2 fix: escape config.userLang/acpLang, don't allow invalid language codes 5 years ago
Barış Soner Uşaklı 9d074731f4 fix: login with weak password 5 years ago
Barış Soner Uşaklı f6d7a24a67 fix: dont check password strength on login 5 years ago
Barış Soner Uşaklı 1b992d8201 fix: #8058, fix incorrect digest setting display in ACP 5 years ago
Barış Soner Uşaklı f4381ba366 fix: add missing await to sendValidationEmail 5 years ago
Julian Lam 645d647248
feat: wip, better digest handling (+ eventual digest resend logic) (#7995)
* feat: wip, better digest handling (+ eventual digest resend logic)

- await emailer.send call in digest.send method
- save send success to a new sorted set digest:{interval}:byUid

* feat: continuing work on digest tools

- Added ACP page to view digest settings and delivery times per user

* feat: added paginator and stub buttons for resending digest

* feat: wrapping up digest revamp

- New language strings in ACP digest page
- Client-side ACP script for digest ACP page
- Websocket call for ACP page to execute digests
- Broke out logic to retrieve user digest settings to getUsersInterval

* fix: minor cleanup

* fix: #8010 and some style suggestions from baris

* fix: resolve confusing comment
5 years ago
Barış Soner Uşaklı 0037a03886 fix: #8018, allow absolute urls in notification.path 5 years ago
Barış Soner Uşaklı 59242d31aa fix: #8010, fix isBanned call 5 years ago
Baris Usakli 485fbd2f14 feat: #7964, change all categories at once
allow passing cids to setCategoryWatchState and category.exists
5 years ago
Barış Soner Uşaklı 75bcb0f484 fix: remove unused data from post/topic/user hashes 5 years ago
Barış Soner Uşaklı f8c8038a06 refactor: remove log, topics.exists 5 years ago
Barış Soner Uşaklı dc8d721c46 refactor: async/await 5 years ago
Baris Usakli d5dda26f97 fix: #7938, escape username in registration queue 5 years ago
Barış Soner Uşaklı 603908c10a refactor: async/await socket.io/index 5 years ago
Barış Soner Uşaklı c5ffd8cc74 refactor: async/await image.js 5 years ago
Barış Soner Uşaklı 9a7560049a feat: bypass cropper for gifs 5 years ago
Barış Soner Uşaklı 625b0815bb refactor: shorter, new Date doesnt throw 6 years ago
Barış Soner Uşaklı babb9d7c55 fix: #7913, dont allow urls in fullname/location, validate birthday 6 years ago
Barış Soner Uşaklı 96ab8d05aa fix: only allow png/jpg/bmp in cover/profile images 6 years ago
Barış Soner Uşaklı 5505628c8d refactor: change to const 6 years ago
Barış Soner Uşaklı a7d2b8a1fe refactor: async/await socket.io 6 years ago
Barış Soner Uşaklı ec98945a5f refactor: remove commented out code 6 years ago
Barış Soner Uşaklı b9105ef9c6 refactor: async/await controllers/authentication 6 years ago
Barış Soner Uşaklı 22f8011686 refactor: remove async from isPasswordValid, function is sync 6 years ago
Barış Soner Uşaklı 09410ff1c5 feat: don't hardcode numberic fields in user search 6 years ago
Barış Soner Uşaklı 4652c68ba7 fix: dont show deleted topics in digest 6 years ago
Barış Soner Uşaklı 88dfbf213f refactor: async/await socket.io/admin 6 years ago
Julian Lam 29f96b199c fix(style): requiring parens in block bodies 6 years ago
Julian Lam 0921230976 fix(style): updated code to follow new eslint recommendations
Squashed commit of the following:

commit f9ce878b269b3568f0d649309aae1af4dcfdfeef
Author: Julian Lam <julian@nodebb.org>
Date:   Tue Aug 13 14:30:46 2019 -0400

    fix(style): updated code to follow new eslint recommendations

commit 80dd370e413f22badb96ff2138e7991dfff6d836
Author: Julian Lam <julian@nodebb.org>
Date:   Tue Aug 13 14:14:58 2019 -0400

    fix(deps): update dependency sitemap to v4

    Squashed commit of the following:

    commit f4dd9cabb21e26fdc21f8413be822ea7c64251f8
    Author: Julian Lam <julian@nodebb.org>
    Date:   Tue Aug 13 11:33:05 2019 -0400

        fix: resolved breaking changes from sitemap v4 upgrade

    commit 9043415ee16dcc27a8dcc2e4479d1bc5e2d1b60e
    Merge: e3352b272 72590b346
    Author: Julian Lam <julian@nodebb.org>
    Date:   Tue Aug 13 11:09:55 2019 -0400

        Merge branch 'master' into renovate/sitemap-4.x

    commit e3352b272eb9400bdb00774973181397803765e4
    Author: Renovate Bot <bot@renovateapp.com>
    Date:   Mon Aug 12 07:59:05 2019 +0000

        fix(deps): update dependency sitemap to v4

commit 8e3c0cdcae22acc32d352be8bb72d60e7502dbc5
Author: Renovate Bot <bot@renovateapp.com>
Date:   Fri Aug 9 00:49:51 2019 +0000

    fix(deps): update dependency commander to v3

commit 2104449d38818f2fa4d44b3a58a0a168781acbfb
Author: Renovate Bot <bot@renovateapp.com>
Date:   Tue Aug 13 15:00:27 2019 +0000

    fix(deps): update dependency mongodb to v3.3.0

commit d2937f446a21131c070ae5d0ff33d67cfe465b8c
Author: Barış Soner Uşaklı <barisusakli@gmail.com>
Date:   Tue Aug 13 10:36:48 2019 -0400

    feat: async/await admin/controllers

commit 1b97e8b199f960dc24e5722702f27499ae049914
Author: Misty (Bot) <deploy@nodebb.org>
Date:   Tue Aug 13 09:28:39 2019 +0000

    Latest translations and fallbacks

commit 69a48957a2f0d23c4d194b664bda3a0431179c01
Author: Barış Soner Uşaklı <barisusakli@gmail.com>
Date:   Mon Aug 12 21:56:09 2019 -0400

    feat: async/await

commit b9b2a7e593a452de4bef6d0ab6abe368a3bdb8dd
Author: Barış Soner Uşaklı <barisusakli@gmail.com>
Date:   Mon Aug 12 20:58:29 2019 -0400

    feat: async/await refactor

    controllers/accounts

commit a8d43a175974a0c8ae3dc132bf51a7ed9a4c6305
Author: Baris Usakli <barisusakli@gmail.com>
Date:   Mon Aug 12 14:49:40 2019 -0400

    feat: async/await controllers/accounts

commit 2f25aae57bf9dbe98d655276770e56bed9ec023b
Author: Barış Soner Uşaklı <barisusakli@gmail.com>
Date:   Sun Aug 11 23:09:50 2019 -0400

    fix: #7831, fix pagination

    convert to async/await

commit c9e83f2374572264855a04156278eef256b0a20c
Author: Barış Soner Uşaklı <barisusakli@gmail.com>
Date:   Sun Aug 11 00:14:35 2019 -0400

    fix: remove empty line

commit 30be91b26c4dd7583412c4e8d56e9c1688e48a44
Author: Barış Soner Uşaklı <barisusakli@gmail.com>
Date:   Sun Aug 11 00:13:41 2019 -0400

    fix: remove useless catchs and empty line

commit 2e4a71c0b6104738f15ffbfe3246105b922fdfb3
Author: Renovate Bot <bot@renovateapp.com>
Date:   Sat Aug 10 06:51:50 2019 +0000

    chore(deps): update dependency eslint-config-airbnb-base to v14
6 years ago
Barış Soner Uşaklı 3ecac97d7e fix: #7826, fix order of categories on recent dropdown 6 years ago
Barış Soner Uşaklı bc6f22ebdb fix: digest not sending topics 6 years ago
Barış Soner Uşaklı ce91288607 fix: derpy catch 6 years ago
Baris Usakli 6a486e35bb fix: user urls in subfolder install
fix missing await
6 years ago
Barış Soner Uşaklı 0b498acdcf fix: #7765 6 years ago
Barış Soner Uşaklı e2e33dfb1e fix: status and groupTitle, if its not set 6 years ago
Barış Soner Uşaklı 930ffd074f fix: tests 6 years ago
Barış Soner Uşaklı a51ec591ee feat: #7743, finish user module 6 years ago
Barış Soner Uşaklı 6fea46b6e2 feat: #7743
user/posts
user/profile
6 years ago
Barış Soner Uşaklı cd80c2638c feat: #7743
user/password
user/picture
6 years ago
Barış Soner Uşaklı 0a690c5710 feat: #7743
user/online.js
6 years ago
Barış Soner Uşaklı 1c5fad6dae feat: #7743
user/notifications.js
6 years ago
Barış Soner Uşaklı fe4c048198 feat: #7743
user/index.js
user/info.js
user/invite.js
user/jobs.js
6 years ago
Barış Soner Uşaklı c610eb1430 feat: #7743, user/digest, user/email, user/follow 6 years ago
Barış Soner Uşaklı 9eb1fcd4e5 fix: #7762, allow array for isBanned
dont filter banned users one by one in digest
6 years ago
Barış Soner Uşaklı d6e36c3166 feat: #7743, user/create, user/data, user/delete 6 years ago
Barış Soner Uşaklı 4541caa4f8 feat: #7743 , user/block, user/categories 6 years ago
Baris Usakli 1970214a24 feat: #7743 user/ban, up mubsub 6 years ago
Barış Soner Uşaklı b24ce97602 feat: #7743, user/approval, user/auth 6 years ago
Barış Soner Uşaklı 2c33595507 feat: #7743 user/admin.js 6 years ago
Barış Soner Uşaklı 805dcd7ca2
Async refactor in place (#7736)
* feat: allow both callback&and await

* feat: ignore async key

* feat: callbackify and promisify in same file

* Revert "feat: callbackify and promisify in same file"

This reverts commit cea206a9b8e6d8295310074b18cc82a504487862.

* feat: no need to store .callbackify

* feat: change getTopics to async

* feat: remove .async

* fix: byScore

* feat: rewrite topics/index and social with async/await

* fix: rewrite topics/data.js

fix issue with async.waterfall, only pass result if its not undefined

* feat: add callbackify to redis/psql

* feat: psql use await

* fix: redis 🌋

* feat: less returns

* feat: more await rewrite

* fix: redis tests

* feat: convert sortedSetAdd

rewrite psql transaction to async/await

* feat: 🐶

* feat: test

* feat: log client and query

* feat: log bind

* feat: more logs

* feat: more logs

* feat: check perform

* feat: dont callbackify transaction

* feat: remove logs

* fix: main functions

* feat: more logs

* fix: increment

* fix: rename

* feat: remove cls

* fix: remove console.log

* feat: add deprecation message to .async usage

* feat: update more dbal methods

* fix: redis :voodoo:

* feat:  fix redis zrem, convert setObject

* feat: upgrade getObject methods

* fix: psql getObjectField

* fix: redis tests

* feat: getObjectKeys

* feat: getObjectValues

* feat: isObjectField

* fix: add missing return

* feat: delObjectField

* feat: incrObjectField

* fix: add missing await

* feat: remove exposed helpers

* feat: list methods

* feat: flush/empty

* feat: delete

* fix: redis delete all

* feat: get/set

* feat: incr/rename

* feat: type

* feat: expire

* feat: setAdd

* feat: setRemove

* feat: isSetMember

* feat: getSetMembers

* feat: setCount, setRemoveRandom

* feat: zcard,zcount

* feat: sortedSetRank

* feat: isSortedSetMember

* feat: zincrby

* feat: sortedSetLex

* feat: processSortedSet

* fix: add mising await

* feat: debug psql

* fix: psql test

* fix: test

* fix: another test

* fix: test fix

* fix: psql tests

* feat: remove logs

* feat: user arrow func

use builtin async promises

* feat: topic bookmarks

* feat: topic.delete

* feat: topic.restore

* feat: topics.purge

* feat: merge

* feat: suggested

* feat: topics/user.js

* feat: topics modules

* feat: topics/follow

* fix: deprecation msg

* feat: fork

* feat: topics/posts

* feat: sorted/recent

* feat: topic/teaser

* feat: topics/tools

* feat: topics/unread

* feat: add back node versions

disable deprecation notice
wrap async controllers in try/catch

* feat: use db directly

* feat: promisify in place

* fix: redis/psql

* feat: deprecation message

logs for psql

* feat: more logs

* feat: more logs

* feat: logs again

* feat: more logs

* fix: call release

* feat: restore travis, remove logs

* fix: loops

* feat: remove .async. usage
6 years ago
Barış Soner Uşaklı 198d05875f feat: cleanup, use bulk 6 years ago
Barış Soner Uşaklı 3ecd703ea3 feat: #7707, added sortedSetAddBulk 6 years ago
Barış Soner Uşaklı 6a7bc1c5fb fix: on new post add it to cid::uid::pids 6 years ago
Barış Soner Uşaklı 7e54d7aa35 feat: use db.sortedSetsAdd 6 years ago
Barış Soner Uşaklı 39ee3980d6 fix: get uids directly for csv 6 years ago
Barış Soner Uşaklı ede060a646 feat: add hook for user notifications, closes #7672 6 years ago
Barış Soner Uşaklı 580f786095 feat: user/notifications refactor 6 years ago
Barış Soner Uşaklı 4b843ba16f fix: #7567, allow invite and approval at the same time 6 years ago
Julian Lam 80c0d579e3 fix: #7593, unable to set account password if no password set 6 years ago
Andrew Rodrigues e114b16d7a fix: if editing password is disabled in ACP, prevent direct access via route/socket (related: #7576) 6 years ago
Aziz Khoury 45acf80987 remove expire timestamp when banning user permanently, fixes #7547 (#7548) 6 years ago
Andrew Rodrigues 9bf3517db1 fix: failing test from 00552d7183 6 years ago
Andrew Rodrigues 00552d7183 fix: fire filter:register.complete for users approved via registration queue 6 years ago
Julian Lam 808c4909a4
fix: #6438 only apply whitelist when fields request empty (#7528)
* fix: #6438 only apply whitelist when fields request empty

* feat: explicit password retrieval denied via getUsersFields
6 years ago
Aziz Khoury 3fbb6faf28 feat: update unban logic/invocation and refactor User.bans module
* auto unban when User.getUsersFields is called and the user is banned but has expired

* cleanups and removal of expiry_readable

* expiry_readable make an alias for backward compatibility

* User.bans.func vs User.*ban*Func

* console.log cleanups, plus todo message added

* use code util.deprecate

* fix: remove ununsed winston require
6 years ago
Baris Usakli ed91d3f2c8 fix: #7519 6 years ago
Barış Soner Uşaklı fddb783ee9 fix: #7487 6 years ago
Barış Soner Uşaklı e331f6b51d fix: #7414 6 years ago
Julian Lam 0360f6e1cb fix: l2spread @baris nib 6 years ago
Baris Usakli 23da300958 feat: pass options to digest 6 years ago
Julian Lam f32a992237
feat: revamp email templates to be more style agnostic (#7375)
* feat: re-designed digest

Updated design, logic no longer shows "no topics", just doesn't
show the list at all, teaser re-retrieved for digest so that it
always grabs a teaser even if there is no reply, changed default
email background to a light grey.

* fix: minor padding issues in digest

* fix: banned template

* fix: invitation.tpl

* fix: removed unused notif_chat and notif_post email templates

* fix: notification template

* fix: registration_accepted template

* fix: reset tpl

* fix: test tpl

* fix: email verify tpl

* fix: reset notify tpl

* fix: welcome tpl

* fix: additional minor font fixes

* fix: removed unused email header image assets

* fix: internationalised 'your daily digest' string

* fix: broken url in digest 🤦

* feat: added RTL support for emailer

/cc @PostMidnight
6 years ago