Commit Graph

6103 Commits (3b125ba27e162f6a0439b12a1f9a10a4ece18add)

Author SHA1 Message Date
Barış Soner Uşaklı 4833a2b90c feat: center chat modal attr
Barış Soner Uşaklı 51096ad234 poc: use csrf_token in ws handshake ()
Barış Soner Uşaklı 63b859f053
poc: use csrf_token in ws handshake ()
Barış Soner Uşaklı efea33d906 Merge branch 'master' into develop
Barış Soner Uşaklı d55cd464a0 fix: , dont trigger edit if chat input has text
pressing escape will cancel edit
Julian Lam 4f524e9f94 feat: token rolling API for admins
+ tests
Julian Lam ce23caf7e6 feat: token editing and deletion
Julian Lam e4888dea17 feat: api token migration, new ACP tokens list, token creation
Barış Soner Uşaklı e0149462b3 refactor: remove return
Julian Lam e94c58becd Merge remote-tracking branch 'origin/master' into develop
Barış Soner Uşaklı e1bb277fb4 feat: add helper to convert isostrings to localeString
Barış Soner Uşaklı f974c230ef fix: chat ip button not doing anything if clicked outside of icon
Barış Soner Uşaklı 34730caf97 fix: selector for nav scroll
harmony doesn't have topic-header, they all have topic-main-buttons
Barış Soner Uşaklı e832d365ba refactor: removed parsing for taskbar
harmony doesnt have a taskbar
Barış Soner Uşaklı 101fe81d42 feat: add app.newReply
like app.newTopic
Barış Soner Uşaklı 0af2b800b3 fix: closes , close dialogs on escape/backdrop click
Barış Soner Uşaklı 24e0e5024d fix: show edit indicator after an edit without reloading the page
Julian Lam 36895421ba refactor: topic mark read/unread routes
Julian Lam f2082d7de8 refactor: started work on porting socket methods to write API [breaking]
The following socket calls have been removed:

* `posts.getRawPost`
* `posts.getPostSummaryByPid`

Two new Write API routes have been added:

- `GET /api/v3/posts/:pid/raw`
- `GET /api/v3/posts/:pid/summary`
Julian Lam 2b70063eec fix: , wrong message shown to new users re: email confirmation
Barış Soner Uşaklı d0a15e9ec8 fix: closes
Barış Soner Uşaklı 156b8e7721 fix: add check for no tids
Barış Soner Uşaklı e3551d80d7 feat: allow tag editing from topic tools
closes 
closes 
closes 
Barış Soner Uşaklı 4aa87366f9 feat: , copy ip on click
Barış Soner Uşaklı eb0c77fd69 feat: , improve chat editing
use a new template for editing chats,
remove the data-mid on the chat inputEl
Barış Soner Uşaklı 83569debe8 Merge branch 'master' into develop
Barış Soner Uşaklı 9484ddc36f fix: use query param sort over user setting if it's set
regression from 77ddfc642e
Barış Soner Uşaklı 073f4d37dc lint: fix comma
Barış Soner Uşaklı 619e910f69 fix: only add copy button to multiline codeblocks
Barış Soner Uşaklı 0a292fc1ae feat: closes , add a copy code button to code blocks
Barış Soner Uşaklı 84a78c2d5f feat: move topic thumb to template
use a single modal to show all thumbs and allow switching
Julian Lam 04219c4ccb feat: open topic thumbs on click in a bootbox dialog instead of opening in same page; complements
Julian Lam c3ebda22c0
fix: go back to post queue after deleting an account in post queue ()
It makes little sense to refresh the page as the content no longer exists, so just go back to the post queue list.
Barış Soner Uşaklı 6b51dd5a2f
feat: closes , add category selector to fork modal ()
select the current category on open
Barış Soner Uşaklı bb4be716d4 test: no need for this check
Barış Soner Uşaklı eacbad7ff7 test: fix utils
Barış Soner Uşaklı 699c3bdf35 test: missing utils tests
Barış Soner Uşaklı 9894d05f32 fix: closes , update selector
Barış Soner Uşaklı 2055aae17f https://github.com/NodeBB/NodeBB/issues/11501
Barış Soner Uşaklı 9ec5f1f54b https://github.com/NodeBB/NodeBB/issues/11500
Julian Lam 5feb509b16 fix: don't crash if taskbar.tasklist is not defined yet
Barış Soner Uşaklı 0e4dbae91b fix dropdown nav highlight
Julian Lam 70f4d7f099 fix: topic thumbnail removal error
Relaxed DOM selector to accommodate changed tpl
Julian Lam dd8719a10e fix: upload modal error handler
The underlying API call was updated to v3 style (with standard status/response object in response body), so the existing code always falls back to the default error instead of showing the more specific error sent back by the backend.

Also, the fallback wasn't internationalized, so that's done to.
Barış Soner Uşaklı 2235f6c280 fix: , use bookmark from localstorage for guests
Barış Soner Uşaklı 0e5ae21286 fix: , update timestamp on lastpost button
Julian Lam 9d49ec60a1 fix: remove socketGroups.issueMassInvite
Julian Lam b53f92fa2e fix: handle client-side acceptAll and rejectAll
Julian Lam 18c45b4461 refactor: group invitations; issuing, accepting, rejecting; now via API
Julian Lam 34d99c15af fix: use api routes for group accept/reject
Barış Soner Uşaklı cc1c493bbf fix: updating user bookmark when entering topic at the end from teaser
Barış Soner Uşaklı a3ae0c583a remove old code
Barış Soner Uşaklı 645ebec8fa feat: allow multiple topic selects in topic-list
chore: up persona
Barış Soner Uşaklı 5d9b23cafc fix: direct replies on dynamic posts
Barış Soner Uşaklı 29872b4326 make border color important
Barış Soner Uşaklı 2615192fc0 fix: topic labels on topics_list
Barış Soner Uşaklı 28ed6c923c update buildCategoryLabel
no bg image in labels dont put a i tag if no icon
Barış Soner Uşaklı 45addcf5ec refactor: simple load new posts
Barış Soner Uşaklı 69f24ed92a feat: add support for selected topic count
Barış Soner Uşaklı a83734fb2b fix: dont show search input if user doesn't have tag search priv
Julian Lam 33ad5a724a fix: buttons for post queue content editing
Barış Soner Uşaklı 6b89884dd5 use selected class for user status elements
Barış Soner Uşaklı 661a6e0473 https://github.com/NodeBB/NodeBB/issues/11329
Julian Lam 596db09f7e Merge branch 'master' into develop
Julian Lam ddcdaacc94 refactor: post-queue frontend logic
Barış Soner Uşaklı 77ddfc642e feat: closes , move sort settings to user settings page
don't change user settings when user changes sort inside topic/category
Julian Lam 402229845c feat: display when an api key was last used, in ACP,
Julian Lam 2614b95c40 fix: , bug where the call to `action:settings.sorted-list.itemLoaded` did not properly pass in the correct element
Barış Soner Uşaklı 7ba70d1561
Bootstrap5 ()
* chore: up deps

* chore: up composer

* fix(deps): bump 2factor to v7

* chore: up harmony

* chore: up harmony

* fix: missing await

* feat: allow middlewares to pass in template values via res.locals

* feat: buildAccountData middleware automatically added ot all account routes

* fix: properly allow values in res.locals.templateValues to be added to the template data

* refactor: user/blocks

* refactor(accounts): categories and consent

* feat: automatically 404 if exposeUid or exposeGroupName come up empty

* refactor: remove calls to getUserDataByUserSlug for most account routes, since it is populated via middleware now

* fix: allow exposeUid and exposeGroupName to work with slugs with mixed capitalization

* fix: move reputation removal check to accountHelpers method

* test: skip i18n tests if ref branch when present is not develop

* fix(deps): bump theme versions

* fix(deps): bump ntfy and 2factor

* chore: up harmony

* fix: add missing return

* fix: , only focus on search input on md environments and up

* feat: allow file uploads on mobile chat

closes https://github.com/NodeBB/NodeBB/issues/11217

* chore: up themes

* chore: add lang string

* fix(deps): bump ntfy to 1.0.15

* refactor: use new if/each syntax

* chore: up composer

* fix: regression from user helper refactor

* chore: up harmony

* chore: up composer

* chore: up harmony

* chore: up harmony

* chore: up harmony

* chore: fix composer version

* feat: add increment helper

* chore: up harmony

* fix:  no timestamps in future 

* chore: up harmony

* check config.theme as well

fire action:posts.loaded after processing dom

* chore: up harmony

* chore: up harmony

* chore: up harmony

* chore: up themes

* chore: up harmony

* remove extra class

* refactor: move these to core from harmony

* chore: up widgets

* chore: up widgets

* height auto

* fix: closes 

* dont focus inputs, annoying on mobile

* fix: dont focus twice, only focus on chat input on desktop

dont wrap widget footer in row

* chore: up harmony

* chore: up harmony

* update chat window

* chore: up themes

* fix cache buster for skins

* chat fixes

* chore: up harmony

* chore: up composer

* refactor: change hook logs to debug

* fix: scroll to post right after adding to dom

* fix: hash scrolling and highlighting correct post

* test: re-enable read API schema tests

* fix: add back schema changes for 179faa2270f2ad955dcc4a7b04755acce59e6ffd and c3920ccb10d8ead2dcd9914bb1784bed3f6adfd4

* fix: schema changes from 488f0978a4

* fix: schema changes for f4cf482a87

* fix: schema update for be6bbabd0e

* fix: schema changes for 69c96078ea

* fix: schema changes for d1364c3130

* fix: schema changes for 84ff1152f7

* fix: schema changes for b860c2605c

* fix: schema changes for 23cb67a112

* fix: schema changes for b916e42f40

* fix: schema change for a9bbb586fc

* fix: schema changes for 4b738c8cd3

* fix: schema changes for 58b5781cea

* fix: schema changes for 794bf01b21

* fix: schema changes for 80ea12c1c1, e368feef51, and 52ead114bec961c62fa2eb0786540e229f6e4873

* fix: composer-default object in config?

* fix: schema changes for 9acdc6808c and 093093420027999df3c67bf0ea6024f6dbf81d2d

* fix: schema changes for c0a52924f1

* fix: schema change for aba420a3f3, move loggedInUser to optional props

* fix: schema changes for 8c67031609

* fix: schema changes for 27e53b42f3

* fix: schema changes for 2835966518

* fix: breaking test for email confirmation API call

* fix: schema changes for refactored search page

* fix: schema changes for user object

* fix: schema changes for 9f531f957e

* fix: schema changes for c4042c70de and 23175110a2

* fix: schema changes for 9b3616b10392e247974eb0c1e6225a1582bf6c69

* fix: schema changes for 5afd5de07d

* fix: schema change for 1d7baf12171cffbd3af8914bef4e6297d1160d49

* fix: schema changes for 57bfb37c55a839662144e684875003ab52315ecc and be6bbabd0e

* fix: schema changes for 6e86b4afa20d662af8b9f1c07518df2d8c258105 and 3efad2e13b7319eb9a1f4fda7af047be43ebc11f and 68f66223e73a72f378f193c83a9b5546bede2cda

* fix: allowing optional qs prop in pagination keys (not sure why this didn't break before)

* fix: re-login on email change

* fix: schema changes for c926358d73

* fix: schema changes for 388a8270c9882892bad5c8141f65da8d59eac0fd

* fix: schema change for 2658bcc821c22e137a6eeb9bb74098856a642eaf

* fix: no need to call account middlewares for chats routes

* fix: schema changes for 71743affc3e58dc85d4ffa15ce043d4d9ddd3d67

* fix: final schema changes

* test: support for anyOf and oneOf

* fix: check thumb

* dont scroll to top on back press

* remove group log

* fix: add top margin to merged and deleted alerts

* chore: up widgets

* fix: improve fix-lists mixin

* chore: up harmony/composer

* feat: allow hiding quicksearch results during search

* dont record searches made by composer

* chore: up 54

* chore: up spam be gone

* feat: add prev/next page and page count into mobile paginator

* chore: up harmony

* chore: up harmony

* use old style for IS

* fix: hide entire toolbar row if no posts or not singlePost

* fix: updated messaging for post-queue template, 

* fix: btn-sm on post queue back button

* fix: bump harmony, closes 

* fix: remove unused alert module import

* fix: bump harmony

* fix: bump harmony

* chore: up harmony

* refactor: IS scrolltop

* fix: update users:search-user-for-chat source string

* feat: support for mark-read toggle on chats dropdown and recent chats list

* feat: api v3 calls to mark chat read/unread

* feat: send event:chats.mark socket event on mark read or unread

* refactor: allow frontend to mark chats as unread, use new API v3 routes instead of socket calls, better frontend event handling

* docs: openapi schema updates for chat marking

* fix: allow unread state toggling in chats dropdown too

* fix: issue where repeated openings of the chats dropdown would continually add events for mark-read/unread

* fix: debug log

* refactor: move userSearch filter to a module

* feat(routes): allow remounting /categories ()

* feat: send flags count to frontend on flags list page

* refactor: filter form client-side js to extract out some logic

* fix: applyFilters to not take any arguments, update selectedCids in updateButton instead of onHidden

* fix: use userFilter module for assignee, reporterId, targetUid

* fix(openapi): schema changes for updated flags page

* fix: dont allow adding duplicates to userFilter

* use same var

* remove log

* fix: closes 

* feat: lang key for x-topics

* chore: up harmony

* chore: up emoji

* chore: up harmony

* fix: update userFilter to allow new option `selectedBlock`

* fix: wrong block name passed to userFilter

* fix: https://github.com/NodeBB/NodeBB/issues/11283

* fix: chats, allow multiple dropdowns like in harmony

* chore: up harmony

* refactor: flag note adding/editing, closes 

* fix: remove old prepareEdit logic

* chore: add caveat about hacky code block in userFilter module

* fix: placeholders for userFilter module

* refactor: navigator so it works with multiple thumbs/navigators

* chore: up harmony

* fix: closes , destroy quick reply autocomplete

on navigation

* fix: filter disabled categories on user categories page count

* chore: up harmony

* docs: update openapi spec to include info about passing in timestamps for topic creation, removing timestamp as valid request param for topic replying

* fix: send back null values on ACP search dashboard for startDate and endDate if not expicitly passed in, fix tests

* fix: tweak table order in ACP dash searches

* fix: only invoke navigator click drag on left mouse button

* feat: add back unread indicator to navigator

* clear bookmark on mark unread

* fix: navigator crash on ajaxify

* better thumb top calculation

* fix: reset user bookmark when topic is marked unread

* Revert "fix: reset user bookmark when topic is marked unread"

This reverts commit 9bcd85c2c6848c3d325d32027261809da6e11c9e.

* fix: update unread indicator on scroll, add unread count

* chore: bump harmony

* fix: crash on navigator unread update when backing out of a topic

* fix: closes 

* fix: update topics:recent zset when rescheduling a topic

* fix: dupe quote button, increase delay, hide immediately on empty selection

* fix: navigator not showing up on first load

* refactor: remove glance

assorted fixes to navigator
dont reduce remaning count if user scrolls down and up quickly
only call topic.navigatorCallback when index changes

* more sanity checks for bookmark

dont allow setting bookmark higher than topic postcount

* closes , 🚋

* Revert "fix: update topics:recent zset when rescheduling a topic"

This reverts commit 737973cca9e94b6cb3867492a09e1e0b1af391d5.

* fix: , show proper error if queued post doesn't exist

was showing no-privileges if someone else accepted the post

* https://github.com/NodeBB/NodeBB/issues/11307

dont use li

* chore: up harmony

* chore: bump version string

* fix: copy paste fail

* feat: closes , tag filtering

add client side support for filtering by tags on /category, /recent and /unread

* chore: up harmony

* chore: up harmony

* Revert "fix: add back req.query fallback for backwards compatibility" [breaking]

This reverts commit cf6cc2c454dc35c330393c62ee8ce67b42d8eefb.
This commit is no longer required as passing in a CSRF token via query parameter is no longer supported as of NodeBB v3.x

This is a breaking change.

* fix: pass csrf token in form data, re: 

* chore: up deps

* fix: tests, use x-csrf-token query param removed

* test: fix csrf_token

* lint: remove unused

* feat: add itemprop="image" to avatar helper

* fix: get chat upload button in chat modal

* breaking: remove deprecated socket.io methods

* test: update messaging tests to not use sockets

* fix: parent post links

* fix: prevent post tooltip if mouse leaves before data/tpl is loaded

* chore: up harmony

* chore: up harmony

* chore: up harmony

* chore: up harmony

* fix: nested replies indices

* fix(deps): bump 2factor

* feat: add loggedIn user to all api routes

* chore: up themes

* refactor: audit admin v3 write api routes as per 

* refactor: audit category v3 write api routes as per  [breaking]

docs: fix open api spec for 

* refactor: audit chat v3 write api routes as per 

* refactor: audit files v3 write api routes as per 

* refactor: audit flags v3 write api routes as per 

* refactor: audit posts v3 write api routes as per 

* refactor: audit topics v3 write api routes as per 

* refactor: audit users v3 write api routes as per 

* fix: lang string

* remove min height

* fix: empty topic/labels taking up space

* fix: tag filtering when changing filter to watched topics

or changing popular time limit to month

* chore: up harmony

* fix: closes , show no post error if queued post already accepted/rejected

* test: 

* test: 

* fix(deps): bump 2factor

* fix:  clear cache on thumb remove

* fix: thumb remove on windows, closes 

* test: openapi for thumbs

* test: fix openapi

---------

Co-authored-by: Julian Lam <julian@nodebb.org>
Co-authored-by: Opliko <opliko.reg@protonmail.com>
Julian Lam 17d0b40efa fix: stop topic navigation hotkeys from firing if in a mousetrap-enabled form element
Barış Soner Uşaklı f054a4f44d fix: get cid from pid instead of passing in
Julian Lam 36bcdf8f9d Merge branch 'master' into develop
Barış Soner Uşaklı 8cf4a6f62e fix: alert on page load
Eldor 3bd9a87154 fix: show error alert if password change fails
Barış Soner Uşaklı 79731735c0 feat: allow file uploads on mobile chat
closes https://github.com/NodeBB/NodeBB/issues/11217
Barış Soner Uşaklı 06f4801e57 refactor: remove debug log closes
Julian Lam 43e7c98824 fix: relax selectors for client-side form validation so that all form elements are checked
Julian Lam dadbcd731c feat: integrating basic client-side form validity checking in settings v1 and v2
Barış Soner Uşaklı 91c2e5ac25 refactor: not deprecated on 2.x
Julian Lam 97d8b53fd3 Merge branch 'master' into develop
Barış Soner Uşaklı d264c6ac4b refactor: use utils.debounce
Julian Lam a2fafc2b15 Merge remote-tracking branch 'origin/master' into develop
Barış Soner Uşaklı 9227b82e2c fix: check cid as well as template
Julian Lam 96b46411b1 Merge branch 'master' into develop
Julian Lam 9c576a0758
Email confirmation QOL updates ()
* breaking: remove `SocketUser.emailConfirm`, re: 

* chore: move email confirmation related configs to own section in Settings > Email

* feat: new user email method `getValidationExpiry`, returns expiration in ms.. probably.

* fix: bug where `user.email.isValidationPending` returned an u nexpected non-boolean value if there was no confirmation pending (only when checking email as well)

* fix: update getValidationExpiry to return ms

* test: use emailConfirmInterval for tests, for now

* fix: throw friendly error when attempting an email change within email confirmation window

* feat: new config option `emailConfirmExpiry` in days, governs how long the confirm link is good for

* test: additional tests for user email methods

* fix: add back missing handling of  option

* test: fix tests
Julian Lam af27606e20 fix: , icon selector in ACP when icon name is typed in
Julian Lam 1e864a7518 Merge remote-tracking branch 'origin/master' into develop
Barış Soner Uşaklı 61d32bdebb fix: category ordering add test
Barış Soner Uşaklı 989b55d07e fix: crash in category drag, closes
happens when a child is dragged to root or from root to a nested level
Barış Soner Uşaklı c0b1ded363 fix more categories button not moving with parent
fix order issue
Julian Lam 803398e915 fix: broken flag history on flag update
Barış Soner Uşaklı a584dae650 feat: add relevant topic events to post objects
see c9604f216a
Barış Soner Uşaklı aad0a618c8 fix: scroll to post if theme doesn't have top navbar
Julian Lam 6391f77b01 Merge remote-tracking branch 'origin/master' into develop
Julian Lam 135fe55bed feat: client-side hooks for navigator scroll action
Julian Lam 664bc5f54d fix: update nav thumb on setIndex call (thx @barisusakli)
Julian Lam aeb94c32b9 feat: j and k hotkeys in topic to navigate through it quickly
Julian Lam b7287c1eb8 fix: do not call `navigator.update()` when `scrollToElement` is explicitly passed a new index value
Julian Lam fa643eb808 fix: race condition where `navigator.update` was called when it should not be
Julian Lam 9f9a835fcb feat: a couple utility methods in navigator module to get and set count and index
Julian Lam 5b9de0e521 fix: be tidier and explicitly clean up ctrl-f hotkey on topic page
Julian Lam 3700174c62 refactor: added new ajaxify method .cleanup, called before ajaxify.start.
Barış Soner Uşaklı b5dd89e1c0
feat: store topic title and tags in diffs ()
* feat: store topic title and tags in diffs

allow restoring post diff if tags didn't change

* test: fix tests, fast computer problems
Barış Soner Uşaklı 8e2129f858 fix: , unescape / in taskbar
Julian Lam f1cca5be8d Merge remote-tracking branch 'origin/master' into develop
Julian Lam d3e38df8ea fix: add back timeago to post history modal
Julian Lam 881c7c4d18 fix: automatically remove `lang` parameter if it matches the forum default
Barış Soner Uşaklı f6f37dc1cd fix: registration regression, closes
Opliko 1920732528
feat: remove visibilityjs ()
* feat: remove visibilityjs

* fix: actually remove require

* style: add a newline

* style: forgot a semicolon

* style: accidently removed trailing newline

* fix: move property declaration to its actual previous place
Barış Soner Uşaklı b7addffc9e breaking: reduce nodebb.min.js size by around 800kb
const zxcvbn = require('zxcvbn');
bundles a huge amount of code, now it won't be in nodebb.min.js
Julian Lam df36d96788 fix: empty thread tools container on open
Julian Lam 3dd3cd8297 fix: add dropup handler to thread tools menu, updated how post tools menu adds dropup handler
Barış Soner Uşaklı a2d0cd162d
refactor: remove console.log
Julian Lam bc2ea86023 chore: remove client-side js file for tpl that no longer exists
Julian Lam d05705183f refactor: move export generation logic to v3 controller, GET/HEAD routes for exports
re: 
Barış Soner Uşaklı 0a6900fc77 feat: don't show signatures again in pagination mode in same topic
Barış Soner Uşaklı aba420a3f3 feat: setting to show signatures only once in topics, closes
Opliko bcb94edeb4 feat: add event type to topic event component
Julian Lam 4055e3bd1c feat: automatically enable the SMTP transport option if the SMTP service is changed
Barış Soner Uşaklı 4586f68eaf fix: race condition causing undefined ajaxify.data
Julian Lam 847d2b9141 fix: , early return for selection tooltip based on calling user privilege
Barış Soner Uşaklı b2da02d676 feat: add client side filter:chat.send, closes
Julian Lam 820bc994d8
feat: UI changes for ACP > Manage > Categories ()
* Revert "Revert "feat: cross origin opener policy options ()""

This reverts commit 46050ace1a.

* Revert "Revert "chore(i18n): fallback strings for new resources: nodebb.admin-settings-advanced""

This reverts commit 9f291c07d3.

* feat: closes , don't trim children if category is marked section

* feat: fire hook to allow plugins to filter the pids returned in a user profile

/cc 

* fix: use `user.hidePrivateData();` more consistently across user retrieval endpoints

* fix: better looking placeholder text for ACP search

* fix: bug where fallback to forum search was not working due to client-side error

* feat: allow plugins to toggle whether IPs are shown in the users CSV export

* feat: Allow defining active plugins in config ()

* Revert "Revert "feat: cross origin opener policy options ()""

This reverts commit 46050ace1a.

* Revert "Revert "chore(i18n): fallback strings for new resources: nodebb.admin-settings-advanced""

This reverts commit 9f291c07d3.

* feat: closes , don't trim children if category is marked section

* feat: fire hook to allow plugins to filter the pids returned in a user profile

/cc 

* fix: use `user.hidePrivateData();` more consistently across user retrieval endpoints

* feat: Allow defining active plugins in config

resolves 

* fix: assign the db result to files properly

* test: add tests with plugins in config

* feat: better theme change handling

* feat: add visual indication that plugins can't be activated

* test: correct hooks

* test: fix test definitions

* test: remove instead of resetting nconf to avoid affecting other tests

* test: ... I forgot how nconf worked

* fix: remove negation

* docs: improve wording of error message

* feat: reduce code duplication

* style: remove a redundant space

* fix: remove unused imports

* fix: use nconf instead of requiring config.json

* fix: await...

* fix: second missed await

* fix: move back from getActiveIds to getActive

* fix: use paths again?

* fix: typo

* fix: move require into the function

* fix: forgot to change back to getActive

* test: getActive returns only id

* test: accedently commented out some stuff

* feat: added note to top of plugins page if \!canChangeState

Co-authored-by: Julian Lam <julian@nodebb.org>
Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>

* feat: show an informative message when no plugins are found after filtering

fixes 

* Latest translations and fallbacks

* Latest translations and fallbacks

* chore(deps): bump ace-builds from 1.7.1 to 1.8.1 in /install

Bumps [ace-builds](https://github.com/ajaxorg/ace-builds) from 1.7.1 to 1.8.1.
- [Release notes](https://github.com/ajaxorg/ace-builds/releases)
- [Changelog](https://github.com/ajaxorg/ace-builds/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ajaxorg/ace-builds/compare/v1.7.1...v1.8.1)

---
updated-dependencies:
- dependency-name: ace-builds
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: swap out icons in ACP > Manage > Categories to more intuitive ones, remove extra placeholder div

* fix: hide expando button if no subcategories; remove attempt at establishing common vars, increased spacing between categories in list

* fix: buggy expando state on category drag/drop

Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
Co-authored-by: Opliko <opliko.reg@protonmail.com>
Co-authored-by: Misty Release Bot <deploy@nodebb.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Julian Lam 6840a7423b feat: show an informative message when no plugins are found after filtering
fixes 
Julian Lam 25046642e7 fix: bug where fallback to forum search was not working due to client-side error
Julian Lam 1b9c68196f fix: better looking placeholder text for ACP search
Julian Lam b778e38c2b fix: move call to `ajaxify.parseData` out to root level
Julian Lam 165b804d64 refactor: rewrite ajaxify.parseData in vanilla
Julian Lam 2582cb53a6 fix: move `ajaxify.parseData` back out to DOMContentLoaded
partialy reverts 2bfccac72
Barış Soner Uşaklı 2da188fe10 fix: , fix alert for password reset email
Barış Soner Uşaklı 48564cfa86 fix: , don't ajaxify to /assets/ urls
Barış Soner Uşaklı 6a0339dea4 https://github.com/pichalite/nodebb-theme-slick/issues/60
Barış Soner Uşaklı 39d61061e0 feat: add clipboard to runtime modules
Barış Soner Uşaklı 2bfccac72a fix: , fix order of dom ready events
plugin $().ready hooks will fire first, core will fire last
Barış Soner Uşaklı 191fb9f443 test: fix tests again
Barış Soner Uşaklı 60eeae95d2 lint: unnecessary escape
Barış Soner Uşaklı e802fab87f fix: get rid of math.random in utils.generateUUID
Barış Soner Uşaklı b124370b92 Merge branch 'master' of https://github.com/NodeBB/NodeBB
Barış Soner Uşaklı 7e4d2852f6 fix: , gray out disabled nav items
use enabled property if present
change default to true, so added nav items are enabled by default
Julian Lam 92abb352b6 fix: encode privilege name for API call
Barış Soner Uşaklı 9acdc6808c feat: allow unban/unmute on flag details page. closes
Barış Soner Uşaklı b17a81bfb0 fix: translate api error messages to user lang, closes ,
Barış Soner Uşaklı 24a640d93e fix: alert template error. closes
Barış Soner Uşaklı 082a9e1d42 fix: remove ev, hooks don't pass event, closes
Barış Soner Uşaklı b860c2605c feat: paginaton for admins-mods, closes
ability to select categoriest to see children
Barış Soner Uşaklı a583141252 feat: add button to see category children, closes
Barış Soner Uşaklı 70ad4a5222 fix: clear dragging on mouseup as well
dragging a modal wasn't firing dragend
Julian Lam 5aca106b81 chore: add note re: sort module
Barış Soner Uşaklı dc320c897a feat: closes , ability to prevent alerts on topic list
Barış Soner Uşaklı e904f43857 feat: add sorted-list.parse