From facc10e40f8789058214d0677806e65b0cc7c37d Mon Sep 17 00:00:00 2001 From: Baris Usakli Date: Fri, 12 Nov 2021 11:18:44 -0500 Subject: [PATCH] perf: remove createUserTooltips --- public/src/app.js | 20 ++------------------ public/src/client/account/posts.js | 1 - public/src/client/account/topics.js | 1 - public/src/client/categories.js | 2 -- public/src/client/category.js | 1 - public/src/client/topic/posts.js | 3 --- public/src/modules/chat.js | 1 - public/src/modules/topicList.js | 1 - 8 files changed, 2 insertions(+), 28 deletions(-) diff --git a/public/src/app.js b/public/src/app.js index 6154c8b323..e92eb5c8ca 100644 --- a/public/src/app.js +++ b/public/src/app.js @@ -209,18 +209,8 @@ app.flags = {}; .addClass('active'); } - app.createUserTooltips = function (els, placement) { - if (isTouchDevice) { - return; - } - els = els || $('body'); - els.find('.avatar,img[title].teaser-pic,img[title].user-img,div.user-icon,span.user-icon').each(function () { - $(this).tooltip({ - placement: placement || $(this).attr('title-placement') || 'top', - title: $(this).attr('title'), - container: '#content', - }); - }); + app.createUserTooltips = function () { + console.warn('[removed] app.creatUserTooltips is removed'); }; app.createStatusTooltips = function () { @@ -234,15 +224,9 @@ app.flags = {}; app.processPage = function () { highlightNavigationLink(); - $('.timeago').timeago(); - utils.makeNumbersHumanReadable($('.human-readable-number')); - utils.addCommasToNumbers($('.formatted-number')); - - app.createUserTooltips($('#content')); - app.createStatusTooltips(); }; diff --git a/public/src/client/account/posts.js b/public/src/client/account/posts.js index 27442e21a5..a0c0a3e92f 100644 --- a/public/src/client/account/posts.js +++ b/public/src/client/account/posts.js @@ -45,7 +45,6 @@ define('forum/account/posts', ['forum/account/header', 'forum/infinitescroll', ' $('[component="posts"]').append(html); html.find('img:not(.not-responsive)').addClass('img-responsive'); html.find('.timeago').timeago(); - app.createUserTooltips(); utils.makeNumbersHumanReadable(html.find('.human-readable-number')); hooks.fire('action:posts.loaded', { posts: posts }); callback(); diff --git a/public/src/client/account/topics.js b/public/src/client/account/topics.js index cba3358275..565bb9b170 100644 --- a/public/src/client/account/topics.js +++ b/public/src/client/account/topics.js @@ -46,7 +46,6 @@ define('forum/account/topics', [ app.parseAndTranslate(template, 'topics', { topics: topics }, function (html) { $('[component="category"]').append(html); html.find('.timeago').timeago(); - app.createUserTooltips(); utils.makeNumbersHumanReadable(html.find('.human-readable-number')); hooks.fire('action:topics.loaded', { topics: topics }); callback(); diff --git a/public/src/client/categories.js b/public/src/client/categories.js index 44025e8b8c..1881941c00 100644 --- a/public/src/client/categories.js +++ b/public/src/client/categories.js @@ -55,8 +55,6 @@ define('forum/categories', ['components', 'categorySelector', 'hooks'], function } html.fadeIn(); - - app.createUserTooltips(); html.find('.timeago').timeago(); if (category.find('[component="category/posts"]').length > parseInt(numRecentReplies, 10)) { diff --git a/public/src/client/category.js b/public/src/client/category.js index da8a6296cf..5e0fccbcbb 100644 --- a/public/src/client/category.js +++ b/public/src/client/category.js @@ -104,7 +104,6 @@ define('forum/category', [ html.find('.timeago').timeago(); $('[component="category/subcategory/container"]').append(html); utils.makeNumbersHumanReadable(html.find('.human-readable-number')); - app.createUserTooltips(html); ajaxify.data.nextSubCategoryStart += ajaxify.data.subCategoriesPerPage; ajaxify.data.subCategoriesLeft -= data.length; btn.toggleClass('hidden', ajaxify.data.subCategoriesLeft <= 0) diff --git a/public/src/client/topic/posts.js b/public/src/client/topic/posts.js index b84953e915..9e3f63a657 100644 --- a/public/src/client/topic/posts.js +++ b/public/src/client/topic/posts.js @@ -370,9 +370,6 @@ define('forum/topic/posts', [ Posts.onNewPostsAddedToDom = function (posts) { Posts.onTopicPageLoad(posts); - - app.createUserTooltips(posts); - utils.addCommasToNumbers(posts.find('.formatted-number')); utils.makeNumbersHumanReadable(posts.find('.human-readable-number')); posts.find('.timeago').timeago(); diff --git a/public/src/modules/chat.js b/public/src/modules/chat.js index d57386040a..1300b78c22 100644 --- a/public/src/modules/chat.js +++ b/public/src/modules/chat.js @@ -96,7 +96,6 @@ define('chat', [ app.parseAndTranslate('partials/chats/dropdown', { rooms: rooms }, function (html) { chatsListEl.find('*').not('.navigation-link').remove(); chatsListEl.prepend(html); - app.createUserTooltips(chatsListEl, 'right'); chatsListEl.off('click').on('click', '[data-roomid]', function (ev) { if ($(ev.target).parents('.user-link').length) { return; diff --git a/public/src/modules/topicList.js b/public/src/modules/topicList.js index 1ce4016364..db65c20522 100644 --- a/public/src/modules/topicList.js +++ b/public/src/modules/topicList.js @@ -262,7 +262,6 @@ define('topicList', [ } html.find('.timeago').timeago(); - app.createUserTooltips(html); utils.makeNumbersHumanReadable(html.find('.human-readable-number')); hooks.fire('action:topics.loaded', { topics: topics, template: templateName }); callback();