From f88db22ca246b6687c0677f6e45b2acaa1ff5dbd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Mon, 17 Dec 2018 16:36:43 -0500 Subject: [PATCH] feat: give the rest of the middlewares names --- src/middleware/render.js | 4 ++-- src/middleware/user.js | 20 ++++++++++---------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/middleware/render.js b/src/middleware/render.js index d49a5dcee2..56ee550504 100644 --- a/src/middleware/render.js +++ b/src/middleware/render.js @@ -11,10 +11,10 @@ var widgets = require('../widgets'); var utils = require('../utils'); module.exports = function (middleware) { - middleware.processRender = function (req, res, next) { + middleware.processRender = function processRender(req, res, next) { // res.render post-processing, modified from here: https://gist.github.com/mrlannigan/5051687 var render = res.render; - res.render = function (template, options, fn) { + res.render = function renderOverride(template, options, fn) { var self = this; var req = this.req; var defaultFn = function (err, str) { diff --git a/src/middleware/user.js b/src/middleware/user.js index 29f756eb52..02d8446122 100644 --- a/src/middleware/user.js +++ b/src/middleware/user.js @@ -43,21 +43,21 @@ module.exports = function (middleware) { callback(); } - middleware.authenticate = function (req, res, next) { + middleware.authenticate = function authenticate(req, res, next) { authenticate(req, res, next, function () { controllers.helpers.notAllowed(req, res, next); }); }; - middleware.authenticateOrGuest = function (req, res, next) { + middleware.authenticateOrGuest = function authenticateOrGuest(req, res, next) { authenticate(req, res, next, next); }; - middleware.ensureSelfOrGlobalPrivilege = function (req, res, next) { + middleware.ensureSelfOrGlobalPrivilege = function ensureSelfOrGlobalPrivilege(req, res, next) { ensureSelfOrMethod(user.isAdminOrGlobalMod, req, res, next); }; - middleware.ensureSelfOrPrivileged = function (req, res, next) { + middleware.ensureSelfOrPrivileged = function ensureSelfOrPrivileged(req, res, next) { ensureSelfOrMethod(user.isPrivileged, req, res, next); }; @@ -87,7 +87,7 @@ module.exports = function (middleware) { ], next); } - middleware.checkGlobalPrivacySettings = function (req, res, next) { + middleware.checkGlobalPrivacySettings = function checkGlobalPrivacySettings(req, res, next) { if (!req.loggedIn && meta.config.privateUserInfo) { return middleware.authenticate(req, res, next); } @@ -95,7 +95,7 @@ module.exports = function (middleware) { next(); }; - middleware.checkAccountPermissions = function (req, res, next) { + middleware.checkAccountPermissions = function checkAccountPermissions(req, res, next) { // This middleware ensures that only the requested user and admins can pass async.waterfall([ function (next) { @@ -128,7 +128,7 @@ module.exports = function (middleware) { ], next); }; - middleware.redirectToAccountIfLoggedIn = function (req, res, next) { + middleware.redirectToAccountIfLoggedIn = function redirectToAccountIfLoggedIn(req, res, next) { if (req.session.forceLogin || req.uid <= 0) { return next(); } @@ -143,7 +143,7 @@ module.exports = function (middleware) { ], next); }; - middleware.redirectUidToUserslug = function (req, res, next) { + middleware.redirectUidToUserslug = function redirectUidToUserslug(req, res, next) { var uid = parseInt(req.params.uid, 10); if (uid <= 0) { return next(); @@ -164,7 +164,7 @@ module.exports = function (middleware) { ], next); }; - middleware.redirectMeToUserslug = function (req, res, next) { + middleware.redirectMeToUserslug = function redirectMeToUserslug(req, res, next) { var uid = req.uid; async.waterfall([ function (next) { @@ -180,7 +180,7 @@ module.exports = function (middleware) { ], next); }; - middleware.isAdmin = function (req, res, next) { + middleware.isAdmin = function isAdmin(req, res, next) { async.waterfall([ function (next) { user.isAdministrator(req.uid, next);