From f83dd956ebbc239290d93e99e3ae4239cdc7bd49 Mon Sep 17 00:00:00 2001
From: barisusakli <barisusakli@gmail.com>
Date: Fri, 31 Oct 2014 22:27:50 -0400
Subject: [PATCH] check if post exists on up/down vote favourite

---
 src/socket.io/posts.js | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/src/socket.io/posts.js b/src/socket.io/posts.js
index e08e52808c..0cb493cd80 100644
--- a/src/socket.io/posts.js
+++ b/src/socket.io/posts.js
@@ -96,7 +96,14 @@ SocketPosts.unfavourite = function(socket, data, callback) {
 };
 
 function favouriteCommand(command, eventName, socket, data, callback) {
-	if(data && data.pid && data.room_id) {
+	if(!data || !data.pid || !data.room_id) {
+		return;
+	}
+	posts.exists(data.pid, function(err, exists) {
+		if (err || !exists) {
+			return callback(err);
+		}
+
 		favourites[command](data.pid, socket.uid, function(err, result) {
 			if (err) {
 				return callback(err);
@@ -109,7 +116,7 @@ function favouriteCommand(command, eventName, socket, data, callback) {
 			}
 			callback();
 		});
-	}
+	});
 }
 
 SocketPosts.sendNotificationToPostOwner = function(pid, fromuid, notification) {
@@ -121,7 +128,7 @@ SocketPosts.sendNotificationToPostOwner = function(pid, fromuid, notification) {
 			return;
 		}
 
-		if (fromuid === parseInt(postData.uid, 10)) {
+		if (!postData.uid || fromuid === parseInt(postData.uid, 10)) {
 			return;
 		}