From 9b7f8076ebd782da0a3611c8fc40f9bf6d5597b9 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sat, 28 Sep 2013 16:18:55 -0400
Subject: [PATCH 01/16] removed console.log

---
 public/src/forum/topic.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js
index 246d25a409..159fb970bc 100644
--- a/public/src/forum/topic.js
+++ b/public/src/forum/topic.js
@@ -234,7 +234,6 @@
 
 			if ($(window).scrollTop() > bottom && !app.infiniteLoaderActive && $('#post-container').children().length) {
 				app.loadMorePosts(tid);
-				console.log('window scrolling');
 			}
 		});
 	}

From 4cea3130605fd69c1a9c6bbdfa022c09b6c4fc6e Mon Sep 17 00:00:00 2001
From: Julian Lam <julian.lam@gmail.com>
Date: Sat, 28 Sep 2013 17:44:18 -0400
Subject: [PATCH 02/16] updated getPostsByPids method to resolve premature
 return issue, and refactored it to use async.map instead of eachSeries

---
 src/posts.js | 63 ++++++++++------------------------------------------
 1 file changed, 12 insertions(+), 51 deletions(-)

diff --git a/src/posts.js b/src/posts.js
index d3a804acf6..29989fb8e2 100644
--- a/src/posts.js
+++ b/src/posts.js
@@ -19,7 +19,6 @@ var RDB = require('./redis.js'),
 
 	Posts.getPostsByTid = function(tid, start, end, callback) {
 		RDB.lrange('tid:' + tid + ':posts', start, end, function(err, pids) {
-
 			RDB.handle(err);
 
 			if (pids.length) {
@@ -154,28 +153,23 @@ var RDB = require('./redis.js'),
 		RDB.hset('post:' + pid, field, value);
 	}
 
-
-
-
-	/* getPostsByPids using redis's multi pipeline */
 	Posts.getPostsByPids = function(pids, callback) {
-		var posts = []
-		var multi = RDB.multi();
+		var posts = [],
+			multi = RDB.multi();
 
-		for (v in pids) {
-			var _pid = pids[v]
-			multi.hgetall("post:"+_pid);
+		for(var x=0,numPids=pids.length;x<numPids;x++) {
+			multi.hgetall("post:"+pids[x]);
 		}
 
 		multi.exec(function (err, replies) {
-			async.eachSeries(replies, function(postData, _callback) {
-				if(postData) {
+			async.map(replies, function(postData, _callback) {
+				if (postData) {
 					postData.relativeTime = new Date(parseInt(postData.timestamp,10)).toISOString();
 					postData.post_rep = postData.reputation;
 					postData['edited-class'] = postData.editor !== '' ? '' : 'none';
 					postData['relativeEditTime'] = postData.edited !== '0' ? (new Date(parseInt(postData.edited,10)).toISOString()) : '';
 
-					if(postData.uploadedImages) {
+					if (postData.uploadedImages) {
 						try {
 							postData.uploadedImages = JSON.parse(postData.uploadedImages);
 						} catch(err) {
@@ -188,15 +182,13 @@ var RDB = require('./redis.js'),
 
                     postTools.parse(postData.content, function(err, content) {
                         postData.content = content;
-                        posts.push(postData);
+						_callback(null, postData);
                     });
-					return _callback(null)
-				}
-				else {
-					return _callback(null)
+				} else {
+					_callback(null);
 				}
-			}, function(err) {
-				if(!err) {
+			}, function(err, posts) {
+				if (!err) {
 					return callback(null, posts);
 				} else {
 					return callback(err, null);
@@ -205,37 +197,6 @@ var RDB = require('./redis.js'),
 		})
 	}
 
-
-
-
-
-	Posts.getPostsByPids_original = function(pids, callback) {
-		var posts = [];
-
-		async.eachSeries(pids, function(pid, callback) {
-			Posts.getPostData(pid, function(postData) {
-				if (postData) {
-					postData.relativeTime = new Date(parseInt(postData.timestamp,10)).toISOString();
-					postData.post_rep = postData.reputation;
-					postData['edited-class'] = postData.editor !== '' ? '' : 'none';
-					postData['relativeEditTime'] = postData.edited !== '0' ? (new Date(parseInt(postData.edited,10)).toISOString()) : '';
-
-					postTools.parse(postData.content, function(err, content) {
-						postData.content = content;
-						posts.push(postData);
-						callback(null);
-					});
-				}
-			});
-		}, function(err) {
-			if (!err) {
-				callback(null, posts);
-			} else {
-				callback(err, null);
-			}
-		});
-	}
-
 	Posts.get_cid_by_pid = function(pid, callback) {
 		Posts.getPostField(pid, 'tid', function(tid) {
 			if (tid) {

From 1160f39cb0fcd8e05508a9dedc65142c8fc1cf74 Mon Sep 17 00:00:00 2001
From: Julian Lam <julian.lam@gmail.com>
Date: Sat, 28 Sep 2013 22:05:10 -0400
Subject: [PATCH 03/16] revamped reconnection notification, closes #354

---
 public/language/en/footer.json    |  3 --
 public/src/app.js                 | 47 +++++++------------------------
 public/templates/footer.tpl       | 16 -----------
 public/templates/header.tpl       |  4 +++
 public/themes/vanilla/header.less | 16 +++++++++++
 5 files changed, 30 insertions(+), 56 deletions(-)

diff --git a/public/language/en/footer.json b/public/language/en/footer.json
index 2655ac2795..91cb43fb42 100644
--- a/public/language/en/footer.json
+++ b/public/language/en/footer.json
@@ -1,7 +1,4 @@
 {
-	"disconnect.title": "Socket Disconnect",
-	"disconnect.message": "Looks like you disconnected, try reloading the page.",
-	"disconnect.reload_button": "Reload",
 	"chat.chatting_with": "Chat with <span id='chat-with-name'></span>",
 	"chat.placeholder": "type chat message, here press enter to send",
 	"chat.send": "Send",
diff --git a/public/src/app.js b/public/src/app.js
index c3376caf65..e0acf14152 100644
--- a/public/src/app.js
+++ b/public/src/app.js
@@ -23,8 +23,8 @@ var socket,
 				} else {
 					socket = io.connect(config.socket.address);
 
-					var reconnecting = false;
-					var reconnectTries = 0;
+					var reconnecting = false,
+						reconnectEl, reconnectTimer;
 
 					socket.on('event:connect', function (data) {
 						app.username = data.username;
@@ -40,17 +40,12 @@ var socket,
 
 					socket.on('connect', function (data) {
 						if (reconnecting) {
-							setTimeout(function () {
-								app.alert({
-									alert_id: 'connection_alert',
-									title: 'Connected',
-									message: 'Connection successful.',
-									type: 'success',
-									timeout: 5000
-								});
-							}, 1000);
+							reconnectEl.html('<i class="icon-ok"></i> Connected!');
 							reconnecting = false;
-							reconnectTries = 0;
+
+							setTimeout(function() {
+								reconnectEl.removeClass('active');
+							}, 3000);
 						}
 
 						socket.emit('api:updateHeader', {
@@ -63,33 +58,11 @@ var socket,
 					});
 
 					socket.on('reconnecting', function (data) {
-						function showDisconnectModal() {
-							$('#disconnect-modal').modal({
-								backdrop: 'static',
-								show: true
-							});
-
-							$('#reload-button').on('click', function () {
-								$('#disconnect-modal').modal('hide');
-								window.location.reload();
-							});
-						}
-
+						if (!reconnectEl) reconnectEl = $('#reconnect');
 						reconnecting = true;
-						reconnectTries++;
 
-						if (reconnectTries > 4) {
-							showDisconnectModal();
-							return;
-						}
-
-						app.alert({
-							alert_id: 'connection_alert',
-							title: 'Reconnecting',
-							message: 'You have disconnected from NodeBB, we will try to reconnect you. <br/><i class="icon-refresh icon-spin"></i>',
-							type: 'warning',
-							timeout: 5000
-						});
+						reconnectEl.addClass('active');
+						reconnectEl.html('<i class="icon-spinner icon-spin"></i> Reconnecting...');
 					});
 
 					socket.on('api:user.get_online_users', function (users) {
diff --git a/public/templates/footer.tpl b/public/templates/footer.tpl
index ea47c97d86..38b4614a79 100644
--- a/public/templates/footer.tpl
+++ b/public/templates/footer.tpl
@@ -2,22 +2,6 @@
 
 	</div><!--END container -->
 
-	<div id="disconnect-modal" class="modal fade" tabindex="-1" role="dialog" aria-labelledby="You were disconnected" aria-hidden="true">
-		<div class="modal-dialog">
-			<div class="modal-content">
-				<div class="modal-header">
-					<h3 id="myModalLabel">[[footer:disconnect.title]]</h3>
-				</div>
-				<div class="modal-body">
-					<span id="disconnect-text">[[footer:disconnect.message]]</span>
-				</div>
-				<div class="modal-footer">
-					<a id="reload-button" href="/" class="btn btn-primary">[[footer:disconnect.reload_button]]</a>
-				</div>
-			</div><!-- /.modal-content -->
-		</div><!-- /.modal-dialog -->
-	</div><!-- /.modal -->
-
 	<div id="chat-modal" class="modal" tabindex="-1" role="dialog" aria-labelledby="Chat" aria-hidden="true">
 		<div class="modal-dialog">
 			<div class="modal-content">
diff --git a/public/templates/header.tpl b/public/templates/header.tpl
index f77c9cb0e0..c151a5bd58 100644
--- a/public/templates/header.tpl
+++ b/public/templates/header.tpl
@@ -69,6 +69,10 @@
 				</form>
 
 				<ul id="logged-in-menu" class="nav navbar-nav navbar-right hide">
+					<li>
+						<a href="#" id="reconnect"></a>
+					</li>
+
 					<li id="notifications-list" class="notifications dropdown text-center hidden-xs">
 						<a class="dropdown-toggle" data-toggle="dropdown" href="#" id="notif_dropdown"><i class="icon-circle-blank"></i></a>
 						<ul id="notif-list" class="dropdown-menu" aria-labelledby="notif_dropdown">
diff --git a/public/themes/vanilla/header.less b/public/themes/vanilla/header.less
index ae5ac387f3..0ca6f4d590 100644
--- a/public/themes/vanilla/header.less
+++ b/public/themes/vanilla/header.less
@@ -65,3 +65,19 @@
 		overflow: hidden;
 	}
 }
+
+#reconnect {
+	font-size: 14px;
+	-webkit-transition: opacity 250ms linear;
+	-moz-transition: opacity 250ms linear;
+	-ms-transition: opacity 250ms linear;
+	-o-transition: opacity 250ms linear;
+	transition: opacity 250ms linear;
+	-moz-opacity: 0.00;
+	opacity: 0.00;
+
+	&.active {
+		-moz-opacity: 1;
+		opacity: 1;
+	}
+}
\ No newline at end of file

From f08067bab266cee48adf2cb1a9386c95c0939317 Mon Sep 17 00:00:00 2001
From: Julian Lam <julian.lam@gmail.com>
Date: Sun, 29 Sep 2013 13:47:27 -0400
Subject: [PATCH 04/16] fixes #356 - issue where accessing a NodeBB using a
 different machine name from one that it was set up with causing template data
 to not load, as it was being accessed via absolute url, instead of relative
 url

---
 public/src/ajaxify.js                         |  4 ++--
 public/src/app.js                             |  6 +-----
 public/src/templates.js                       | 14 ++++----------
 public/templates/admin/testing/categories.tpl |  2 +-
 4 files changed, 8 insertions(+), 18 deletions(-)

diff --git a/public/src/ajaxify.js b/public/src/ajaxify.js
index 95619b4ffb..497823e3c7 100644
--- a/public/src/ajaxify.js
+++ b/public/src/ajaxify.js
@@ -38,8 +38,8 @@ var ajaxify = {};
 		window.onscroll = null;
 		// end
 
-
-		var url = url.replace(/\/$/, "");
+		// Remove trailing slash
+		url = url.replace(/\/$/, "");
 
 		var hash = window.location.hash;
 
diff --git a/public/src/app.js b/public/src/app.js
index e0acf14152..5b9918afed 100644
--- a/public/src/app.js
+++ b/public/src/app.js
@@ -1,8 +1,6 @@
 var socket,
 	config,
-	app = {},
-	API_URL = null;
-
+	app = {};
 
 (function () {
 	var showWelcomeMessage = false;
@@ -12,8 +10,6 @@ var socket,
 		$.ajax({
 			url: RELATIVE_PATH + '/api/config',
 			success: function (data) {
-				API_URL = data.api_url;
-
 				config = data;
 				if(socket) {
 					socket.disconnect();
diff --git a/public/src/templates.js b/public/src/templates.js
index 25ed9a5d94..2e4faffc21 100644
--- a/public/src/templates.js
+++ b/public/src/templates.js
@@ -114,13 +114,9 @@
 
 	templates.load_template = function (callback, url, template) {
 		var location = document.location || window.location,
-			rootUrl = location.protocol + '//' + (location.hostname || location.host) + (location.port ? ':' + location.port : '');
-
-		var api_url = (url === '' || url === '/') ? 'home' : url;
-
-		var tpl_url = templates.get_custom_map(api_url.split('?')[0]);
-
-		var trimmed = api_url;
+			api_url = (url === '' || url === '/') ? 'home' : url,
+			tpl_url = templates.get_custom_map(api_url.split('?')[0]),
+			trimmed = api_url;
 
 		if (!tpl_url) {
 			tpl_url = templates.getTemplateNameFromUrl(api_url);
@@ -128,7 +124,6 @@
 
 		var template_data = null;
 
-
 		(function () {
 			var timestamp = new Date().getTime(); //debug
 
@@ -155,8 +150,7 @@
 		}());
 
 		(function () {
-
-			jQuery.get(API_URL + api_url, function (data) {
+			jQuery.get(RELATIVE_PATH + '/api/' + api_url, function (data) {
 
 				if (!data) {
 					ajaxify.go('404');
diff --git a/public/templates/admin/testing/categories.tpl b/public/templates/admin/testing/categories.tpl
index 5bab8d5857..1b2709d1fb 100644
--- a/public/templates/admin/testing/categories.tpl
+++ b/public/templates/admin/testing/categories.tpl
@@ -10,7 +10,7 @@ jQuery(document).ready(function () {
 	QUnit.init();
 	asyncTest( "Loading Categories", function() {
 		
-		jQuery.get(config.api_url + 'home', function(data) {
+		jQuery.get(RELATIVE_PATH + '/api/home', function(data) {
 			ok( data.categories.length > 0, JSON.stringify(data.categories) );
 			
 			start();

From 9de5214a2fd6090b5f766cf64f1717d0d69f6d12 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sun, 29 Sep 2013 14:18:43 -0400
Subject: [PATCH 05/16] closes #353

---
 public/src/forum/admin/footer.js | 2 +-
 src/meta.js                      | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/public/src/forum/admin/footer.js b/public/src/forum/admin/footer.js
index 9d1d3acd44..ee9062af9d 100644
--- a/public/src/forum/admin/footer.js
+++ b/public/src/forum/admin/footer.js
@@ -102,7 +102,7 @@ var nodebb_admin = (function(nodebb_admin) {
 				alert_id: 'config_status',
 				timeout: 2500,
 				title: 'Changes Saved',
-				message: 'Your changes to the NodeBB configuration have been saved. You may have to restart NodeBB to see the changes.',
+				message: 'Your changes to the NodeBB configuration have been saved.',
 				type: 'success'
 			});
 		} else {
diff --git a/src/meta.js b/src/meta.js
index 97cfe65789..f641e034af 100644
--- a/src/meta.js
+++ b/src/meta.js
@@ -39,6 +39,8 @@ var utils = require('./../public/src/utils.js'),
 		set: function (field, value, callback) {
 			RDB.hset('config', field, value, function (err, res) {
 				if (callback) {
+					if(!err)
+						Meta.config[field] = value;
 					callback(err, res);
 				}
 			});

From 83b4b5434fe1926b86e7d43f4a2d215cb99d790f Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sun, 29 Sep 2013 14:27:31 -0400
Subject: [PATCH 06/16] fixed username button title

---
 public/language/en/topic.json | 1 +
 public/templates/topic.tpl    | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/public/language/en/topic.json b/public/language/en/topic.json
index a00c1e6f60..d7a4581ad6 100644
--- a/public/language/en/topic.json
+++ b/public/language/en/topic.json
@@ -1,5 +1,6 @@
 {
 	"profile": "Profile",
+	"posted_by": "Posted by",
 	"chat": "Chat",
 	"notify_me": "Be notified of new replies in this topic",
 	"favourite": "Favourite",
diff --git a/public/templates/topic.tpl b/public/templates/topic.tpl
index e1a13d95e6..a568e61cc0 100644
--- a/public/templates/topic.tpl
+++ b/public/templates/topic.tpl
@@ -27,7 +27,7 @@
 
 						<div class="topic-buttons">
 							<div class="btn-group">
-								<button class="btn btn-sm btn-default dropdown-toggle" data-toggle="dropdown" type="button" title="[[topic:posted_by, {main_posts.username}]]">
+								<button class="btn btn-sm btn-default dropdown-toggle" data-toggle="dropdown" type="button" title="[[topic:posted_by]] {main_posts.username}">
 									<span class="username-field" href="/user/{main_posts.userslug}">{main_posts.username}&nbsp;</span>
 									<span class="caret"></span>
 								</button>

From 06f59cf853e01905654be89af2a17e9ed4ffdf1d Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sun, 29 Sep 2013 15:08:00 -0400
Subject: [PATCH 07/16] closes #310

---
 src/routes/api.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/routes/api.js b/src/routes/api.js
index 34135bbcf9..40b19aec91 100644
--- a/src/routes/api.js
+++ b/src/routes/api.js
@@ -123,7 +123,7 @@ var user = require('./../user.js'),
 			app.get('/category/:id/:slug?', function (req, res, next) {
 				var uid = (req.user) ? req.user.uid : 0;
 				categories.getCategoryById(req.params.id, uid, function (err, data) {
-					if (!err)
+					if (!err && data && data.disabled === "0")
 						res.json(data);
 					else
 						next();

From c58cb257dc8b5e3a80ce924561ad276a4af358af Mon Sep 17 00:00:00 2001
From: Julian Lam <julian.lam@gmail.com>
Date: Sun, 29 Sep 2013 20:27:52 -0400
Subject: [PATCH 08/16] closes #349 - loading middlewares using async instead
 of crazy middleware-stack modifying shenanigans

---
 src/plugins.js   |   5 +-
 src/webserver.js | 194 ++++++++++++++++++++++++-----------------------
 2 files changed, 101 insertions(+), 98 deletions(-)

diff --git a/src/plugins.js b/src/plugins.js
index c8e77de3f7..2f129d5094 100644
--- a/src/plugins.js
+++ b/src/plugins.js
@@ -26,7 +26,6 @@ var fs = require('fs'),
 				function(plugins, next) {
 					if (plugins && Array.isArray(plugins) && plugins.length > 0) {
 						async.each(plugins, function(plugin, next) {
-							// TODO: Update this check to also check node_modules
 							var pluginPath = path.join(__dirname, '../plugins/', plugin),
 								modulePath = path.join(__dirname, '../node_modules/', plugin);
 							if (fs.existsSync(pluginPath)) _self.loadPlugin(pluginPath, next);
@@ -57,11 +56,13 @@ var fs = require('fs'),
 
 				if (global.env === 'development') winston.info('[plugins] Plugins OK');
 
+				_self.initialized = true;
 				_self.readyEvent.emit('ready');
 			});
 		},
 		ready: function(callback) {
-			this.readyEvent.once('ready', callback);
+			if (!this.initialized) this.readyEvent.once('ready', callback);
+			else callback();
 		},
 		initialized: false,
 		loadPlugin: function(pluginPath, callback) {
diff --git a/src/webserver.js b/src/webserver.js
index b9116e7906..a9b7488f90 100644
--- a/src/webserver.js
+++ b/src/webserver.js
@@ -22,7 +22,8 @@ var express = require('express'),
 	meta = require('./meta.js'),
 	feed = require('./feed'),
 	plugins = require('./plugins'),
-	nconf = require('nconf');
+	nconf = require('nconf'),
+	winston = require('winston');
 
 (function (app) {
 	var templates = null,
@@ -72,54 +73,104 @@ var express = require('express'),
 	};
 
 	// Middlewares
-	app.use(express.compress());
-	app.use(express.favicon(path.join(__dirname, '../', 'public', 'favicon.ico')));
-	app.use(require('less-middleware')({
-		src: path.join(__dirname, '../', 'public'),
-		prefix: nconf.get('relative_path'),
-		yuicompress: true
-	}));
-	app.use(nconf.get('relative_path'), express.static(path.join(__dirname, '../', 'public')));
-	app.use(express.bodyParser()); // Puts POST vars in request.body
-
-	app.use(express.cookieParser()); // If you want to parse cookies (res.cookies)
-	app.use(express.session({
-		store: new RedisStore({
-			client: RDB,
-			ttl: 60 * 60 * 24 * 30
-		}),
-		secret: nconf.get('secret'),
-		key: 'express.sid',
-		cookie: {
-			maxAge: 60 * 60 * 24 * 30 * 1000 // 30 days
-		}
-	}));
-	app.use(express.csrf());
-	app.use(function (req, res, next) {
-		res.locals.csrf_token = req.session._csrf;
-		next();
-	});
+	app.configure(function() {
+		async.series([
+			function(next) {
+				// Pre-router middlewares
+				app.use(express.compress());
+				app.use(express.favicon(path.join(__dirname, '../', 'public', 'favicon.ico')));
+				app.use(require('less-middleware')({
+					src: path.join(__dirname, '../', 'public'),
+					prefix: nconf.get('relative_path'),
+					yuicompress: true
+				}));
+				app.use(nconf.get('relative_path'), express.static(path.join(__dirname, '../', 'public')));
+				app.use(express.bodyParser()); // Puts POST vars in request.body
+				app.use(express.cookieParser()); // If you want to parse cookies (res.cookies)
+				app.use(express.session({
+					store: new RedisStore({
+						client: RDB,
+						ttl: 60 * 60 * 24 * 30
+					}),
+					secret: nconf.get('secret'),
+					key: 'express.sid',
+					cookie: {
+						maxAge: 60 * 60 * 24 * 30 * 1000 // 30 days
+					}
+				}));
+				app.use(express.csrf());
+
+				// Local vars, other assorted setup
+				app.use(function (req, res, next) {
+					nconf.set('https', req.secure);
+					res.locals.csrf_token = req.session._csrf;
+					next();
+				});
 
-	// Static Directories for NodeBB Plugins
-	app.configure(function () {
-		var tailMiddlewares = [];
-
-		plugins.ready(function () {
-			// Remove some middlewares until the router is gone
-			// This is not recommended behaviour: http://stackoverflow.com/a/13691542/122353
-			// Also: https://www.exratione.com/2013/03/nodejs-abusing-express-3-to-enable-late-addition-of-middleware/
-			tailMiddlewares.push(app.stack.pop());
-			tailMiddlewares.push(app.stack.pop());
-			tailMiddlewares.push(app.stack.pop());
-			for (d in plugins.staticDirs) {
-				app.use(nconf.get('relative_path') + '/plugins/' + d, express.static(plugins.staticDirs[d]));
-			}
+				// Authentication Routes
+				auth.initialize(app);
+
+				next();
+			},
+			function(next) {
+				// Static Directories for NodeBB Plugins
+				plugins.ready(function () {
+					for (d in plugins.staticDirs) {
+						app.use(nconf.get('relative_path') + '/plugins/' + d, express.static(plugins.staticDirs[d]));
+						winston.info('Static directory routed for plugin: ' + d);
+					}
+
+					next();
+				});
+			},
+			function(next) {
+				// Router & post-router middlewares
+				app.use(app.router);
+
+				// 404 catch-all
+				app.use(function (req, res, next) {
+					res.status(404);
+
+					// respond with html page
+					if (req.accepts('html')) {
+						res.redirect(nconf.get('relative_path') + '/404');
+						return;
+					}
+
+					// respond with json
+					if (req.accepts('json')) {
+						res.send({
+							error: 'Not found'
+						});
+						return;
+					}
 
-			// Push the removed middlewares back onto the application stack
-			tailMiddlewares.reverse();
-			app.stack.push(tailMiddlewares.shift());
-			app.stack.push(tailMiddlewares.shift());
-			app.stack.push(tailMiddlewares.shift());
+					// default to plain-text. send()
+					res.type('txt').send('Not found');
+				});
+
+				app.use(function (err, req, res, next) {
+
+					// we may use properties of the error object
+					// here and next(err) appropriately, or if
+					// we possibly recovered from the error, simply next().
+					console.error(err.stack);
+
+					res.status(err.status || 500);
+
+					res.json('500', {
+						error: err.message
+					});
+				});
+
+				next();
+			}
+		], function(err) {
+			if (err) {
+				winston.error('Errors were encountered while attempting to initialise NodeBB.');
+			} else {
+				winston.info('Middlewares loaded.');
+			}
 		});
 	});
 
@@ -137,59 +188,10 @@ var express = require('express'),
 		server.listen(nconf.get('PORT') || nconf.get('port'));
 	}
 
-	auth.initialize(app);
-
-	app.use(function (req, res, next) {
-
-		nconf.set('https', req.secure);
-
-		next();
-	});
-
-	app.use(app.router);
-
-	app.use(function (req, res, next) {
-		res.status(404);
-
-		// respond with html page
-		if (req.accepts('html')) {
-			//res.json('404', { url: req.url });
-			res.redirect(nconf.get('relative_path') + '/404');
-			return;
-		}
-
-		// respond with json
-		if (req.accepts('json')) {
-			res.send({
-				error: 'Not found'
-			});
-			return;
-		}
-
-		// default to plain-text. send()
-		res.type('txt').send('Not found');
-	});
-
-	app.use(function (err, req, res, next) {
-
-		// we may use properties of the error object
-		// here and next(err) appropriately, or if
-		// we possibly recovered from the error, simply next().
-		console.error(err.stack);
-
-		res.status(err.status || 500);
-
-		res.json('500', {
-			error: err.message
-		});
-	});
-
-
 	app.create_route = function (url, tpl) { // to remove
 		return '<script>templates.ready(function(){ajaxify.go("' + url + '", null, "' + tpl + '");});</script>';
 	};
 
-
 	app.namespace(nconf.get('relative_path'), function () {
 
 		auth.create_routes(app);

From 7bf5b2ec573a6eb2c51538805f8a9d3cdf134ac0 Mon Sep 17 00:00:00 2001
From: Julian Lam <julian.lam@gmail.com>
Date: Sun, 29 Sep 2013 20:33:35 -0400
Subject: [PATCH 09/16] changed fireHook to be error-first, closes #319

---
 src/plugins.js   |  4 ++--
 src/postTools.js |  8 ++++----
 src/posts.js     | 13 +++++++++----
 3 files changed, 15 insertions(+), 10 deletions(-)

diff --git a/src/plugins.js b/src/plugins.js
index 2f129d5094..645c90952f 100644
--- a/src/plugins.js
+++ b/src/plugins.js
@@ -162,7 +162,7 @@ var fs = require('fs'),
 								}
 							}
 
-							callback(returnVal);
+							callback(err, returnVal);
 						});
 						break;
 					case 'action':
@@ -185,7 +185,7 @@ var fs = require('fs'),
 			} else {
 				// Otherwise, this hook contains no methods
 				var returnVal = (Array.isArray(args) ? args[0] : args);
-				if (callback) callback(returnVal);
+				if (callback) callback(err, returnVal);
 			}
 		},
 		isActive: function(id, callback) {
diff --git a/src/postTools.js b/src/postTools.js
index 8913a1e787..8f41608391 100644
--- a/src/postTools.js
+++ b/src/postTools.js
@@ -102,8 +102,8 @@ var RDB = require('./redis.js'),
 
 		PostTools.privileges(pid, uid, function(privileges) {
 			if (privileges.editable) {
-				plugins.fireHook('filter:post.save', content, function(parsedContent) {
-					content = parsedContent;
+				plugins.fireHook('filter:post.save', content, function(err, parsedContent) {
+					if (!err) content = parsedContent;
 					success();
 				});
 			}
@@ -193,8 +193,8 @@ var RDB = require('./redis.js'),
 	PostTools.parse = function(raw, callback) {
 		raw = raw || '';
 
-		plugins.fireHook('filter:post.parse', raw, function(parsed) {
-			callback(null, parsed);
+		plugins.fireHook('filter:post.parse', raw, function(err, parsed) {
+			callback(null, !err ? parsed : raw);
 		});
 	}
 
diff --git a/src/posts.js b/src/posts.js
index 29989fb8e2..957d2790b9 100644
--- a/src/posts.js
+++ b/src/posts.js
@@ -122,8 +122,9 @@ var RDB = require('./redis.js'),
 	Posts.getPostData = function(pid, callback) {
 		RDB.hgetall('post:' + pid, function(err, data) {
 			if (err === null) {
-				plugins.fireHook('filter:post.get', data, function(data) {
-					callback(data);
+				plugins.fireHook('filter:post.get', data, function(err, newData) {
+					if (!err) callback(newData);
+					else callback(data);
 				});
 			} else
 				console.log(err);
@@ -287,7 +288,9 @@ var RDB = require('./redis.js'),
 				RDB.incr('global:next_post_id', function(err, pid) {
 					RDB.handle(err);
 
-					plugins.fireHook('filter:post.save', content, function(content) {
+					plugins.fireHook('filter:post.save', content, function(err, newContent) {
+						if (!err) content = newContent;
+
 						var timestamp = Date.now(),
 							postData = {
 								'pid': pid,
@@ -337,7 +340,9 @@ var RDB = require('./redis.js'),
 
 						async.parallel({
 							content: function(next) {
-								plugins.fireHook('filter:post.get', postData, function(postData) {
+								plugins.fireHook('filter:post.get', postData, function(err, newPostData) {
+									if (!err) postData = newPostData;
+
 									postTools.parse(postData.content, function(err, content) {
 										next(null, content);
 									});

From 8dd8536f6ba3e526cc1e465bc4eb436b3c2ad6da Mon Sep 17 00:00:00 2001
From: Julian Lam <julian.lam@gmail.com>
Date: Sun, 29 Sep 2013 20:38:45 -0400
Subject: [PATCH 10/16] closes #317 - hitting discard on a post with content
 will now throw a bootbox confirmation modal

---
 public/src/modules/composer.js | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/public/src/modules/composer.js b/public/src/modules/composer.js
index 8326ec0245..924cf94fec 100644
--- a/public/src/modules/composer.js
+++ b/public/src/modules/composer.js
@@ -187,7 +187,15 @@ define(['taskbar'], function(taskbar) {
 				switch(action) {
 					case 'post': composer.post(uuid); break;
 					case 'minimize': composer.minimize(uuid); break;
-					case 'discard': composer.discard(uuid); break;
+					case 'discard':
+						if (postContentEl.value.length > 0) {
+							bootbox.confirm('Are you sure you wish to discard this post?', function(discard) {
+								if (discard) composer.discard(uuid);
+							});
+						} else {
+							composer.discard(uuid);
+						}
+						break;
 				}
 			});
 

From ad28b9b33971cd1d49b60699b4130d4829980e5a Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sun, 29 Sep 2013 21:03:16 -0400
Subject: [PATCH 11/16] fixed crash in meta

---
 src/meta.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/meta.js b/src/meta.js
index f641e034af..1b47d1900a 100644
--- a/src/meta.js
+++ b/src/meta.js
@@ -39,7 +39,7 @@ var utils = require('./../public/src/utils.js'),
 		set: function (field, value, callback) {
 			RDB.hset('config', field, value, function (err, res) {
 				if (callback) {
-					if(!err)
+					if(!err && Meta.config)
 						Meta.config[field] = value;
 					callback(err, res);
 				}

From 2dcc4172c4faebf5172088a1db23219b227d9f8a Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sun, 29 Sep 2013 21:29:43 -0400
Subject: [PATCH 12/16] closes #357

---
 public/src/forum/admin/users.js | 17 -----------------
 src/admin/user.js               | 21 ---------------------
 src/upgrade.js                  |  2 +-
 src/user.js                     | 28 ----------------------------
 4 files changed, 1 insertion(+), 67 deletions(-)

diff --git a/public/src/forum/admin/users.js b/public/src/forum/admin/users.js
index a83d424964..289adafa3c 100644
--- a/public/src/forum/admin/users.js
+++ b/public/src/forum/admin/users.js
@@ -83,23 +83,6 @@
 			return false;
 		});
 
-		$('#users-container').on('click', '.delete-btn', function() {
-			var deleteBtn = $(this);
-			var isAdmin = isUserAdmin(deleteBtn);
-			var parent = deleteBtn.parents('.users-box');
-			var uid = getUID(deleteBtn);
-
-			if (!isAdmin) {
-				bootbox.confirm('Do you really want to delete "' + parent.attr('data-username') + '"?', function(confirm) {
-					if (confirm) {
-						socket.emit('api:admin.user.deleteUser', uid);
-					}
-				});
-			}
-
-			return false;
-		});
-
 		$('#users-container').on('click', '.ban-btn', function() {
 			var banBtn = $(this);
 			var isAdmin = isUserAdmin(banBtn);
diff --git a/src/admin/user.js b/src/admin/user.js
index 8933018828..df12b04937 100644
--- a/src/admin/user.js
+++ b/src/admin/user.js
@@ -11,8 +11,6 @@ var RDB = require('../redis'),
 				Groups.getGidFromName('Administrators', function(err, gid) {
 					Groups.join(gid, theirid, function(err) {
 						if (!err) {
-							user.setUserField(theirid, 'administrator', 1);
-
 							socket.emit('event:alert', {
 								title: 'User Modified',
 								message: 'This user is now an administrator!',
@@ -39,7 +37,6 @@ var RDB = require('../redis'),
 				Groups.getGidFromName('Administrators', function(err, gid) {
 					Groups.leave(gid, theirid, function(err) {
 						if (!err) {
-							user.setUserField(theirid, 'administrator', 0);
 
 							socket.emit('event:alert', {
 								title: 'User Modified',
@@ -54,24 +51,6 @@ var RDB = require('../redis'),
 		});
 	};
 
-	UserAdmin.deleteUser = function(uid, theirid, socket) {
-		user.isAdministrator(uid, function(amIAdmin) {
-			user.isAdministrator(theirid, function(areTheyAdmin) {
-				if (amIAdmin && !areTheyAdmin) {
-					user.delete(theirid, function(data) {
-
-						socket.emit('event:alert', {
-							title: 'User Deleted',
-							message: 'This user is deleted!',
-							type: 'success',
-							timeout: 2000
-						});
-					});
-				}
-			});
-		});
-	};
-
 	UserAdmin.banUser = function(uid, theirid, socket) {
 		user.isAdministrator(uid, function(amIAdmin) {
 			user.isAdministrator(theirid, function(areTheyAdmin) {
diff --git a/src/upgrade.js b/src/upgrade.js
index 84b777f567..36dfb076c4 100644
--- a/src/upgrade.js
+++ b/src/upgrade.js
@@ -100,7 +100,7 @@ function upgradeUserHash(uid, callback) {
 function upgradeAdmins(callback) {
 	Groups.getGidFromName('Administrators', function(err, gid) {
 		if (!err && !gid) {
-			winston.info('Upgading Administrators');
+			winston.info('Upgrading Administrators');
 
 			async.parallel([
 				function(next) {
diff --git a/src/user.js b/src/user.js
index 90bddffff4..ecbee2eb76 100644
--- a/src/user.js
+++ b/src/user.js
@@ -72,7 +72,6 @@ var utils = require('./../public/src/utils.js'),
 					'reputation': 0,
 					'postcount': 0,
 					'lastposttime': 0,
-					'administrator': (uid == 1) ? 1 : 0,
 					'banned': 0,
 					'showemail': 0
 				});
@@ -114,33 +113,6 @@ var utils = require('./../public/src/utils.js'),
 		});
 	};
 
-	User.delete = function(uid, callback) {
-		RDB.exists('user:' + uid, function(err, exists) {
-			if (exists === 1) {
-				console.log('deleting uid ' + uid);
-
-				User.getUserData(uid, function(err, data) {
-
-					RDB.hdel('username:uid', data['username']);
-					RDB.hdel('email:uid', data['email']);
-					RDB.hdel('userslug:uid', data['userslug']);
-
-					RDB.del('user:' + uid);
-					RDB.del('followers:' + uid);
-					RDB.del('following:' + uid);
-
-					RDB.zrem('users:joindate', uid);
-					RDB.zrem('users:postcount', uid);
-					RDB.zrem('users:reputation', uid);
-
-					callback(true);
-				});
-			} else {
-				callback(false);
-			}
-		});
-	}
-
 	User.ban = function(uid, callback) {
 		User.setUserField(uid, 'banned', 1, callback);
 	}

From a4c1d733b72558cca6bf7c5a38664d772b9083b8 Mon Sep 17 00:00:00 2001
From: Julian Lam <julian.lam@gmail.com>
Date: Mon, 30 Sep 2013 11:17:12 -0400
Subject: [PATCH 13/16] fixed issue where setOnEmpty would fail in install.js
 as Meta.config was not defined (as it had not been initted yet)

---
 src/meta.js | 29 ++---------------------------
 1 file changed, 2 insertions(+), 27 deletions(-)

diff --git a/src/meta.js b/src/meta.js
index cfc2a1d66d..e7da74e99d 100644
--- a/src/meta.js
+++ b/src/meta.js
@@ -7,6 +7,7 @@ var utils = require('./../public/src/utils.js'),
 	nconf = require('nconf');
 
 (function (Meta) {
+	Meta.config = {};
 
 	Meta.configs = {
 		init: function (callback) {
@@ -162,33 +163,7 @@ var utils = require('./../public/src/utils.js'),
 			'src/ajaxify.js',
 			'src/translator.js',
 			'src/jquery.form.js',
-			'src/utils.js',
-			'src/forum/account.js',
-			'src/forum/accountedit.js',
-			'src/forum/accountheader.js',
-			'src/forum/accountsettings.js',
-			'src/forum/category.js',
-			'src/forum/favourites.js',
-			'src/forum/followers.js',
-			'src/forum/following.js',
-			'src/forum/footer.js',
-			'src/forum/login.js',
-			'src/forum/recent.js',
-			'src/forum/register.js',
-			'src/forum/reset.js',
-			'src/forum/reset_code.js',
-			'src/forum/search.js',
-			'src/forum/topic.js',
-			'src/forum/unread.js',
-			'src/forum/users.js',
-			'src/forum/admin/categories.js',
-			'src/forum/admin/footer.js',
-			'src/forum/admin/groups.js',
-			'src/forum/admin/index.js',
-			'src/forum/admin/plugins.js',
-			'src/forum/admin/themes.js',
-			'src/forum/admin/topics.js',
-			'src/forum/admin/users'
+			'src/utils.js'
 		],
 		minFile: path.join(__dirname, '..', 'public/src/nodebb.min.js'),
 		get: function (callback) {

From 8cbe79655a873f8e3cbeac0253ee1d1499316ddc Mon Sep 17 00:00:00 2001
From: Julian Lam <julian.lam@gmail.com>
Date: Mon, 30 Sep 2013 11:18:02 -0400
Subject: [PATCH 14/16] emptying Meta.config on init (Just to be safe)

---
 src/meta.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/meta.js b/src/meta.js
index e7da74e99d..9a9c0f4c49 100644
--- a/src/meta.js
+++ b/src/meta.js
@@ -11,6 +11,8 @@ var utils = require('./../public/src/utils.js'),
 
 	Meta.configs = {
 		init: function (callback) {
+			delete Meta.config;
+
 			Meta.configs.list(function (err, config) {
 				if (!err) {
 					Meta.config = config;

From 06f2284bcd4047390b93be3f1d952e76942e8538 Mon Sep 17 00:00:00 2001
From: Julian Lam <julian.lam@gmail.com>
Date: Mon, 30 Sep 2013 11:23:11 -0400
Subject: [PATCH 15/16] added output to show bound address on instance start

---
 app.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app.js b/app.js
index 7a6f68dc7a..a081cd4fa3 100644
--- a/app.js
+++ b/app.js
@@ -66,6 +66,7 @@
 		nconf.set('upload_url', nconf.get('url') + 'uploads/');
 
 		winston.info('Initializing NodeBB v' + pkg.version + ', on port ' + nconf.get('port') + ', using Redis store at ' + nconf.get('redis:host') + ':' + nconf.get('redis:port') + '.');
+		winston.info('NodeBB instance bound to: ' + (nconf.get('bind_address') || 'Any address'));
 
 		if (process.env.NODE_ENV === 'development') {
 			winston.info('Base Configuration OK.');

From 9f67282a79497e409cc233fda2e7028ec8382f33 Mon Sep 17 00:00:00 2001
From: Baris Usakli <barisusakli@gmail.com>
Date: Mon, 30 Sep 2013 13:04:03 -0400
Subject: [PATCH 16/16] admin site will display reconnecting notification when
 server is offline closes #346

---
 public/templates/admin/header.tpl | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/public/templates/admin/header.tpl b/public/templates/admin/header.tpl
index 3a2c7b4768..72469a018a 100644
--- a/public/templates/admin/header.tpl
+++ b/public/templates/admin/header.tpl
@@ -58,6 +58,9 @@
 					<li>
 					  <a href="/admin/settings"><i class="icon-cogs"></i> Settings</a>
 					</li>
+					<li>
+						<a href="#" id="reconnect"></a>
+					</li>
 				</ul>
 				<ul class="nav pull-right" id="right-menu">
 					<li><a href="/users" id="user_label"></a></li>