From f38b2a737a6fc8a501f86893c42fd3e800264cc1 Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@nodebb.org>
Date: Wed, 29 Jun 2022 16:19:52 -0400
Subject: [PATCH] fix: improper handling of single vs. multiple inputs for
 hidePrivateData

---
 src/user/data.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/user/data.js b/src/user/data.js
index 09ff2e6d3e..6c46268e81 100644
--- a/src/user/data.js
+++ b/src/user/data.js
@@ -146,8 +146,10 @@ module.exports = function (User) {
 	};
 
 	User.hidePrivateData = async function (users, callerUID) {
+		let single = false;
 		if (!Array.isArray(users)) {
 			users = [users];
+			single = true;
 		}
 
 		const [userSettings, isAdmin, isGlobalModerator] = await Promise.all([
@@ -171,7 +173,7 @@ module.exports = function (User) {
 			return _userData;
 		}));
 
-		return users.length === 1 ? users.pop() : users;
+		return single ? users.pop() : users;
 	};
 
 	async function modifyUserData(users, requestedFields, fieldsToRemove) {