From c13589735d0a49dc70d8ffc742d4ce1f6bf74bb1 Mon Sep 17 00:00:00 2001 From: Mani Wang Date: Mon, 20 Jul 2015 16:57:35 +0800 Subject: [PATCH 1/2] allow use github module avoid `outdated` error when use github address as module. --- src/meta/dependencies.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/meta/dependencies.js b/src/meta/dependencies.js index 3bc9719890..487640ee81 100644 --- a/src/meta/dependencies.js +++ b/src/meta/dependencies.js @@ -23,7 +23,7 @@ module.exports = function(Meta) { var pkgData = JSON.parse(pkgData), ok = semver.satisfies(pkgData.version, pkg.dependencies[module]); - if (ok) { + if (ok || pkgData._fromGithub) { next(true); } else { process.stdout.write('[' + 'outdated'.yellow + '] ' + module.bold + ' v' + pkgData.version + ', requires ' + pkg.dependencies[module] + '\n') @@ -38,4 +38,4 @@ module.exports = function(Meta) { callback(!ok && global.env !== 'development' ? new Error('dependencies-out-of-date') : null); }); }; -}; \ No newline at end of file +}; From 92968dfd8d6db3fa28a409609abbe75ac55ea8b5 Mon Sep 17 00:00:00 2001 From: Mani Wang Date: Wed, 22 Jul 2015 19:49:15 +0800 Subject: [PATCH 2/2] avoid outdated error when use github address as module --- src/meta/dependencies.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/meta/dependencies.js b/src/meta/dependencies.js index 487640ee81..419708381f 100644 --- a/src/meta/dependencies.js +++ b/src/meta/dependencies.js @@ -23,7 +23,7 @@ module.exports = function(Meta) { var pkgData = JSON.parse(pkgData), ok = semver.satisfies(pkgData.version, pkg.dependencies[module]); - if (ok || pkgData._fromGithub) { + if (ok || pkgData._resolved.indexOf('//github.com') != -1) { next(true); } else { process.stdout.write('[' + 'outdated'.yellow + '] ' + module.bold + ' v' + pkgData.version + ', requires ' + pkg.dependencies[module] + '\n')