From ea007e2da4ae1ec39afe8cd2a5b5b818ddb5c732 Mon Sep 17 00:00:00 2001 From: barisusakli Date: Thu, 1 Dec 2016 11:52:35 +0300 Subject: [PATCH] closes #5245 --- src/groups/create.js | 2 +- test/groups.js | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/src/groups/create.js b/src/groups/create.js index 0b38b3ebcc..1d16ea33cf 100644 --- a/src/groups/create.js +++ b/src/groups/create.js @@ -92,7 +92,7 @@ module.exports = function (Groups) { return callback(new Error('[[error:group-name-too-long]]')); } - if (name.indexOf('/') !== -1) { + if (name.indexOf('/') !== -1 || !utils.slugify(name)) { return callback(new Error('[[error:invalid-group-name]]')); } diff --git a/test/groups.js b/test/groups.js index 122645cc2b..35d3c17be6 100644 --- a/test/groups.js +++ b/test/groups.js @@ -184,6 +184,20 @@ describe('Groups', function () { done(); }); }); + + it('should fail to create group if slug is empty', function (done) { + Groups.create({name: '>>>>'}, function (err) { + assert.equal(err.message, '[[error:invalid-group-name]]'); + done(); + }); + }); + + it('should fail if group name is invalid', function (done) { + Groups.create({name: 'not/valid'}, function (err) { + assert.equal(err.message, '[[error:invalid-group-name]]'); + done(); + }); + }); }); describe('.hide()', function () {