From e725beaa4a25ca5b78c83499c11bb7dff2980304 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <barisusakli@gmail.com>
Date: Sat, 13 Mar 2021 11:39:34 -0500
Subject: [PATCH] Revert "feat: allow filter functions that return promises or
 the data directly"

This reverts commit e6c52cf26caa52f8878d7f046143e9e6a50be1a6.
---
 src/plugins/hooks.js | 52 ++++++++++++++++++++++----------------------
 test/plugins.js      | 14 +++++-------
 2 files changed, 32 insertions(+), 34 deletions(-)

diff --git a/src/plugins/hooks.js b/src/plugins/hooks.js
index 1e9464c3ee..95b5aec47a 100644
--- a/src/plugins/hooks.js
+++ b/src/plugins/hooks.js
@@ -1,5 +1,6 @@
 'use strict';
 
+const async = require('async');
 const util = require('util');
 const winston = require('winston');
 const plugins = require('.');
@@ -115,38 +116,37 @@ async function fireFilterHook(hook, hookList, params) {
 	if (!Array.isArray(hookList) || !hookList.length) {
 		return params;
 	}
-
-	async function fireMethod(hookObj, params) {
+	return await async.reduce(hookList, params, (params, hookObj, next) => {
 		if (typeof hookObj.method !== 'function') {
 			if (global.env === 'development') {
 				winston.warn(`[plugins] Expected method for hook '${hook}' in plugin '${hookObj.id}' not found, skipping.`);
 			}
-			return params;
+			return next(null, params);
 		}
-
-		if (hookObj.method.constructor && hookObj.method.constructor.name === 'AsyncFunction') {
-			return await hookObj.method(params);
+		const returned = hookObj.method(params, next);
+		if (utils.isPromise(returned)) {
+			returned.then(
+				payload => setImmediate(next, null, payload),
+				err => setImmediate(next, err)
+			);
 		}
-		return new Promise((resolve, reject) => {
-			const returned = hookObj.method(params, (err, result) => {
-				if (err) reject(err); else resolve(result);
-			});
-
-			if (utils.isPromise(returned)) {
-				returned.then(
-					payload => resolve(payload),
-					err => reject(err)
-				);
-				return;
-			}
-			resolve(returned);
-		});
-	}
-	for (const hookObj of hookList) {
-		// eslint-disable-next-line
-		params = await fireMethod(hookObj, params);
-	}
-	return params;
+	});
+	// breaks plugins that use a non-async function ie emoji-one parse.raw
+	// for (const hookObj of hookList) {
+	// 	if (typeof hookObj.method !== 'function') {
+	// 		if (global.env === 'development') {
+	// 			winston.warn(`[plugins] Expected method for hook '${hook}' in plugin '${hookObj.id}' not found, skipping.`);
+	// 		}
+	// 	} else {
+	// 		let hookFn = hookObj.method;
+	// 		if (hookFn.constructor && hookFn.constructor.name !== 'AsyncFunction') {
+	// 			hookFn = util.promisify(hookFn);
+	// 		}
+	// 		// eslint-disable-next-line
+	// 		params = await hookFn(params);
+	// 	}
+	// }
+	// return params;
 }
 
 async function fireActionHook(hook, hookList, params) {
diff --git a/test/plugins.js b/test/plugins.js
index b7b5575d28..bf4a600ff8 100644
--- a/test/plugins.js
+++ b/test/plugins.js
@@ -47,7 +47,7 @@ describe('Plugins', () => {
 		});
 	});
 
-	it('should register and fire a filter hook having 3 methods, one returning a promise, one calling the callback and one just returning', async () => {
+	it('should register and fire a filter hook having 2 methods, one returning a promise and the other calling the callback', (done) => {
 		function method1(data, callback) {
 			data.foo += 1;
 			callback(null, data);
@@ -58,17 +58,15 @@ describe('Plugins', () => {
 				resolve(data);
 			});
 		}
-		function method3(data) {
-			data.foo += 1;
-			return data;
-		}
 
 		plugins.hooks.register('test-plugin', { hook: 'filter:test.hook2', method: method1 });
 		plugins.hooks.register('test-plugin', { hook: 'filter:test.hook2', method: method2 });
-		plugins.hooks.register('test-plugin', { hook: 'filter:test.hook2', method: method3 });
 
-		const data = await plugins.hooks.fire('filter:test.hook2', { foo: 1 });
-		assert.strictEqual(data.foo, 8);
+		plugins.hooks.fire('filter:test.hook2', { foo: 1 }, (err, data) => {
+			assert.ifError(err);
+			assert.equal(data.foo, 7);
+			done();
+		});
 	});
 
 	it('should register and fire a filter hook that returns a promise that gets rejected', (done) => {