From e6768ab57286749821eec15cb69e39641139577a Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@nodebb.org>
Date: Wed, 14 Dec 2016 10:03:39 -0500
Subject: [PATCH] some more fixes to flags, simplifying qs manipulation in
 flags search

re: #5232
---
 public/language/en-GB/flags.json |  1 +
 public/src/client/flags/list.js  | 14 ++++----------
 src/controllers/mods.js          |  1 -
 3 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/public/language/en-GB/flags.json b/public/language/en-GB/flags.json
index a9272897ca..f1fd71bf27 100644
--- a/public/language/en-GB/flags.json
+++ b/public/language/en-GB/flags.json
@@ -41,6 +41,7 @@
 	"no-history": "No flag history.",
 
 	"state": "State",
+	"state-all": "All states",
 	"state-open": "New/Open",
 	"state-wip": "Work in Progress",
 	"state-resolved": "Resolved",
diff --git a/public/src/client/flags/list.js b/public/src/client/flags/list.js
index 255c7176f1..12cc19093f 100644
--- a/public/src/client/flags/list.js
+++ b/public/src/client/flags/list.js
@@ -20,16 +20,10 @@ define('forum/flags/list', ['components', 'Chart'], function (components, Chart)
 		}
 
 		filtersEl.find('button').on('click', function () {
-			var payload = filtersEl.serializeArray();
-			var qs = payload.map(function (filter) {
-				if (filter.value) {
-					return filter.name + '=' + filter.value;
-				} else {
-					return;
-				}
-			}).filter(Boolean).join('&');
-
-			ajaxify.go('flags?' + qs);
+			var payload = filtersEl.serializeArray().filter(function (item) {
+				return !!item.value;
+			});
+			ajaxify.go('flags?' + $.param(payload));
 		});
 	};
 
diff --git a/src/controllers/mods.js b/src/controllers/mods.js
index 39820e60a6..666f449316 100644
--- a/src/controllers/mods.js
+++ b/src/controllers/mods.js
@@ -5,7 +5,6 @@ var async = require('async');
 var user = require('../user');
 var flags = require('../flags');
 var analytics = require('../analytics');
-// var adminFlagsController = require('./admin/flags');
 
 var modsController = {
 	flags: {}