From e592499d48c3112ec24da3ba2f9876dcf1808ff7 Mon Sep 17 00:00:00 2001
From: barisusakli <barisusakli@gmail.com>
Date: Thu, 30 Jul 2015 15:14:02 -0400
Subject: [PATCH] correctly hide/show user in browsing users

---
 public/src/app.js                   |  4 +++-
 public/src/client/topic/browsing.js | 11 ++++++-----
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/public/src/app.js b/public/src/app.js
index a14a403da5..650a509eda 100644
--- a/public/src/app.js
+++ b/public/src/app.js
@@ -185,7 +185,8 @@ app.cacheBuster = null;
 				enter: room,
 				username: app.user.username,
 				userslug: app.user.userslug,
-				picture: app.user.picture
+				picture: app.user.picture,
+				status: app.user.status
 			}, function(err) {
 				if (err) {
 					app.alertError(err.message);
@@ -454,6 +455,7 @@ app.cacheBuster = null;
 					return app.alertError(err.message);
 				}
 				$('#logged-in-menu #user_label #user-profile-link>i').attr('class', 'fa fa-circle status ' + status);
+				app.user.status = status;
 			});
 			e.preventDefault();
 		});
diff --git a/public/src/client/topic/browsing.js b/public/src/client/topic/browsing.js
index 0bed58f952..9eeb22c9d8 100644
--- a/public/src/client/topic/browsing.js
+++ b/public/src/client/topic/browsing.js
@@ -4,14 +4,14 @@
 
 /* globals define, app, config, socket, ajaxify */
 
-define('forum/topic/browsing', ['translator'], function(translator) {
+define('forum/topic/browsing', function() {
 
 	var Browsing = {};
 
 	Browsing.onUpdateUsersInRoom = function(data) {
 		if (data && data.room.indexOf('topic_' + ajaxify.data.tid) !== -1) {
 			$('[component="topic/browsing/list"]').parent().toggleClass('hidden', !data.users.length);
-			for(var i=0; i<data.users.length; ++i) {
+			for (var i=0; i<data.users.length; ++i) {
 				addUserIcon(data.users[i]);
 			}
 
@@ -29,6 +29,7 @@ define('forum/topic/browsing', ['translator'], function(translator) {
 		} else {
 			increaseUserCount(1);
 		}
+		Browsing.onUserStatusChange(data);
 	};
 
 	Browsing.onUserLeave = function(uid) {
@@ -56,8 +57,8 @@ define('forum/topic/browsing', ['translator'], function(translator) {
 	function updateBrowsingUsers(data) {
 		var activeEl = $('[component="topic/browsing/list"]');
 		var user = activeEl.find('a[data-uid="'+ data.uid + '"]');
-		if (user.length && data.status === 'offline') {
-			user.parent().remove();
+		if (user.length) {
+			user.parent().toggleClass('hidden', data.status === 'offline');
 		}
 	}
 
@@ -80,7 +81,7 @@ define('forum/topic/browsing', ['translator'], function(translator) {
 	}
 
 	function createUserIcon(uid, picture, userslug, username) {
-		if(!$('[component="topic/browsing/list"]').find('[data-uid="' + uid + '"]').length) {
+		if (!$('[component="topic/browsing/list"]').find('[data-uid="' + uid + '"]').length) {
 			return $('<div class="inline-block"><a title="' + username + '" data-uid="' + uid + '" data-count="1" href="' + config.relative_path + '/user/' + userslug + '"><img src="'+ picture +'"/></a></div>');
 		}
 	}