From d23966c5343005e02f6f20756b59ef130a6d61db Mon Sep 17 00:00:00 2001 From: barisusakli Date: Tue, 8 Nov 2016 19:59:19 +0300 Subject: [PATCH] more tests --- src/socket.io/modules.js | 3 +-- test/messaging.js | 34 ++++++++++++++++++++++++++++------ 2 files changed, 29 insertions(+), 8 deletions(-) diff --git a/src/socket.io/modules.js b/src/socket.io/modules.js index 263ff76a29..f74e077c5c 100644 --- a/src/socket.io/modules.js +++ b/src/socket.io/modules.js @@ -1,5 +1,4 @@ "use strict"; - var async = require('async'); var validator = require('validator'); @@ -82,7 +81,7 @@ SocketModules.chats.send = function (socket, data, callback) { function (message, next) { Messaging.notifyUsersInRoom(socket.uid, data.roomId, message); user.updateOnlineUsers(socket.uid); - next(); + next(null, message); } ], callback); }; diff --git a/test/messaging.js b/test/messaging.js index 7acb95000a..13fa06d6a2 100644 --- a/test/messaging.js +++ b/test/messaging.js @@ -12,6 +12,7 @@ var Groups = require('../src/groups'); var Messaging = require('../src/messaging'); var helpers = require('./helpers'); + describe('Messaging Library', function () { var testUids; var fooUid; @@ -84,8 +85,9 @@ describe('Messaging Library', function () { }); describe('rooms', function () { + var socketModules = require('../src/socket.io/modules'); it('should create a new chat room', function (done) { - Messaging.newRoom(fooUid, [bazUid, herpUid], function (err, _roomId) { + socketModules.chats.newRoom({uid: fooUid}, {touid: bazUid}, function (err, _roomId) { roomId = _roomId; assert.ifError(err); assert(roomId); @@ -93,8 +95,15 @@ describe('Messaging Library', function () { }); }); + it('should add a user to room', function (done) { + socketModules.chats.addUserToRoom({uid: fooUid}, {roomId: roomId, username: 'herp'}, function (err) { + assert.ifError(err); + done(); + }); + }); + it('should leave the chat room', function (done) { - Messaging.leaveRoom([bazUid], roomId, function (err) { + socketModules.chats.leave({uid: bazUid}, roomId, function (err) { assert.ifError(err); Messaging.isUserInRoom(bazUid, roomId, function (err, isUserInRoom) { assert.ifError(err); @@ -105,21 +114,26 @@ describe('Messaging Library', function () { }); it('should send a message to a room', function (done) { - Messaging.sendMessage(fooUid, roomId, 'first chat message', Date.now(), function (err, messageData) { + socketModules.chats.send({uid: fooUid}, {roomId: roomId, message: 'first chat message'}, function (err, messageData) { assert.ifError(err); assert(messageData); assert.equal(messageData.content, 'first chat message'); assert(messageData.fromUser); assert(messageData.roomId, roomId); - done(); + socketModules.chats.getRaw({uid: fooUid}, {roomId: roomId, mid: messageData.mid}, function (err, raw) { + assert.ifError(err); + assert.equal(raw, 'first chat message'); + done(); + }); }); }); + it('should get messages from room', function (done) { - Messaging.getMessages({ - callerUid: fooUid, + socketModules.chats.getMessages({uid: fooUid}, { uid: fooUid, roomId: roomId, + start: 0, markRead: true }, function (err, messages) { assert.ifError(err); @@ -129,6 +143,14 @@ describe('Messaging Library', function () { done(); }); }); + + it('should load chat room', function (done) { + socketModules.chats.loadRoom({uid: fooUid}, {roomId: roomId}, function (err, data) { + assert.ifError(err); + assert(data); + done(); + }); + }); }); describe('controller', function () {