From d1101a7fb407cd15fd315fb7d0ef916a7aa58c94 Mon Sep 17 00:00:00 2001 From: Peter Jaszkowiak Date: Sat, 18 Feb 2017 00:21:44 -0700 Subject: [PATCH] ESlint dot-notation and func-call-spacing --- .eslintrc | 7 +++---- public/src/admin/advanced/errors.js | 4 ++-- public/src/modules/pictureCropper.js | 2 +- public/src/modules/search.js | 2 +- public/src/modules/settings/array.js | 2 +- public/src/modules/settings/object.js | 2 +- src/install.js | 2 +- 7 files changed, 10 insertions(+), 11 deletions(-) diff --git a/.eslintrc b/.eslintrc index fce036ca1a..6d0b50a7da 100644 --- a/.eslintrc +++ b/.eslintrc @@ -12,6 +12,7 @@ }], "import/no-unresolved": "off", "import/no-extraneous-dependencies": "off", + "newline-per-chained-call": "off", // "linebreak-style": "off", // "one-var": "off", // "no-undef": "off", @@ -103,10 +104,8 @@ "import/no-dynamic-require": "off", "no-bitwise": "off", "no-empty": "off", - "array-bracket-spacin": "off", - "dot-notation": "off", - "func-call-spacing": "off", - "newline-per-chained-call": "off", + // "dot-notation": "off", + // "func-call-spacing": "off", // "array-bracket-spacing": "off", // "object-property-newline": "off", // "no-continue": "off", diff --git a/public/src/admin/advanced/errors.js b/public/src/admin/advanced/errors.js index ec1bf1bff5..1d428da4c2 100644 --- a/public/src/admin/advanced/errors.js +++ b/public/src/admin/advanced/errors.js @@ -63,7 +63,7 @@ define('admin/advanced/errors', ['Chart', 'translator'], function (Chart, transl pointHoverBackgroundColor: "#fff", pointBorderColor: "#fff", pointHoverBorderColor: "rgba(151,187,205,1)", - data: ajaxify.data.analytics['toobusy'], + data: ajaxify.data.analytics.toobusy, }, ], }, @@ -92,7 +92,7 @@ define('admin/advanced/errors', ['Chart', 'translator'], function (Chart, transl new Chart(tooBusyCanvas.getContext('2d'), { type: 'line', - data: data['toobusy'], + data: data.toobusy, options: { responsive: true, legend: { diff --git a/public/src/modules/pictureCropper.js b/public/src/modules/pictureCropper.js index 7113c6bdd8..4a6e7b1388 100644 --- a/public/src/modules/pictureCropper.js +++ b/public/src/modules/pictureCropper.js @@ -67,7 +67,7 @@ define('pictureCropper', ['translator', 'cropper'], function (translator, croppe var socketData = {}; socketData[data.paramName] = data.paramValue; - socketData['imageData'] = imageData; + socketData.imageData = imageData; socket.emit(data.socketMethod, socketData, function (err, imageData) { if (err) { diff --git a/public/src/modules/search.js b/public/src/modules/search.js index 582ea3d4f2..f6cf3c1621 100644 --- a/public/src/modules/search.js +++ b/public/src/modules/search.js @@ -35,7 +35,7 @@ define('search', ['navigator', 'translator'], function (nav, translator) { }; function createQueryString(data) { - var searchIn = data['in'] || 'titlesposts'; + var searchIn = data.in || 'titlesposts'; var postedBy = data.by || ''; var query = { term: data.term, diff --git a/public/src/modules/settings/array.js b/public/src/modules/settings/array.js index 96dcc744cb..e505839568 100644 --- a/public/src/modules/settings/array.js +++ b/public/src/modules/settings/array.js @@ -45,7 +45,7 @@ define('settings/array', function () { var element = $(helper.createElementOfType(type, attributes.tagName, attributes)); element.attr('data-parent', '_' + key); delete attributes['data-type']; - delete attributes['tagName']; + delete attributes.tagName; for (var name in attributes) { var val = attributes[name]; if (name.search('data-') === 0) { diff --git a/public/src/modules/settings/object.js b/public/src/modules/settings/object.js index 8c761fcfb4..11166607e7 100644 --- a/public/src/modules/settings/object.js +++ b/public/src/modules/settings/object.js @@ -27,7 +27,7 @@ define('settings/object', function () { element.attr('data-parent', '_' + key); element.attr('data-prop', prop); delete attributes['data-type']; - delete attributes['tagName']; + delete attributes.tagName; for (var name in attributes) { var val = attributes[name]; if (name.search('data-') === 0) { diff --git a/src/install.js b/src/install.js index 9e463b5e25..cd94e8726d 100644 --- a/src/install.js +++ b/src/install.js @@ -133,7 +133,7 @@ function setupConfig(next) { var allQuestions = questions.main.concat(questions.optional).concat(redisQuestions).concat(mongoQuestions); allQuestions.forEach(function (question) { - config[question.name] = install.values[question.name] || question['default'] || undefined; + config[question.name] = install.values[question.name] || question.default || undefined; }); setImmediate(next, null, config); } else {