From bb7303834f440a3e222fa64e294b6bf1a3f3fbf8 Mon Sep 17 00:00:00 2001 From: barisusakli Date: Thu, 14 Jul 2016 21:44:33 +0300 Subject: [PATCH] remove csrf r.js module --- public/src/app.js | 22 ++++++++-------------- public/src/client/account/settings.js | 4 ++-- public/src/client/login.js | 4 ++-- public/src/client/register.js | 4 ++-- public/src/modules/csrf.js | 17 ----------------- public/src/modules/uploader.js | 4 ++-- src/meta/js.js | 3 +-- 7 files changed, 17 insertions(+), 41 deletions(-) delete mode 100644 public/src/modules/csrf.js diff --git a/public/src/app.js b/public/src/app.js index c40fdc4a2a..d4a88929b1 100644 --- a/public/src/app.js +++ b/public/src/app.js @@ -15,10 +15,6 @@ app.cacheBuster = null; app.cacheBuster = config['cache-buster']; - require(['csrf'], function(csrf) { - csrf.set(config.csrf_token); - }); - bootbox.setDefaults({ locale: config.userLang }); @@ -88,16 +84,14 @@ app.cacheBuster = null; }; app.logout = function() { - require(['csrf'], function(csrf) { - $.ajax(config.relative_path + '/logout', { - type: 'POST', - headers: { - 'x-csrf-token': csrf.get() - }, - success: function() { - window.location.href = config.relative_path + '/'; - } - }); + $.ajax(config.relative_path + '/logout', { + type: 'POST', + headers: { + 'x-csrf-token': config.csrf_token + }, + success: function() { + window.location.href = config.relative_path + '/'; + } }); }; diff --git a/public/src/client/account/settings.js b/public/src/client/account/settings.js index 763b41b504..4e68c73449 100644 --- a/public/src/client/account/settings.js +++ b/public/src/client/account/settings.js @@ -2,7 +2,7 @@ /*global define, socket, app, ajaxify, config*/ -define('forum/account/settings', ['forum/account/header', 'components', 'csrf'], function(header, components, csrf) { +define('forum/account/settings', ['forum/account/header', 'components'], function(header, components) { var AccountSettings = {}; AccountSettings.init = function() { @@ -99,7 +99,7 @@ define('forum/account/settings', ['forum/account/header', 'components', 'csrf'], url: config.relative_path + '/user/' + ajaxify.data.userslug + '/session/' + uuid, method: 'delete', headers: { - 'x-csrf-token': csrf.get() + 'x-csrf-token': config.csrf_token } }).done(function() { parentEl.remove(); diff --git a/public/src/client/login.js b/public/src/client/login.js index ab8dc0fe8a..65b54aa446 100644 --- a/public/src/client/login.js +++ b/public/src/client/login.js @@ -1,7 +1,7 @@ "use strict"; /* global define, app, config, RELATIVE_PATH */ -define('forum/login', ['csrf', 'translator'], function(csrf, translator) { +define('forum/login', ['translator'], function(translator) { var Login = {}; Login.init = function() { @@ -25,7 +25,7 @@ define('forum/login', ['csrf', 'translator'], function(csrf, translator) { submitEl.addClass('disabled'); formEl.ajaxSubmit({ headers: { - 'x-csrf-token': csrf.get() + 'x-csrf-token': config.csrf_token }, success: function(data, status) { window.location.href = data + '?loggedin'; diff --git a/public/src/client/register.js b/public/src/client/register.js index eecb2682bf..ce51d695b3 100644 --- a/public/src/client/register.js +++ b/public/src/client/register.js @@ -3,7 +3,7 @@ /* globals define, app, utils, socket, config, ajaxify, bootbox */ -define('forum/register', ['csrf', 'translator'], function(csrf, translator) { +define('forum/register', ['translator'], function(translator) { var Register = {}, validationError = false, successIcon = ''; @@ -78,7 +78,7 @@ define('forum/register', ['csrf', 'translator'], function(csrf, translator) { registerBtn.parents('form').ajaxSubmit({ headers: { - 'x-csrf-token': csrf.get() + 'x-csrf-token': config.csrf_token }, success: function(data) { registerBtn.removeClass('disabled'); diff --git a/public/src/modules/csrf.js b/public/src/modules/csrf.js deleted file mode 100644 index 10a9b002f0..0000000000 --- a/public/src/modules/csrf.js +++ /dev/null @@ -1,17 +0,0 @@ -"use strict"; -/*globals define*/ - -define('csrf', function() { - var csrf = {}, - _data = {}; - - csrf.get = function() { - return _data.token; - }; - - csrf.set = function(token) { - _data.token = token; - }; - - return csrf; -}); \ No newline at end of file diff --git a/public/src/modules/uploader.js b/public/src/modules/uploader.js index c54c12c912..5d257e4cfb 100644 --- a/public/src/modules/uploader.js +++ b/public/src/modules/uploader.js @@ -2,7 +2,7 @@ /* globals define, templates */ -define('uploader', ['csrf', 'translator'], function(csrf, translator) { +define('uploader', ['translator'], function(translator) { var module = {}; @@ -76,7 +76,7 @@ define('uploader', ['csrf', 'translator'], function(csrf, translator) { uploadModal.find('#uploadForm').ajaxSubmit({ headers: { - 'x-csrf-token': csrf.get() + 'x-csrf-token': config.csrf_token }, error: function(xhr) { xhr = maybeParse(xhr); diff --git a/src/meta/js.js b/src/meta/js.js index 9d8b1d6c34..fb8cb6023a 100644 --- a/src/meta/js.js +++ b/src/meta/js.js @@ -61,7 +61,6 @@ module.exports = function(Meta) { 'public/src/client/category.js', 'public/src/client/categoryTools.js', - 'public/src/modules/csrf.js', 'public/src/modules/translator.js', 'public/src/modules/notifications.js', 'public/src/modules/chat.js', @@ -93,7 +92,7 @@ module.exports = function(Meta) { var numBridged = 0, addRoute = function(relPath) { var relativePath = nconf.get('relative_path'); - + app.get(relativePath + '/src/modules/' + relPath, function(req, res) { return res.sendFile(path.join(__dirname, '../../', Meta.js.scripts.modules[relPath]), { maxAge: app.enabled('cache') ? 5184000000 : 0