From b887b76c29a94d97057f2e01efc812bad2166392 Mon Sep 17 00:00:00 2001
From: MrWaffle <mrwafflewaffle@aim.com>
Date: Wed, 22 Jan 2014 19:46:34 +0100
Subject: [PATCH] Implement favourite tooltip to show who favourited a post

---
 public/src/forum/topic.js  |  2 ++
 public/templates/topic.tpl |  2 +-
 src/favourites.js          | 19 +++++++++++++++++++
 src/topics.js              | 24 ++++++++++++++++++++++--
 4 files changed, 44 insertions(+), 3 deletions(-)

diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js
index f8cb5b5f67..9c1eaf2e27 100644
--- a/public/src/forum/topic.js
+++ b/public/src/forum/topic.js
@@ -341,6 +341,8 @@ define(['composer'], function(composer) {
 					updateHeader();
 				}
 			})();
+
+			$('.favourite-tooltip').tooltip();
 		});
 
 		function enableInfiniteLoading() {
diff --git a/public/templates/topic.tpl b/public/templates/topic.tpl
index 90ad7db476..8a134876cd 100644
--- a/public/templates/topic.tpl
+++ b/public/templates/topic.tpl
@@ -66,7 +66,7 @@
 							<!-- IF @first -->
 							<button class="btn btn-sm btn-default follow" type="button" title="Be notified of new replies in this topic"><i class="fa fa-eye"></i></button>
 							<!-- ENDIF @first -->
-							<button data-favourited="{posts.favourited}" class="favourite btn btn-sm btn-default <!-- IF posts.favourited --> btn-warning <!-- ENDIF posts.favourited -->" type="button">
+							<button title="{posts.favourited_users}" data-favourited="{posts.favourited}" class="favourite favourite-tooltip btn btn-sm btn-default <!-- IF posts.favourited --> btn-warning <!-- ENDIF posts.favourited -->" type="button">
 								<span class="favourite-text">[[topic:favourite]]</span>
 								<span class="post_rep_{posts.pid}">{posts.reputation} </span>
 								<!-- IF posts.favourited -->
diff --git a/src/favourites.js b/src/favourites.js
index 77e9606084..bf0259502f 100644
--- a/src/favourites.js
+++ b/src/favourites.js
@@ -115,4 +115,23 @@ var db = require('./database'),
 		}
 	};
 
+	Favourites.getFavouritedUidsByPids = function (pids, callback) {
+		//Might as well take the method above this as an example
+		var loaded = 0;
+		var data = {};
+
+		for (var i = 0, ii = pids.length; i < ii; i++) {
+			(function (post_id) {
+				db.getSetMembers('pid:' + post_id + ':users_favourited', function(err, uids) {
+					data[post_id] = uids;
+					loaded++;
+					if (loaded === pids.length) {
+						callback(data);
+					}
+				});
+			}(pids[i]));
+		}
+		//Literally
+	};
+
 }(exports));
\ No newline at end of file
diff --git a/src/topics.js b/src/topics.js
index ba88cef81b..f346e3130f 100644
--- a/src/topics.js
+++ b/src/topics.js
@@ -370,6 +370,24 @@ var async = require('async'),
 				});
 			}
 
+			function getFavouritedUsers(next) {
+				favourites.getFavouritedUidsByPids(pids, function(data) {
+					var usernames = {};
+					async.each(pids, function(pid, next) {
+						if (data.hasOwnProperty(pid) && data[pid].length > 0) {
+							user.getUsernamesByUids(data[pid], function(result) {
+								usernames[pid] = result;
+							});
+						} else {
+							usernames[pid] = [];
+						}
+						next();
+					}, function(err) {
+						next(err, usernames);
+					});
+				});
+			}
+
 			function addUserInfoToPosts(next) {
 				function iterator(post, callback) {
 					posts.addUserInfoToPost(post, function() {
@@ -399,17 +417,19 @@ var async = require('async'),
 				}
 			}
 
-			async.parallel([getFavouritesData, addUserInfoToPosts, getPrivileges], function(err, results) {
+			async.parallel([getFavouritesData, addUserInfoToPosts, getPrivileges, getFavouritedUsers], function(err, results) {
 				if(err) {
 					return callback(err);
 				}
 
 				var fav_data = results[0],
-					privileges = results[2];
+					privileges = results[2],
+					fav_users = results[3];
 
 				for (var i = 0; i < postData.length; ++i) {
 					var pid = postData[i].pid;
 					postData[i].favourited = fav_data[pid];
+					postData[i].favourited_users = fav_users[pid].join(', ');
 					postData[i].display_moderator_tools = (current_user != 0) && privileges[pid].editable;
 					postData[i].display_move_tools = privileges[pid].move ? '' : 'hidden';
 				}