From b58ab48485cdf2906d7a1e3da663b7e605c12085 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Thu, 4 Oct 2018 14:30:16 -0400 Subject: [PATCH] add test for /sessions controller --- src/controllers/accounts/sessions.js | 12 ++++-------- test/controllers.js | 10 +++++++++- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/src/controllers/accounts/sessions.js b/src/controllers/accounts/sessions.js index df77a44dbc..1609fa2383 100644 --- a/src/controllers/accounts/sessions.js +++ b/src/controllers/accounts/sessions.js @@ -7,7 +7,7 @@ var user = require('../../user'); var helpers = require('../helpers'); var accountHelpers = require('./helpers'); -var sessionController = {}; +var sessionController = module.exports; sessionController.get = function (req, res, callback) { var userData; @@ -22,12 +22,10 @@ sessionController.get = function (req, res, callback) { return callback(); } - async.parallel({ - sessions: async.apply(user.auth.getSessions, userData.uid, req.sessionID), - }, next); + user.auth.getSessions(userData.uid, req.sessionID, next); }, - function (data) { - userData.sessions = data.sessions; + function (sessions) { + userData.sessions = sessions; userData.title = '[[pages:account/sessions]]'; userData.breadcrumbs = helpers.buildBreadcrumbs([{ text: userData.username, url: '/user/' + userData.userslug }, { text: '[[pages:account/sessions]]' }]); @@ -80,5 +78,3 @@ sessionController.revoke = function (req, res, next) { return res.sendStatus(200); }); }; - -module.exports = sessionController; diff --git a/test/controllers.js b/test/controllers.js index aed9de430d..44259db3b7 100644 --- a/test/controllers.js +++ b/test/controllers.js @@ -1074,7 +1074,6 @@ describe('Controllers', function () { }); }); - it('should load /user/foo/posts', function (done) { request(nconf.get('url') + '/api/user/foo/posts', function (err, res, body) { assert.ifError(err); @@ -1174,6 +1173,15 @@ describe('Controllers', function () { }); }); + it('should load /user/foo/sessions', function (done) { + request(nconf.get('url') + '/api/user/foo/sessions', { jar: jar }, function (err, res, body) { + assert.ifError(err); + assert.equal(res.statusCode, 200); + assert(body); + done(); + }); + }); + it('should load /user/foo/uploads', function (done) { request(nconf.get('url') + '/api/user/foo/uploads', { jar: jar }, function (err, res, body) { assert.ifError(err);