From b48b6d75e5ad6a948e8fdb660c38e902f15faeae Mon Sep 17 00:00:00 2001
From: Baris Usakli <barisusakli@gmail.com>
Date: Fri, 15 Mar 2019 16:06:38 -0400
Subject: [PATCH] fix: callbacks

---
 src/database/redis/hash.js | 8 ++++----
 src/groups/membership.js   | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/database/redis/hash.js b/src/database/redis/hash.js
index 5be88c025b..32ed49472c 100644
--- a/src/database/redis/hash.js
+++ b/src/database/redis/hash.js
@@ -63,13 +63,13 @@ module.exports = function (redisClient, module) {
 
 	module.getObjects = function (keys, callback) {
 		var cachedData = {};
-		function getFromCache() {
-			process.nextTick(callback, null, keys.map(key => _.clone(cachedData[key])));
+		function getFromCache(next) {
+			process.nextTick(next, null, keys.map(key => _.clone(cachedData[key])));
 		}
 
 		const unCachedKeys = cache.getUnCachedKeys(keys, cachedData);
 		if (!unCachedKeys.length) {
-			return getFromCache();
+			return getFromCache(callback);
 		}
 
 		async.waterfall([
@@ -86,7 +86,7 @@ module.exports = function (redisClient, module) {
 					cache.set(key, cachedData[key]);
 				});
 
-				getFromCache();
+				getFromCache(next);
 			},
 		], callback);
 	};
diff --git a/src/groups/membership.js b/src/groups/membership.js
index 86ce185487..910601a4db 100644
--- a/src/groups/membership.js
+++ b/src/groups/membership.js
@@ -162,8 +162,8 @@ module.exports = function (Groups) {
 
 	Groups.isMembers = function (uids, groupName, callback) {
 		var cachedData = {};
-		function getFromCache() {
-			setImmediate(callback, null, uids.map(uid => cachedData[uid + ':' + groupName]));
+		function getFromCache(next) {
+			setImmediate(next, null, uids.map(uid => cachedData[uid + ':' + groupName]));
 		}
 		if (!groupName || !uids.length) {
 			return setImmediate(callback, null, uids.map(() => false));