From b385655dba522a2a1f3e1725395b00313cffe6a5 Mon Sep 17 00:00:00 2001 From: Julian Lam Date: Sat, 25 Feb 2017 15:40:22 -0500 Subject: [PATCH] adding upgrade scripts from all of v1.x.x, #5467 --- src/upgrade.js | 16 ++- src/upgrades/assign_topic_read_privilege.js | 73 ++++++++++++ src/upgrades/chat_room_hashes.js | 41 +++++++ src/upgrades/chat_upgrade.js | 87 ++++++++++++++ .../dismiss_flags_from_deleted_topics.js | 43 +++++++ .../edit_delete_deletetopic_privileges.js | 109 ++++++++++++++++++ src/upgrades/global_moderators.js | 34 ++++++ src/upgrades/group_title_update.js | 34 ++++++ src/upgrades/remove_negative_best_posts.js | 22 ++++ src/upgrades/separate_upvote_downvote.js | 50 ++++++++ src/upgrades/social_post_sharing.js | 23 ++++ src/upgrades/theme_to_active_plugins.js | 18 +++ src/upgrades/upload_privileges.js | 40 +++++++ src/upgrades/user_best_posts.js | 31 +++++ src/upgrades/user_post_count_per_tid.js | 50 ++++++++ src/upgrades/users_notvalidated.js | 31 +++++ 16 files changed, 700 insertions(+), 2 deletions(-) create mode 100644 src/upgrades/assign_topic_read_privilege.js create mode 100644 src/upgrades/chat_room_hashes.js create mode 100644 src/upgrades/chat_upgrade.js create mode 100644 src/upgrades/dismiss_flags_from_deleted_topics.js create mode 100644 src/upgrades/edit_delete_deletetopic_privileges.js create mode 100644 src/upgrades/global_moderators.js create mode 100644 src/upgrades/group_title_update.js create mode 100644 src/upgrades/remove_negative_best_posts.js create mode 100644 src/upgrades/separate_upvote_downvote.js create mode 100644 src/upgrades/social_post_sharing.js create mode 100644 src/upgrades/theme_to_active_plugins.js create mode 100644 src/upgrades/upload_privileges.js create mode 100644 src/upgrades/user_best_posts.js create mode 100644 src/upgrades/user_post_count_per_tid.js create mode 100644 src/upgrades/users_notvalidated.js diff --git a/src/upgrade.js b/src/upgrade.js index 3558a2b30a..33aaa831ca 100644 --- a/src/upgrade.js +++ b/src/upgrade.js @@ -10,9 +10,21 @@ var utils = require('../public/src/utils'); var Upgrade = { available: [ + { + version: '1.0.0', + upgrades: ['chat_upgrade', 'chat_room_hashes', 'theme_to_active_plugins', 'user_best_posts', 'users_notvalidated', 'global_moderators', 'social_post_sharing'], + }, + { + version: '1.1.0', + upgrades: ['group_title_update', 'user_post_count_per_tid', 'dismiss_flags_from_deleted_topics', 'assign_topic_read_privilege', 'separate_upvote_downvote'], + }, + { + version: '1.1.1', + upgrades: ['upload_privileges', 'remove_negative_best_posts'], + }, { version: '1.2.0', - upgrades: ['category_recent_tids'], + upgrades: ['category_recent_tids', 'edit_delete_deletetopic_privileges'], }, { version: '1.3.0', @@ -85,7 +97,7 @@ Upgrade.process = function (files, skipCount, callback) { var scriptExport = require(file); var date = new Date(scriptExport.timestamp); - process.stdout.write(' → '.white + String('[' + [date.getFullYear(), date.getMonth() + 1, date.getDate() + 1].join('/') + '] ').gray + String(scriptExport.name).reset + '... '); + process.stdout.write(' → '.white + String('[' + [date.getUTCFullYear(), date.getUTCMonth() + 1, date.getUTCDate()].join('/') + '] ').gray + String(scriptExport.name).reset + '... '); // Do the upgrade... scriptExport.method(function (err) { diff --git a/src/upgrades/assign_topic_read_privilege.js b/src/upgrades/assign_topic_read_privilege.js new file mode 100644 index 0000000000..1e65d0d6f7 --- /dev/null +++ b/src/upgrades/assign_topic_read_privilege.js @@ -0,0 +1,73 @@ +/* jslint node: true */ + +'use strict'; + +var db = require('../database'); + +var async = require('async'); +var winston = require('winston'); + +module.exports = { + name: 'Giving topics:read privs to any group that was previously allowed to Find & Access Category', + timestamp: Date.UTC(2016, 4, 28), + method: function (callback) { + var groupsAPI = require('../groups'); + var privilegesAPI = require('../privileges'); + + db.getSortedSetRange('categories:cid', 0, -1, function (err, cids) { + if (err) { + return callback(err); + } + + async.eachSeries(cids, function (cid, next) { + privilegesAPI.categories.list(cid, function (err, data) { + if (err) { + return next(err); + } + + var groups = data.groups; + var users = data.users; + + async.waterfall([ + function (next) { + async.eachSeries(groups, function (group, next) { + if (group.privileges['groups:read']) { + return groupsAPI.join('cid:' + cid + ':privileges:groups:topics:read', group.name, function (err) { + if (!err) { + winston.verbose('cid:' + cid + ':privileges:groups:topics:read granted to gid: ' + group.name); + } + + return next(err); + }); + } + + next(null); + }, next); + }, + function (next) { + async.eachSeries(users, function (user, next) { + if (user.privileges.read) { + return groupsAPI.join('cid:' + cid + ':privileges:topics:read', user.uid, function (err) { + if (!err) { + winston.verbose('cid:' + cid + ':privileges:topics:read granted to uid: ' + user.uid); + } + + return next(err); + }); + } + + next(null); + }, next); + }, + ], function (err) { + if (!err) { + winston.verbose('-- cid ' + cid + ' upgraded'); + } + + next(err); + }); + }); + }, callback); + }); + }, +}; diff --git a/src/upgrades/chat_room_hashes.js b/src/upgrades/chat_room_hashes.js new file mode 100644 index 0000000000..bccf85282c --- /dev/null +++ b/src/upgrades/chat_room_hashes.js @@ -0,0 +1,41 @@ +/* jslint node: true */ + +'use strict'; + +var db = require('../database'); + +var async = require('async'); + +module.exports = { + name: 'Chat room hashes', + timestamp: Date.UTC(2015, 11, 23), + method: function (callback) { + db.getObjectField('global', 'nextChatRoomId', function (err, nextChatRoomId) { + if (err) { + return callback(err); + } + var currentChatRoomId = 1; + async.whilst(function () { + return currentChatRoomId <= nextChatRoomId; + }, function (next) { + db.getSortedSetRange('chat:room:' + currentChatRoomId + ':uids', 0, 0, function (err, uids) { + if (err) { + return next(err); + } + if (!Array.isArray(uids) || !uids.length || !uids[0]) { + currentChatRoomId += 1; + return next(); + } + + db.setObject('chat:room:' + currentChatRoomId, { owner: uids[0], roomId: currentChatRoomId }, function (err) { + if (err) { + return next(err); + } + currentChatRoomId += 1; + next(); + }); + }); + }, callback); + }); + }, +}; diff --git a/src/upgrades/chat_upgrade.js b/src/upgrades/chat_upgrade.js new file mode 100644 index 0000000000..ce49b501de --- /dev/null +++ b/src/upgrades/chat_upgrade.js @@ -0,0 +1,87 @@ +/* jslint node: true */ + +'use strict'; + +var db = require('../database'); + +var async = require('async'); +var winston = require('winston'); + +module.exports = { + name: 'Upgrading chats', + timestamp: Date.UTC(2015, 11, 15), + method: function (callback) { + db.getObjectFields('global', ['nextMid', 'nextChatRoomId'], function (err, globalData) { + if (err) { + return callback(err); + } + + var rooms = {}; + var roomId = globalData.nextChatRoomId || 1; + var currentMid = 1; + + async.whilst(function () { + return currentMid <= globalData.nextMid; + }, function (next) { + db.getObject('message:' + currentMid, function (err, message) { + var msgTime; + + function addMessageToUids(roomId, callback) { + async.parallel([ + function (next) { + db.sortedSetAdd('uid:' + message.fromuid + ':chat:room:' + roomId + ':mids', msgTime, currentMid, next); + }, + function (next) { + db.sortedSetAdd('uid:' + message.touid + ':chat:room:' + roomId + ':mids', msgTime, currentMid, next); + }, + ], callback); + } + + if (err || !message) { + winston.verbose('skipping chat message ', currentMid); + currentMid += 1; + return next(err); + } + + var pairID = [parseInt(message.fromuid, 10), parseInt(message.touid, 10)].sort().join(':'); + msgTime = parseInt(message.timestamp, 10); + + if (rooms[pairID]) { + winston.verbose('adding message ' + currentMid + ' to existing roomID ' + roomId); + addMessageToUids(rooms[pairID], function (err) { + if (err) { + return next(err); + } + currentMid += 1; + next(); + }); + } else { + winston.verbose('adding message ' + currentMid + ' to new roomID ' + roomId); + async.parallel([ + function (next) { + db.sortedSetAdd('uid:' + message.fromuid + ':chat:rooms', msgTime, roomId, next); + }, + function (next) { + db.sortedSetAdd('uid:' + message.touid + ':chat:rooms', msgTime, roomId, next); + }, + function (next) { + db.sortedSetAdd('chat:room:' + roomId + ':uids', [msgTime, msgTime + 1], [message.fromuid, message.touid], next); + }, + function (next) { + addMessageToUids(roomId, next); + }, + ], function (err) { + if (err) { + return next(err); + } + rooms[pairID] = roomId; + roomId += 1; + currentMid += 1; + db.setObjectField('global', 'nextChatRoomId', roomId, next); + }); + } + }); + }, callback); + }); + }, +}; diff --git a/src/upgrades/dismiss_flags_from_deleted_topics.js b/src/upgrades/dismiss_flags_from_deleted_topics.js new file mode 100644 index 0000000000..cf4af73436 --- /dev/null +++ b/src/upgrades/dismiss_flags_from_deleted_topics.js @@ -0,0 +1,43 @@ +/* jslint node: true */ + +'use strict'; + +var db = require('../database'); + +var async = require('async'); +var winston = require('winston'); + +module.exports = { + name: 'Dismiss flags from deleted topics', + timestamp: Date.UTC(2016, 3, 29), + method: function (callback) { + var posts = require('../posts'); + var topics = require('../topics'); + + var pids; + var tids; + + async.waterfall([ + async.apply(db.getSortedSetRange, 'posts:flagged', 0, -1), + function (_pids, next) { + pids = _pids; + posts.getPostsFields(pids, ['tid'], next); + }, + function (_tids, next) { + tids = _tids.map(function (a) { + return a.tid; + }); + + topics.getTopicsFields(tids, ['deleted'], next); + }, + function (state, next) { + var toDismiss = state.map(function (a, idx) { + return parseInt(a.deleted, 10) === 1 ? pids[idx] : null; + }).filter(Boolean); + + winston.verbose('[2016/04/29] ' + toDismiss.length + ' dismissable flags found'); + async.each(toDismiss, posts.dismissFlag, next); + }, + ], callback); + }, +}; diff --git a/src/upgrades/edit_delete_deletetopic_privileges.js b/src/upgrades/edit_delete_deletetopic_privileges.js new file mode 100644 index 0000000000..5ba6f604c5 --- /dev/null +++ b/src/upgrades/edit_delete_deletetopic_privileges.js @@ -0,0 +1,109 @@ +/* jslint node: true */ + +'use strict'; + +var db = require('../database'); + +var async = require('async'); +var winston = require('winston'); + +module.exports = { + name: 'Granting edit/delete/delete topic on existing categories', + timestamp: Date.UTC(2016, 7, 7), + method: function (callback) { + var groupsAPI = require('../groups'); + var privilegesAPI = require('../privileges'); + + db.getSortedSetRange('categories:cid', 0, -1, function (err, cids) { + if (err) { + return callback(err); + } + + async.eachSeries(cids, function (cid, next) { + privilegesAPI.categories.list(cid, function (err, data) { + if (err) { + return next(err); + } + + var groups = data.groups; + var users = data.users; + + async.waterfall([ + function (next) { + async.eachSeries(groups, function (group, next) { + if (group.privileges['groups:topics:reply']) { + return async.parallel([ + async.apply(groupsAPI.join, 'cid:' + cid + ':privileges:groups:posts:edit', group.name), + async.apply(groupsAPI.join, 'cid:' + cid + ':privileges:groups:posts:delete', group.name), + ], function (err) { + if (!err) { + winston.verbose('cid:' + cid + ':privileges:groups:posts:edit, cid:' + cid + ':privileges:groups:posts:delete granted to gid: ' + group.name); + } + + return next(err); + }); + } + + next(null); + }, next); + }, + function (next) { + async.eachSeries(groups, function (group, next) { + if (group.privileges['groups:topics:create']) { + return groupsAPI.join('cid:' + cid + ':privileges:groups:topics:delete', group.name, function (err) { + if (!err) { + winston.verbose('cid:' + cid + ':privileges:groups:topics:delete granted to gid: ' + group.name); + } + + return next(err); + }); + } + + next(null); + }, next); + }, + function (next) { + async.eachSeries(users, function (user, next) { + if (user.privileges['topics:reply']) { + return async.parallel([ + async.apply(groupsAPI.join, 'cid:' + cid + ':privileges:posts:edit', user.uid), + async.apply(groupsAPI.join, 'cid:' + cid + ':privileges:posts:delete', user.uid), + ], function (err) { + if (!err) { + winston.verbose('cid:' + cid + ':privileges:posts:edit, cid:' + cid + ':privileges:posts:delete granted to uid: ' + user.uid); + } + + return next(err); + }); + } + + next(null); + }, next); + }, + function (next) { + async.eachSeries(users, function (user, next) { + if (user.privileges['topics:create']) { + return groupsAPI.join('cid:' + cid + ':privileges:topics:delete', user.uid, function (err) { + if (!err) { + winston.verbose('cid:' + cid + ':privileges:topics:delete granted to uid: ' + user.uid); + } + + return next(err); + }); + } + + next(null); + }, next); + }, + ], function (err) { + if (!err) { + winston.verbose('-- cid ' + cid + ' upgraded'); + } + + next(err); + }); + }); + }, callback); + }); + }, +}; diff --git a/src/upgrades/global_moderators.js b/src/upgrades/global_moderators.js new file mode 100644 index 0000000000..bfe909a11b --- /dev/null +++ b/src/upgrades/global_moderators.js @@ -0,0 +1,34 @@ +/* jslint node: true */ + +'use strict'; + +var async = require('async'); + +module.exports = { + name: 'Creating Global moderators group', + timestamp: Date.UTC(2016, 0, 23), + method: function (callback) { + var groups = require('../groups'); + async.waterfall([ + function (next) { + groups.exists('Global Moderators', next); + }, + function (exists, next) { + if (exists) { + return next(null, null); + } + groups.create({ + name: 'Global Moderators', + userTitle: 'Global Moderator', + description: 'Forum wide moderators', + hidden: 0, + private: 1, + disableJoinRequests: 1, + }, next); + }, + function (groupData, next) { + groups.show('Global Moderators', next); + }, + ], callback); + }, +}; diff --git a/src/upgrades/group_title_update.js b/src/upgrades/group_title_update.js new file mode 100644 index 0000000000..5f82e97bfe --- /dev/null +++ b/src/upgrades/group_title_update.js @@ -0,0 +1,34 @@ +/* jslint node: true */ + +'use strict'; + +var db = require('../database'); + +var async = require('async'); +var winston = require('winston'); + +module.exports = { + name: 'Group title from settings to user profile', + timestamp: Date.UTC(2016, 3, 14), + method: function (callback) { + var user = require('../user'); + var batch = require('../batch'); + var count = 0; + batch.processSortedSet('users:joindate', function (uids, next) { + winston.verbose('upgraded ' + count + ' users'); + user.getMultipleUserSettings(uids, function (err, settings) { + if (err) { + return next(err); + } + count += uids.length; + settings = settings.filter(function (setting) { + return setting && setting.groupTitle; + }); + + async.each(settings, function (setting, next) { + db.setObjectField('user:' + setting.uid, 'groupTitle', setting.groupTitle, next); + }, next); + }); + }, {}, callback); + }, +}; diff --git a/src/upgrades/remove_negative_best_posts.js b/src/upgrades/remove_negative_best_posts.js new file mode 100644 index 0000000000..604d1d8234 --- /dev/null +++ b/src/upgrades/remove_negative_best_posts.js @@ -0,0 +1,22 @@ +/* jslint node: true */ + +'use strict'; + +var db = require('../database'); + +var async = require('async'); +var winston = require('winston'); + +module.exports = { + name: 'Removing best posts with negative scores', + timestamp: Date.UTC(2016, 7, 5), + method: function (callback) { + var batch = require('../batch'); + batch.processSortedSet('users:joindate', function (ids, next) { + async.each(ids, function (id, next) { + winston.verbose('processing uid ' + id); + db.sortedSetsRemoveRangeByScore(['uid:' + id + ':posts:votes'], '-inf', 0, next); + }, next); + }, {}, callback); + }, +}; diff --git a/src/upgrades/separate_upvote_downvote.js b/src/upgrades/separate_upvote_downvote.js new file mode 100644 index 0000000000..b313c7439d --- /dev/null +++ b/src/upgrades/separate_upvote_downvote.js @@ -0,0 +1,50 @@ +/* jslint node: true */ + +'use strict'; + +var db = require('../database'); + +var async = require('async'); +var winston = require('winston'); + +module.exports = { + name: 'Store upvotes/downvotes separately', + timestamp: Date.UTC(2016, 5, 13), + method: function (callback) { + var batch = require('../batch'); + var posts = require('../posts'); + var count = 0; + batch.processSortedSet('posts:pid', function (pids, next) { + winston.verbose('upgraded ' + count + ' posts'); + count += pids.length; + async.each(pids, function (pid, next) { + async.parallel({ + upvotes: function (next) { + db.setCount('pid:' + pid + ':upvote', next); + }, + downvotes: function (next) { + db.setCount('pid:' + pid + ':downvote', next); + }, + }, function (err, results) { + if (err) { + return next(err); + } + var data = {}; + + if (parseInt(results.upvotes, 10) > 0) { + data.upvotes = results.upvotes; + } + if (parseInt(results.downvotes, 10) > 0) { + data.downvotes = results.downvotes; + } + + if (Object.keys(data).length) { + posts.setPostFields(pid, data, next); + } else { + next(); + } + }, next); + }, next); + }, {}, callback); + }, +}; diff --git a/src/upgrades/social_post_sharing.js b/src/upgrades/social_post_sharing.js new file mode 100644 index 0000000000..22c4a8c7cf --- /dev/null +++ b/src/upgrades/social_post_sharing.js @@ -0,0 +1,23 @@ +/* jslint node: true */ + +'use strict'; + +var db = require('../database'); + +var async = require('async'); + +module.exports = { + name: 'Social: Post Sharing', + timestamp: Date.UTC(2016, 1, 25), + method: function (callback) { + var social = require('../social'); + async.parallel([ + function (next) { + social.setActivePostSharingNetworks(['facebook', 'google', 'twitter'], next); + }, + function (next) { + db.deleteObjectField('config', 'disableSocialButtons', next); + }, + ], callback); + }, +}; diff --git a/src/upgrades/theme_to_active_plugins.js b/src/upgrades/theme_to_active_plugins.js new file mode 100644 index 0000000000..3adbca16dc --- /dev/null +++ b/src/upgrades/theme_to_active_plugins.js @@ -0,0 +1,18 @@ +/* jslint node: true */ + +'use strict'; + +var db = require('../database'); + +var async = require('async'); + +module.exports = { + name: 'Adding theme to active plugins sorted set', + timestamp: Date.UTC(2015, 11, 23), + method: function (callback) { + async.waterfall([ + async.apply(db.getObjectField, 'config', 'theme:id'), + async.apply(db.sortedSetAdd, 'plugins:active', 0), + ], callback); + }, +}; diff --git a/src/upgrades/upload_privileges.js b/src/upgrades/upload_privileges.js new file mode 100644 index 0000000000..b3268a2022 --- /dev/null +++ b/src/upgrades/upload_privileges.js @@ -0,0 +1,40 @@ +/* jslint node: true */ + +'use strict'; + +var db = require('../database'); + +var async = require('async'); + +module.exports = { + name: 'Giving upload privileges', + timestamp: Date.UTC(2016, 6, 12), + method: function (callback) { + var privilegesAPI = require('../privileges'); + var meta = require('../meta'); + + db.getSortedSetRange('categories:cid', 0, -1, function (err, cids) { + if (err) { + return callback(err); + } + + async.eachSeries(cids, function (cid, next) { + privilegesAPI.categories.list(cid, function (err, data) { + if (err) { + return next(err); + } + async.eachSeries(data.groups, function (group, next) { + if (group.name === 'guests' && parseInt(meta.config.allowGuestUploads, 10) !== 1) { + return next(); + } + if (group.privileges['groups:read']) { + privilegesAPI.categories.give(['upload:post:image'], cid, group.name, next); + } else { + next(); + } + }, next); + }); + }, callback); + }); + }, +}; diff --git a/src/upgrades/user_best_posts.js b/src/upgrades/user_best_posts.js new file mode 100644 index 0000000000..126539c2b7 --- /dev/null +++ b/src/upgrades/user_best_posts.js @@ -0,0 +1,31 @@ +/* jslint node: true */ + +'use strict'; + +var db = require('../database'); + +var async = require('async'); +var winston = require('winston'); + +module.exports = { + name: 'Creating user best post sorted sets', + timestamp: Date.UTC(2016, 0, 14), + method: function (callback) { + var batch = require('../batch'); + + batch.processSortedSet('posts:pid', function (ids, next) { + async.eachSeries(ids, function (id, next) { + db.getObjectFields('post:' + id, ['pid', 'uid', 'votes'], function (err, postData) { + if (err) { + return next(err); + } + if (!postData || !parseInt(postData.votes, 10) || !parseInt(postData.uid, 10)) { + return next(); + } + winston.verbose('processing pid: ' + postData.pid + ' uid: ' + postData.uid + ' votes: ' + postData.votes); + db.sortedSetAdd('uid:' + postData.uid + ':posts:votes', postData.votes, postData.pid, next); + }); + }, next); + }, {}, callback); + }, +}; diff --git a/src/upgrades/user_post_count_per_tid.js b/src/upgrades/user_post_count_per_tid.js new file mode 100644 index 0000000000..c0e86c4f52 --- /dev/null +++ b/src/upgrades/user_post_count_per_tid.js @@ -0,0 +1,50 @@ +/* jslint node: true */ + +'use strict'; + +var db = require('../database'); + +var async = require('async'); +var winston = require('winston'); + +module.exports = { + name: 'Users post count per tid', + timestamp: Date.UTC(2016, 3, 19), + method: function (callback) { + var batch = require('../batch'); + var topics = require('../topics'); + var count = 0; + batch.processSortedSet('topics:tid', function (tids, next) { + winston.verbose('upgraded ' + count + ' topics'); + count += tids.length; + async.each(tids, function (tid, next) { + db.delete('tid:' + tid + ':posters', function (err) { + if (err) { + return next(err); + } + topics.getPids(tid, function (err, pids) { + if (err) { + return next(err); + } + + if (!pids.length) { + return next(); + } + + async.eachSeries(pids, function (pid, next) { + db.getObjectField('post:' + pid, 'uid', function (err, uid) { + if (err) { + return next(err); + } + if (!parseInt(uid, 10)) { + return next(); + } + db.sortedSetIncrBy('tid:' + tid + ':posters', 1, uid, next); + }); + }, next); + }); + }); + }, next); + }, {}, callback); + }, +}; diff --git a/src/upgrades/users_notvalidated.js b/src/upgrades/users_notvalidated.js new file mode 100644 index 0000000000..9c23b6a539 --- /dev/null +++ b/src/upgrades/users_notvalidated.js @@ -0,0 +1,31 @@ +/* jslint node: true */ + +'use strict'; + +var db = require('../database'); + +var async = require('async'); +var winston = require('winston'); + +module.exports = { + name: 'Creating users:notvalidated', + timestamp: Date.UTC(2016, 0, 20), + method: function (callback) { + var batch = require('../batch'); + var now = Date.now(); + batch.processSortedSet('users:joindate', function (ids, next) { + async.eachSeries(ids, function (id, next) { + db.getObjectFields('user:' + id, ['uid', 'email:confirmed'], function (err, userData) { + if (err) { + return next(err); + } + if (!userData || !parseInt(userData.uid, 10) || parseInt(userData['email:confirmed'], 10) === 1) { + return next(); + } + winston.verbose('processing uid: ' + userData.uid + ' email:confirmed: ' + userData['email:confirmed']); + db.sortedSetAdd('users:notvalidated', now, userData.uid, next); + }); + }, next); + }, callback); + }, +};