From ae7f9bac98122c5174c3091e12f2da0942d382ef Mon Sep 17 00:00:00 2001 From: barisusakli Date: Thu, 2 Feb 2017 13:11:27 +0300 Subject: [PATCH] prevent crash if uri is malformed --- src/middleware/render.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/middleware/render.js b/src/middleware/render.js index 59348aba34..688b32c66f 100644 --- a/src/middleware/render.js +++ b/src/middleware/render.js @@ -3,6 +3,7 @@ var async = require('async'); var nconf = require('nconf'); var validator = require('validator'); +var winston = require('winston'); var plugins = require('../plugins'); var translator = require('../../public/src/modules/translator'); @@ -114,7 +115,13 @@ module.exports = function (middleware) { var clean = req.path.replace(/^\/api/, '').replace(/^\/|\/$/g, ''); var parts = clean.split('/').slice(0, 3); parts.forEach(function (p, index) { - p = decodeURIComponent(p); + try { + p = decodeURIComponent(p); + } catch (err) { + winston.error(err.message); + p = ''; + } + parts[index] = index ? parts[0] + '-' + p : 'page-' + (p || 'home'); }); return parts.join(' ');