From a96293574363d8e4f5b14a5909da3cb58157492a Mon Sep 17 00:00:00 2001 From: Julian Lam Date: Wed, 16 Dec 2020 20:10:15 -0500 Subject: [PATCH] fix: bad error message for request body api test --- test/api.js | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/test/api.js b/test/api.js index 6384481903..c2a78641be 100644 --- a/test/api.js +++ b/test/api.js @@ -235,6 +235,7 @@ describe('API', async () => { const qs = {}; Object.keys(context).forEach((_method) => { + // Only test GET routes in the Read API if (api.info.title === 'NodeBB Read API' && _method !== 'get') { return; } @@ -279,17 +280,18 @@ describe('API', async () => { it('should contain a valid request body (if present) with application/json or multipart/form-data type if POST/PUT/DELETE', () => { if (['post', 'put', 'delete'].includes(method) && context[method].hasOwnProperty('requestBody')) { - assert(context[method].requestBody); - assert(context[method].requestBody.content); + const failMessage = `${method.toUpperCase()} ${path} has a malformed request body`; + assert(context[method].requestBody, failMessage); + assert(context[method].requestBody.content, failMessage); if (context[method].requestBody.content.hasOwnProperty('application/json')) { - assert(context[method].requestBody.content['application/json']); - assert(context[method].requestBody.content['application/json'].schema); - assert(context[method].requestBody.content['application/json'].schema.properties); + assert(context[method].requestBody.content['application/json'], failMessage); + assert(context[method].requestBody.content['application/json'].schema, failMessage); + assert(context[method].requestBody.content['application/json'].schema.properties, failMessage); } else if (context[method].requestBody.content.hasOwnProperty('multipart/form-data')) { - assert(context[method].requestBody.content['multipart/form-data']); - assert(context[method].requestBody.content['multipart/form-data'].schema); - assert(context[method].requestBody.content['multipart/form-data'].schema.properties); + assert(context[method].requestBody.content['multipart/form-data'], failMessage); + assert(context[method].requestBody.content['multipart/form-data'].schema, failMessage); + assert(context[method].requestBody.content['multipart/form-data'].schema.properties, failMessage); } } });