diff --git a/src/database/mongo.js b/src/database/mongo.js index 9e1c3a5a8f..b91acde0cb 100644 --- a/src/database/mongo.js +++ b/src/database/mongo.js @@ -9,7 +9,6 @@ var session = require('express-session'); var _ = require('underscore'); var semver = require('semver'); - var meta = require('../meta'); var db; _.mixin(require('underscore.deep')); @@ -130,14 +129,12 @@ rdb.client = rdb.connect(); var ttlDays = 1000 * 60 * 60 * 24 * (parseInt(meta.config.loginDays, 10) || 0); - var ttlHours = 1000 * 60 * 60 * (parseInt(meta.config.loginHours, 10) || 0); - var ttlMinutes = 1000 * 60 * (parseInt(meta.config.loginMinutes, 10) || 0); var ttlSeconds = 1000 * (parseInt(meta.config.loginSeconds, 10) || 0); - var ttlTotal = (ttlDays + ttlHours + ttlMinutes + ttlSeconds) || 1209600000; // Default to 14 days + var ttl = ttlSeconds || ttlDays || 1209600000; // Default to 14 days module.sessionStore = new sessionStore({ client: rdb.client, - ttl: ttlTotal + ttl: ttl }); } else if (nconf.get('mongo')) { sessionStore = require('connect-mongo')(session); diff --git a/src/database/redis.js b/src/database/redis.js index 7d89054b26..8519b57bae 100644 --- a/src/database/redis.js +++ b/src/database/redis.js @@ -63,14 +63,12 @@ var sessionStore = require('connect-redis')(session); var ttlDays = 1000 * 60 * 60 * 24 * (parseInt(meta.config.loginDays, 10) || 0); - var ttlHours = 1000 * 60 * 60 * (parseInt(meta.config.loginHours, 10) || 0); - var ttlMinutes = 1000 * 60 * (parseInt(meta.config.loginMinutes, 10) || 0); var ttlSeconds = 1000 * (parseInt(meta.config.loginSeconds, 10) || 0); - var ttlTotal = (ttlDays + ttlHours + ttlMinutes + ttlSeconds) || 1209600000; // Default to 14 days + var ttl = ttlSeconds || ttlDays || 1209600000; // Default to 14 days module.sessionStore = new sessionStore({ client: module.client, - ttl: ttlTotal + ttl: ttl }); if (typeof callback === 'function') { diff --git a/src/views/admin/settings/user.tpl b/src/views/admin/settings/user.tpl index 440b34edbb..25de94b6d4 100644 --- a/src/views/admin/settings/user.tpl +++ b/src/views/admin/settings/user.tpl @@ -113,19 +113,18 @@
-
Session time +
+ Session time
- - - - +

Note that only one of these values will be used. If there is no seconds value we fall back to days. If + there is no days value we default to 14 days.

diff --git a/src/webserver.js b/src/webserver.js index 686451aef7..4e103d4a11 100644 --- a/src/webserver.js +++ b/src/webserver.js @@ -171,13 +171,11 @@ function setupFavicon(app) { function setupCookie() { var ttlDays = 1000 * 60 * 60 * 24 * (parseInt(meta.config.loginDays, 10) || 0); - var ttlHours = 1000 * 60 * 60 * (parseInt(meta.config.loginHours, 10) || 0); - var ttlMinutes = 1000 * 60 * (parseInt(meta.config.loginMinutes, 10) || 0); var ttlSeconds = 1000 * (parseInt(meta.config.loginSeconds, 10) || 0); - var ttlTotal = (ttlDays + ttlHours + ttlMinutes + ttlSeconds) || 1209600000; // Default to 14 days + var ttl = ttlSeconds || ttlDays || 1209600000; // Default to 14 days var cookie = { - maxAge: ttlTotal + maxAge: ttl }; if (nconf.get('cookieDomain') || meta.config.cookieDomain) {