From 9d45373b5938f190701e0c1cd49b9a2894c03980 Mon Sep 17 00:00:00 2001 From: dhingey Date: Wed, 9 Jul 2014 22:20:49 -0700 Subject: [PATCH] Change user.delete hook from action to filter The user.delete hook is now a filter, giving plugins a chance to access the user's data before it's deleted from Redis. --- docs/plugins/hooks.rst | 6 +++--- src/user/delete.js | 4 +++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/docs/plugins/hooks.rst b/docs/plugins/hooks.rst index 5d332b337d..b259952642 100644 --- a/docs/plugins/hooks.rst +++ b/docs/plugins/hooks.rst @@ -121,6 +121,9 @@ Executed when a post or signature needs to be parsed from raw text to HTML (for ``filter:user.create`` ^^^^^^^^^^^^^^^^^^^^^ +``filter:user.delete`` +^^^^^^^^^^^^^^^^^^^^^ + ``filter:user.profileLinks`` ^^^^^^^^^^^^^^^^^^^^^ @@ -225,9 +228,6 @@ Executed whenever a notification is pushed to a user. ``action:user.create`` ^^^^^^^^^^^^^^^^^^^^^ -``action:user.delete`` -^^^^^^^^^^^^^^^^^^^^^ - ``action:topic.delete`` ^^^^^^^^^^^^^^^^^^^^^ diff --git a/src/user/delete.js b/src/user/delete.js index b955104b37..a58e7f945f 100644 --- a/src/user/delete.js +++ b/src/user/delete.js @@ -106,13 +106,15 @@ module.exports = function(User) { }, function(next) { groups.leaveAllGroups(uid, next); + }, + function(next) { + plugins.fireHook('filter:user.delete', uid, next); } ], function(err) { if (err) { return callback(err); } - plugins.fireHook('action:user.delete', uid); async.parallel([ function(next) { db.delete('followers:' + uid, next);