From 96d2980472720dcf6d62d10cb04027b54337ef46 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <baris@nodebb.org>
Date: Thu, 3 May 2018 16:06:56 -0400
Subject: [PATCH] fix updrade error if file is not found closes #6485

---
 src/posts/uploads.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/posts/uploads.js b/src/posts/uploads.js
index 496ff9e068..04b5e954a4 100644
--- a/src/posts/uploads.js
+++ b/src/posts/uploads.js
@@ -73,9 +73,7 @@ module.exports = function (Posts) {
 
 	Posts.uploads.associate = function (pid, filePaths, callback) {
 		// Adds an upload to a post's sorted set of uploads
-		const now = Date.now();
 		filePaths = !Array.isArray(filePaths) ? [filePaths] : filePaths;
-		const scores = filePaths.map(() => now);
 
 		async.filter(filePaths, function (filePath, next) {
 			// Only process files that exist
@@ -83,10 +81,12 @@ module.exports = function (Posts) {
 				next(null, !err);
 			});
 		}, function (err, filePaths) {
-			let methods = [async.apply(db.sortedSetAdd.bind(db), 'post:' + pid + ':uploads', scores, filePaths)];
 			if (err) {
 				return callback(err);
 			}
+			const now = Date.now();
+			const scores = filePaths.map(() => now);
+			let methods = [async.apply(db.sortedSetAdd.bind(db), 'post:' + pid + ':uploads', scores, filePaths)];
 
 			methods = methods.concat(filePaths.map(path => async.apply(db.sortedSetAdd.bind(db), 'upload:' + md5(path) + ':pids', now, pid)));
 			async.parallel(methods, function (err) {