diff --git a/public/css/style.less b/public/css/style.less index df3a249ede..f8ceba625f 100644 --- a/public/css/style.less +++ b/public/css/style.less @@ -399,10 +399,12 @@ body .navbar .nodebb-inline-block { .icon-circle { font-size: 12px; color: green; + margin-right:3px; } .icon-circle-blank { font-size: 12px; color: red; + margin-right:3px; } } diff --git a/public/src/app.js b/public/src/app.js index 177a9f4f0a..3f325662b1 100644 --- a/public/src/app.js +++ b/public/src/app.js @@ -86,9 +86,11 @@ var socket, uid = el.parents('li').attr('data-uid'); if (uid && jQuery.inArray(uid, users) !== -1) { - el.prepend(' '); + el.find('i').remove(); + el.prepend(''); } else { - el.prepend(' '); + el.find('i').remove(); + el.prepend(''); } el.processed = true; @@ -208,17 +210,17 @@ var socket, } }; - app.process_page = function() { + app.populate_online_users = function() { + var uids = []; - function populate_online_users() { - var uids = []; + jQuery('.post-row').each(function() { + uids.push(this.getAttribute('data-uid')); + }); + + socket.emit('api:user.get_online_users', uids); + } - jQuery('.post-row').each(function() { - uids.push(this.getAttribute('data-uid')); - }); - - socket.emit('api:user.get_online_users', uids); - } + app.process_page = function() { // here is where all modules' onNavigate should be called, I think. require(['mobileMenu'], function(mobileMenu) { @@ -226,7 +228,7 @@ var socket, }); - populate_online_users(); + app.populate_online_users(); setTimeout(function() { window.scrollTo(0, 1); // rehide address bar on mobile after page load completes. diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js index 217f176b5c..5d7ed4226c 100644 --- a/public/src/forum/topic.js +++ b/public/src/forum/topic.js @@ -324,6 +324,8 @@ var activeEl = $('#thread_active_users'); if(activeEl.length) activeEl.html(data); + + app.populate_online_users(); }); socket.on('event:rep_up', function(data) { @@ -351,6 +353,7 @@ tempContainer.replaceWith(tempContainer.contents()); infiniteLoaderActive = false; + app.populate_online_users(); addCommasToNumbers(); }); diff --git a/public/templates/admin/index.tpl b/public/templates/admin/index.tpl index af5b04ba12..507cea020e 100644 --- a/public/templates/admin/index.tpl +++ b/public/templates/admin/index.tpl @@ -8,7 +8,7 @@ Get Themes dcplabs
-You are running NodeBB v0.0.1. This is where we will check to make sure your NodeBB is latest, etc.
+You are running NodeBB v{version}. This is where we will check to make sure your NodeBB is latest, etc.
diff --git a/src/routes/admin.js b/src/routes/admin.js index f2c00f6a48..38be4c3094 100644 --- a/src/routes/admin.js +++ b/src/routes/admin.js @@ -1,7 +1,8 @@ var user = require('./../user.js'), topics = require('./../topics.js'), - RDB = require('./../redis.js') + RDB = require('./../redis.js'), + pkg = require('./../../package.json'), categories = require('./../categories.js'); (function(Admin) { @@ -57,6 +58,9 @@ var user = require('./../user.js'), function api_method(req, res) { switch(req.params.method) { + case 'index': + res.json({version:pkg.version}); + break; case 'users' : if (req.params.tab == 'search') { res.json({search_display: 'block', users: []}); diff --git a/src/topics.js b/src/topics.js index 715122cc3e..1d8eef2f92 100644 --- a/src/topics.js +++ b/src/topics.js @@ -51,16 +51,15 @@ marked.setOptions({ } function addUserInfoToPosts(next) { - var done = 0; - - for(var i=0, ii=postData.length; i