From 91f0bce628a8ec1f87b23678b6e51286f105378b Mon Sep 17 00:00:00 2001 From: Julian Lam Date: Tue, 21 May 2019 12:23:19 -0400 Subject: [PATCH] fix: #7624, default open state on stateless flags --- src/flags.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/flags.js b/src/flags.js index c66b870464..97cd4b09e5 100644 --- a/src/flags.js +++ b/src/flags.js @@ -93,7 +93,9 @@ Flags.get = function (flagId, callback) { targetObj: async.apply(Flags.getTarget, data.base.type, data.base.targetId, 0), }, function (err, payload) { // Final object return construction - next(err, Object.assign(data.base, { + next(err, Object.assign({ + state: 'open', + }, data.base, { description: validator.escape(data.base.description), datetimeISO: utils.toISOString(data.base.datetime), target_readable: data.base.type.charAt(0).toUpperCase() + data.base.type.slice(1) + ' ' + data.base.targetId, @@ -179,7 +181,9 @@ Flags.list = function (filters, uid, callback) { async.apply(db.getObject, 'flag:' + flagId), function (flagObj, next) { user.getUserFields(flagObj.uid, ['username', 'picture'], function (err, userObj) { - next(err, Object.assign(flagObj, { + next(err, Object.assign({ + state: 'open', + }, flagObj, { reporter: { username: userObj.username, picture: userObj.picture,