From 8abf2835a50e9b74f8f611a0101930e0fc7a9021 Mon Sep 17 00:00:00 2001 From: psychobunny Date: Wed, 8 Oct 2014 17:06:35 -0400 Subject: [PATCH] removed modules/admin and moved mousetrap + keybindings out of client #2245 --- public/src/admin.js | 23 +++++++++++++++++++++-- public/src/app.js | 5 ----- public/src/modules/admin.js | 25 ------------------------- src/meta/js.js | 1 - src/views/admin/header.tpl | 1 + 5 files changed, 22 insertions(+), 33 deletions(-) delete mode 100644 public/src/modules/admin.js diff --git a/public/src/admin.js b/public/src/admin.js index 22eb108125..d206d7f627 100644 --- a/public/src/admin.js +++ b/public/src/admin.js @@ -4,7 +4,6 @@ var admin = {}; (function() { - admin.enableColorPicker = function(inputEl, callback) { (inputEl instanceof jQuery ? inputEl : $(inputEl)).each(function() { var $this = $(this); @@ -48,6 +47,8 @@ var admin = {}; activate(parentEl); } }); + + setupKeybindings(); }); socket.emit('admin.config.get', function(err, config) { @@ -63,5 +64,23 @@ var admin = {}; // move this to admin.config app.config = config; - }); + }); + + function setupKeybindings() { + Mousetrap.bind('ctrl+shift+a r', function() { + console.log('[admin] Reloading NodeBB...'); + socket.emit('admin.reload'); + }); + + Mousetrap.bind('ctrl+shift+a R', function() { + console.log('[admin] Restarting NodeBB...'); + socket.emit('admin.restart'); + }); + + Mousetrap.bind('/', function(e) { + $('#acp-search input').focus(); + + return false; + }); + } }()); \ No newline at end of file diff --git a/public/src/app.js b/public/src/app.js index cd1563da20..0e6a41fb3d 100644 --- a/public/src/app.js +++ b/public/src/app.js @@ -582,11 +582,6 @@ var socket, }); } }); - - // Admin keyboard shortcuts - require(['admin'], function(Admin) { - Admin.init(); - }); }); }; diff --git a/public/src/modules/admin.js b/public/src/modules/admin.js deleted file mode 100644 index cdcb25267d..0000000000 --- a/public/src/modules/admin.js +++ /dev/null @@ -1,25 +0,0 @@ -define('admin', ['mousetrap'], function(Mousetrap) { - var Admin= {}; - - Admin.init = function() { - if (app.isAdmin) { - Mousetrap.bind('ctrl+shift+a r', function() { - console.log('[admin] Reloading NodeBB...'); - socket.emit('admin.reload'); - }); - - Mousetrap.bind('ctrl+shift+a R', function() { - console.log('[admin] Restarting NodeBB...'); - socket.emit('admin.restart'); - }); - - Mousetrap.bind('/', function(e) { - $('#acp-search input').focus(); - - return false; - }); - } - }; - - return Admin; -}); \ No newline at end of file diff --git a/src/meta/js.js b/src/meta/js.js index aac6edc86c..6ee079a184 100644 --- a/src/meta/js.js +++ b/src/meta/js.js @@ -38,7 +38,6 @@ module.exports = function(Meta) { 'public/vendor/xregexp/xregexp.js', 'public/vendor/xregexp/unicode/unicode-base.js', 'public/vendor/buzz/buzz.min.js', - 'public/vendor/mousetrap/mousetrap.js', './node_modules/templates.js/lib/templates.js', 'public/src/utils.js', 'public/src/app.js', diff --git a/src/views/admin/header.tpl b/src/views/admin/header.tpl index 6c74399d6a..acebeae1d5 100644 --- a/src/views/admin/header.tpl +++ b/src/views/admin/header.tpl @@ -33,6 +33,7 @@ +