From 89e6c75d5839cc2cbb4c1b9501725ada537459fd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Mon, 11 Jan 2021 14:35:23 -0500 Subject: [PATCH] fix: #9185, fix string boolean values --- src/groups/update.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/groups/update.js b/src/groups/update.js index 0e34169660..bced8783df 100644 --- a/src/groups/update.js +++ b/src/groups/update.js @@ -24,10 +24,11 @@ module.exports = function (Groups) { values: values, })); - // Case some values as bool (if not boolean already) + // Cast some values as bool (if not boolean already) + // 'true' and '1' = true, everything else false ['userTitleEnabled', 'private', 'hidden', 'disableJoinRequests', 'disableLeave'].forEach((prop) => { if (values.hasOwnProperty(prop) && typeof values[prop] !== 'boolean') { - values[prop] = !!parseInt(values[prop], 10); + values[prop] = values[prop] === 'true' || parseInt(values[prop], 10) === 1; } });