From 82b2a20d0c427cffb884b78e82ae9dab694a8e3e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <baris@nodebb.org>
Date: Wed, 27 Jun 2018 12:15:38 -0400
Subject: [PATCH] user tests

---
 src/user.js  |  2 +-
 test/user.js | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 68 insertions(+), 1 deletion(-)

diff --git a/src/user.js b/src/user.js
index 9712f8063f..3b005d5572 100644
--- a/src/user.js
+++ b/src/user.js
@@ -274,7 +274,7 @@ User.getAdminsandGlobalMods = function (callback) {
 			], next);
 		},
 		function (results, next) {
-			User.getUsersData(_.union(results), next);
+			User.getUsersData(_.union.apply(_, results), next);
 		},
 	], callback);
 };
diff --git a/test/user.js b/test/user.js
index 116fe2811c..d3dfc1d359 100644
--- a/test/user.js
+++ b/test/user.js
@@ -575,6 +575,30 @@ describe('User', function () {
 				done();
 			});
 		});
+
+		it('should return 0 as uid if username is falsy', function (done) {
+			User.getUidByUsername('', function (err, uid) {
+				assert.ifError(err);
+				assert.strictEqual(uid, 0);
+				done();
+			});
+		});
+
+		it('should get username by userslug', function (done) {
+			User.getUsernameByUserslug('john-smith', function (err, username) {
+				assert.ifError(err);
+				assert.strictEqual('John Smith', username);
+				done();
+			});
+		});
+
+		it('should get uids by emails', function (done) {
+			User.getUidsByEmails(['john@example.com'], function (err, uids) {
+				assert.ifError(err);
+				assert.equal(uids[0], testUid);
+				done();
+			});
+		});
 	});
 
 	describe('not logged in', function () {
@@ -1907,4 +1931,47 @@ describe('User', function () {
 			});
 		});
 	});
+
+	it('should return offline if user is guest', function (done) {
+		var status = User.getStatus({ uid: 0 });
+		assert.strictEqual(status, 'offline');
+		done();
+	});
+
+	describe('isPrivilegedOrSelf', function () {
+		it('should return not error if self', function (done) {
+			User.isPrivilegedOrSelf(1, 1, function (err) {
+				assert.ifError(err);
+				done();
+			});
+		});
+
+		it('should not error if privileged', function (done) {
+			User.create({ username: 'theadmin' }, function (err, uid) {
+				assert.ifError(err);
+				groups.join('administrators', uid, function (err) {
+					assert.ifError(err);
+					User.isPrivilegedOrSelf(uid, 2, function (err) {
+						assert.ifError(err);
+						done();
+					});
+				});
+			});
+		});
+
+		it('should error if not privileged', function (done) {
+			User.isPrivilegedOrSelf(0, 1, function (err) {
+				assert.equal(err.message, '[[error:no-privileges]]');
+				done();
+			});
+		});
+	});
+
+	it('should get admins and mods', function (done) {
+		User.getAdminsandGlobalMods(function (err, data) {
+			assert.ifError(err);
+			assert(Array.isArray(data));
+			done();
+		});
+	});
 });