From 7c1a46f25db8874a8bef4a94f59ed0718b9997dc Mon Sep 17 00:00:00 2001 From: Baris Soner Usakli Date: Tue, 25 Feb 2014 14:41:14 -0500 Subject: [PATCH] misc cleanup --- src/topics.js | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/topics.js b/src/topics.js index dbf370f645..05d12787b8 100644 --- a/src/topics.js +++ b/src/topics.js @@ -958,9 +958,7 @@ var async = require('async'), return callback(null, []); } - async.map(tids, function(tid, next) { - Topics.getTeaser(tid, next); - }, callback); + async.map(tids, Topics.getTeaser, callback) }; Topics.getTeaser = function(tid, callback) { @@ -1039,7 +1037,7 @@ var async = require('async'), Topics.isLocked = function(tid, callback) { Topics.getTopicField(tid, 'locked', function(err, locked) { if(err) { - return callback(err, null); + return callback(err); } callback(null, parseInt(locked, 10) === 1); }); @@ -1074,16 +1072,18 @@ var async = require('async'), function getUid(pid, next) { posts.getPostField(pid, 'uid', function(err, uid) { - if (err) + if (err) { return next(err); + } uids[uid] = 1; - next(null); + next(); }); } async.each(pids, getUid, function(err) { - if (err) - return callback(err, null); + if (err) { + return callback(err); + } callback(null, Object.keys(uids)); });