From aae393ebe13b3a3a4a53c22143f71416fea3180b Mon Sep 17 00:00:00 2001 From: barisusakli Date: Wed, 28 Oct 2015 15:06:19 -0400 Subject: [PATCH 1/3] closes #3794 --- public/src/client/topic.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/public/src/client/topic.js b/public/src/client/topic.js index faaaddbf00..c216943e32 100644 --- a/public/src/client/topic.js +++ b/public/src/client/topic.js @@ -18,6 +18,11 @@ define('forum/topic', [ currentUrl = ''; $(window).on('action:ajaxify.start', function(ev, data) { + if (Topic.replaceURLTimeout) { + clearTimeout(Topic.replaceURLTimeout); + Topic.replaceURLTimeout = 0; + } + if (ajaxify.currentPage !== data.url) { navigator.disable(); components.get('navbar/title').find('span').text('').hide(); From 47c71b5a372bd210200557ab1eeaea3afdac7ec2 Mon Sep 17 00:00:00 2001 From: barisusakli Date: Wed, 28 Oct 2015 15:10:27 -0400 Subject: [PATCH 2/3] closes https://github.com/NodeBB/nodebb-theme-persona/issues/181 --- src/privileges/categories.js | 3 +++ src/socket.io/posts/tools.js | 5 +---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/privileges/categories.js b/src/privileges/categories.js index 31d1deeeb3..d51edbb9a8 100644 --- a/src/privileges/categories.js +++ b/src/privileges/categories.js @@ -191,6 +191,9 @@ module.exports = function(privileges) { }; privileges.categories.isAdminOrMod = function(cid, uid, callback) { + if (!parseInt(uid, 10)) { + return callback(null, false); + } helpers.some([ function (next) { user.isModerator(uid, cid, next); diff --git a/src/socket.io/posts/tools.js b/src/socket.io/posts/tools.js index fc4491ea44..d05c2b74be 100644 --- a/src/socket.io/posts/tools.js +++ b/src/socket.io/posts/tools.js @@ -13,9 +13,6 @@ var favourites = require('../../favourites'); module.exports = function(SocketPosts) { SocketPosts.loadPostTools = function(socket, data, callback) { - if (!socket.uid) { - return; - } if (!data) { return callback(new Error('[[error:invalid-data]]')) } @@ -37,7 +34,7 @@ module.exports = function(SocketPosts) { results.posts.tools = []; // TODO: add filter for this results.posts.deleted = parseInt(results.posts.deleted, 10) === 1; results.posts.favourited = results.favourited[0]; - results.posts.selfPost = socket.uid === parseInt(results.posts.uid, 10); + results.posts.selfPost = socket.uid && socket.uid === parseInt(results.posts.uid, 10); results.posts.display_moderator_tools = results.isAdminOrMod || results.posts.selfPost; results.posts.display_move_tools = results.isAdminOrMod; callback(null, results); From 887358f045a51e57196ccb0212ee1410ce86a836 Mon Sep 17 00:00:00 2001 From: barisusakli Date: Wed, 28 Oct 2015 15:16:14 -0400 Subject: [PATCH 3/3] closes #3784 --- public/src/client/topic/events.js | 1 + public/src/client/topic/posts.js | 10 +++++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/public/src/client/topic/events.js b/public/src/client/topic/events.js index 7dfe57beed..7e04a5ffae 100644 --- a/public/src/client/topic/events.js +++ b/public/src/client/topic/events.js @@ -118,6 +118,7 @@ define('forum/topic/events', [ editedPostEl.html(data.post.content); editedPostEl.find('img:not(.not-responsive)').addClass('img-responsive'); app.replaceSelfLinks(editedPostEl.find('a')); + posts.wrapImagesInLinks(editedPostEl.parent()); editedPostEl.fadeIn(250); $(window).trigger('action:posts.edited', data); }); diff --git a/public/src/client/topic/posts.js b/public/src/client/topic/posts.js index 02fdfbc26f..89c9e70e1d 100644 --- a/public/src/client/topic/posts.js +++ b/public/src/client/topic/posts.js @@ -217,15 +217,19 @@ define('forum/topic/posts', [ utils.addCommasToNumbers(posts.find('.formatted-number')); utils.makeNumbersHumanReadable(posts.find('.human-readable-number')); posts.find('.timeago').timeago(); + Posts.wrapImagesInLinks(posts); + + addBlockquoteEllipses(posts.find('[component="post/content"] > blockquote > blockquote')); + hidePostToolsForDeletedPosts(posts); + }; + + Posts.wrapImagesInLinks = function(posts) { posts.find('[component="post/content"] img:not(.emoji)').each(function() { var $this = $(this); if (!$this.parent().is('a')) { $this.wrap(''); } }); - - addBlockquoteEllipses(posts.find('[component="post/content"] > blockquote > blockquote')); - hidePostToolsForDeletedPosts(posts); }; Posts.showBottomPostBar = function() {