From fb45aa92fd54737dfb7a0737a380363b8578a7aa Mon Sep 17 00:00:00 2001 From: Evan Lucas Date: Fri, 29 Aug 2014 06:48:22 -0500 Subject: [PATCH 1/2] Add upvote hook adhere to similar project style --- src/favourites.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/favourites.js b/src/favourites.js index c887c5c7e7..ecc61045c3 100644 --- a/src/favourites.js +++ b/src/favourites.js @@ -3,6 +3,7 @@ var async = require('async'), db = require('./database'), posts = require('./posts'), user = require('./user'), + plugins = require('./plugins'), meta = require('./meta'); (function (Favourites) { @@ -102,7 +103,14 @@ var async = require('async'), return callback(false); } - toggleVote('upvote', pid, uid, callback); + toggleVote('upvote', pid, uid, function(err, votes) { + if (err) return callback(err); + plugins.fireHook('action:upvote.post', { + pid: pid, + uid: uid + }); + callback(null, votes); + }); }; Favourites.downvote = function(pid, uid, callback) { From 440c78c949cef10aa65d967795a4a5b8eb2dc004 Mon Sep 17 00:00:00 2001 From: Evan Lucas Date: Tue, 2 Sep 2014 13:26:56 -0500 Subject: [PATCH 2/2] match `object.action` nomenclature --- src/favourites.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/favourites.js b/src/favourites.js index ecc61045c3..e2edc36c4f 100644 --- a/src/favourites.js +++ b/src/favourites.js @@ -105,7 +105,7 @@ var async = require('async'), toggleVote('upvote', pid, uid, function(err, votes) { if (err) return callback(err); - plugins.fireHook('action:upvote.post', { + plugins.fireHook('action:post.upvote', { pid: pid, uid: uid });