From 747cb1f0a196920bed0d4a0f87ced7d87a065c62 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Wed, 18 Jan 2023 09:40:00 -0500 Subject: [PATCH] fix: closes #11173, clear require cache if wrong dependency is installed --- src/cli/index.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/cli/index.js b/src/cli/index.js index 938f588701..5eb9f4924c 100644 --- a/src/cli/index.js +++ b/src/cli/index.js @@ -32,6 +32,12 @@ try { if (!semver.satisfies(version, defaultPackage.dependencies[packageName])) { const e = new TypeError(`Incorrect dependency version: ${packageName}`); e.code = 'DEP_WRONG_VERSION'; + // delete the module from require cache so it doesn't break rest of the upgrade + // https://github.com/NodeBB/NodeBB/issues/11173 + const resolvedModule = require.resolve(packageName); + if (require.cache[resolvedModule]) { + delete require.cache[resolvedModule]; + } throw e; } };