diff --git a/public/src/admin/manage/users.js b/public/src/admin/manage/users.js index 11bbf95b7b..0cf21718d7 100644 --- a/public/src/admin/manage/users.js +++ b/public/src/admin/manage/users.js @@ -347,7 +347,7 @@ define('admin/manage/users', [ }); function handleUserCreate() { - $('#createUser').on('click', function () { + $('[data-action="create"]').on('click', function () { Benchpress.parse('admin/partials/create_user_modal', {}, function (html) { var modal = bootbox.dialog({ message: html, diff --git a/src/controllers/admin/users.js b/src/controllers/admin/users.js index 722d5df0bd..79e023db55 100644 --- a/src/controllers/admin/users.js +++ b/src/controllers/admin/users.js @@ -22,11 +22,11 @@ usersController.index = async function (req, res) { if (req.query.query) { await usersController.search(req, res); } else { - await newGet(req, res); + await getUsers(req, res); } }; -async function newGet(req, res) { +async function getUsers(req, res) { const sortDirection = req.query.sortDirection || 'desc'; const reverse = sortDirection === 'desc'; @@ -35,7 +35,7 @@ async function newGet(req, res) { if (![50, 100, 250, 500].includes(resultsPerPage)) { resultsPerPage = 50; } - const sortBy = validator.escape(req.query.sortBy || 'joindate'); + let sortBy = validator.escape(req.query.sortBy || ''); const filterBy = Array.isArray(req.query.filter) ? req.query.filter : [req.query.filter]; const start = Math.max(0, page - 1) * resultsPerPage; const stop = start + resultsPerPage - 1; @@ -49,13 +49,20 @@ async function newGet(req, res) { flags: 'users:flags', }; - const set = [sortToSet[sortBy] || 'users:joindate']; + const set = []; + if (sortBy) { + set.push(sortToSet[sortBy]); + } if (filterBy.includes('notvalidated')) { set.push('users:notvalidated'); } if (filterBy.includes('banned')) { set.push('users:banned'); } + if (!set.length) { + set.push('users:online'); + sortBy = 'online'; + } return set.length > 1 ? set : set[0]; } diff --git a/src/views/admin/manage/users.tpl b/src/views/admin/manage/users.tpl index fb05acb7b8..68b479875d 100644 --- a/src/views/admin/manage/users.tpl +++ b/src/views/admin/manage/users.tpl @@ -2,31 +2,24 @@
- - - - - [[admin/manage/users:download-csv]] -
- - +
+ +
+ + +

@@ -95,10 +95,9 @@ {users.username} - - - {users.email} + + {users.email} {users.postcount} {users.reputation} {users.flags}0 @@ -114,3 +113,7 @@
+ + \ No newline at end of file diff --git a/src/views/admin/partials/create_user_modal.tpl b/src/views/admin/partials/create_user_modal.tpl index 2e6505e81c..ece62fc7f0 100644 --- a/src/views/admin/partials/create_user_modal.tpl +++ b/src/views/admin/partials/create_user_modal.tpl @@ -1,4 +1,4 @@ -
+