From e1758e0c36243505febdba4803390d569d347ca6 Mon Sep 17 00:00:00 2001 From: barisusakli Date: Sun, 23 Nov 2014 00:30:19 -0500 Subject: [PATCH 1/3] closes #2449 --- public/src/client/account/edit.js | 27 ++++++++++++++++++++------- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/public/src/client/account/edit.js b/public/src/client/account/edit.js index a99c6c448f..a6ea023473 100644 --- a/public/src/client/account/edit.js +++ b/public/src/client/account/edit.js @@ -55,7 +55,6 @@ define('forum/account/edit', ['forum/account/header', 'uploader'], function(head if (data.picture) { $('#user-current-picture').attr('src', data.picture); - $('#user_label img').attr('src', data.picture); } if (data.gravatarpicture) { @@ -70,20 +69,34 @@ define('forum/account/edit', ['forum/account/header', 'uploader'], function(head }); $('.account-username-box').attr('data-userslug', data.userslug); - - $('#user-profile-link').attr('href', config.relative_path + '/user/' + data.userslug); - $('#user-header-name').text(userData.username); } if (currentEmail !== data.email) { currentEmail = data.email; $('#confirm-email').removeClass('hide'); } + + updateHeader(data.picture, data.username, data.userslug); }); return false; } + function updateHeader(picture, username, userslug) { + if (parseInt(ajaxify.variables.get('theirid'), 10) !== parseInt(ajaxify.variables.get('yourid'), 10)) { + return; + } + + if (picture) { + $('#user-header-picture').attr('src', picture); + } + + if (username && userslug) { + $('#user-profile-link').attr('href', config.relative_path + '/user/' + userslug); + $('#user-header-name').text(username); + } + } + function handleImageChange() { function selectImageType(type) { $('#gravatar-box .fa-check').toggle(type === 'gravatar'); @@ -117,10 +130,10 @@ define('forum/account/edit', ['forum/account/header', 'uploader'], function(head if (selectedImageType === 'gravatar') { $('#user-current-picture').attr('src', gravatarPicture); - $('#user-header-picture').attr('src', gravatarPicture); + updateHeader(gravatarPicture); } else if (selectedImageType === 'uploaded') { $('#user-current-picture').attr('src', uploadedPicture); - $('#user-header-picture').attr('src', uploadedPicture); + updateHeader(uploadedPicture); } } }); @@ -156,7 +169,7 @@ define('forum/account/edit', ['forum/account/header', 'uploader'], function(head $('#user-current-picture').attr('src', urlOnServer); $('#user-uploaded-picture').attr('src', urlOnServer); - $('#user-header-picture').attr('src', urlOnServer); + updateHeader(urlOnServer); uploadedPicture = urlOnServer; } From 1ea295ed1b773e6d3c2069f31bd740d8d0e23473 Mon Sep 17 00:00:00 2001 From: barisusakli Date: Sun, 23 Nov 2014 00:31:37 -0500 Subject: [PATCH 2/3] #2449 --- public/src/client/account/edit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/public/src/client/account/edit.js b/public/src/client/account/edit.js index a6ea023473..a203efb1d2 100644 --- a/public/src/client/account/edit.js +++ b/public/src/client/account/edit.js @@ -76,7 +76,7 @@ define('forum/account/edit', ['forum/account/header', 'uploader'], function(head $('#confirm-email').removeClass('hide'); } - updateHeader(data.picture, data.username, data.userslug); + updateHeader(data.picture, userData.username, data.userslug); }); return false; From 7daf3a34a7039781e1be0df6e070be706fcf65ae Mon Sep 17 00:00:00 2001 From: barisusakli Date: Sun, 23 Nov 2014 00:32:31 -0500 Subject: [PATCH 3/3] removed slice --- src/categories/activeusers.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/categories/activeusers.js b/src/categories/activeusers.js index 8f3fd1fd54..1719b8b9d8 100644 --- a/src/categories/activeusers.js +++ b/src/categories/activeusers.js @@ -19,7 +19,7 @@ module.exports = function(Categories) { return post.uid; }).filter(function(uid, index, array) { return parseInt(uid, 10) !== 0 && array.indexOf(uid) === index; - }).slice(0, 24); + }); next(null, uids); }