From cf39c660173a976bbd1f4a883c8a772daac92801 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Fri, 24 Jan 2014 13:27:36 -0500
Subject: [PATCH 01/28] some pagination work

---
 public/src/app.js                   |  4 ++++
 public/src/forum/topic.js           | 28 ++++++++++++++++++++--------
 public/templates/admin/settings.tpl | 16 ++++++++++++++++
 public/templates/topic.tpl          |  7 +++++++
 src/routes/api.js                   | 24 +++++++++++++++---------
 5 files changed, 62 insertions(+), 17 deletions(-)

diff --git a/public/src/app.js b/public/src/app.js
index bc583e2b17..c6ad9c7305 100644
--- a/public/src/app.js
+++ b/public/src/app.js
@@ -528,6 +528,10 @@ var socket,
 		});
 
 		templates.setGlobal('relative_path', RELATIVE_PATH);
+		templates.setGlobal('usePagination', config.usePagination);
+		templates.setGlobal('topicsPerPage', config.topicsPerPage);
+		templates.setGlobal('postsPerPage', config.postsPerPage);
+		console.log(templates.globals);
 	});
 
 	showWelcomeMessage = location.href.indexOf('loggedin') !== -1;
diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js
index a48d8c82cf..62ded4c4ce 100644
--- a/public/src/forum/topic.js
+++ b/public/src/forum/topic.js
@@ -355,15 +355,27 @@ define(['composer'], function(composer) {
 		});
 
 		function enableInfiniteLoading() {
-			$(window).off('scroll').on('scroll', function() {
-				var bottom = ($(document).height() - $(window).height()) * 0.9;
+			if(!config.usePagination) {
+				$(window).off('scroll').on('scroll', function() {
+					var bottom = ($(document).height() - $(window).height()) * 0.9;
 
-				if ($(window).scrollTop() > bottom && !infiniteLoaderActive && $('#post-container').children().length) {
-					loadMorePosts(tid, function(posts) {
-						fixDeleteStateForPosts();
-					});
-				}
-			});
+					if ($(window).scrollTop() > bottom && !infiniteLoaderActive && $('#post-container').children().length) {
+						loadMorePosts(tid, function(posts) {
+							fixDeleteStateForPosts();
+						});
+					}
+				});
+			} else {
+				$('.pagination .previous').on('click', function() {
+
+					return false;
+				});
+
+				$('.pagination .next').on('click', function() {
+
+					return false;
+				});
+			}
 		}
 
 		$('.topic').on('click', '.post_reply', function() {
diff --git a/public/templates/admin/settings.tpl b/public/templates/admin/settings.tpl
index 8ddd896da9..3601f7c2ca 100644
--- a/public/templates/admin/settings.tpl
+++ b/public/templates/admin/settings.tpl
@@ -7,6 +7,7 @@
 	<li><a href="#email" data-toggle="tab">Email</a></li>
 	<li><a href="#user" data-toggle="tab">User</a></li>
 	<li><a href="#post" data-toggle="tab">Post</a></li>
+	<li><a href="#pagination" data-toggle="tab">Pagination</a></li>
 	<li><a href="#web-crawler" data-toggle="tab">Web Crawler</a></li>
 </ul>
 
@@ -133,6 +134,21 @@
 		</form>
 	</div>
 
+	<div class="tab-pane" id="pagination">
+		<form>
+			<div class="alert alert-warning">
+				<div class="checkbox">
+					<label>
+						<input type="checkbox" data-field="usePagination"> <strong>Paginate topics and posts instead of using infinite scroll.</strong>
+					</label>
+				</div>
+
+				<strong>Topics per Page</strong><br /> <input type="text" class="form-control" value="20" data-field="topicsPerPage"><br />
+				<strong>Posts per Page</strong><br /> <input type="text" class="form-control" value="20" data-field="postsPerPage"><br />
+			</div>
+		</form>
+	</div>
+
 	<div class="tab-pane" id="web-crawler">
 		<form>
 			<div class="alert alert-warning">
diff --git a/public/templates/topic.tpl b/public/templates/topic.tpl
index ec72ff958b..1aabe3c8c0 100644
--- a/public/templates/topic.tpl
+++ b/public/templates/topic.tpl
@@ -201,6 +201,13 @@
 		<div style="clear:both;"></div>
 	</div>
 
+	<!-- {usePagination} -->
+	<ul class="pager">
+		<li class="previous"><a href="#">&larr; Older</a></li>
+		<li class="next"><a href="#">Newer &rarr;</a></li>
+	</ul>
+	<!-- {usePagination} -->
+
 	<div id="move_thread_modal" class="modal" tabindex="-1" role="dialog" aria-labelledby="Move Topic" aria-hidden="true">
 		<div class="modal-dialog">
 			<div class="modal-content">
diff --git a/src/routes/api.js b/src/routes/api.js
index 78c7e6f8ac..3d1fb270df 100644
--- a/src/routes/api.js
+++ b/src/routes/api.js
@@ -42,6 +42,9 @@ var path = require('path'),
 				config.useOutgoingLinksPage = parseInt(meta.config.useOutgoingLinksPage, 10) === 1;
 				config.allowGuestPosting = parseInt(meta.config.allowGuestPosting, 10) === 1;
 				config.allowFileUploads = parseInt(meta.config.allowFileUploads, 10) === 1;
+				config.usePagination = parseInt(meta.config.usePagination, 10) === 1;
+				config.topicsPerPage = meta.config.topicsPerPage || 20;
+				config.postsPerPage = meta.config.postsPerPage || 20;
 				config.maximumFileSize = meta.config.maximumFileSize;
 				config.emailSetup = !!meta.config['email:from'];
 				config.defaultLang = meta.config.defaultLang || 'en';
@@ -161,20 +164,23 @@ var path = require('path'),
 			});
 
 			app.get('/topic/:id/:slug?', function (req, res, next) {
+				console.log(req.query);
 				var uid = (req.user) ? req.user.uid : 0;
 				ThreadTools.privileges(req.params.id, uid, function(err, privileges) {
 					if (privileges.read) {
-						topics.getTopicWithPosts(req.params.id, uid, 0, 10, false, function (err, data) {
-							if (!err) {
-								// Send in privilege data as well
-								data.privileges = privileges;
+						var postsPerPage = meta.config.postsPerPage ? (meta.config.postsPerPage - 1) : 20;
+						topics.getTopicWithPosts(req.params.id, uid, 0, postsPerPage, false, function (err, data) {
+							if(err) {
+								return next(err);
+							}
 
-								if (parseInt(data.deleted, 10) === 1 && parseInt(data.expose_tools, 10) === 0) {
-									return res.json(404, {});
-								}
+							data.privileges = privileges;
 
-								res.json(data);
-							} else next();
+							if (parseInt(data.deleted, 10) === 1 && parseInt(data.expose_tools, 10) === 0) {
+								return res.json(404, {});
+							}
+
+							res.json(data);
 						});
 					} else {
 						res.send(403);

From 606367701fd59f632709e7b10163112e3e3cb488 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Fri, 24 Jan 2014 20:00:56 -0500
Subject: [PATCH 02/28] pagination on posts

---
 public/src/app.js         |   1 -
 public/src/forum/topic.js | 142 +++++++++++++++++++++++++++++++++-----
 src/database/mongo.js     |  13 ++++
 src/database/redis.js     |   4 ++
 src/routes/api.js         |   7 +-
 src/routes/debug.js       |   8 ++-
 src/socket.io/topics.js   |  38 +++++++++-
 src/topics.js             |  51 +++++++++++---
 8 files changed, 232 insertions(+), 32 deletions(-)

diff --git a/public/src/app.js b/public/src/app.js
index c6ad9c7305..3f9f33e152 100644
--- a/public/src/app.js
+++ b/public/src/app.js
@@ -531,7 +531,6 @@ var socket,
 		templates.setGlobal('usePagination', config.usePagination);
 		templates.setGlobal('topicsPerPage', config.topicsPerPage);
 		templates.setGlobal('postsPerPage', config.postsPerPage);
-		console.log(templates.globals);
 	});
 
 	showWelcomeMessage = location.href.indexOf('loggedin') !== -1;
diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js
index 62ded4c4ce..e972ee11ae 100644
--- a/public/src/forum/topic.js
+++ b/public/src/forum/topic.js
@@ -17,7 +17,9 @@ define(['composer'], function(composer) {
 				deleted: templates.get('deleted'),
 				pinned: templates.get('pinned')
 			},
-			topic_name = templates.get('topic_name');
+			topic_name = templates.get('topic_name'),
+			currentPage = parseInt(templates.get('currentPage'), 10),
+			pageCount = parseInt(templates.get('pageCount'), 10);
 
 
 		function fixDeleteStateForPosts() {
@@ -323,14 +325,10 @@ define(['composer'], function(composer) {
 
 			var bookmark = localStorage.getItem('topic:' + tid + ':bookmark');
 
-			if(bookmark) {
+			if(bookmark && !config.usePagination) {
 				Topic.scrollToPost(parseInt(bookmark, 10));
 			}
 
-			$('#post-container').on('click', '.deleted', function(ev) {
-				$(this).toggleClass('deleted-expanded');
-			});
-
 			// Show the paginator block, now that the DOM has finished loading
 			(function delayedHeaderUpdate() {
 				if (!Topic.postCount) {
@@ -366,18 +364,129 @@ define(['composer'], function(composer) {
 					}
 				});
 			} else {
-				$('.pagination .previous').on('click', function() {
+				$('.pagination-block').addClass('hide');
+				updatePageLinks();
 
-					return false;
+				$('.pagination').on('click', '.previous', function() {
+					loadPage(currentPage - 1);
 				});
 
-				$('.pagination .next').on('click', function() {
+				$('.pagination').on('click', '.next', function() {
+					loadPage(currentPage + 1);
+				});
 
-					return false;
+				$('.pagination').on('click', '.page', function() {
+					loadPage($(this).attr('data-page'));
 				});
 			}
 		}
 
+		function updatePageLinks() {
+			$('.pagination .next').removeClass('disabled');
+			$('.pagination .previous').removeClass('disabled');
+
+			if(currentPage === 1) {
+				$('.pagination .previous').addClass('disabled');
+			}
+
+			if(currentPage === parseInt($('.pagination').attr('data-pageCount'), 10)) {
+				$('.pagination .next').addClass('disabled');
+			}
+
+			$('.pagination .page').removeClass('active');
+			$('.pagination .page[data-page="' + currentPage + '"]').addClass('active');
+		}
+
+		function loadPage(page) {
+			page = parseInt(page, 10);
+			if(page < 1 || page > pageCount) {
+				return;
+			}
+
+			socket.emit('topics.loadPage', {tid: tid, page: page}, function(err, data) {
+				if(err) {
+					return app.alertError(err.message);
+				}
+				currentPage = page;
+
+				if (data && data.posts && data.posts.length) {
+					createPagePosts(data, function() {
+						fixDeleteStateForPosts();
+					});
+				}
+
+				updatePageLinks();
+			});
+		}
+
+		function onNewPostPagination(data) {
+			var posts = data.posts;
+			socket.emit('topics.getPageCount', tid, function(err, newPageCount) {
+
+				pageCount = newPageCount;
+				recreatePaginationLinks();
+				if(currentPage === newPageCount) {
+					createNewPosts(data);
+				} else if(data.posts && data.posts.length && parseInt(data.posts[0].uid, 10) === parseInt(app.uid, 10)) {
+					loadPage(pageCount);
+				}
+			});
+
+		}
+
+		function recreatePaginationLinks() {
+			var pages = [];
+			for(var i=1; i<=pageCount; ++i) {
+				pages.push({pageNumber: i});
+			}
+			var html = templates.prepare(templates['topic'].blocks['pages']).parse({pages:pages});
+			html = $(html);
+			$('.pagination li.page').remove();
+			html.insertAfter($('.pagination li.previous'));
+			updatePageLinks();
+		}
+
+		function createPagePosts(data, callback) {
+			if(!data || (data.posts && !data.posts.length)) {
+				return;
+			}
+
+			var html = templates.prepare(templates['topic'].blocks['posts']).parse(data);
+			var regexp = new RegExp("<!--[\\s]*IF @first[\\s]*-->([\\s\\S]*?)<!--[\\s]*ENDIF @first[\\s]*-->", 'g');
+			html = html.replace(regexp, '');
+
+			translator.translate(html, function(translatedHTML) {
+				var translated = $(translatedHTML);
+
+				$('#post-container').fadeOut(function() {
+
+					$(this).empty();
+					translated.appendTo($(this));
+					$(this).fadeIn('slow');
+
+					for (var x = 0, numPosts = data.posts.length; x < numPosts; x++) {
+						socket.emit('posts.getPrivileges', data.posts[x].pid, function(err, privileges) {
+							if(err) {
+								return app.alertError(err.message);
+							}
+							toggle_mod_tools(privileges.pid, privileges.editable);
+						});
+					}
+
+					app.populateOnlineUsers();
+					app.createUserTooltips();
+					app.addCommasToNumbers();
+					$('span.timeago').timeago();
+					$('.post-content img').addClass('img-responsive');
+					updatePostCount();
+					showBottomPostBar();
+
+					callback();
+				});
+			});
+		}
+
+
 		$('.topic').on('click', '.post_reply', function() {
 			var selectionText = '',
 				selection = window.getSelection() || document.getSelection();
@@ -653,6 +762,11 @@ define(['composer'], function(composer) {
 		});
 
 		socket.on('event:new_post', function(data) {
+			if(config.usePagination) {
+				onNewPostPagination(data);
+				return;
+			}
+
 			var posts = data.posts;
 			for (var p in posts) {
 				if (posts.hasOwnProperty(p)) {
@@ -926,11 +1040,8 @@ define(['composer'], function(composer) {
 						}
 					}
 
-					if (privileges.view_deleted) {
-						postEl.toggleClass('deleted');
-					} else {
-						postEl.toggleClass('none');
-					}
+					postEl.toggleClass('deleted');
+
 					updatePostCount();
 				});
 			}
@@ -1162,7 +1273,6 @@ define(['composer'], function(composer) {
 			return;
 		}
 
-
 		if (indicatorEl.attr('done') === '0') {
 			infiniteLoaderActive = true;
 			indicatorEl.fadeIn();
diff --git a/src/database/mongo.js b/src/database/mongo.js
index 3b653a1693..59fbc41b5a 100644
--- a/src/database/mongo.js
+++ b/src/database/mongo.js
@@ -626,6 +626,19 @@
 		});
 	}
 
+	module.sortedSetCard = function(key, callback) {
+		db.collection('objects').count({_key:key}, function(err, count) {
+			if(err) {
+				return callback(err);
+			}
+
+			if(!count) {
+				return callback(null, 0);
+			}
+			callback(null, count);
+		});
+	}
+
 	module.sortedSetRank = function(key, value, callback) {
 		if(value !== null && value !== undefined) {
 			value = value.toString();
diff --git a/src/database/redis.js b/src/database/redis.js
index 6af259f9ca..de4802456c 100644
--- a/src/database/redis.js
+++ b/src/database/redis.js
@@ -374,6 +374,10 @@
 		redisClient.zcount(key, min, max, callback);
 	}
 
+	module.sortedSetCard = function(key, callback) {
+		redisClient.zcard(key, callback);
+	}
+
 	module.sortedSetRank = function(key, value, callback) {
 		redisClient.zrank(key, value, callback);
 	}
diff --git a/src/routes/api.js b/src/routes/api.js
index 3d1fb270df..ca5c63fd6f 100644
--- a/src/routes/api.js
+++ b/src/routes/api.js
@@ -166,14 +166,15 @@ var path = require('path'),
 			app.get('/topic/:id/:slug?', function (req, res, next) {
 				console.log(req.query);
 				var uid = (req.user) ? req.user.uid : 0;
+
 				ThreadTools.privileges(req.params.id, uid, function(err, privileges) {
 					if (privileges.read) {
-						var postsPerPage = meta.config.postsPerPage ? (meta.config.postsPerPage - 1) : 20;
-						topics.getTopicWithPosts(req.params.id, uid, 0, postsPerPage, false, function (err, data) {
+						var postsPerPage = parseInt(meta.config.postsPerPage ? meta.config.postsPerPage : 20, 10);
+						topics.getTopicWithPosts(req.params.id, uid, 0, postsPerPage - 1, false, function (err, data) {
 							if(err) {
 								return next(err);
 							}
-
+							data.currentPage = 1;
 							data.privileges = privileges;
 
 							if (parseInt(data.deleted, 10) === 1 && parseInt(data.expose_tools, 10) === 0) {
diff --git a/src/routes/debug.js b/src/routes/debug.js
index db55f82258..b2a6e5c335 100644
--- a/src/routes/debug.js
+++ b/src/routes/debug.js
@@ -74,7 +74,13 @@ var	DebugRoute = function(app) {
 		});
 
 		app.get('/test', function(req, res) {
-			res.send();
+
+			/*topics.getTopicPosts2(2, 0, 10, 5, function(err, data) {
+				res.json(data);
+			})*/
+			topics.getTopicWithPosts(2, 1, 0, -1, true, function (err, topicData) {
+				res.json(topicData);
+			});
 		});
 
 	});
diff --git a/src/socket.io/topics.js b/src/socket.io/topics.js
index dc39ca209a..3a45f1293e 100644
--- a/src/socket.io/topics.js
+++ b/src/socket.io/topics.js
@@ -230,14 +230,46 @@ SocketTopics.loadMore = function(socket, data, callback) {
 		return callback(new Error('invalid data'));
 	}
 
+	var postsPerPage = parseInt(meta.config.postsPerPage, 10);
+	postsPerPage = postsPerPage ? postsPerPage : 20;
+
 	var start = data.after,
-		end = start + 9;
+		end = start + postsPerPage - 1;
 
 	topics.getTopicPosts(data.tid, start, end, socket.uid, function(err, posts) {
+		if(err) {
+			return callback(err);
+		}
+
 		callback(err, {posts: posts});
 	});
 };
 
+SocketTopics.loadPage = function(socket, data, callback) {
+	if(!data || !data.tid || !data.page || parseInt(data.page < 0)) {
+		return callback(new Error('invalid data'));
+	}
+
+	var postsPerPage = parseInt((meta.config.postsPerPage ? meta.config.postsPerPage : 20), 10);
+
+	topics.getPageCount(data.tid, function(err, pageCount) {
+		if(err) {
+			return callback(err);
+		}
+
+		if(data.page > pageCount) {
+			return callback(new Error('page doesn\'t exist'));
+		}
+
+		var start = (data.page-1) * postsPerPage,
+			end = start + postsPerPage - 1;
+
+		topics.getTopicPosts(data.tid, start, end, socket.uid, function(err, posts) {
+			callback(err, {posts: posts});
+		});
+	});
+}
+
 SocketTopics.loadMoreRecentTopics = function(socket, data, callback) {
 	if(!data || !data.term) {
 		return callback(new Error('invalid data'));
@@ -256,4 +288,8 @@ SocketTopics.loadMoreUnreadTopics = function(socket, data, callback) {
 	topics.getUnreadTopics(socket.uid, start, end, callback);
 };
 
+SocketTopics.getPageCount = function(socket, tid, callback) {
+	topics.getPageCount(tid, callback);
+}
+
 module.exports = SocketTopics;
\ No newline at end of file
diff --git a/src/topics.js b/src/topics.js
index aeac06f43e..b64e4fee1a 100644
--- a/src/topics.js
+++ b/src/topics.js
@@ -330,10 +330,6 @@ var async = require('async'),
 				postData[i].index = start + i;
 			}
 
-			postData = postData.filter(function(post) {
-				return parseInt(current_user, 10) !== 0 || parseInt(post.deleted, 10) === 0;
-			});
-
 			pids = postData.map(function(post) {
 				return post.pid;
 			});
@@ -386,6 +382,9 @@ var async = require('async'),
 					postData[i].favourited = fav_data[pid];
 					postData[i].display_moderator_tools = (current_user != 0) && privileges[pid].editable;
 					postData[i].display_move_tools = privileges[pid].move ? '' : 'hidden';
+					if(parseInt(postData[i].deleted, 10) === 1 && !privileges[pid].view_deleted) {
+						postData[i].content = 'This post is deleted!';
+					}
 				}
 
 				callback(null, postData);
@@ -393,6 +392,19 @@ var async = require('async'),
 		});
 	}
 
+	Topics.getPageCount = function(tid, callback) {
+		db.sortedSetCard('tid:' + tid + ':posts', function(err, postCount) {
+			if(err) {
+				return callback(err);
+			}
+
+			var postsPerPage = parseInt(meta.config.postsPerPage, 10);
+			postsPerPage = postsPerPage ? postsPerPage : 20;
+
+			callback(null, Math.ceil(parseInt(postCount, 10) / postsPerPage));
+		});
+	}
+
 	Topics.getCategoryData = function(tid, callback) {
 		Topics.getTopicField(tid, 'cid', function(err, cid) {
 			if(err) {
@@ -755,21 +767,34 @@ var async = require('async'),
 
 			function getTopicData(next) {
 				Topics.getTopicData(tid, next);
-			};
+			}
 
 			function getTopicPosts(next) {
 				Topics.getTopicPosts(tid, start, end, current_user, next);
-			};
+			}
 
 			function getPrivileges(next) {
 				threadTools.privileges(tid, current_user, next);
-			};
+			}
 
 			function getCategoryData(next) {
 				Topics.getCategoryData(tid, next);
-			};
+			}
 
-			async.parallel([getTopicData, getTopicPosts, getPrivileges, getCategoryData], function(err, results) {
+			function getPages(next) {
+				Topics.getPageCount(tid, function(err, pageCount) {
+					if(err) {
+						return next(err);
+					}
+					var pages = [];
+					for(var i=1; i<=pageCount; ++i) {
+						pages.push({pageNumber: i});
+					}
+					next(null, pages);
+				});
+			}
+
+			async.parallel([getTopicData, getTopicPosts, getPrivileges, getCategoryData, getPages], function(err, results) {
 				if (err) {
 					winston.error('[Topics.getTopicWithPosts] Could not retrieve topic data: ', err.message);
 					return callback(err, null);
@@ -778,7 +803,11 @@ var async = require('async'),
 				var topicData = results[0],
 					topicPosts = results[1],
 					privileges = results[2],
-					categoryData = results[3];
+					categoryData = results[3],
+					pages = results[4];
+
+				var postsPerPage = parseInt(meta.config.postsPerPage, 10);
+				postsPerPage = postsPerPage ? postsPerPage : 20;
 
 				callback(null, {
 					'topic_name': topicData.title,
@@ -791,6 +820,8 @@ var async = require('async'),
 					'slug': topicData.slug,
 					'postcount': topicData.postcount,
 					'viewcount': topicData.viewcount,
+					'pages': pages,
+					'pageCount': pages.length,
 					'unreplied': parseInt(topicData.postcount, 10) > 1,
 					'topic_id': tid,
 					'expose_tools': privileges.editable ? 1 : 0,

From 5f0c6e508d472c08d65b73f33fdaab1e482f8802 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Fri, 24 Jan 2014 20:50:55 -0500
Subject: [PATCH 03/28] some cleanup

---
 public/src/forum/topic.js      | 106 ++++++++++++++-------------------
 public/src/modules/composer.js |   2 +-
 2 files changed, 47 insertions(+), 61 deletions(-)

diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js
index e972ee11ae..70b3172d8b 100644
--- a/public/src/forum/topic.js
+++ b/public/src/forum/topic.js
@@ -19,7 +19,8 @@ define(['composer'], function(composer) {
 			},
 			topic_name = templates.get('topic_name'),
 			currentPage = parseInt(templates.get('currentPage'), 10),
-			pageCount = parseInt(templates.get('pageCount'), 10);
+			pageCount = parseInt(templates.get('pageCount'), 10),
+			Topic.postCount = templates.get('postcount');
 
 
 		function fixDeleteStateForPosts() {
@@ -40,7 +41,8 @@ define(['composer'], function(composer) {
 
 			showBottomPostBar();
 
-			// Resetting thread state
+			updateHeader();
+
 			if (thread_state.locked === '1') set_locked_state(true);
 			if (thread_state.deleted === '1') set_delete_state(true);
 			if (thread_state.pinned === '1') set_pinned_state(true);
@@ -329,17 +331,6 @@ define(['composer'], function(composer) {
 				Topic.scrollToPost(parseInt(bookmark, 10));
 			}
 
-			// Show the paginator block, now that the DOM has finished loading
-			(function delayedHeaderUpdate() {
-				if (!Topic.postCount) {
-					setTimeout(function() {
-						delayedHeaderUpdate();
-					}, 25);
-				} else {
-					updateHeader();
-				}
-			})();
-
 			$('#post-container').on('mouseenter', '.favourite-tooltip', function(e) {
 				if (!$(this).data('users-loaded')) {
 					$(this).data('users-loaded', "true");
@@ -389,7 +380,7 @@ define(['composer'], function(composer) {
 				$('.pagination .previous').addClass('disabled');
 			}
 
-			if(currentPage === parseInt($('.pagination').attr('data-pageCount'), 10)) {
+			if(currentPage === pageCount) {
 				$('.pagination .next').addClass('disabled');
 			}
 
@@ -403,6 +394,11 @@ define(['composer'], function(composer) {
 				return;
 			}
 
+			if(page === 1) {
+				ajaxify.go('topic/' + tid );
+				return;
+			}
+
 			socket.emit('topics.loadPage', {tid: tid, page: page}, function(err, data) {
 				if(err) {
 					return app.alertError(err.message);
@@ -451,11 +447,7 @@ define(['composer'], function(composer) {
 				return;
 			}
 
-			var html = templates.prepare(templates['topic'].blocks['posts']).parse(data);
-			var regexp = new RegExp("<!--[\\s]*IF @first[\\s]*-->([\\s\\S]*?)<!--[\\s]*ENDIF @first[\\s]*-->", 'g');
-			html = html.replace(regexp, '');
-
-			translator.translate(html, function(translatedHTML) {
+			parseAndTranslatePosts(data.posts, function(translatedHTML) {
 				var translated = $(translatedHTML);
 
 				$('#post-container').fadeOut(function() {
@@ -464,22 +456,7 @@ define(['composer'], function(composer) {
 					translated.appendTo($(this));
 					$(this).fadeIn('slow');
 
-					for (var x = 0, numPosts = data.posts.length; x < numPosts; x++) {
-						socket.emit('posts.getPrivileges', data.posts[x].pid, function(err, privileges) {
-							if(err) {
-								return app.alertError(err.message);
-							}
-							toggle_mod_tools(privileges.pid, privileges.editable);
-						});
-					}
-
-					app.populateOnlineUsers();
-					app.createUserTooltips();
-					app.addCommasToNumbers();
-					$('span.timeago').timeago();
-					$('.post-content img').addClass('img-responsive');
-					updatePostCount();
-					showBottomPostBar();
+					onNewPostsLoaded(data.posts);
 
 					callback();
 				});
@@ -554,7 +531,7 @@ define(['composer'], function(composer) {
 			var pid = $(this).parents('.post-row').attr('data-pid');
 			$('#post_' + pid + '_link').val(window.location.href + "#" + pid);
 			// without the setTimeout can't select the text in the input
-			setTimeout(function(){
+			setTimeout(function() {
 				$('#post_' + pid + '_link').select();
 			}, 50);
 		});
@@ -1064,8 +1041,6 @@ define(['composer'], function(composer) {
 			}
 		}
 
-		Topic.postCount = templates.get('postcount');
-
 		window.onscroll = updateHeader;
 	};
 
@@ -1186,6 +1161,7 @@ define(['composer'], function(composer) {
 		function findInsertionPoint() {
 			var after = null,
 				firstPid = data.posts[0].pid;
+
 			$('#post-container li[data-pid]').each(function() {
 				if(parseInt(firstPid, 10) > parseInt($(this).attr('data-pid'), 10)) {
 					after = $(this);
@@ -1206,11 +1182,7 @@ define(['composer'], function(composer) {
 
 		var insertAfter = findInsertionPoint();
 
-		var html = templates.prepare(templates['topic'].blocks['posts']).parse(data);
-		var regexp = new RegExp("<!--[\\s]*IF @first[\\s]*-->([\\s\\S]*?)<!--[\\s]*ENDIF @first[\\s]*-->", 'g');
-		html = html.replace(regexp, '');
-
-		translator.translate(html, function(translatedHTML) {
+		parseAndTranslatePosts(data.posts, function(translatedHTML) {
 			var translated = $(translatedHTML);
 
 			if(!infiniteLoaded) {
@@ -1221,27 +1193,41 @@ define(['composer'], function(composer) {
 				.hide()
 				.fadeIn('slow');
 
-			for (var x = 0, numPosts = data.posts.length; x < numPosts; x++) {
-				socket.emit('posts.getPrivileges', data.posts[x].pid, function(err, privileges) {
-					if(err) {
-						return app.alertError(err.message);
-					}
-					toggle_mod_tools(privileges.pid, privileges.editable);
-				});
-			}
+			onNewPostsLoaded(data.posts);
+		});
+	}
 
-			infiniteLoaderActive = false;
+	function parseAndTranslatePosts(posts, callback) {
+		var html = templates.prepare(templates['topic'].blocks['posts']).parse({posts: posts});
+		var regexp = new RegExp("<!--[\\s]*IF @first[\\s]*-->([\\s\\S]*?)<!--[\\s]*ENDIF @first[\\s]*-->", 'g');
+		html = html.replace(regexp, '');
 
-			app.populateOnlineUsers();
-			app.createUserTooltips();
-			app.addCommasToNumbers();
-			$('span.timeago').timeago();
-			$('.post-content img').addClass('img-responsive');
-			updatePostCount();
-			showBottomPostBar();
-		});
+		translator.translate(html, callback);
 	}
 
+
+	function onNewPostsLoaded(posts) {
+		for (var x = 0, numPosts = posts.length; x < numPosts; x++) {
+			socket.emit('posts.getPrivileges', posts[x].pid, function(err, privileges) {
+				if(err) {
+					return app.alertError(err.message);
+				}
+				toggle_mod_tools(privileges.pid, privileges.editable);
+			});
+		}
+
+		infiniteLoaderActive = false;
+
+		app.populateOnlineUsers();
+		app.createUserTooltips();
+		app.addCommasToNumbers();
+		$('span.timeago').timeago();
+		$('.post-content img').addClass('img-responsive');
+		updatePostCount();
+		showBottomPostBar();
+	}
+
+
 	function toggle_mod_tools(pid, state) {
 		var postEl = $(document.querySelector('#post-container li[data-pid="' + pid + '"]')),
 			editEl = postEl.find('.edit'),
diff --git a/public/src/modules/composer.js b/public/src/modules/composer.js
index 7b0239aba8..d22153acbd 100644
--- a/public/src/modules/composer.js
+++ b/public/src/modules/composer.js
@@ -352,7 +352,7 @@ define(['taskbar'], function(taskbar) {
 		}
 
 		postContainer.css('visibility', 'visible')
-			.css('z-index', 1);
+			.css('z-index', 2);
 
 		$('body').css({'margin-bottom': postContainer.css('height')});
 

From aa73a10fc4eefe3ebdc07b104e0dcb141a27bec5 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Fri, 24 Jan 2014 21:01:28 -0500
Subject: [PATCH 04/28] added pagination to vanilla topic template

---
 public/src/forum/topic.js  |  5 +++--
 public/templates/topic.tpl | 19 +++++++++++++------
 2 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js
index 70b3172d8b..d17b136c63 100644
--- a/public/src/forum/topic.js
+++ b/public/src/forum/topic.js
@@ -19,8 +19,9 @@ define(['composer'], function(composer) {
 			},
 			topic_name = templates.get('topic_name'),
 			currentPage = parseInt(templates.get('currentPage'), 10),
-			pageCount = parseInt(templates.get('pageCount'), 10),
-			Topic.postCount = templates.get('postcount');
+			pageCount = parseInt(templates.get('pageCount'), 10);
+
+		Topic.postCount = templates.get('postcount');
 
 
 		function fixDeleteStateForPosts() {
diff --git a/public/templates/topic.tpl b/public/templates/topic.tpl
index 1aabe3c8c0..36b3a63076 100644
--- a/public/templates/topic.tpl
+++ b/public/templates/topic.tpl
@@ -1,5 +1,7 @@
 <input type="hidden" template-variable="expose_tools" value="{expose_tools}" />
 <input type="hidden" template-variable="topic_id" value="{topic_id}" />
+<input type="hidden" template-variable="currentPage" value="{currentPage}" />
+<input type="hidden" template-variable="pageCount" value="{pageCount}" />
 <input type="hidden" template-variable="locked" value="{locked}" />
 <input type="hidden" template-variable="deleted" value="{deleted}" />
 <input type="hidden" template-variable="pinned" value="{pinned}" />
@@ -201,12 +203,17 @@
 		<div style="clear:both;"></div>
 	</div>
 
-	<!-- {usePagination} -->
-	<ul class="pager">
-		<li class="previous"><a href="#">&larr; Older</a></li>
-		<li class="next"><a href="#">Newer &rarr;</a></li>
-	</ul>
-	<!-- {usePagination} -->
+	<!-- IF usePagination -->
+	<div class="text-center">
+		<ul class="pagination">
+			<li class="previous pull-left"><a href="#">&larr; Older</a></li>
+			<!-- BEGIN pages -->
+			<li class="page" data-page="{pages.pageNumber}"><a href="#">{pages.pageNumber}</a></li>
+			<!-- END pages -->
+			<li class="next pull-right"><a href="#">Newer &rarr;</a></li>
+		</ul>
+	</div>
+	<!-- ENDIF usePagination -->
 
 	<div id="move_thread_modal" class="modal" tabindex="-1" role="dialog" aria-labelledby="Move Topic" aria-hidden="true">
 		<div class="modal-dialog">

From ef6fd35e85ce20d679aef9692d711f12ffe4fc56 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Fri, 24 Jan 2014 22:26:11 -0500
Subject: [PATCH 05/28] lots of cleanup, moved pagination to requirejs module

---
 public/src/forum/category.js   | 54 ++++++++++++++++-------
 public/src/forum/pagination.js | 79 ++++++++++++++++++++++++++++++++++
 public/src/forum/topic.js      | 73 ++++++-------------------------
 public/templates/category.tpl  | 15 ++++++-
 src/categories.js              | 39 +++++++++++++++--
 src/routes/api.js              |  2 +-
 src/socket.io/categories.js    | 25 ++++++++++-
 src/topics.js                  | 24 ++++++-----
 8 files changed, 220 insertions(+), 91 deletions(-)
 create mode 100644 public/src/forum/pagination.js

diff --git a/public/src/forum/category.js b/public/src/forum/category.js
index a2f7443768..d995aaf8d9 100644
--- a/public/src/forum/category.js
+++ b/public/src/forum/category.js
@@ -1,13 +1,10 @@
-define(['composer'], function(composer) {
+define(['composer', 'forum/pagination'], function(composer, pagination) {
 	var Category = {},
 		loadingMoreTopics = false;
 
 	Category.init = function() {
 		var	cid = templates.get('category_id'),
 			categoryName = templates.get('category_name'),
-			twitterEl = jQuery('#twitter-intent'),
-			facebookEl = jQuery('#facebook-share'),
-			googleEl = jQuery('#google-share'),
 			categoryUrl = encodeURIComponent(window.location.href),
 			twitterUrl = "https://twitter.com/intent/tweet?url=" + categoryUrl + "&text=" + encodeURIComponent(categoryName),
 			facebookUrl = "https://www.facebook.com/sharer/sharer.php?u=" + categoryUrl,
@@ -15,17 +12,17 @@ define(['composer'], function(composer) {
 
 		app.enterRoom('category_' + cid);
 
-
-
-		twitterEl.on('click', function () {
+		$('#twitter-intent').on('click', function () {
 			window.open(twitterUrl, '_blank', 'width=550,height=420,scrollbars=no,status=no');
 			return false;
 		});
-		facebookEl.on('click', function () {
+
+		$('#facebook-share').on('click', function () {
 			window.open(facebookUrl, '_blank', 'width=626,height=436,scrollbars=no,status=no');
 			return false;
 		});
-		googleEl.on('click', function () {
+
+		$('#google-share').on('click', function () {
 			window.open(googleUrl, '_blank', 'width=500,height=570,scrollbars=no,status=no');
 			return false;
 		});
@@ -42,14 +39,36 @@ define(['composer'], function(composer) {
 
 		socket.emit('categories.getRecentReplies', cid, renderRecentReplies);
 
-		$(window).off('scroll').on('scroll', function (ev) {
-			var bottom = ($(document).height() - $(window).height()) * 0.9;
+		enableInfiniteLoading();
+	};
+
+	function enableInfiniteLoading() {
+		if(!config.usePagination) {
+			$(window).off('scroll').on('scroll', function (ev) {
+				var bottom = ($(document).height() - $(window).height()) * 0.9;
+
+				if ($(window).scrollTop() > bottom && !loadingMoreTopics) {
+					Category.loadMoreTopics(cid);
+				}
+			});
+		} else {
+			pagination.init(templates.get('currentPage'), templates.get('pageCount'), loadPage);
+		}
+	}
 
-			if ($(window).scrollTop() > bottom && !loadingMoreTopics) {
-				Category.loadMoreTopics(cid);
+	function loadPage(page, callback) {
+		socket.emit('categories.loadPage', {cid: templates.get('category_id'), page: page}, function(err, data) {
+			if(err) {
+				return callback(err);
 			}
+
+			if (data && data.topics && data.topics.length) {
+				Category.onTopicsLoaded(data.topics);
+			}
+
+			callback(null);
 		});
-	};
+	}
 
 	Category.onNewTopic = function(data) {
 		var html = templates.prepare(templates['category'].blocks['topics']).parse({
@@ -116,7 +135,12 @@ define(['composer'], function(composer) {
 			jQuery('#category-no-topics').remove();
 
 			html = $(translatedHTML);
-			container.append(html);
+
+			if(config.usePagination) {
+				container.empty().append(html);
+			} else {
+				container.append(html);
+			}
 
 			$('#topics-container span.timeago').timeago();
 			app.makeNumbersHumanReadable(html.find('.human-readable-number'));
diff --git a/public/src/forum/pagination.js b/public/src/forum/pagination.js
new file mode 100644
index 0000000000..4ebc89e313
--- /dev/null
+++ b/public/src/forum/pagination.js
@@ -0,0 +1,79 @@
+
+
+define(function() {
+	var pagination = {};
+
+	pagination.currentPage = 0;
+	pagination.pageCount = 0;
+	pagination.loadFunction = null;
+
+	pagination.init = function(currentPage, pageCount, loadFunction) {
+		pagination.currentPage = parseInt(currentPage, 10);
+		pagination.pageCount = parseInt(pageCount, 10);
+		pagination.loadFunction = loadFunction;
+
+		updatePageLinks();
+
+		$('.pagination').on('click', '.previous', function() {
+			pagination.loadPage(pagination.currentPage - 1);
+		});
+
+		$('.pagination').on('click', '.next', function() {
+			pagination.loadPage(pagination.currentPage + 1);
+		});
+
+		$('.pagination').on('click', '.page', function() {
+			pagination.loadPage($(this).attr('data-page'));
+		});
+	}
+
+	pagination.recreatePaginationLinks = function(newPageCount) {
+		pagination.pageCount = parseInt(newPageCount);
+
+		var pages = [];
+		for(var i=1; i<=pagination.page; ++i) {
+			pages.push({pageNumber: i});
+		}
+
+		var html = templates.prepare(templates['topic'].blocks['pages']).parse({pages:pages});
+		html = $(html);
+		$('.pagination li.page').remove();
+		html.insertAfter($('.pagination li.previous'));
+		updatePageLinks();
+	}
+
+	pagination.loadPage = function(page, callback) {
+		page = parseInt(page, 10);
+		if(page < 1 || page > pagination.pageCount) {
+			return;
+		}
+
+		pagination.loadFunction(page, function(err) {
+			if(err) {
+				return app.alertError(err.message);
+			}
+
+			pagination.currentPage = parseInt(page, 10);
+			updatePageLinks();
+		});
+	}
+
+
+	function updatePageLinks() {
+		$('.pagination .next').removeClass('disabled');
+		$('.pagination .previous').removeClass('disabled');
+
+		if(pagination.currentPage === 1) {
+			$('.pagination .previous').addClass('disabled');
+		}
+
+		if(pagination.currentPage === pagination.pageCount) {
+			$('.pagination .next').addClass('disabled');
+		}
+
+		$('.pagination .page').removeClass('active');
+		$('.pagination .page[data-page="' + pagination.currentPage + '"]').addClass('active');
+	}
+
+	return pagination;
+});
\ No newline at end of file
diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js
index d17b136c63..9f18bd247e 100644
--- a/public/src/forum/topic.js
+++ b/public/src/forum/topic.js
@@ -1,4 +1,4 @@
-define(['composer'], function(composer) {
+define(['composer', 'forum/pagination'], function(composer, pagination) {
 	var	Topic = {},
 		infiniteLoaderActive = false,
 		pagination;
@@ -357,44 +357,12 @@ define(['composer'], function(composer) {
 				});
 			} else {
 				$('.pagination-block').addClass('hide');
-				updatePageLinks();
 
-				$('.pagination').on('click', '.previous', function() {
-					loadPage(currentPage - 1);
-				});
-
-				$('.pagination').on('click', '.next', function() {
-					loadPage(currentPage + 1);
-				});
-
-				$('.pagination').on('click', '.page', function() {
-					loadPage($(this).attr('data-page'));
-				});
+				pagination.init(currentPage, pageCount, loadPage);
 			}
 		}
 
-		function updatePageLinks() {
-			$('.pagination .next').removeClass('disabled');
-			$('.pagination .previous').removeClass('disabled');
-
-			if(currentPage === 1) {
-				$('.pagination .previous').addClass('disabled');
-			}
-
-			if(currentPage === pageCount) {
-				$('.pagination .next').addClass('disabled');
-			}
-
-			$('.pagination .page').removeClass('active');
-			$('.pagination .page[data-page="' + currentPage + '"]').addClass('active');
-		}
-
-		function loadPage(page) {
-			page = parseInt(page, 10);
-			if(page < 1 || page > pageCount) {
-				return;
-			}
-
+		function loadPage(page, callback) {
 			if(page === 1) {
 				ajaxify.go('topic/' + tid );
 				return;
@@ -402,9 +370,8 @@ define(['composer'], function(composer) {
 
 			socket.emit('topics.loadPage', {tid: tid, page: page}, function(err, data) {
 				if(err) {
-					return app.alertError(err.message);
+					return callback(err);
 				}
-				currentPage = page;
 
 				if (data && data.posts && data.posts.length) {
 					createPagePosts(data, function() {
@@ -412,7 +379,7 @@ define(['composer'], function(composer) {
 					});
 				}
 
-				updatePageLinks();
+				callback(null);
 			});
 		}
 
@@ -420,27 +387,14 @@ define(['composer'], function(composer) {
 			var posts = data.posts;
 			socket.emit('topics.getPageCount', tid, function(err, newPageCount) {
 
-				pageCount = newPageCount;
-				recreatePaginationLinks();
-				if(currentPage === newPageCount) {
+				pagination.recreatePaginationLinks(newPageCount);
+
+				if(pagination.currentPage === pagination.newPageCount) {
 					createNewPosts(data);
 				} else if(data.posts && data.posts.length && parseInt(data.posts[0].uid, 10) === parseInt(app.uid, 10)) {
-					loadPage(pageCount);
+					pagination.loadPage(pagination.pageCount);
 				}
 			});
-
-		}
-
-		function recreatePaginationLinks() {
-			var pages = [];
-			for(var i=1; i<=pageCount; ++i) {
-				pages.push({pageNumber: i});
-			}
-			var html = templates.prepare(templates['topic'].blocks['pages']).parse({pages:pages});
-			html = $(html);
-			$('.pagination li.page').remove();
-			html.insertAfter($('.pagination li.previous'));
-			updatePageLinks();
 		}
 
 		function createPagePosts(data, callback) {
@@ -451,11 +405,9 @@ define(['composer'], function(composer) {
 			parseAndTranslatePosts(data.posts, function(translatedHTML) {
 				var translated = $(translatedHTML);
 
-				$('#post-container').fadeOut(function() {
+				$('#post-container').fadeOut(200, function() {
 
-					$(this).empty();
-					translated.appendTo($(this));
-					$(this).fadeIn('slow');
+					$('#post-container').empty().append(translated).fadeIn('slow');
 
 					onNewPostsLoaded(data.posts);
 
@@ -1068,7 +1020,8 @@ define(['composer'], function(composer) {
 		var	progressBarContainer = $('.progress-container');
 		var tid = templates.get('topic_id');
 
-		pagination.parentNode.style.display = 'block';
+		if(pagination.parentNode)
+			pagination.parentNode.style.display = 'block';
 		progressBarContainer.css('display', '');
 
 		if (scrollTop < jQuery('.posts > .post-row:first-child').height() && Topic.postCount > 1) {
diff --git a/public/templates/category.tpl b/public/templates/category.tpl
index 8ba94b3788..6bbd2a5ae7 100644
--- a/public/templates/category.tpl
+++ b/public/templates/category.tpl
@@ -84,6 +84,17 @@
 			</li>
 			<!-- END topics -->
 		</ul>
+		<!-- IF usePagination -->
+		<div class="text-center">
+			<ul class="pagination">
+				<li class="previous pull-left"><a href="#">&larr; Older</a></li>
+				<!-- BEGIN pages -->
+				<li class="page" data-page="{pages.pageNumber}"><a href="#">{pages.pageNumber}</a></li>
+				<!-- END pages -->
+				<li class="next pull-right"><a href="#">Newer &rarr;</a></li>
+			</ul>
+		</div>
+		<!-- ENDIF usePagination -->
 	</div>
 	<div class="col-md-3 col-xs-12 {show_sidebar} category-sidebar">
 		<div class="panel panel-default">
@@ -121,4 +132,6 @@
 </div>
 
 <input type="hidden" template-variable="category_id" value="{category_id}" />
-<input type="hidden" template-variable="category_name" value="{category_name}" />
\ No newline at end of file
+<input type="hidden" template-variable="category_name" value="{category_name}" />
+<input type="hidden" template-variable="currentPage" value="{currentPage}" />
+<input type="hidden" template-variable="pageCount" value="{pageCount}" />
\ No newline at end of file
diff --git a/src/categories.js b/src/categories.js
index 06394ee47f..0a742c00e7 100644
--- a/src/categories.js
+++ b/src/categories.js
@@ -52,7 +52,8 @@ var db = require('./database.js'),
 			}
 
 			function getTopicIds(next) {
-				Categories.getTopicIds(category_id, 0, 19, next);
+				var topicsPerPage = meta.config.topicsPerPage || 20;
+				Categories.getTopicIds(category_id, 0, topicsPerPage - 1, next);
 			}
 
 			function getActiveUsers(next) {
@@ -65,10 +66,15 @@ var db = require('./database.js'),
 				});
 			}
 
-			async.parallel([getTopicIds, getActiveUsers, getSidebars], function(err, results) {
+			function getPages(next) {
+				Categories.getPages(category_id, next);
+			}
+
+			async.parallel([getTopicIds, getActiveUsers, getSidebars, getPages], function(err, results) {
 				var tids = results[0],
 					active_users = results[1],
-					sidebars = results[2];
+					sidebars = results[2],
+					pages = results[3];
 
 				var category = {
 					'category_name': categoryData.name,
@@ -82,6 +88,8 @@ var db = require('./database.js'),
 					'category_id': category_id,
 					'active_users': [],
 					'topics': [],
+					'pages': pages,
+					'pageCount': pages.length,
 					'disableSocialButtons': meta.config.disableSocialButtons !== undefined ? parseInt(meta.config.disableSocialButtons, 10) !== 0 : false,
 					'sidebars': sidebars
 				};
@@ -137,6 +145,31 @@ var db = require('./database.js'),
 		db.getSortedSetRevRange('categories:' + cid + ':tid', start, stop, callback);
 	};
 
+	Categories.getPages = function(cid, callback) {
+		Categories.getPageCount(cid, function(err, pageCount) {
+			if(err) {
+				return callback(err);
+			}
+			var pages = [];
+			for(var i=1; i<=pageCount; ++i) {
+				pages.push({pageNumber: i});
+			}
+			callback(null, pages);
+		});
+	};
+
+	Categories.getPageCount = function(cid, callback) {
+		db.sortedSetCard('categories:' + cid + ':tid', function(err, topicCount) {
+			if(err) {
+				return callback(err);
+			}
+
+			var topicsPerPage = parseInt(meta.config.topicsPerPage, 10);
+			topicsPerPage = topicsPerPage ? topicsPerPage : 20;
+
+			callback(null, Math.ceil(parseInt(topicCount, 10) / topicsPerPage));
+		});
+	};
 
 	Categories.getAllCategories = function(current_user, callback) {
 		db.getListRange('categories:cid', 0, -1, function(err, cids) {
diff --git a/src/routes/api.js b/src/routes/api.js
index ca5c63fd6f..171dc5147d 100644
--- a/src/routes/api.js
+++ b/src/routes/api.js
@@ -200,7 +200,7 @@ var path = require('path'),
 								return next(err);
 							}
 
-							// Add privilege data to template data
+							data.currentPage = 1;
 							data.privileges = privileges;
 
 							if (data && parseInt(data.disabled, 10) === 0) {
diff --git a/src/socket.io/categories.js b/src/socket.io/categories.js
index 545635750d..b664114cdc 100644
--- a/src/socket.io/categories.js
+++ b/src/socket.io/categories.js
@@ -1,4 +1,5 @@
 var	categories = require('../categories'),
+	meta = require('./../meta'),
 
 	SocketCategories = {};
 
@@ -15,8 +16,10 @@ SocketCategories.loadMore = function(socket, data, callback) {
 		return callback(new Error('invalid data'));
 	}
 
+	var topicsPerPage = parseInt(meta.config.topicsPerPage, 10) || 20;
+
 	var start = data.after,
-		end = start + 9;
+		end = start + topicsPerPage - 1;
 
 	categories.getCategoryTopics(data.cid, start, end, socket.uid, function(err, topics) {
 		callback(err, {
@@ -25,4 +28,24 @@ SocketCategories.loadMore = function(socket, data, callback) {
 	});
 };
 
+SocketCategories.loadPage = function(socket, data, callback) {
+	if(!data) {
+		return callback(new Error('invalid data'));
+	}
+
+	var topicsPerPage = parseInt(meta.config.topicsPerPage, 10) || 20;
+
+	var start = (data.page - 1) * topicsPerPage,
+		end = start + topicsPerPage - 1;
+
+		console.log('start to end' ,start, end);
+
+	categories.getCategoryTopics(data.cid, start, end, socket.uid, function(err, topics) {
+		console.log('getting topics', topics.length);
+		callback(err, {
+			topics: topics
+		});
+	});
+}
+
 module.exports = SocketCategories;
\ No newline at end of file
diff --git a/src/topics.js b/src/topics.js
index b64e4fee1a..439f751d36 100644
--- a/src/topics.js
+++ b/src/topics.js
@@ -392,6 +392,19 @@ var async = require('async'),
 		});
 	}
 
+	Topics.getPages = function(tid, callback) {
+		Topics.getPageCount(tid, function(err, pageCount) {
+			if(err) {
+				return callback(err);
+			}
+			var pages = [];
+			for(var i=1; i<=pageCount; ++i) {
+				pages.push({pageNumber: i});
+			}
+			callback(null, pages);
+		});
+	}
+
 	Topics.getPageCount = function(tid, callback) {
 		db.sortedSetCard('tid:' + tid + ':posts', function(err, postCount) {
 			if(err) {
@@ -782,16 +795,7 @@ var async = require('async'),
 			}
 
 			function getPages(next) {
-				Topics.getPageCount(tid, function(err, pageCount) {
-					if(err) {
-						return next(err);
-					}
-					var pages = [];
-					for(var i=1; i<=pageCount; ++i) {
-						pages.push({pageNumber: i});
-					}
-					next(null, pages);
-				});
+				Topics.getPages(tid, next);
 			}
 
 			async.parallel([getTopicData, getTopicPosts, getPrivileges, getCategoryData, getPages], function(err, results) {

From b23960e8d7139338a253f23ae9ba1ed8499d3618 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Fri, 24 Jan 2014 23:05:59 -0500
Subject: [PATCH 06/28] fixes to category pagination

---
 public/src/forum/category.js   |  6 ++++++
 public/src/forum/pagination.js | 14 ++++++++++----
 public/src/forum/topic.js      |  2 +-
 public/templates/category.tpl  |  1 +
 src/socket.io/categories.js    |  7 ++++---
 5 files changed, 22 insertions(+), 8 deletions(-)

diff --git a/public/src/forum/category.js b/public/src/forum/category.js
index d995aaf8d9..aa6b25dd79 100644
--- a/public/src/forum/category.js
+++ b/public/src/forum/category.js
@@ -104,7 +104,12 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 
 			addActiveUser(data);
 
+			socket.emit('categories.getPageCount', templates.get('category_id'), function(err, newPageCount) {
+				pagination.recreatePaginationLinks('category', newPageCount);
+			});
+
 			$('#topics-container span.timeago').timeago();
+			app.createUserTooltips();
 		});
 	}
 
@@ -143,6 +148,7 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 			}
 
 			$('#topics-container span.timeago').timeago();
+			app.createUserTooltips();
 			app.makeNumbersHumanReadable(html.find('.human-readable-number'));
 		});
 	}
diff --git a/public/src/forum/pagination.js b/public/src/forum/pagination.js
index 4ebc89e313..d7e9abc965 100644
--- a/public/src/forum/pagination.js
+++ b/public/src/forum/pagination.js
@@ -27,15 +27,15 @@ define(function() {
 		});
 	}
 
-	pagination.recreatePaginationLinks = function(newPageCount) {
-		pagination.pageCount = parseInt(newPageCount);
+	pagination.recreatePaginationLinks = function(template, newPageCount) {
+		pagination.pageCount = parseInt(newPageCount, 10);
 
 		var pages = [];
-		for(var i=1; i<=pagination.page; ++i) {
+		for(var i=1; i<=pagination.pageCount; ++i) {
 			pages.push({pageNumber: i});
 		}
 
-		var html = templates.prepare(templates['topic'].blocks['pages']).parse({pages:pages});
+		var html = templates.prepare(templates[template].blocks['pages']).parse({pages:pages});
 		html = $(html);
 		$('.pagination li.page').remove();
 		html.insertAfter($('.pagination li.previous'));
@@ -60,6 +60,12 @@ define(function() {
 
 
 	function updatePageLinks() {
+		if(pagination.pageCount === 0) {
+			$('.pagination').addClass('hide');
+		} else {
+			$('.pagination').removeClass('hide');
+		}
+
 		$('.pagination .next').removeClass('disabled');
 		$('.pagination .previous').removeClass('disabled');
 
diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js
index 9f18bd247e..60ab01ce92 100644
--- a/public/src/forum/topic.js
+++ b/public/src/forum/topic.js
@@ -387,7 +387,7 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 			var posts = data.posts;
 			socket.emit('topics.getPageCount', tid, function(err, newPageCount) {
 
-				pagination.recreatePaginationLinks(newPageCount);
+				pagination.recreatePaginationLinks('topic', newPageCount);
 
 				if(pagination.currentPage === pagination.newPageCount) {
 					createNewPosts(data);
diff --git a/public/templates/category.tpl b/public/templates/category.tpl
index 6bbd2a5ae7..81727bd042 100644
--- a/public/templates/category.tpl
+++ b/public/templates/category.tpl
@@ -96,6 +96,7 @@
 		</div>
 		<!-- ENDIF usePagination -->
 	</div>
+
 	<div class="col-md-3 col-xs-12 {show_sidebar} category-sidebar">
 		<div class="panel panel-default">
 			<div class="panel-heading">[[category:sidebar.recent_replies]]</div>
diff --git a/src/socket.io/categories.js b/src/socket.io/categories.js
index b664114cdc..ec663ee8e6 100644
--- a/src/socket.io/categories.js
+++ b/src/socket.io/categories.js
@@ -38,14 +38,15 @@ SocketCategories.loadPage = function(socket, data, callback) {
 	var start = (data.page - 1) * topicsPerPage,
 		end = start + topicsPerPage - 1;
 
-		console.log('start to end' ,start, end);
-
 	categories.getCategoryTopics(data.cid, start, end, socket.uid, function(err, topics) {
-		console.log('getting topics', topics.length);
 		callback(err, {
 			topics: topics
 		});
 	});
 }
 
+SocketCategories.getPageCount = function(socket, cid, callback) {
+	categories.getPageCount(cid, callback);
+}
+
 module.exports = SocketCategories;
\ No newline at end of file

From d718eca935b000be15275ebb419ff7af3c639141 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sat, 25 Jan 2014 01:34:56 -0500
Subject: [PATCH 07/28] fixes global meta leak, and categories meta require,
 #873

---
 src/categories.js | 1 +
 src/messaging.js  | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/categories.js b/src/categories.js
index 06394ee47f..3750deb459 100644
--- a/src/categories.js
+++ b/src/categories.js
@@ -5,6 +5,7 @@ var db = require('./database.js'),
 	topics = require('./topics.js'),
 	plugins = require('./plugins'),
 	CategoryTools = require('./categoryTools'),
+	meta = require('./meta'),
 
 	async = require('async'),
 	winston = require('winston'),
diff --git a/src/messaging.js b/src/messaging.js
index af3b8a1183..1c9a23f9f9 100644
--- a/src/messaging.js
+++ b/src/messaging.js
@@ -1,7 +1,7 @@
 var db = require('./database'),
 	async = require('async'),
 	user = require('./user'),
-    plugins = require('./plugins');
+	plugins = require('./plugins'),
 	meta = require('./meta');
 
 

From 393bb7245ce7a73bbd346b1c1a1d69e9172f275c Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sat, 25 Jan 2014 12:05:48 -0500
Subject: [PATCH 08/28] closes #866

---
 src/posts.js          |  2 +-
 src/socket.io/meta.js |  2 +-
 src/topics.js         |  6 +++---
 src/upgrade.js        | 39 +++++++++++++++++++++++++++++++++++++--
 src/user.js           |  5 ++---
 src/webserver.js      |  1 -
 6 files changed, 44 insertions(+), 11 deletions(-)

diff --git a/src/posts.js b/src/posts.js
index 650311c979..b4aa4c1882 100644
--- a/src/posts.js
+++ b/src/posts.js
@@ -194,7 +194,7 @@ var db = require('./database'),
 				post.user_rep = userData.reputation || 0;
 				post.user_postcount = userData.postcount || 0;
 				post.user_banned = parseInt(userData.banned, 10) === 1;
-				post.picture = userData.picture || gravatar.url('', {}, https = nconf.get('https'));
+				post.picture = userData.picture || gravatar.url('', {}, true);
 
 				if(meta.config.disableSignatures === undefined || parseInt(meta.config.disableSignatures, 10) === 0) {
 					post.signature = signature;
diff --git a/src/socket.io/meta.js b/src/socket.io/meta.js
index 106c6d5621..096c7553b3 100644
--- a/src/socket.io/meta.js
+++ b/src/socket.io/meta.js
@@ -58,7 +58,7 @@ SocketMeta.updateHeader = function(socket, data, callback) {
 			email: '',
 			picture: gravatar.url('', {
 				s: '24'
-			}, nconf.get('https')),
+			}, true),
 			config: {
 				allowGuestSearching: meta.config.allowGuestSearching
 			}
diff --git a/src/topics.js b/src/topics.js
index aeac06f43e..2183ddc354 100644
--- a/src/topics.js
+++ b/src/topics.js
@@ -713,14 +713,14 @@ var async = require('async'),
 					topicData.unreplied = parseInt(topicData.postcount, 10) === 1;
 					topicData.username = topicInfo.username || 'anonymous';
 					topicData.userslug = topicInfo.userslug || '';
-					topicData.picture = topicInfo.picture || gravatar.url('', {}, https = nconf.get('https'));
+					topicData.picture = topicInfo.picture || gravatar.url('', {}, true);
 					topicData.categoryIcon = topicInfo.categoryData.icon;
 					topicData.categoryName = topicInfo.categoryData.name;
 					topicData.categorySlug = topicInfo.categoryData.slug;
 					topicData.badgeclass = (topicInfo.hasread && parseInt(current_user, 10) !== 0) ? '' : 'badge-important';
 					topicData.teaser_username = topicInfo.teaserInfo.username || '';
 					topicData.teaser_userslug = topicInfo.teaserInfo.userslug || '';
-					topicData.teaser_userpicture = topicInfo.teaserInfo.picture || gravatar.url('', {}, https = nconf.get('https'));
+					topicData.teaser_userpicture = topicInfo.teaserInfo.picture || gravatar.url('', {}, true);
 					topicData.teaser_pid = topicInfo.teaserInfo.pid;
 					topicData.teaser_timestamp = utils.toISOString(topicInfo.teaserInfo.timestamp);
 
@@ -1018,7 +1018,7 @@ var async = require('async'),
 						pid: postData.pid,
 						username: userData.username || 'anonymous',
 						userslug: userData.userslug,
-						picture: userData.picture || gravatar.url('', {}, https = nconf.get('https')),
+						picture: userData.picture || gravatar.url('', {}, true),
 						timestamp: postData.timestamp
 					});
 				});
diff --git a/src/upgrade.js b/src/upgrade.js
index 688d84183f..8eff8db0c7 100644
--- a/src/upgrade.js
+++ b/src/upgrade.js
@@ -17,7 +17,7 @@ var db = require('./database'),
 
 Upgrade.check = function(callback) {
 	// IMPORTANT: REMEMBER TO UPDATE VALUE OF latestSchema
-	var	latestSchema = new Date(2014, 0, 23, 16, 5).getTime();
+	var	latestSchema = new Date(2014, 0, 25, 0, 0).getTime();
 
 	db.get('schemaDate', function(err, value) {
 		if (parseInt(value, 10) >= latestSchema) {
@@ -318,11 +318,46 @@ Upgrade.upgrade = function(callback) {
 						winston.info('[2014/1/23] Updating Administrators Group');
 						next();
 					});
-				})
+				});
 			} else {
 				winston.info('[2014/1/23] Updating Administrators Group -- skipped');
 				next();
 			}
+		},
+		function(next) {
+			thisSchemaDate = new Date(2014, 0, 25, 0, 0).getTime();
+			if (schemaDate < thisSchemaDate) {
+				updatesMade = true;
+
+				db.getSortedSetRange('users:joindate', 0, -1, function(err, uids) {
+					if(err) {
+						return next(err);
+					}
+
+					if(!uids || !uids.length) {
+						winston.info('[2014/1/25] Updating User Gravatars to HTTPS  -- skipped');
+						return next();
+					}
+
+					var gravatar = require('gravatar');
+
+					function updateGravatar(uid, next) {
+						User.getUserFields(uid, ['email', 'picture', 'gravatarpicture'], function(err, userData) {
+							var gravatarPicture = User.createGravatarURLFromEmail(userData.email);
+							if(userData.picture === userData.gravatarpicture) {
+								User.setUserField(uid, 'picture', gravatarPicture);
+							}
+							User.setUserField(uid, 'gravatarpicture', gravatarPicture, next);
+						});
+					}
+
+					winston.info('[2014/1/25] Updating User Gravatars to HTTPS');
+					async.each(uids, updateGravatar, next);
+				});
+			} else {
+				winston.info('[2014/1/25] Updating User Gravatars to HTTPS -- skipped');
+				next();
+			}
 		}
 		// Add new schema updates here
 		// IMPORTANT: REMEMBER TO UPDATE VALUE OF latestSchema IN LINE 17!!!
diff --git a/src/user.js b/src/user.js
index 2a983b0c21..14c370b451 100644
--- a/src/user.js
+++ b/src/user.js
@@ -442,15 +442,14 @@ var bcrypt = require('bcrypt'),
 			size: '128',
 			default: 'identicon',
 			rating: 'pg'
-		},
-		https = nconf.get('https');
+		};
 
 		if (!email) {
 			email = '';
 			options.forcedefault = 'y';
 		}
 
-		return gravatar.url(email, options, https);
+		return gravatar.url(email, options, true);
 	};
 
 	User.hashPassword = function(password, callback) {
diff --git a/src/webserver.js b/src/webserver.js
index bf31fd22f4..03bcf4abf3 100644
--- a/src/webserver.js
+++ b/src/webserver.js
@@ -200,7 +200,6 @@ if(nconf.get('ssl')) {
 
 				// Local vars, other assorted setup
 				app.use(function (req, res, next) {
-					nconf.set('https', req.secure);
 					res.locals.csrf_token = req.session._csrf;
 
 					// Disable framing

From 2e786cc4d126e9c290d5cbf358a183a58d0b9654 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sat, 25 Jan 2014 16:39:27 -0500
Subject: [PATCH 09/28] closes #873, removed global translator, templates and
 server objects

---
 app.js                  |  4 +---
 public/src/templates.js |  4 ++--
 src/emailer.js          | 14 ++++++++------
 src/routes/admin.js     |  5 +++--
 src/socket.io/index.js  |  4 ++--
 src/webserver.js        | 17 +++++------------
 6 files changed, 21 insertions(+), 27 deletions(-)

diff --git a/app.js b/app.js
index 8dec4daa79..c4084fa676 100644
--- a/app.js
+++ b/app.js
@@ -106,11 +106,9 @@
 				upgrade.check(function(schema_ok) {
 					if (schema_ok || nconf.get('check-schema') === false) {
 
-						sockets.init();
+						sockets.init(webserver.server);
 
 						plugins.init();
-						global.templates = {};
-						global.translator = translator;
 
 						translator.loadServer();
 
diff --git a/public/src/templates.js b/public/src/templates.js
index 06295dc79e..3e32653c1c 100644
--- a/public/src/templates.js
+++ b/public/src/templates.js
@@ -79,7 +79,7 @@
 							template.prototype.parse = parse;
 							template.prototype.html = String(html);
 
-							global.templates[file] = new template;
+							templates[file] = new template;
 
 							loaded--;
 							if (loaded === 0) {
@@ -396,7 +396,7 @@
 				namespace = '';
 			} else {
 				// clean up all undefined conditionals
-				template = template.replace(/<!-- IF([^@]*?)ENDIF([^@]*?)-->/gi, '');	
+				template = template.replace(/<!-- IF([^@]*?)ENDIF([^@]*?)-->/gi, '');
 			}
 
 			return template;
diff --git a/src/emailer.js b/src/emailer.js
index 529fdaf38f..18c48256cc 100644
--- a/src/emailer.js
+++ b/src/emailer.js
@@ -1,16 +1,18 @@
-var	User = require('./user'),
+var	fs = require('fs'),
+	async = require('async'),
+	path = require('path'),
+
+	User = require('./user'),
 	Plugins = require('./plugins'),
 	Meta = require('./meta'),
 	Translator = require('../public/src/translator'),
-
-	fs = require('fs'),
-	async = require('async'),
-	path = require('path'),
+	templates = require('../public/src/templates'),
 
 	Emailer = {};
 
 var	render = function(template, params, callback) {
-	if (templates[template] !== null) {
+
+	if (templates[template]) {
 		Translator.translate(templates[template].parse(params), function(template) {
 			callback(null, template);
 		});
diff --git a/src/routes/admin.js b/src/routes/admin.js
index d7c1c7863f..0cdac99a9a 100644
--- a/src/routes/admin.js
+++ b/src/routes/admin.js
@@ -7,13 +7,14 @@ var nconf = require('nconf'),
 	user = require('./../user'),
 	groups = require('../groups'),
 	topics = require('./../topics'),
-	pkg = require('./../../package.json'),
+	pkg = require('./../../package'),
 	categories = require('./../categories'),
 	meta = require('../meta'),
 	plugins = require('../plugins'),
 	Languages = require('../languages'),
 	events = require('./../events'),
-	utils = require('./../../public/src/utils.js');
+	utils = require('./../../public/src/utils'),
+	templates = require('./../../public/src/templates');
 
 (function (Admin) {
 	Admin.isAdmin = function (req, res, next) {
diff --git a/src/socket.io/index.js b/src/socket.io/index.js
index 993b9bb8ed..90ff00d7f3 100644
--- a/src/socket.io/index.js
+++ b/src/socket.io/index.js
@@ -30,9 +30,9 @@ Sockets.userSockets = {};
 Sockets.rooms = {};
 
 
-Sockets.init = function() {
+Sockets.init = function(server) {
 
-	io = socketioWildcard(SocketIO).listen(global.server, {
+	io = socketioWildcard(SocketIO).listen(server, {
 		log: false,
 		transports: ['websocket', 'xhr-polling', 'jsonp-polling', 'flashsocket'],
 		'browser client minification': true
diff --git a/src/webserver.js b/src/webserver.js
index 03bcf4abf3..ee5b1a0dc6 100644
--- a/src/webserver.js
+++ b/src/webserver.js
@@ -28,7 +28,9 @@ var path = require('path'),
 	meta = require('./meta'),
 	feed = require('./feed'),
 	plugins = require('./plugins'),
-	logger = require('./logger');
+	logger = require('./logger'),
+	templates = require('./../public/src/templates'),
+	translator = require('./../public/src/translator');
 
 if(nconf.get('ssl')) {
 	server = require('https').createServer({
@@ -39,13 +41,12 @@ if(nconf.get('ssl')) {
 	server = require('http').createServer(WebServer);
 }
 
+module.exports.server = server;
 
 (function (app) {
 	"use strict";
 
-	var templates = null,
-		clientScripts;
-
+	var	clientScripts;
 
 	plugins.ready(function() {
 		// Minify client-side libraries
@@ -60,9 +61,6 @@ if(nconf.get('ssl')) {
 		});
 	});
 
-
-	server.app = app;
-
 	/**
 	 *	`options` object	requires:	req, res
 	 *						accepts:	metaTags, linkTags
@@ -375,8 +373,6 @@ if(nconf.get('ssl')) {
 	});
 
 	module.exports.init = function () {
-		templates = global.templates;
-
 		// translate all static templates served by webserver here. ex. footer, logout
 		plugins.fireHook('filter:footer.build', '', function(err, appendHTML) {
 			var footer = templates.footer.parse({
@@ -931,6 +927,3 @@ if(nconf.get('ssl')) {
 
 	});
 }(WebServer));
-
-
-global.server = server;

From 1084523c92f81dcec5a6f0cf2f7891c8e89f37c5 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sat, 25 Jan 2014 19:19:25 -0500
Subject: [PATCH 10/28] lots of pagination work, query params, ajaxify to pids

---
 public/src/forum/category.js   |  16 +---
 public/src/forum/pagination.js |  19 ++---
 public/src/forum/topic.js      | 129 +++++++++++++--------------------
 public/templates/topic.tpl     |   6 +-
 src/categories.js              |   5 +-
 src/feed.js                    |   2 +-
 src/posts.js                   |  24 ++++++
 src/routes/api.js              |  44 +++++++++--
 src/socket.io/categories.js    |  17 -----
 src/socket.io/posts.js         |   4 +
 src/socket.io/topics.js        |  25 -------
 src/webserver.js               |  11 ++-
 tests/categories.js            |   2 +-
 13 files changed, 142 insertions(+), 162 deletions(-)

diff --git a/public/src/forum/category.js b/public/src/forum/category.js
index aa6b25dd79..b0dff6f486 100644
--- a/public/src/forum/category.js
+++ b/public/src/forum/category.js
@@ -52,24 +52,10 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 				}
 			});
 		} else {
-			pagination.init(templates.get('currentPage'), templates.get('pageCount'), loadPage);
+			pagination.init(templates.get('currentPage'), templates.get('pageCount'));
 		}
 	}
 
-	function loadPage(page, callback) {
-		socket.emit('categories.loadPage', {cid: templates.get('category_id'), page: page}, function(err, data) {
-			if(err) {
-				return callback(err);
-			}
-
-			if (data && data.topics && data.topics.length) {
-				Category.onTopicsLoaded(data.topics);
-			}
-
-			callback(null);
-		});
-	}
-
 	Category.onNewTopic = function(data) {
 		var html = templates.prepare(templates['category'].blocks['topics']).parse({
 			topics: [data]
diff --git a/public/src/forum/pagination.js b/public/src/forum/pagination.js
index d7e9abc965..7c21a3090d 100644
--- a/public/src/forum/pagination.js
+++ b/public/src/forum/pagination.js
@@ -5,12 +5,10 @@ define(function() {
 
 	pagination.currentPage = 0;
 	pagination.pageCount = 0;
-	pagination.loadFunction = null;
 
-	pagination.init = function(currentPage, pageCount, loadFunction) {
+	pagination.init = function(currentPage, pageCount) {
 		pagination.currentPage = parseInt(currentPage, 10);
 		pagination.pageCount = parseInt(pageCount, 10);
-		pagination.loadFunction = loadFunction;
 
 		updatePageLinks();
 
@@ -48,17 +46,9 @@ define(function() {
 			return;
 		}
 
-		pagination.loadFunction(page, function(err) {
-			if(err) {
-				return app.alertError(err.message);
-			}
-
-			pagination.currentPage = parseInt(page, 10);
-			updatePageLinks();
-		});
+		ajaxify.go(window.location.pathname.slice(1) + '?page=' + page);
 	}
 
-
 	function updatePageLinks() {
 		if(pagination.pageCount === 0) {
 			$('.pagination').addClass('hide');
@@ -79,6 +69,11 @@ define(function() {
 
 		$('.pagination .page').removeClass('active');
 		$('.pagination .page[data-page="' + pagination.currentPage + '"]').addClass('active');
+		$('.pagination .page').each(function(index, element) {
+			var li = $(this);
+			var page = li.attr('data-page');
+			li.find('a').attr('href', window.location.pathname + '?page=' + page);
+		});
 	}
 
 	return pagination;
diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js
index 60ab01ce92..3976687684 100644
--- a/public/src/forum/topic.js
+++ b/public/src/forum/topic.js
@@ -4,8 +4,8 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 		pagination;
 
 	function showBottomPostBar() {
-		if($('#post-container .post-row').length > 1) {
-			$('.topic-main-buttons').removeClass('hide').parent().removeClass('hide');
+		if($('#post-container .post-row').length > 1 || !$('#post-container li[data-index="0"]').length) {
+			$('.bottom-post-bar').removeClass('hide');
 		}
 	}
 
@@ -328,7 +328,7 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 
 			var bookmark = localStorage.getItem('topic:' + tid + ':bookmark');
 
-			if(bookmark && !config.usePagination) {
+			if(bookmark) {
 				Topic.scrollToPost(parseInt(bookmark, 10));
 			}
 
@@ -358,65 +358,10 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 			} else {
 				$('.pagination-block').addClass('hide');
 
-				pagination.init(currentPage, pageCount, loadPage);
+				pagination.init(currentPage, pageCount);
 			}
 		}
 
-		function loadPage(page, callback) {
-			if(page === 1) {
-				ajaxify.go('topic/' + tid );
-				return;
-			}
-
-			socket.emit('topics.loadPage', {tid: tid, page: page}, function(err, data) {
-				if(err) {
-					return callback(err);
-				}
-
-				if (data && data.posts && data.posts.length) {
-					createPagePosts(data, function() {
-						fixDeleteStateForPosts();
-					});
-				}
-
-				callback(null);
-			});
-		}
-
-		function onNewPostPagination(data) {
-			var posts = data.posts;
-			socket.emit('topics.getPageCount', tid, function(err, newPageCount) {
-
-				pagination.recreatePaginationLinks('topic', newPageCount);
-
-				if(pagination.currentPage === pagination.newPageCount) {
-					createNewPosts(data);
-				} else if(data.posts && data.posts.length && parseInt(data.posts[0].uid, 10) === parseInt(app.uid, 10)) {
-					pagination.loadPage(pagination.pageCount);
-				}
-			});
-		}
-
-		function createPagePosts(data, callback) {
-			if(!data || (data.posts && !data.posts.length)) {
-				return;
-			}
-
-			parseAndTranslatePosts(data.posts, function(translatedHTML) {
-				var translated = $(translatedHTML);
-
-				$('#post-container').fadeOut(200, function() {
-
-					$('#post-container').empty().append(translated).fadeIn('slow');
-
-					onNewPostsLoaded(data.posts);
-
-					callback();
-				});
-			});
-		}
-
-
 		$('.topic').on('click', '.post_reply', function() {
 			var selectionText = '',
 				selection = window.getSelection() || document.getSelection();
@@ -1071,36 +1016,64 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 			return;
 		}
 
-		var container = $(window),
+		if(config.usePagination) {
+			socket.emit('posts.getPidPage', pid, function(err, page) {
+				if(parseInt(page, 10) !== pagination.currentPage) {
+					pagination.loadPage(page);
+				} else {
+					scrollToPid(pid);
+				}
+			});
+		} else {
+			scrollToPid(pid);
+		}
+
+		function scrollToPid(pid) {
+			var container = $(window),
 			scrollTo = $('#post_anchor_' + pid),
 			tid = $('#post-container').attr('data-tid');
 
-		function animateScroll() {
-			$('window,html').animate({
-				scrollTop: scrollTo.offset().top + container.scrollTop() - $('#header-menu').height()
-			}, 400);
-		}
+			function animateScroll() {
+				$('window,html').animate({
+					scrollTop: scrollTo.offset().top + container.scrollTop() - $('#header-menu').height()
+				}, 400);
+			}
 
-		if (!scrollTo.length && tid) {
+			if (!scrollTo.length && tid) {
 
-			var intervalID = setInterval(function () {
-				loadMorePosts(tid, function (posts) {
-					scrollTo = $('#post_anchor_' + pid);
+				var intervalID = setInterval(function () {
+					loadMorePosts(tid, function (posts) {
+						scrollTo = $('#post_anchor_' + pid);
 
-					if (tid && scrollTo.length) {
-						animateScroll();
-					}
+						if (tid && scrollTo.length) {
+							animateScroll();
+						}
 
-					if (!posts.length || scrollTo.length)
-						clearInterval(intervalID);
-				});
-			}, 100);
+						if (!posts.length || scrollTo.length)
+							clearInterval(intervalID);
+					});
+				}, 100);
 
-		} else if (tid) {
-			animateScroll();
+			} else if (tid) {
+				animateScroll();
+			}
 		}
 	}
 
+	function onNewPostPagination(data) {
+		var posts = data.posts;
+		socket.emit('topics.getPageCount', tid, function(err, newPageCount) {
+
+			pagination.recreatePaginationLinks('topic', newPageCount);
+
+			if(pagination.currentPage === pagination.pageCount) {
+				createNewPosts(data);
+			} else if(data.posts && data.posts.length && parseInt(data.posts[0].uid, 10) === parseInt(app.uid, 10)) {
+				pagination.loadPage(pagination.pageCount);
+			}
+		});
+	}
+
 	function createNewPosts(data, infiniteLoaded) {
 		if(!data || (data.posts && !data.posts.length)) {
 			return;
diff --git a/public/templates/topic.tpl b/public/templates/topic.tpl
index 36b3a63076..bd5b7e82b7 100644
--- a/public/templates/topic.tpl
+++ b/public/templates/topic.tpl
@@ -143,7 +143,7 @@
 			</li>
 
 			<!-- IF @first -->
-			<li class="well post-bar">
+			<li class="well post-bar" data-index="{posts.index}">
 				<div class="inline-block">
 					<small class="topic-stats">
 						<span>[[category:posts]]</span>
@@ -178,8 +178,8 @@
 		<!-- END posts -->
 	</ul>
 
-	<div class="well col-md-11 col-xs-12 pull-right hide">
-		<div class="topic-main-buttons pull-right inline-block hide">
+	<div class="well col-md-11 col-xs-12 pull-right post-bar bottom-post-bar hide">
+		<div class="topic-main-buttons pull-right inline-block">
 			<div class="loading-indicator" done="0" style="display:none;">
 				<span class="hidden-xs-inline">[[topic:loading_more_posts]]</span> <i class="fa fa-refresh fa-spin"></i>
 			</div>
diff --git a/src/categories.js b/src/categories.js
index d3d6f04c95..5131f8e57a 100644
--- a/src/categories.js
+++ b/src/categories.js
@@ -46,15 +46,14 @@ var db = require('./database.js'),
 		});
 	};
 
-	Categories.getCategoryById = function(category_id, current_user, callback) {
+	Categories.getCategoryById = function(category_id, start, end, current_user, callback) {
 		Categories.getCategoryData(category_id, function(err, categoryData) {
 			if (err) {
 				return callback(err);
 			}
 
 			function getTopicIds(next) {
-				var topicsPerPage = meta.config.topicsPerPage || 20;
-				Categories.getTopicIds(category_id, 0, topicsPerPage - 1, next);
+				Categories.getTopicIds(category_id, start, end, next);
 			}
 
 			function getActiveUsers(next) {
diff --git a/src/feed.js b/src/feed.js
index ac55c64460..89828328e1 100644
--- a/src/feed.js
+++ b/src/feed.js
@@ -84,7 +84,7 @@
 	};
 
 	Feed.updateCategory = function (cid, callback) {
-		categories.getCategoryById(cid, 0, function (err, categoryData) {
+		categories.getCategoryById(cid, 0, -1, 0, function (err, categoryData) {
 			if (err) return callback(new Error('category-invalid'));
 
 			var feed = new rss({
diff --git a/src/posts.js b/src/posts.js
index b4aa4c1882..b7048dc09c 100644
--- a/src/posts.js
+++ b/src/posts.js
@@ -468,4 +468,28 @@ var db = require('./database'),
 		});
 	}
 
+	Posts.getPidPage = function(pid, callback) {
+		Posts.getPostField(pid, 'tid', function(err, tid) {
+			if(err) {
+				return callback(err);
+			}
+
+			topics.getPids(tid, function(err, pids) {
+				if(err) {
+					return callback(err);
+				}
+
+				var index = pids.indexOf(pid);
+				if(index === -1) {
+					return callback(new Error('pid not found'));
+				}
+				var postsPerPage = parseInt(meta.config.postsPerPage, 10);
+				postsPerPage = postsPerPage ? postsPerPage : 20;
+
+				var page = Math.ceil((index + 1) / postsPerPage);
+				callback(null, page);
+			});
+		});
+	}
+
 }(exports));
diff --git a/src/routes/api.js b/src/routes/api.js
index 171dc5147d..f700334764 100644
--- a/src/routes/api.js
+++ b/src/routes/api.js
@@ -164,17 +164,33 @@ var path = require('path'),
 			});
 
 			app.get('/topic/:id/:slug?', function (req, res, next) {
-				console.log(req.query);
+
 				var uid = (req.user) ? req.user.uid : 0;
+				var page = 1;
+				if(req.query && req.query.page) {
+					page = req.query.page;
+				}
+
+				if(parseInt(page, 10) < 1) {
+					return res.send(404);
+				}
+
+				var postsPerPage = parseInt(meta.config.postsPerPage ? meta.config.postsPerPage : 20, 10);
+				var start = (page - 1) * postsPerPage;
+				var end = start + postsPerPage - 1;
 
 				ThreadTools.privileges(req.params.id, uid, function(err, privileges) {
 					if (privileges.read) {
-						var postsPerPage = parseInt(meta.config.postsPerPage ? meta.config.postsPerPage : 20, 10);
-						topics.getTopicWithPosts(req.params.id, uid, 0, postsPerPage - 1, false, function (err, data) {
+						topics.getTopicWithPosts(req.params.id, uid, start, end, false, function (err, data) {
 							if(err) {
 								return next(err);
 							}
-							data.currentPage = 1;
+
+							if(page > data.pageCount) {
+								return res.send(404);
+							}
+
+							data.currentPage = page;
 							data.privileges = privileges;
 
 							if (parseInt(data.deleted, 10) === 1 && parseInt(data.expose_tools, 10) === 0) {
@@ -191,16 +207,32 @@ var path = require('path'),
 
 			app.get('/category/:id/:slug?', function (req, res, next) {
 				var uid = (req.user) ? req.user.uid : 0;
+				var page = 1;
+				if(req.query && req.query.page) {
+					page = req.query.page;
+				}
+
+				if(parseInt(page, 10) < 1) {
+					return res.send(404);
+				}
+
+				var topicsPerPage = parseInt(meta.config.topicsPerPage ? meta.config.topicsPerPage : 20, 10);
+				var start = (page - 1) * topicsPerPage;
+				var end = start + topicsPerPage - 1;
 
 				// Category Whitelisting
 				categoryTools.privileges(req.params.id, uid, function(err, privileges) {
 					if (!err && privileges.read) {
-						categories.getCategoryById(req.params.id, uid, function (err, data) {
+						categories.getCategoryById(req.params.id, start, end, uid, function (err, data) {
 							if(err) {
 								return next(err);
 							}
 
-							data.currentPage = 1;
+							if(page > data.pageCount) {
+								return res.send(404);
+							}
+
+							data.currentPage = page;
 							data.privileges = privileges;
 
 							if (data && parseInt(data.disabled, 10) === 0) {
diff --git a/src/socket.io/categories.js b/src/socket.io/categories.js
index ec663ee8e6..eaac85b4ac 100644
--- a/src/socket.io/categories.js
+++ b/src/socket.io/categories.js
@@ -28,23 +28,6 @@ SocketCategories.loadMore = function(socket, data, callback) {
 	});
 };
 
-SocketCategories.loadPage = function(socket, data, callback) {
-	if(!data) {
-		return callback(new Error('invalid data'));
-	}
-
-	var topicsPerPage = parseInt(meta.config.topicsPerPage, 10) || 20;
-
-	var start = (data.page - 1) * topicsPerPage,
-		end = start + topicsPerPage - 1;
-
-	categories.getCategoryTopics(data.cid, start, end, socket.uid, function(err, topics) {
-		callback(err, {
-			topics: topics
-		});
-	});
-}
-
 SocketCategories.getPageCount = function(socket, cid, callback) {
 	categories.getPageCount(cid, callback);
 }
diff --git a/src/socket.io/posts.js b/src/socket.io/posts.js
index 652f09cada..14726ab0cb 100644
--- a/src/socket.io/posts.js
+++ b/src/socket.io/posts.js
@@ -194,4 +194,8 @@ SocketPosts.getFavouritedUsers = function(socket, pid, callback) {
 	});
 };
 
+SocketPosts.getPidPage = function(socket, pid, callback) {
+	posts.getPidPage(pid, callback);
+}
+
 module.exports = SocketPosts;
\ No newline at end of file
diff --git a/src/socket.io/topics.js b/src/socket.io/topics.js
index 3a45f1293e..6ea39afbc9 100644
--- a/src/socket.io/topics.js
+++ b/src/socket.io/topics.js
@@ -245,31 +245,6 @@ SocketTopics.loadMore = function(socket, data, callback) {
 	});
 };
 
-SocketTopics.loadPage = function(socket, data, callback) {
-	if(!data || !data.tid || !data.page || parseInt(data.page < 0)) {
-		return callback(new Error('invalid data'));
-	}
-
-	var postsPerPage = parseInt((meta.config.postsPerPage ? meta.config.postsPerPage : 20), 10);
-
-	topics.getPageCount(data.tid, function(err, pageCount) {
-		if(err) {
-			return callback(err);
-		}
-
-		if(data.page > pageCount) {
-			return callback(new Error('page doesn\'t exist'));
-		}
-
-		var start = (data.page-1) * postsPerPage,
-			end = start + postsPerPage - 1;
-
-		topics.getTopicPosts(data.tid, start, end, socket.uid, function(err, posts) {
-			callback(err, {posts: posts});
-		});
-	});
-}
-
 SocketTopics.loadMoreRecentTopics = function(socket, data, callback) {
 	if(!data || !data.term) {
 		return callback(new Error('invalid data'));
diff --git a/src/webserver.js b/src/webserver.js
index ee5b1a0dc6..323a977522 100644
--- a/src/webserver.js
+++ b/src/webserver.js
@@ -9,6 +9,7 @@ var path = require('path'),
 	validator = require('validator'),
 	async = require('async'),
 	S = require('string'),
+	qs = require('querystring'),
 
 	pkg = require('../package.json'),
 
@@ -644,6 +645,10 @@ module.exports.server = server;
 				}
 
 				var topic_url = tid + (req.params.slug ? '/' + req.params.slug : '');
+				var queryString = qs.stringify(req.query);
+				if(queryString.length) {
+					topic_url += '?' + queryString;
+				}
 
 				res.send(
 					data.header +
@@ -701,7 +706,7 @@ module.exports.server = server;
 					});
 				},
 				function (next) {
-					categories.getCategoryById(cid, 0, function (err, categoryData) {
+					categories.getCategoryById(cid, 0, -1, 0, function (err, categoryData) {
 
 						if (categoryData) {
 							if (parseInt(categoryData.disabled, 10) === 1) {
@@ -758,6 +763,10 @@ module.exports.server = server;
 				}
 
 				var category_url = cid + (req.params.slug ? '/' + req.params.slug : '');
+				var queryString = qs.stringify(req.query);
+				if(queryString.length) {
+					category_url += '?' + queryString;
+				}
 
 				res.send(
 					data.header +
diff --git a/tests/categories.js b/tests/categories.js
index 6f83d774f8..ba9cf3b702 100644
--- a/tests/categories.js
+++ b/tests/categories.js
@@ -31,7 +31,7 @@ describe('Categories', function() {
 
 	describe('.getCategoryById', function() {
 		it('should retrieve a newly created category by its ID', function(done) {
-			Categories.getCategoryById(categoryObj.cid, 0, function(err, categoryData) {
+			Categories.getCategoryById(categoryObj.cid, 0, -1, 0, function(err, categoryData) {
 				assert(categoryData);
 				assert.equal(categoryObj.name, categoryData.category_name);
 				assert.equal(categoryObj.description, categoryData.category_description);

From 75f178636b93076335b4a956581ca02fe6864f91 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sat, 25 Jan 2014 19:50:50 -0500
Subject: [PATCH 11/28] more fixes

---
 public/src/forum/pagination.js | 2 +-
 public/src/forum/topic.js      | 3 +++
 public/src/templates.js        | 1 +
 src/routes/api.js              | 2 +-
 src/routes/user.js             | 1 +
 5 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/public/src/forum/pagination.js b/public/src/forum/pagination.js
index 7c21a3090d..ca0d0513c7 100644
--- a/public/src/forum/pagination.js
+++ b/public/src/forum/pagination.js
@@ -42,7 +42,7 @@ define(function() {
 
 	pagination.loadPage = function(page, callback) {
 		page = parseInt(page, 10);
-		if(page < 1 || page > pagination.pageCount) {
+		if(!utils.isNumber(page) || page < 1 || page > pagination.pageCount) {
 			return;
 		}
 
diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js
index 3976687684..cc5524655b 100644
--- a/public/src/forum/topic.js
+++ b/public/src/forum/topic.js
@@ -1018,6 +1018,9 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 
 		if(config.usePagination) {
 			socket.emit('posts.getPidPage', pid, function(err, page) {
+				if(err) {
+					return;
+				}
 				if(parseInt(page, 10) !== pagination.currentPage) {
 					pagination.loadPage(page);
 				} else {
diff --git a/public/src/templates.js b/public/src/templates.js
index 3e32653c1c..993cf20f30 100644
--- a/public/src/templates.js
+++ b/public/src/templates.js
@@ -196,6 +196,7 @@
 			template_data = data;
 			parse_template();
 		}).fail(function (data, textStatus) {
+			jQuery('#content, #footer').stop(true, true).removeClass('ajaxifying');
 			if (data && data.status == 404) {
 				return ajaxify.go('404');
 			} else if (data && data.status === 403) {
diff --git a/src/routes/api.js b/src/routes/api.js
index f700334764..286392e141 100644
--- a/src/routes/api.js
+++ b/src/routes/api.js
@@ -171,7 +171,7 @@ var path = require('path'),
 					page = req.query.page;
 				}
 
-				if(parseInt(page, 10) < 1) {
+				if(!utils.isNumber(page) || parseInt(page, 10) < 1) {
 					return res.send(404);
 				}
 
diff --git a/src/routes/user.js b/src/routes/user.js
index b8d385e3fd..7ae12c386b 100644
--- a/src/routes/user.js
+++ b/src/routes/user.js
@@ -8,6 +8,7 @@ var fs = require('fs'),
 	posts = require('./../posts'),
 	postTools = require('../postTools'),
 	utils = require('./../../public/src/utils'),
+	templates = require('./../../public/src/templates'),
 	meta = require('./../meta'),
 	db = require('./../database');
 

From 6ff11c524325a835183cb6c2032626c5e36adaad Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sat, 25 Jan 2014 19:57:25 -0500
Subject: [PATCH 12/28] check for number

---
 src/routes/api.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/routes/api.js b/src/routes/api.js
index 286392e141..c70dbd107b 100644
--- a/src/routes/api.js
+++ b/src/routes/api.js
@@ -212,7 +212,7 @@ var path = require('path'),
 					page = req.query.page;
 				}
 
-				if(parseInt(page, 10) < 1) {
+				if(!utils.isNumber(page) || parseInt(page, 10) < 1) {
 					return res.send(404);
 				}
 

From b4ea8e58fa94a19edeaadaa17ca28f93c192d9f3 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sat, 25 Jan 2014 20:08:02 -0500
Subject: [PATCH 13/28] removed check for no topics in category, you should be
 able to go into empty categories

---
 src/routes/api.js | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/routes/api.js b/src/routes/api.js
index c70dbd107b..6dbb0080f7 100644
--- a/src/routes/api.js
+++ b/src/routes/api.js
@@ -228,10 +228,6 @@ var path = require('path'),
 								return next(err);
 							}
 
-							if(page > data.pageCount) {
-								return res.send(404);
-							}
-
 							data.currentPage = page;
 							data.privileges = privileges;
 

From 6628db89af52099089d388194fce818a320132b2 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sat, 25 Jan 2014 20:36:55 -0500
Subject: [PATCH 14/28] added saerch array

---
 src/user.js | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/user.js b/src/user.js
index 14c370b451..4728f4b824 100644
--- a/src/user.js
+++ b/src/user.js
@@ -489,13 +489,13 @@ var bcrypt = require('bcrypt'),
 
 	User.search = function(query, callback) {
 		if (!query || query.length === 0) {
-			return callback(null, []);
+			return callback(null, {timing:0, users:[]});
 		}
 		var start = process.hrtime();
 
 		db.getObject('username:uid', function(err, usernamesHash) {
 			if (err) {
-				return callback(null, []);
+				return callback(null, {timing: 0, users:[]});
 			}
 
 			query = query.toLowerCase();
@@ -515,7 +515,9 @@ var bcrypt = require('bcrypt'),
 			});
 
 			User.getDataForUsers(results, function(userdata) {
-				callback(null, userdata);
+				var diff = process.hrtime(start);
+				var timing = (diff[0] * 1e3 + diff[1] / 1e6).toFixed(1);
+				callback(null, {timing: timing, users: userdata});
 			});
 		});
 	};

From a240fc81ce8eb86ab9bebda0b257580e56191c1e Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@designcreateplay.com>
Date: Sat, 25 Jan 2014 20:42:29 -0500
Subject: [PATCH 15/28] fixed #869

---
 public/src/forum/topic.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js
index cc5524655b..822ab3b2ca 100644
--- a/public/src/forum/topic.js
+++ b/public/src/forum/topic.js
@@ -376,7 +376,7 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 			var username = '',
 				post = $(this).parents('li[data-pid]');
 			if (post.length) {
-				username = '@' + post.attr('data-username') + ' ';
+				username = '@' + post.attr('data-username').replace(/\s/g, '-') + ' ';
 			}
 
 			if (thread_state.locked !== '1') {
@@ -391,7 +391,7 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 					pid = $(this).parents('.post-row').attr('data-pid');
 
 				if (post.length) {
-					username = '@' + post.attr('data-username');
+					username = '@' + post.attr('data-username').replace(/\s/g, '-');
 				}
 
 				socket.emit('posts.getRawPost', pid, function(err, post) {

From 1afd7ae33263e9102135e63b38232c48325f12f3 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sat, 25 Jan 2014 21:25:56 -0500
Subject: [PATCH 16/28] trim pagination numberS

---
 public/language/en/global.json |  5 ++++-
 public/src/forum/pagination.js | 40 +++++++++++++++++++++++++++-------
 public/templates/category.tpl  |  7 ++----
 public/templates/topic.tpl     |  7 ++----
 src/categories.js              | 24 +++++---------------
 src/topics.js                  | 24 +++++---------------
 6 files changed, 50 insertions(+), 57 deletions(-)

diff --git a/public/language/en/global.json b/public/language/en/global.json
index 6c41d49b2a..99fd8c74dc 100644
--- a/public/language/en/global.json
+++ b/public/language/en/global.json
@@ -33,5 +33,8 @@
 	"motd.get": "Get NodeBB",
 	"motd.fork": "Fork",
 	"motd.like": "Like",
-	"motd.follow": "Follow"
+	"motd.follow": "Follow",
+
+	"previouspage": "Previous Page",
+	"nextpage": "Next Page"
 }
diff --git a/public/src/forum/pagination.js b/public/src/forum/pagination.js
index ca0d0513c7..3915d40c1e 100644
--- a/public/src/forum/pagination.js
+++ b/public/src/forum/pagination.js
@@ -10,7 +10,7 @@ define(function() {
 		pagination.currentPage = parseInt(currentPage, 10);
 		pagination.pageCount = parseInt(pageCount, 10);
 
-		updatePageLinks();
+		pagination.recreatePaginationLinks(pageCount);
 
 		$('.pagination').on('click', '.previous', function() {
 			pagination.loadPage(pagination.currentPage - 1);
@@ -25,18 +25,42 @@ define(function() {
 		});
 	}
 
-	pagination.recreatePaginationLinks = function(template, newPageCount) {
+	pagination.recreatePaginationLinks = function(newPageCount) {
 		pagination.pageCount = parseInt(newPageCount, 10);
 
-		var pages = [];
-		for(var i=1; i<=pagination.pageCount; ++i) {
-			pages.push({pageNumber: i});
+		var pagesToShow = [1, pagination.pageCount];
+
+		var previous = pagination.currentPage - 1;
+		var next = pagination.currentPage + 1;
+
+		if(previous > 1 && pagesToShow.indexOf(previous) === -1) {
+			pagesToShow.push(previous);
+		}
+
+		if(next < pagination.pageCount && pagesToShow.indexOf(next) === -1) {
+			pagesToShow.push(next);
+		}
+
+		if(pagesToShow.indexOf(pagination.currentPage) === -1) {
+			pagesToShow.push(pagination.currentPage);
+		}
+
+		pagesToShow.sort(function(a, b) {
+			return parseInt(a, 10) - parseInt(b, 10);
+		});
+
+		var html = '';
+		for(var i=0; i<pagesToShow.length; ++i) {
+			if(i > 0) {
+				if (pagesToShow[i] - 1 !== pagesToShow[i-1]) {
+					html += '<li class="disabled"><a href="#">|</a></li>';
+				}
+			}
+			html += '<li class="page" data-page="' + pagesToShow[i] + '"><a href="#">' + pagesToShow[i] + '</a></li>';
 		}
 
-		var html = templates.prepare(templates[template].blocks['pages']).parse({pages:pages});
-		html = $(html);
 		$('.pagination li.page').remove();
-		html.insertAfter($('.pagination li.previous'));
+		$(html).insertAfter($('.pagination li.previous'));
 		updatePageLinks();
 	}
 
diff --git a/public/templates/category.tpl b/public/templates/category.tpl
index 81727bd042..5b578dc604 100644
--- a/public/templates/category.tpl
+++ b/public/templates/category.tpl
@@ -87,11 +87,8 @@
 		<!-- IF usePagination -->
 		<div class="text-center">
 			<ul class="pagination">
-				<li class="previous pull-left"><a href="#">&larr; Older</a></li>
-				<!-- BEGIN pages -->
-				<li class="page" data-page="{pages.pageNumber}"><a href="#">{pages.pageNumber}</a></li>
-				<!-- END pages -->
-				<li class="next pull-right"><a href="#">Newer &rarr;</a></li>
+				<li class="previous pull-left"><a href="#"><i class="fa fa-chevron-left"></i> [[global:previouspage]]</a></li>
+				<li class="next pull-right"><a href="#">[[global:nextpage]] <i class="fa fa-chevron-right"></i></a></li>
 			</ul>
 		</div>
 		<!-- ENDIF usePagination -->
diff --git a/public/templates/topic.tpl b/public/templates/topic.tpl
index bd5b7e82b7..39688723d8 100644
--- a/public/templates/topic.tpl
+++ b/public/templates/topic.tpl
@@ -206,11 +206,8 @@
 	<!-- IF usePagination -->
 	<div class="text-center">
 		<ul class="pagination">
-			<li class="previous pull-left"><a href="#">&larr; Older</a></li>
-			<!-- BEGIN pages -->
-			<li class="page" data-page="{pages.pageNumber}"><a href="#">{pages.pageNumber}</a></li>
-			<!-- END pages -->
-			<li class="next pull-right"><a href="#">Newer &rarr;</a></li>
+			<li class="previous pull-left"><a href="#"><i class="fa fa-chevron-left"></i> [[global:previouspage]]</a></li>
+			<li class="next pull-right"><a href="#">[[global:nextpage]] <i class="fa fa-chevron-right"></i></a></li>
 		</ul>
 	</div>
 	<!-- ENDIF usePagination -->
diff --git a/src/categories.js b/src/categories.js
index 5131f8e57a..a2aee70091 100644
--- a/src/categories.js
+++ b/src/categories.js
@@ -66,15 +66,15 @@ var db = require('./database.js'),
 				});
 			}
 
-			function getPages(next) {
-				Categories.getPages(category_id, next);
+			function getPageCount(next) {
+				Categories.getPageCount(category_id, next);
 			}
 
-			async.parallel([getTopicIds, getActiveUsers, getSidebars, getPages], function(err, results) {
+			async.parallel([getTopicIds, getActiveUsers, getSidebars, getPageCount], function(err, results) {
 				var tids = results[0],
 					active_users = results[1],
 					sidebars = results[2],
-					pages = results[3];
+					pageCount = results[3];
 
 				var category = {
 					'category_name': categoryData.name,
@@ -88,8 +88,7 @@ var db = require('./database.js'),
 					'category_id': category_id,
 					'active_users': [],
 					'topics': [],
-					'pages': pages,
-					'pageCount': pages.length,
+					'pageCount': pageCount,
 					'disableSocialButtons': meta.config.disableSocialButtons !== undefined ? parseInt(meta.config.disableSocialButtons, 10) !== 0 : false,
 					'sidebars': sidebars
 				};
@@ -145,19 +144,6 @@ var db = require('./database.js'),
 		db.getSortedSetRevRange('categories:' + cid + ':tid', start, stop, callback);
 	};
 
-	Categories.getPages = function(cid, callback) {
-		Categories.getPageCount(cid, function(err, pageCount) {
-			if(err) {
-				return callback(err);
-			}
-			var pages = [];
-			for(var i=1; i<=pageCount; ++i) {
-				pages.push({pageNumber: i});
-			}
-			callback(null, pages);
-		});
-	};
-
 	Categories.getPageCount = function(cid, callback) {
 		db.sortedSetCard('categories:' + cid + ':tid', function(err, topicCount) {
 			if(err) {
diff --git a/src/topics.js b/src/topics.js
index ab32d10267..d7848ce466 100644
--- a/src/topics.js
+++ b/src/topics.js
@@ -392,19 +392,6 @@ var async = require('async'),
 		});
 	}
 
-	Topics.getPages = function(tid, callback) {
-		Topics.getPageCount(tid, function(err, pageCount) {
-			if(err) {
-				return callback(err);
-			}
-			var pages = [];
-			for(var i=1; i<=pageCount; ++i) {
-				pages.push({pageNumber: i});
-			}
-			callback(null, pages);
-		});
-	}
-
 	Topics.getPageCount = function(tid, callback) {
 		db.sortedSetCard('tid:' + tid + ':posts', function(err, postCount) {
 			if(err) {
@@ -794,11 +781,11 @@ var async = require('async'),
 				Topics.getCategoryData(tid, next);
 			}
 
-			function getPages(next) {
-				Topics.getPages(tid, next);
+			function getPageCount(next) {
+				Topics.getPageCount(tid, next);
 			}
 
-			async.parallel([getTopicData, getTopicPosts, getPrivileges, getCategoryData, getPages], function(err, results) {
+			async.parallel([getTopicData, getTopicPosts, getPrivileges, getCategoryData, getPageCount], function(err, results) {
 				if (err) {
 					winston.error('[Topics.getTopicWithPosts] Could not retrieve topic data: ', err.message);
 					return callback(err, null);
@@ -808,7 +795,7 @@ var async = require('async'),
 					topicPosts = results[1],
 					privileges = results[2],
 					categoryData = results[3],
-					pages = results[4];
+					pageCount = results[4];
 
 				var postsPerPage = parseInt(meta.config.postsPerPage, 10);
 				postsPerPage = postsPerPage ? postsPerPage : 20;
@@ -824,8 +811,7 @@ var async = require('async'),
 					'slug': topicData.slug,
 					'postcount': topicData.postcount,
 					'viewcount': topicData.viewcount,
-					'pages': pages,
-					'pageCount': pages.length,
+					'pageCount': pageCount,
 					'unreplied': parseInt(topicData.postcount, 10) > 1,
 					'topic_id': tid,
 					'expose_tools': privileges.editable ? 1 : 0,

From bf81159558ec3aa3b454fde85426bcdcf0a00291 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sat, 25 Jan 2014 21:35:09 -0500
Subject: [PATCH 17/28] fixes a pagination bug

---
 public/src/forum/category.js   | 2 +-
 public/src/forum/pagination.js | 5 ++++-
 public/src/forum/topic.js      | 4 ++--
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/public/src/forum/category.js b/public/src/forum/category.js
index b0dff6f486..62c6e0f59f 100644
--- a/public/src/forum/category.js
+++ b/public/src/forum/category.js
@@ -91,7 +91,7 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 			addActiveUser(data);
 
 			socket.emit('categories.getPageCount', templates.get('category_id'), function(err, newPageCount) {
-				pagination.recreatePaginationLinks('category', newPageCount);
+				pagination.recreatePaginationLinks(newPageCount);
 			});
 
 			$('#topics-container span.timeago').timeago();
diff --git a/public/src/forum/pagination.js b/public/src/forum/pagination.js
index 3915d40c1e..c8ba63bc38 100644
--- a/public/src/forum/pagination.js
+++ b/public/src/forum/pagination.js
@@ -28,7 +28,10 @@ define(function() {
 	pagination.recreatePaginationLinks = function(newPageCount) {
 		pagination.pageCount = parseInt(newPageCount, 10);
 
-		var pagesToShow = [1, pagination.pageCount];
+		var pagesToShow = [1];
+		if(pagination.pageCount !== 1) {
+			pagesToShow.push(pagination.pageCount);
+		}
 
 		var previous = pagination.currentPage - 1;
 		var next = pagination.currentPage + 1;
diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js
index 822ab3b2ca..d83b62218f 100644
--- a/public/src/forum/topic.js
+++ b/public/src/forum/topic.js
@@ -1065,9 +1065,9 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 
 	function onNewPostPagination(data) {
 		var posts = data.posts;
-		socket.emit('topics.getPageCount', tid, function(err, newPageCount) {
+		socket.emit('topics.getPageCount', templates.get('topic_id'), function(err, newPageCount) {
 
-			pagination.recreatePaginationLinks('topic', newPageCount);
+			pagination.recreatePaginationLinks(newPageCount);
 
 			if(pagination.currentPage === pagination.pageCount) {
 				createNewPosts(data);

From d42beda3da807841c516afdf8ff5f85bbaa6b75f Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@designcreateplay.com>
Date: Sat, 25 Jan 2014 21:44:47 -0500
Subject: [PATCH 18/28] added page selection if you click on the pipe

---
 public/src/forum/pagination.js | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)

diff --git a/public/src/forum/pagination.js b/public/src/forum/pagination.js
index 3915d40c1e..dec14202f2 100644
--- a/public/src/forum/pagination.js
+++ b/public/src/forum/pagination.js
@@ -12,17 +12,19 @@ define(function() {
 
 		pagination.recreatePaginationLinks(pageCount);
 
-		$('.pagination').on('click', '.previous', function() {
-			pagination.loadPage(pagination.currentPage - 1);
-		});
-
-		$('.pagination').on('click', '.next', function() {
-			pagination.loadPage(pagination.currentPage + 1);
-		});
-
-		$('.pagination').on('click', '.page', function() {
-			pagination.loadPage($(this).attr('data-page'));
-		});
+		$('.pagination')
+			.on('click', '.previous', function() {
+				pagination.loadPage(pagination.currentPage - 1);
+			}).on('click', '.next', function() {
+				pagination.loadPage(pagination.currentPage + 1);
+			}).on('click', '.page', function() {
+				pagination.loadPage($(this).attr('data-page'));
+			}).on('click', '.select_page', function(e) {
+				e.preventDefault();
+				bootbox.prompt('Enter page number:', function(pageNum) {
+					pagination.loadPage(pageNum);
+				});
+			});
 	}
 
 	pagination.recreatePaginationLinks = function(newPageCount) {
@@ -53,7 +55,7 @@ define(function() {
 		for(var i=0; i<pagesToShow.length; ++i) {
 			if(i > 0) {
 				if (pagesToShow[i] - 1 !== pagesToShow[i-1]) {
-					html += '<li class="disabled"><a href="#">|</a></li>';
+					html += '<li class="disabled"><a class="select_page" href="#">|</a></li>';
 				}
 			}
 			html += '<li class="page" data-page="' + pagesToShow[i] + '"><a href="#">' + pagesToShow[i] + '</a></li>';

From 2988230b073c81ee9d99c1a5822f4558bda89b7a Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sat, 25 Jan 2014 22:19:51 -0500
Subject: [PATCH 19/28] some more fixes, cant quote and see deleted messages

---
 public/src/forum/pagination.js | 11 ++++----
 public/src/forum/topic.js      | 47 ++++++++++++----------------------
 src/socket.io/posts.js         | 12 ++++++++-
 3 files changed, 34 insertions(+), 36 deletions(-)

diff --git a/public/src/forum/pagination.js b/public/src/forum/pagination.js
index 3a95d250af..66db32c959 100644
--- a/public/src/forum/pagination.js
+++ b/public/src/forum/pagination.js
@@ -14,11 +14,11 @@ define(function() {
 
 		$('.pagination')
 			.on('click', '.previous', function() {
-				pagination.loadPage(pagination.currentPage - 1);
+				return pagination.loadPage(pagination.currentPage - 1);
 			}).on('click', '.next', function() {
-				pagination.loadPage(pagination.currentPage + 1);
+				return pagination.loadPage(pagination.currentPage + 1);
 			}).on('click', '.page', function() {
-				pagination.loadPage($(this).attr('data-page'));
+				return pagination.loadPage($(this).attr('data-page'));
 			}).on('click', '.select_page', function(e) {
 				e.preventDefault();
 				bootbox.prompt('Enter page number:', function(pageNum) {
@@ -58,7 +58,7 @@ define(function() {
 		for(var i=0; i<pagesToShow.length; ++i) {
 			if(i > 0) {
 				if (pagesToShow[i] - 1 !== pagesToShow[i-1]) {
-					html += '<li class="disabled"><a class="select_page" href="#">|</a></li>';
+					html += '<li><a class="select_page" href="#">|</a></li>';
 				}
 			}
 			html += '<li class="page" data-page="' + pagesToShow[i] + '"><a href="#">' + pagesToShow[i] + '</a></li>';
@@ -72,10 +72,11 @@ define(function() {
 	pagination.loadPage = function(page, callback) {
 		page = parseInt(page, 10);
 		if(!utils.isNumber(page) || page < 1 || page > pagination.pageCount) {
-			return;
+			return false;
 		}
 
 		ajaxify.go(window.location.pathname.slice(1) + '?page=' + page);
+		return true;
 	}
 
 	function updatePageLinks() {
diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js
index d83b62218f..99de78753f 100644
--- a/public/src/forum/topic.js
+++ b/public/src/forum/topic.js
@@ -396,7 +396,7 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 
 				socket.emit('posts.getRawPost', pid, function(err, post) {
 					if(err) {
-						return app.alert(err.message);
+						return app.alertError(err.message);
 					}
 					var quoted = '';
 					if(post) {
@@ -895,47 +895,34 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 		}
 
 		function toggle_post_delete_state(pid) {
-			var postEl = $(document.querySelector('#post-container li[data-pid="' + pid + '"]'));
+			var postEl = $('#post-container li[data-pid="' + pid + '"]');
 
-			if (postEl[0]) {
-				quoteEl = postEl.find('.quote'),
-				favEl = postEl.find('.favourite'),
-				replyEl = postEl.find('.post_reply');
+			if (postEl.length) {
+				postEl.toggleClass('deleted');
 
-				socket.emit('posts.getPrivileges', pid, function(err, privileges) {
-					if(err) {
-						return app.alert(err.message);
-					}
+				toggle_post_tools(pid, postEl.hasClass('deleted'));
 
-					if (privileges.editable) {
-						if (!postEl.hasClass('deleted')) {
-							toggle_post_tools(pid, false);
-						} else {
-							toggle_post_tools(pid, true);
-						}
-					}
-
-					postEl.toggleClass('deleted');
-
-					updatePostCount();
-				});
+				updatePostCount();
 			}
 		}
 
-		function toggle_post_tools(pid, state) {
-			var postEl = $(document.querySelector('#post-container li[data-pid="' + pid + '"]')),
+		function toggle_post_tools(pid, isDeleted) {
+			var postEl = $('#post-container li[data-pid="' + pid + '"]'),
 				quoteEl = $(postEl[0].querySelector('.quote')),
 				favEl = $(postEl[0].querySelector('.favourite')),
-				replyEl = $(postEl[0].querySelector('.post_reply'));
+				replyEl = $(postEl[0].querySelector('.post_reply')),
+				chatEl = $(postEl[0].querySelector('.chat'));
 
-			if (state) {
-				quoteEl.removeClass('none');
-				favEl.removeClass('none');
-				replyEl.removeClass('none');
-			} else {
+			if (isDeleted) {
 				quoteEl.addClass('none');
 				favEl.addClass('none');
 				replyEl.addClass('none');
+				chatEl.addClass('none');
+			} else {
+				quoteEl.removeClass('none');
+				favEl.removeClass('none');
+				replyEl.removeClass('none');
+				chatEl.removeClass('none');
 			}
 		}
 
diff --git a/src/socket.io/posts.js b/src/socket.io/posts.js
index 14726ab0cb..cf5c05a444 100644
--- a/src/socket.io/posts.js
+++ b/src/socket.io/posts.js
@@ -93,7 +93,17 @@ SocketPosts.uploadFile = function(socket, data, callback) {
 };
 
 SocketPosts.getRawPost = function(socket, pid, callback) {
-	posts.getPostField(pid, 'content', callback);
+	posts.getPostFields(pid, ['content', 'deleted'], function(err, data) {
+		if(err) {
+			return callback(err);
+		}
+
+		if(data.deleted === '1') {
+			return callback(new Error('This post no longer exists'));
+		}
+
+		callback(null, data.content);
+	});
 };
 
 SocketPosts.edit = function(socket, data, callback) {

From 810095d287da8351f7824ec35b5685f7188c2b1b Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sat, 25 Jan 2014 22:30:48 -0500
Subject: [PATCH 20/28] fixed infinite loading on categories

---
 public/src/forum/category.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/public/src/forum/category.js b/public/src/forum/category.js
index 62c6e0f59f..bcc636a839 100644
--- a/public/src/forum/category.js
+++ b/public/src/forum/category.js
@@ -48,7 +48,7 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 				var bottom = ($(document).height() - $(window).height()) * 0.9;
 
 				if ($(window).scrollTop() > bottom && !loadingMoreTopics) {
-					Category.loadMoreTopics(cid);
+					Category.loadMoreTopics(templates.get('category_id'));
 				}
 			});
 		} else {

From bd0b5f4cdb8801a702d6c9567ad8a90a8d0d3b57 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sat, 25 Jan 2014 22:43:49 -0500
Subject: [PATCH 21/28] more error checks in thread move

---
 src/threadTools.js | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/src/threadTools.js b/src/threadTools.js
index 076c9b4b0b..201cf7afe8 100644
--- a/src/threadTools.js
+++ b/src/threadTools.js
@@ -187,9 +187,20 @@ var winston = require('winston'),
 
 	ThreadTools.move = function(tid, cid, callback) {
 		topics.getTopicFields(tid, ['cid', 'lastposttime'], function(err, topicData) {
+			if(err) {
+				return callback(err);
+			}
+
 			var oldCid = topicData.cid;
+			if(!oldCid) {
+				return callback(new Error('invalid-topic'));
+			}
 
 			db.sortedSetRemove('categories:' + oldCid + ':tid', tid, function(err, result) {
+				if(err) {
+					return callback(err);
+				}
+
 				db.sortedSetAdd('categories:' + cid + ':tid', topicData.lastposttime, tid, function(err, result) {
 
 					if(err) {

From 14e68bc9e2c07bfff87ab446f8804689ee366edb Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sun, 26 Jan 2014 01:34:40 -0500
Subject: [PATCH 22/28] dropup for bottom post bar

---
 public/templates/topic.tpl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/public/templates/topic.tpl b/public/templates/topic.tpl
index 39688723d8..7ee6f547c8 100644
--- a/public/templates/topic.tpl
+++ b/public/templates/topic.tpl
@@ -186,7 +186,7 @@
 			<!-- IF privileges.write -->
 			<button class="btn btn-primary post_reply" type="button">[[topic:reply]]</button>
 			<!-- ENDIF privileges.write -->
-			<div class="btn-group thread-tools hide">
+			<div class="btn-group thread-tools hide dropup">
 				<button class="btn btn-default dropdown-toggle" data-toggle="dropdown" type="button">[[topic:thread_tools.title]] <span class="caret"></span></button>
 				<ul class="dropdown-menu pull-right">
 					<li><a href="#" class="markAsUnreadForAll"><i class="fa fa-inbox"></i> [[topic:thread_tools.markAsUnreadForAll]]</a></li>

From d7d4290099c3c0438110cdd625723acf7b5ec4cc Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@designcreateplay.com>
Date: Sun, 26 Jan 2014 13:10:39 -0500
Subject: [PATCH 23/28] resolved #879

---
 src/plugins.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/plugins.js b/src/plugins.js
index 375616c414..9b7257204b 100644
--- a/src/plugins.js
+++ b/src/plugins.js
@@ -202,6 +202,10 @@ var fs = require('fs'),
 		} else return;
 	};
 
+	Plugins.hasListeners = function(hook, callback) {
+		return Plugins.loadedHooks[hook].length > 0;
+	};
+
 	Plugins.fireHook = function(hook, args, callback) {
 		hookList = Plugins.loadedHooks[hook];
 

From 96b2a1529038b4818d5c76f3c0211fcca6e0777b Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@designcreateplay.com>
Date: Sun, 26 Jan 2014 13:21:23 -0500
Subject: [PATCH 24/28] user registration now no longer sends a welcome email
 if no emailers are present

---
 src/plugins.js | 4 ++--
 src/user.js    | 4 ++++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/plugins.js b/src/plugins.js
index 9b7257204b..5f1bd0d4e2 100644
--- a/src/plugins.js
+++ b/src/plugins.js
@@ -202,8 +202,8 @@ var fs = require('fs'),
 		} else return;
 	};
 
-	Plugins.hasListeners = function(hook, callback) {
-		return Plugins.loadedHooks[hook].length > 0;
+	Plugins.hasListeners = function(hook) {
+		return (Plugins.loadedHooks[hook] && Plugins.loadedHooks[hook].length > 0);
 	};
 
 	Plugins.fireHook = function(hook, args, callback) {
diff --git a/src/user.js b/src/user.js
index 4728f4b824..4ddfa25f16 100644
--- a/src/user.js
+++ b/src/user.js
@@ -886,6 +886,10 @@ var bcrypt = require('bcrypt'),
 
 	User.email = {
 		verify: function(uid, email) {
+			if (!plugins.hasListeners('action:email.send')) {
+				return;
+			}
+
 			var confirm_code = utils.generateUUID(),
 				confirm_link = nconf.get('url') + '/confirm/' + confirm_code;
 

From c6d48f477c0ea03db52a8b8b08d27138b079fac3 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sun, 26 Jan 2014 14:03:33 -0500
Subject: [PATCH 25/28] fixes recent topic post notification

---
 public/src/forum/recent.js | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/public/src/forum/recent.js b/public/src/forum/recent.js
index 8e0eaeb293..10c8968417 100644
--- a/public/src/forum/recent.js
+++ b/public/src/forum/recent.js
@@ -38,10 +38,8 @@ define(function() {
 		});
 
 		socket.on('event:new_topic', function(data) {
-
 			++Recent.newTopicCount;
 			Recent.updateAlertText();
-
 		});
 
 		socket.on('event:new_post', function(data) {
@@ -61,16 +59,16 @@ define(function() {
 	Recent.updateAlertText = function() {
 		var text = 'There';
 
-		if (newTopicCount > 1) {
-			text += ' are ' + newTopicCount + ' new topics';
-		} else if (newTopicCount === 1) {
+		if (Recent.newTopicCount > 1) {
+			text += ' are ' + Recent.newTopicCount + ' new topics';
+		} else if (Recent.newTopicCount === 1) {
 			text += ' is a new topic';
 		}
 
-		if (newPostCount > 1) {
-			text += (newTopicCount?' and ':' are ') + newPostCount + ' new posts';
+		if (Recent.newPostCount > 1) {
+			text += (Recent.newTopicCount?' and ':' are ') + Recent.newPostCount + ' new posts';
 		} else if(newPostCount === 1) {
-			text += (newTopicCount?' and ':' is ') + ' a new post';
+			text += (Recent.newTopicCount?' and ':' is ') + ' a new post';
 		}
 
 		text += '. Click here to reload.';

From 2560704839875e30d9cc4d01999ec6ac030227b5 Mon Sep 17 00:00:00 2001
From: Baris Soner Usakli <barisusakli@gmail.com>
Date: Sun, 26 Jan 2014 14:56:16 -0500
Subject: [PATCH 26/28] recent unread cleanup

---
 public/src/app.js            | 10 ++++
 public/src/forum/category.js |  6 +--
 public/src/forum/recent.js   | 98 +++++++++++++++++++-----------------
 public/src/forum/topic.js    |  6 +--
 public/src/forum/unread.js   | 88 ++++++--------------------------
 5 files changed, 81 insertions(+), 127 deletions(-)

diff --git a/public/src/app.js b/public/src/app.js
index 3f9f33e152..21c0c72c86 100644
--- a/public/src/app.js
+++ b/public/src/app.js
@@ -396,6 +396,16 @@ var socket,
 		});
 	};
 
+	app.enableInfiniteLoading = function(callback) {
+		$(window).off('scroll').on('scroll', function() {
+			var bottom = ($(document).height() - $(window).height()) * 0.9;
+
+			if ($(window).scrollTop() > bottom) {
+				callback();
+			}
+		});
+	}
+
 	var	titleObj = {
 			active: false,
 			interval: undefined,
diff --git a/public/src/forum/category.js b/public/src/forum/category.js
index bcc636a839..29dcffa269 100644
--- a/public/src/forum/category.js
+++ b/public/src/forum/category.js
@@ -44,10 +44,8 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 
 	function enableInfiniteLoading() {
 		if(!config.usePagination) {
-			$(window).off('scroll').on('scroll', function (ev) {
-				var bottom = ($(document).height() - $(window).height()) * 0.9;
-
-				if ($(window).scrollTop() > bottom && !loadingMoreTopics) {
+			app.enableInfiniteLoading(function() {
+				if(!loadingMoreTopics) {
 					Category.loadMoreTopics(templates.get('category_id'));
 				}
 			});
diff --git a/public/src/forum/recent.js b/public/src/forum/recent.js
index 10c8968417..966ce0058d 100644
--- a/public/src/forum/recent.js
+++ b/public/src/forum/recent.js
@@ -1,20 +1,16 @@
 define(function() {
 	var	Recent = {};
 
-	Recent.newTopicCount = 0;
-	Recent.newPostCount = 0;
-	Recent.loadingMoreTopics = false;
+	var newTopicCount = 0,
+		newPostCount = 0,
+		loadingMoreTopics = false;
 
 	var active = '';
 
 	Recent.init = function() {
 		app.enterRoom('recent_posts');
 
-		ajaxify.register_events([
-			'event:new_topic',
-			'event:new_post'
-		]);
-
+		Recent.watchForNewPosts();
 
 		function getActiveSection() {
 			var url = window.location.href,
@@ -37,78 +33,90 @@ define(function() {
 			$(this).addClass('hide');
 		});
 
+
+		app.enableInfiniteLoading(function() {
+			if(!loadingMoreTopics) {
+				Recent.loadMoreTopics();
+			}
+		});
+	};
+
+	Recent.watchForNewPosts = function () {
+
+		newPostCount = 0;
+		newTopicCount = 0;
+
+		ajaxify.register_events([
+			'event:new_topic',
+			'event:new_post'
+		]);
+
 		socket.on('event:new_topic', function(data) {
-			++Recent.newTopicCount;
+			++newTopicCount;
 			Recent.updateAlertText();
 		});
 
 		socket.on('event:new_post', function(data) {
-			++Recent.newPostCount;
+			++newPostCount;
 			Recent.updateAlertText();
 		});
-
-		$(window).off('scroll').on('scroll', function() {
-			var bottom = ($(document).height() - $(window).height()) * 0.9;
-
-			if ($(window).scrollTop() > bottom && !Recent.loadingMoreTopics) {
-				Recent.loadMoreTopics();
-			}
-		});
-	};
+	}
 
 	Recent.updateAlertText = function() {
 		var text = 'There';
 
-		if (Recent.newTopicCount > 1) {
-			text += ' are ' + Recent.newTopicCount + ' new topics';
-		} else if (Recent.newTopicCount === 1) {
+		if (newTopicCount > 1) {
+			text += ' are ' + newTopicCount + ' new topics';
+		} else if (newTopicCount === 1) {
 			text += ' is a new topic';
 		}
 
-		if (Recent.newPostCount > 1) {
-			text += (Recent.newTopicCount?' and ':' are ') + Recent.newPostCount + ' new posts';
+		if (newPostCount > 1) {
+			text += (newTopicCount?' and ':' are ') + newPostCount + ' new posts';
 		} else if(newPostCount === 1) {
-			text += (Recent.newTopicCount?' and ':' is ') + ' a new post';
+			text += (newTopicCount?' and ':' is ') + ' a new post';
 		}
 
 		text += '. Click here to reload.';
 
 		$('#new-topics-alert').html(text).removeClass('hide').fadeIn('slow');
+		$('#category-no-topics').addClass('hide');
 	}
 
-	Recent.onTopicsLoaded = function(topics) {
-		var html = templates.prepare(templates['recent'].blocks['topics']).parse({
+	Recent.loadMoreTopics = function() {
+		loadingMoreTopics = true;
+		socket.emit('topics.loadMoreRecentTopics', {
+			after: $('#topics-container').children('li').length,
+			term: active
+		}, function(err, data) {
+			if(err) {
+				return app.alertError(err.message);
+			}
+
+			if (data.topics && data.topics.length) {
+				Recent.onTopicsLoaded('recent', data.topics);
+			}
+
+			loadingMoreTopics = false;
+		});
+	}
+
+	Recent.onTopicsLoaded = function(template, topics) {
+		var html = templates.prepare(templates[template].blocks['topics']).parse({
 			topics: topics
 		});
 
 		translator.translate(html, function(translatedHTML) {
-			var container = $('#topics-container');
 
 			$('#category-no-topics').remove();
 
 			html = $(translatedHTML);
-			container.append(html);
+			$('#topics-container').append(html);
 			$('span.timeago').timeago();
 			app.createUserTooltips();
 			app.makeNumbersHumanReadable(html.find('.human-readable-number'));
 		});
 	}
 
-	Recent.loadMoreTopics = function() {
-		Recent.loadingMoreTopics = true;
-		socket.emit('topics.loadMoreRecentTopics', {
-			after: $('#topics-container').children('li').length,
-			term: active
-		}, function(err, data) {
-			if(err) {
-				return app.alertError(err.message);
-			}
-			if (data.topics && data.topics.length) {
-				Recent.onTopicsLoaded(data.topics);
-			}
-			Recent.loadingMoreTopics = false;
-		});
-	}
-
 	return Recent;
 });
diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js
index 99de78753f..518ea3d64b 100644
--- a/public/src/forum/topic.js
+++ b/public/src/forum/topic.js
@@ -346,10 +346,8 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 
 		function enableInfiniteLoading() {
 			if(!config.usePagination) {
-				$(window).off('scroll').on('scroll', function() {
-					var bottom = ($(document).height() - $(window).height()) * 0.9;
-
-					if ($(window).scrollTop() > bottom && !infiniteLoaderActive && $('#post-container').children().length) {
+				app.enableInfiniteLoading(function() {
+					if (!infiniteLoaderActive && $('#post-container').children().length) {
 						loadMorePosts(tid, function(posts) {
 							fixDeleteStateForPosts();
 						});
diff --git a/public/src/forum/unread.js b/public/src/forum/unread.js
index abd19067de..b562ce1502 100644
--- a/public/src/forum/unread.js
+++ b/public/src/forum/unread.js
@@ -1,53 +1,15 @@
-define(function() {
+define(['forum/recent'], function(recent) {
 	var Unread = {},
 		loadingMoreTopics = false;
 
 	Unread.init = function() {
 		app.enterRoom('recent_posts');
 
-		ajaxify.register_events([
-			'event:new_topic',
-			'event:new_post',
-			'topics.markAllRead'
-		]);
-
-		var newTopicCount = 0,
-			newPostCount = 0;
-
 		$('#new-topics-alert').on('click', function() {
 			$(this).addClass('hide');
 		});
 
-		socket.on('event:new_topic', function(data) {
-			++newTopicCount;
-			updateAlertText();
-		});
-
-		function updateAlertText() {
-			var text = 'There';
-
-			if (newTopicCount > 1) {
-				text += ' are ' + newTopicCount + ' new topics';
-			} else if (newTopicCount === 1) {
-				text += ' is a new topic';
-			}
-
-			if (newPostCount > 1) {
-				text += (newTopicCount?' and ':' are ') + newPostCount + ' new posts';
-			} else if(newPostCount === 1) {
-				text += (newTopicCount?' and ':' is ') + ' a new post';
-			}
-
-			text += '. Click here to reload.';
-
-			$('#new-topics-alert').html(text).removeClass('hide').fadeIn('slow');
-			$('#category-no-topics').addClass('hidden');
-		}
-
-		socket.on('event:new_post', function(data) {
-			++newPostCount;
-			updateAlertText();
-		});
+		recent.watchForNewPosts();
 
 		$('#mark-allread-btn').on('click', function() {
 			var btn = $(this);
@@ -67,24 +29,19 @@ define(function() {
 			});
 		});
 
-		function onTopicsLoaded(topics) {
-
-			var html = templates.prepare(templates['unread'].blocks['topics']).parse({
-				topics: topics
-			});
-
-			translator.translate(html, function(translatedHTML) {
-				var container = $('#topics-container');
+		if ($("body").height() <= $(window).height() && $('#topics-container').children().length >= 20) {
+			$('#load-more-btn').show();
+		}
 
-				$('#category-no-topics').remove();
+		$('#load-more-btn').on('click', function() {
+			loadMoreTopics();
+		});
 
-				html = $(translatedHTML);
-				container.append(html);
-				$('span.timeago').timeago();
-				app.createUserTooltips();
-				app.makeNumbersHumanReadable(html.find('.human-readable-number'));
-			});
-		}
+		app.enableInfiniteLoading(function() {
+			if(!loadingMoreTopics) {
+				loadMoreTopics();
+			}
+		});
 
 		function loadMoreTopics() {
 			loadingMoreTopics = true;
@@ -96,7 +53,7 @@ define(function() {
 				}
 
 				if (data.topics && data.topics.length) {
-					onTopicsLoaded(data.topics);
+					recent.onTopicsLoaded('unread', data.topics);
 					$('#topics-container').attr('data-next-start', data.nextStart);
 				} else {
 					$('#load-more-btn').hide();
@@ -105,23 +62,6 @@ define(function() {
 				loadingMoreTopics = false;
 			});
 		}
-
-		$(window).off('scroll').on('scroll', function() {
-			var bottom = ($(document).height() - $(window).height()) * 0.9;
-
-			if ($(window).scrollTop() > bottom && !loadingMoreTopics) {
-				loadMoreTopics();
-			}
-		});
-
-
-		if ($("body").height() <= $(window).height() && $('#topics-container').children().length >= 20) {
-			$('#load-more-btn').show();
-		}
-
-		$('#load-more-btn').on('click', function() {
-			loadMoreTopics();
-		});
 	};
 
 	return Unread;

From 22354227be7f710ebf0b93d303f72b717ad980c9 Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@designcreateplay.com>
Date: Sun, 26 Jan 2014 15:59:22 -0500
Subject: [PATCH 27/28] hiding "Forgot Password" link using
 Plugins.hasListeners, instead of derpy config settings bool

---
 public/src/forum/login.js  |  6 ------
 public/templates/login.tpl |  5 ++++-
 src/routes/api.js          | 11 ++++++-----
 3 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/public/src/forum/login.js b/public/src/forum/login.js
index 9dca615a75..563db9d64e 100644
--- a/public/src/forum/login.js
+++ b/public/src/forum/login.js
@@ -52,12 +52,6 @@ define(function() {
 		});
 
 		document.querySelector('#content input').focus();
-
-		if(!config.emailSetup)
-			$('#reset-link').addClass('hide');
-		else
-			$('#reset-link').removeClass('hide');
-
 	};
 
 	return Login;
diff --git a/public/templates/login.tpl b/public/templates/login.tpl
index 1557a6c2e3..8f7807421d 100644
--- a/public/templates/login.tpl
+++ b/public/templates/login.tpl
@@ -41,7 +41,10 @@
 				<div class="form-group">
 					<div class="col-lg-offset-2 col-lg-10">
 						<hr />
-						<button class="btn btn-primary btn-lg btn-block"  id="login" type="submit">[[login:login]]</button> &nbsp; <a id="reset-link" class="hide" href="{relative_path}/reset">[[login:forgot_password]]</a>
+						<button class="btn btn-primary btn-lg btn-block"  id="login" type="submit">[[login:login]]</button>
+						<!-- IF showResetLink -->
+						&nbsp; <a id="reset-link" href="{relative_path}/reset">[[login:forgot_password]]</a>
+						<!-- ENDIF showResetLink -->
 					</div>
 				</div>
 				<input type="hidden" name="_csrf" value="{token}" id="csrf-token" />
diff --git a/src/routes/api.js b/src/routes/api.js
index 6dbb0080f7..08d4107f74 100644
--- a/src/routes/api.js
+++ b/src/routes/api.js
@@ -11,10 +11,11 @@ var path = require('path'),
 	posts = require('../posts'),
 	categories = require('../categories'),
 	categoryTools = require('../categoryTools')
+	meta = require('../meta'),
+	Plugins = require('../plugins'),
 	utils = require('../../public/src/utils'),
 	translator = require('../../public/src/translator'),
-	pkg = require('../../package.json'),
-	meta = require('../meta');
+	pkg = require('../../package.json');
 
 
 (function (Api) {
@@ -46,7 +47,6 @@ var path = require('path'),
 				config.topicsPerPage = meta.config.topicsPerPage || 20;
 				config.postsPerPage = meta.config.postsPerPage || 20;
 				config.maximumFileSize = meta.config.maximumFileSize;
-				config.emailSetup = !!meta.config['email:from'];
 				config.defaultLang = meta.config.defaultLang || 'en';
 
 				res.json(200, config);
@@ -116,7 +116,8 @@ var path = require('path'),
 			app.get('/login', function (req, res) {
 				var data = {},
 					login_strategies = auth.get_login_strategies(),
-					num_strategies = login_strategies.length;
+					num_strategies = login_strategies.length,
+					emailersPresent = Plugins.hasListeners('action:email.send');
 
 				if (num_strategies == 0) {
 					data = {
@@ -131,8 +132,8 @@ var path = require('path'),
 				}
 
 				data.authentication = login_strategies;
-
 				data.token = res.locals.csrf_token;
+				data.showResetLink = emailersPresent;
 
 				res.json(data);
 			});

From 0c71707fb5bb52196a367c440da8ee930d80e051 Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@designcreateplay.com>
Date: Sun, 26 Jan 2014 16:22:50 -0500
Subject: [PATCH 28/28] fixed #877

---
 public/src/forum/topic.js |  6 +++---
 src/socket.io/topics.js   | 16 +++++++++++-----
 2 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js
index 518ea3d64b..b241c9cc5e 100644
--- a/public/src/forum/topic.js
+++ b/public/src/forum/topic.js
@@ -1097,7 +1097,7 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 
 		var insertAfter = findInsertionPoint();
 
-		parseAndTranslatePosts(data.posts, function(translatedHTML) {
+		parseAndTranslatePosts(data, function(translatedHTML) {
 			var translated = $(translatedHTML);
 
 			if(!infiniteLoaded) {
@@ -1112,8 +1112,8 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 		});
 	}
 
-	function parseAndTranslatePosts(posts, callback) {
-		var html = templates.prepare(templates['topic'].blocks['posts']).parse({posts: posts});
+	function parseAndTranslatePosts(data, callback) {
+		var html = templates.prepare(templates['topic'].blocks['posts']).parse(data);
 		var regexp = new RegExp("<!--[\\s]*IF @first[\\s]*-->([\\s\\S]*?)<!--[\\s]*ENDIF @first[\\s]*-->", 'g');
 		html = html.replace(regexp, '');
 
diff --git a/src/socket.io/topics.js b/src/socket.io/topics.js
index 6ea39afbc9..b81b484610 100644
--- a/src/socket.io/topics.js
+++ b/src/socket.io/topics.js
@@ -1,6 +1,9 @@
 var topics = require('../topics'),
 	threadTools = require('../threadTools'),
 	index = require('./index'),
+
+	async = require('async'),
+
 	SocketTopics = {};
 
 SocketTopics.post = function(socket, data, callback) {
@@ -236,12 +239,15 @@ SocketTopics.loadMore = function(socket, data, callback) {
 	var start = data.after,
 		end = start + postsPerPage - 1;
 
-	topics.getTopicPosts(data.tid, start, end, socket.uid, function(err, posts) {
-		if(err) {
-			return callback(err);
+	async.parallel({
+		posts: function(next) {
+			topics.getTopicPosts(data.tid, start, end, socket.uid, next);
+		},
+		privileges: function(next) {
+			threadTools.privileges(data.tid, socket.uid, next);
 		}
-
-		callback(err, {posts: posts});
+	}, function(err, results) {
+		callback(err, results);
 	});
 };