From 63419d7ca9d248350faae31e0386a508c8c360f3 Mon Sep 17 00:00:00 2001 From: Baris Usakli Date: Fri, 25 Oct 2013 15:35:48 -0400 Subject: [PATCH] fix for reputation checks for manage content and manage threads --- src/postTools.js | 6 +++--- src/threadTools.js | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/postTools.js b/src/postTools.js index bdf69943d6..d75c2da1dc 100644 --- a/src/postTools.js +++ b/src/postTools.js @@ -46,14 +46,14 @@ var RDB = require('./redis.js'), function hasEnoughRep(next) { user.getUserField(uid, 'reputation', function(err, reputation) { if (err) return next(null, false); - next(null, reputation >= meta.config['privileges:manage_content']); + next(null, parseInt(reputation, 10) >= parseInt(meta.config['privileges:manage_content'], 10)); }); } async.parallel([getThreadPrivileges, isOwnPost, hasEnoughRep], function(err, results) { callback({ - editable: results[0].editable || (results.slice(1).indexOf(true) !== -1 ? true : false), - view_deleted: results[0].view_deleted || (results.slice(1).indexOf(true) !== -1 ? true : false) + editable: results[0].editable || results[1], + view_deleted: results[0].view_deleted || results[1] }); }); } diff --git a/src/threadTools.js b/src/threadTools.js index e375876ef0..e757bd41e6 100644 --- a/src/threadTools.js +++ b/src/threadTools.js @@ -34,15 +34,15 @@ var RDB = require('./redis.js'), function hasEnoughRep(next) { user.getUserField(uid, 'reputation', function(err, reputation) { if (err) return next(null, false); - next(null, reputation >= meta.config['privileges:manage_topic']); + next(null, parseInt(reputation, 10) >= parseInt(meta.config['privileges:manage_topic'], 10)); }); } async.parallel([getCategoryPrivileges, hasEnoughRep], function(err, results) { callback({ - editable: results[0].editable || (results.slice(1).indexOf(true) !== -1 ? true : false), - view_deleted: results[0].view_deleted || (results.slice(1).indexOf(true) !== -1 ? true : false) + editable: results[0].editable || results[1], + view_deleted: results[0].view_deleted || results[1] }); }); }