From 6255874e32195d0975be2f42781c3120a5f74047 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Fri, 6 Nov 2020 13:44:29 -0500 Subject: [PATCH] feat: move mkdirp to beforeBuild so it doesnt get called twice --- src/meta/build.js | 3 +++ src/meta/js.js | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/meta/build.js b/src/meta/build.js index 03b98a5c53..9c63902d3a 100644 --- a/src/meta/build.js +++ b/src/meta/build.js @@ -4,6 +4,8 @@ const os = require('os'); const winston = require('winston'); const nconf = require('nconf'); const _ = require('lodash'); +const path = require('path'); +const mkdirp = require('mkdirp'); const cacheBuster = require('./cacheBuster'); let meta; @@ -83,6 +85,7 @@ async function beforeBuild(targets) { await meta.themes.setupPaths(); const plugins = require('../plugins'); await plugins.prepareForBuild(targets); + await mkdirp(path.join(__dirname, '../../build/public')); } catch (err) { winston.error('[build] Encountered error preparing for build\n' + err.stack); throw err; diff --git a/src/meta/js.js b/src/meta/js.js index c2e33a5d23..1859e0dd4a 100644 --- a/src/meta/js.js +++ b/src/meta/js.js @@ -336,7 +336,6 @@ JS.buildBundle = async function (target, fork) { client: 'nodebb.min.js', admin: 'acp.min.js', }; - await mkdirp(path.join(__dirname, '../../build/public')); await requirejsOptimize(target); const files = await getBundleScriptList(target);