From 60a6775c7234fffb3f0064c67e9e2389b0d7cc8a Mon Sep 17 00:00:00 2001 From: Julian Lam Date: Wed, 29 Jul 2015 12:41:09 -0400 Subject: [PATCH] Changed behaviour of the Chat Typing Notification Instead of being placed at the bottom of the modal/list, it will now be displayed at the top of the modal, and not shown in the chats page at all (as it is already present in the contact list) --- public/src/client/chats.js | 12 ------------ public/src/modules/chat.js | 7 ++----- 2 files changed, 2 insertions(+), 17 deletions(-) diff --git a/public/src/client/chats.js b/public/src/client/chats.js index 95fa9266b7..68ee5bf98a 100644 --- a/public/src/client/chats.js +++ b/public/src/client/chats.js @@ -148,22 +148,10 @@ define('forum/chats', ['components', 'string', 'sounds', 'forum/infinitescroll', }); socket.on('event:chats.userStartTyping', function(withUid) { - var typingNotifEl = $('.user-typing'); - - if (Chats.isCurrentChat(withUid)) { - typingNotifEl.removeClass('hide'); - } - $('.chats-list li[data-uid="' + withUid + '"]').addClass('typing'); }); socket.on('event:chats.userStopTyping', function(withUid) { - var typingNotifEl = $('.user-typing'); - - if (Chats.isCurrentChat(withUid)) { - typingNotifEl.addClass('hide'); - } - $('.chats-list li[data-uid="' + withUid + '"]').removeClass('typing'); }); diff --git a/public/src/modules/chat.js b/public/src/modules/chat.js index 54b8fbe93f..da4efcafd5 100644 --- a/public/src/modules/chat.js +++ b/public/src/modules/chat.js @@ -312,8 +312,6 @@ define('chat', ['components', 'taskbar', 'string', 'sounds', 'forum/chats', 'tra } }); - chatModal.find('.user-typing .text').translateText('[[modules:chat.user_typing, ' + data.username + ']]'); - taskbar.push('chat', chatModal.attr('UUID'), { title: data.username, touid: data.touid, @@ -459,14 +457,13 @@ define('chat', ['components', 'taskbar', 'string', 'sounds', 'forum/chats', 'tra } module.appendChatMessage = function(chatModal, data, done) { - var chatContent = chatModal.find('#chat-content'), - typingNotif = chatModal.find('.user-typing'); + var chatContent = chatModal.find('#chat-content'); Chats.parseMessage(data, function(html) { var message = $(html); message.find('img:not(".chat-user-image")').addClass('img-responsive'); message.find('.timeago').timeago(); - message.insertBefore(typingNotif); + message.appendTo(chatContent); Chats.scrollToBottom(chatContent); if (typeof done === 'function') {