From 53021d31b0a4d9ae4c6cbe15b11c300f7808e0e9 Mon Sep 17 00:00:00 2001
From: barisusakli <barisusakli@gmail.com>
Date: Sun, 27 Apr 2014 17:32:24 -0400
Subject: [PATCH] closes #1446

---
 src/controllers/users.js | 69 +++++++++++++++++++++++++---------------
 1 file changed, 43 insertions(+), 26 deletions(-)

diff --git a/src/controllers/users.js b/src/controllers/users.js
index bd8687a809..6458d60729 100644
--- a/src/controllers/users.js
+++ b/src/controllers/users.js
@@ -9,7 +9,7 @@ var async = require('async'),
 usersController.getOnlineUsers = function(req, res, next) {
 	var	websockets = require('../socket.io');
 
-	user.getUsersFromSet('users:online', 0, 49, function (err, data) {
+	user.getUsersFromSet('users:online', 0, 49, function (err, users) {
 		if(err) {
 			return next(err);
 		}
@@ -26,34 +26,44 @@ usersController.getOnlineUsers = function(req, res, next) {
 			}
 
 			if (!isAdministrator) {
-				data = data.filter(function(item) {
+				users = users.filter(function(item) {
 					return item.status !== 'offline';
 				});
 			}
 
-			function iterator(userData, next) {
-				var online = websockets.isUserOnline(userData.uid);
-				if(!online) {
-					db.sortedSetRemove('users:online', userData.uid);
-					return next(null);
+			function updateUserOnlineStatus(user, next) {
+				var online = websockets.isUserOnline(user.uid);
+				if (!online) {
+					db.sortedSetRemove('users:online', user.uid);
+					return next();
 				}
 
-				onlineUsers.push(userData);
-				next(null);
+				onlineUsers.push(user);
+				next();
 			}
 
 			var anonymousUserCount = websockets.getOnlineAnonCount();
 
-			async.each(data, iterator, function(err) {
-				var userData = {
-					search_display: 'none',
-					loadmore_display: 'block',
-					users: onlineUsers,
-					anonymousUserCount: anonymousUserCount,
-					show_anon: anonymousUserCount?'':'hide'
-				};
+			async.each(users, updateUserOnlineStatus, function(err) {
+				if (err) {
+					return next(err);
+				}
+
+				db.sortedSetCard('users:online', function(err, count) {
+					if (err) {
+						return next(err);
+					}
+
+					var userData = {
+						search_display: 'none',
+						loadmore_display: count > 50 ? 'block' : 'hide',
+						users: onlineUsers,
+						anonymousUserCount: anonymousUserCount,
+						show_anon: anonymousUserCount?'':'hide'
+					};
 
-				res.render('users', userData);
+					res.render('users', userData);
+				});
 			});
 		});
 	});
@@ -76,14 +86,21 @@ function getUsers(set, res, next) {
 		if (err) {
 			return next(err);
 		}
-		var userData = {
-			search_display: 'none',
-			loadmore_display: 'block',
-			users: data,
-			show_anon: 'hide'
-		};
-
-		res.render('users', userData);
+
+		db.sortedSetCard(set, function(err, count) {
+			if (err) {
+				return next(err);
+			}
+
+			var userData = {
+				search_display: 'none',
+				loadmore_display: count > 50 ? 'block' : 'hide',
+				users: data,
+				show_anon: 'hide'
+			};
+
+			res.render('users', userData);
+		});
 	});
 }